2881 Commits (bebaa6eced0af2665d105beb59bd21030425245a)

Author	SHA1	Message	Date
Eugen Rochko	61d3ecc805	Fix custom emoji copy not copying file (#5298)	8 years ago
Eugen Rochko	4bb3e4eeba	Fix #5295 - Order custom emoji lexicographically (#5297)	8 years ago
unarist	784c7510d7	Fix an error when video playback buffer is empty (#5300)	8 years ago
nullkal	6c54d2e583	foreign_key, non-nullable, dependent: destroy in account_moderation_notes (#5294) ... * Add foreign key constraint to column `account` in `account_moderation_notes` * Change account_id and target_account_id to non-nullable in account_moderation_notes * Add dependent: :destroy to account and target_account in account_moderation_notes	8 years ago
Eugen Rochko	1c6fc0e4ce	Center error layout (#5289)	8 years ago
Akihiko Odaki	cc796298c9	Fix pagination in Api::V1::BlocksController (#5285)	8 years ago
Eugen Rochko	6e9e0c14e6	Fix dependency of error page generation on database (#5280)	8 years ago
Eugen Rochko	3888a12c79	Fix #5272 - Order of checks in ActivityPub handler (#5276)	8 years ago
Eugen Rochko	cfa68907ae	Fix #5271 - Fix missing attribute in remove_from_feed (#5277) ... Regression from #4801	8 years ago
Eugen Rochko	488584bfc1	Track frequently used emojis in web UI (#5275) ... * Track frequently used emojis in web UI * Persist emoji usage, but debounce commits to the settings API * Fix #5144 - Add tooltips to picker * Display only 2 lines of frequently used emojis	8 years ago
Eugen Rochko	0717d9b3e6	Set snowflake IDs for backdated statuses (#5260) ... - Rename Mastodon::TimestampIds into Mastodon::Snowflake for clarity - Skip for statuses coming from inbox, aka delivered in real-time - Skip for statuses that claim to be from the future	8 years ago
Eugen Rochko	6e4046fc3f	Fix #5178 - Use object URI only in Announce, instead of embedding (#5266)	8 years ago
JeanGauthier	94f15338c3	i18n update Occitan (#5263) ... * Update oc.json * Update oc.yml * Update oc.yml * Update oc.json	8 years ago
Nolan Lawson	db33a53ee8	Video preload should be a string (#5267)	8 years ago
Nolan Lawson	7de6d269d2	Use ES module build of react-router-dom (#5264)	8 years ago
Eugen Rochko	684001d729	Dynamically calculate card height for embeds instead of padding (#5265) ... The padding trick was hard-coded to a 16:9 ratio, but we can use width and height provided from OEmbed information and width of the card itself to calculate a new height	8 years ago
Eugen Rochko	292f3cd7e0	Show buffering in video player (#5261)	8 years ago
nullkal	633426b261	Add moderation note (#5240) ... * Add moderation note * Add frozen_string_literal * Make rspec pass	8 years ago
Eugen Rochko	f486ef2666	Redesign public hashtag pages (#5237)	8 years ago
Eugen Rochko	d2dee6ea43	Fix custom emoji in emoji picker, persist skin tone (#5258)	8 years ago
Eugen Rochko	967e70663f	In REST API, when URL can be missing, cast it to nil (#5259)	8 years ago
MitarashiDango	b7e65a004f	Japanese translation (relative time) (#5251)	8 years ago
Eugen Rochko	3a3475450e	Encode custom emojis as resolveable objects in ActivityPub (#5243) ... * Encode custom emojis as resolveable objects in ActivityPub * Improve code style	8 years ago
Nolan Lawson	057db0ecd0	Update emoji-mart to v2.1.1 (#5256)	8 years ago
Eugen Rochko	11436358b4	Fix regression from #5206 - deduplicate descendants (#5253)	8 years ago
Eugen Rochko	45682f876d	Make auto-play GIFs preference affect custom emojis in web UI (#5254)	8 years ago
Lynx Kotoura	5a2c7bd4ce	Fix overflowing in web UI (#5246) ... * Fix overflowing in web UI * Revert fixing dropdown menu modal	8 years ago
unarist	5c8ca024ef	Improve error handling on LinkCrawlWorker (#5250) ... * Improve error handling on LinkCrawlWorker * Ignore TimeoutError and InvalidURIError too * Record errors to debug log * Enable dead job queue on LinkCrawlWorker Since most of acceptable errors were already ignored, only our side issue should go to dead job queue. * Ignore all http gem errors	8 years ago
unarist	d8b2f89d33	Fix remote profile being displayed in HTML on remote_follow (#5249)	8 years ago
K.SHIRAKASHI	d5f490b1a2	Fix error on reloading status detail column (#5248)	8 years ago
MIYAGI Hikaru	6f2d88dd28	Fix error at emoji_compressed in Firefox ESR (#5241)	8 years ago
Lynx Kotoura	daa59dd454	Fix theme settings (#5242)	8 years ago
Nolan Lawson	72d939b69f	Fix thinking_face emoji autocomplete (#5238)	8 years ago
Nolan Lawson	97b3d0cd56	Import only Spring/Motion from react-motion (#5236)	8 years ago
Nolan Lawson	fd7f0732fe	Compress and combine emoji data (#5229)	8 years ago
Nolan Lawson	2aca22b8ea	import only Overlay from react-overlays (#5235)	8 years ago
Eugen Rochko	7db0f8dcb2	Implement hotkeys for web UI (#5164) ... * Fix #2102 - Implement hotkeys Hotkeys on status list: - r to reply - m to mention author - f to favourite - b to boost - enter to open status - p to open author's profile - up or k to move up in the list - down or j to move down in the list - 1-9 to focus a status in one of the columns - n to focus the compose textarea - alt+n to start a brand new toot - backspace to navigate back * Add navigational hotkeys The key g followed by: - s: start - h: home - n: notifications - l: local timeline - t: federated timeline - f: favourites - u: own profile - p: pinned toots - b: blocked users - m: muted users * Add hotkey for focusing search, make escape un-focus compose/search * Fix focusing notifications column, fix hotkeys in compose textarea	8 years ago
Eugen Rochko	49cc0eb3e7	Improve admin UI for custom emojis, add copy/disable/enable (#5231)	8 years ago
Eugen Rochko	b9c76e2edb	When processing custom emoji, ensure a non-animated version exists (#5230) ... Use the non-animated version in web UI, but return both in API	8 years ago
ThibG	2559d9166c	Fix regression in FetchRemoteResourceService (#5217) ... * Fix regression in FetchRemoteResourceService * Update specs to match interface changes made in #5114	8 years ago
Lynx Kotoura	32e8a87830	adjust public profile pages 2 (#5223)	8 years ago
Eugen Rochko	b406e3cc4c	Fix #5050 - Use summary_large_image only with media attachments (#5219)	8 years ago
Lynx Kotoura	43577e9f59	Fix style of email domain block table (#5218)	8 years ago
MitarashiDango	ecfa1c3f3b	fix error (When part of conversation has already been deleted.) (#5216)	8 years ago
utam0k	b3af3f9f8c	Implement EmailBlackList (#5109) ... * Implement BlacklistedEmailDomain * Use Faker::Internet.domain_name * Remove note column * Add frozen_string_literal comment * Delete unnecessary codes * Sort alphabetically * Change of wording * Rename BlacklistedEmailDomain to EmailDomainBlock	8 years ago
Ryo Kajiwara	d5091387c6	Supply @instance variable in password reset instructions / password change mailer (#5215)	8 years ago
Yamagishi Kazutoshi	178f718a9b	Separate notifications preferences from general preferences (#4447) ... * Separate notifications preferences from general preferences * Refine settings/notifications/show * remove preferences.notifications	8 years ago
ThibG	0e1b0f2747	Check Webfinger-returned author URI even when not redirected (#5213) ... The whole point of verified_webfinger? is to check the WebFinger-discoverable URI maps back to the known author URI. This was not actually verified if the first Webfinger request was not a redirection.	8 years ago
aschmitz	468523f4ad	Non-Serial ("Snowflake") IDs (#4801) ... * Use non-serial IDs This change makes a number of nontrivial tweaks to the data model in Mastodon: * All IDs are now 8 byte integers (rather than mixed 4- and 8-byte) * IDs are now assigned as: * Top 6 bytes: millisecond-resolution time from epoch * Bottom 2 bytes: serial (within the millisecond) sequence number * See /lib/tasks/db.rake's `define_timestamp_id` for details, but note that the purpose of these changes is to make it difficult to determine the number of objects in a table from the ID of any object. * The Redis sorted set used for the feed will have values used to look up toots, rather than scores. This is almost always the same as the existing behavior, except in the case of boosted toots. This change was made because Redis stores scores as double-precision floats, which cannot store the new ID format exactly. Note that this doesn't cause problems with sorting/pagination, because ZREVRANGEBYSCORE sorts lexicographically when scores are tied. (This will still cause sorting issues when the ID gains a new significant digit, but that's extraordinarily uncommon.) Note a couple of tradeoffs have been made in this commit: * lib/tasks/db.rake is used to enforce many/most column constraints, because this commit seems likely to take a while to bring upstream. Enforcing a post-migrate hook is an easier way to maintain the code in the interim. * Boosted toots will appear in the timeline as many times as they have been boosted. This is a tradeoff due to the way the feed is saved in Redis at the moment, but will be handled by a future commit. This would effectively close Mastodon's #1059, as it is a snowflake-like system of generating IDs. However, given how involved the changes were simply within Mastodon, it may have unexpected interactions with some clients, if they store IDs as doubles (or as 4-byte integers). This was a problem that Twitter ran into with their "snowflake" transition, particularly in JavaScript clients that treated IDs as JS integers, rather than strings. It therefore would be useful to test these changes at least in the web interface and popular clients before pushing them to all users. * Fix JavaScript interface with long IDs Somewhat predictably, the JS interface handled IDs as numbers, which in JS are IEEE double-precision floats. This loses some precision when working with numbers as large as those generated by the new ID scheme, so we instead handle them here as strings. This is relatively simple, and doesn't appear to have caused any problems, but should definitely be tested more thoroughly than the built-in tests. Several days of use appear to support this working properly. BREAKING CHANGE: The major(!) change here is that IDs are now returned as strings by the REST endpoints, rather than as integers. In practice, relatively few changes were required to make the existing JS UI work with this change, but it will likely hit API clients pretty hard: it's an entirely different type to consume. (The one API client I tested, Tusky, handles this with no problems, however.) Twitter ran into this issue when introducing Snowflake IDs, and decided to instead introduce an `id_str` field in JSON responses. I have opted to *not* do that, and instead force all IDs to 64-bit integers represented by strings in one go. (I believe Twitter exacerbated their problem by rolling out the changes three times: once for statuses, once for DMs, and once for user IDs, as well as by leaving an integer ID value in JSON. As they said, "If you’re using the `id` field with JSON in a Javascript-related language, there is a very high likelihood that the integers will be silently munged by Javascript interpreters. In most cases, this will result in behavior such as being unable to load or delete a specific direct message, because the ID you're sending to the API is different than the actual identifier associated with the message." [1]) However, given that this is a significant change for API users, alternatives or a transition time may be appropriate. 1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html * Restructure feed pushes/unpushes This was necessary because the previous behavior used Redis zset scores to identify statuses, but those are IEEE double-precision floats, so we can't actually use them to identify all 64-bit IDs. However, it leaves the code in a much better state for refactoring reblog handling / coalescing. Feed-management code has been consolidated in FeedManager, including: * BatchedRemoveStatusService no longer directly manipulates feed zsets * RemoveStatusService no longer directly manipulates feed zsets * PrecomputeFeedService has moved its logic to FeedManager#populate_feed (PrecomputeFeedService largely made lots of calls to FeedManager, but didn't follow the normal adding-to-feed process.) This has the effect of unifying all of the feed push/unpush logic in FeedManager, making it much more tractable to update it in the future. Due to some additional checks that must be made during, for example, batch status removals, some Redis pipelining has been removed. It does not appear that this should cause significantly increased load, but if necessary, some optimizations are possible in batch cases. These were omitted in the pursuit of simplicity, but a batch_push and batch_unpush would be possible in the future. Tests were added to verify that pushes happen under expected conditions, and to verify reblog behavior (both on pushing and unpushing). In the case of unpushing, this includes testing behavior that currently leads to confusion such as Mastodon's #2817, but this codifies that the behavior is currently expected. * Rubocop fixes I could swear I made these changes already, but I must have lost them somewhere along the line. * Address review comments This addresses the first two comments from review of this feature: https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336735 https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336931 This adds an optional argument to FeedManager#key, the subtype of feed key to generate. It also tests to ensure that FeedManager's settings are such that reblogs won't be tracked forever. * Hardcode IdToBigints migration columns This addresses a comment during review: https://github.com/tootsuite/mastodon/pull/4801#discussion_r139337452 This means we'll need to make sure that all _id columns going forward are bigints, but that should happen automatically in most cases. * Additional fixes for stringified IDs in JSON These should be the last two. These were identified using eslint to try to identify any plain casts to JavaScript numbers. (Some such casts are legitimate, but these were not.) Adding the following to .eslintrc.yml will identify casts to numbers: ~~~ no-restricted-syntax: - warn - selector: UnaryExpression[operator='+'] > :not(Literal) message: Avoid the use of unary + - selector: CallExpression[callee.name='Number'] message: Casting with Number() may coerce string IDs to numbers ~~~ The remaining three casts appear legitimate: two casts to array indices, one in a server to turn an environment variable into a number. * Only implement timestamp IDs for Status IDs Per discussion in #4801, this is only being merged in for Status IDs at this point. We do this in a migration, as there is no longer use for a post-migration hook. We keep the initialization of the timestamp_id function as a Rake task, as it is also needed after db:schema:load (as db/schema.rb doesn't store Postgres functions). * Change internal streaming payloads to stringified IDs as well This is equivalent to 591a9af356 from #5019, with an extra change for the addition to FeedManager#unpush. * Ensure we have a status_id_seq sequence Apparently this is not a given when specifying a custom ID function, so now we ensure it gets created. This uses the generic version of this function to more easily support adding additional tables with timestamp IDs in the future, although it would be possible to cut this down to a less generic version if necessary. It is only run during db:schema:load or the relevant migration, so the overhead is extraordinarily minimal. * Transition reblogs to new Redis format This provides a one-way migration to transition old Redis reblog entries into the new format, with a separate tracking entry for reblogs. It is not invertible because doing so could (if timestamp IDs are used) require a database query for each status in each users' feed, which is likely to be a significant toll on major instances. * Address review comments from @akihikodaki No functional changes. * Additional review changes * Heredoc cleanup * Run db:schema:load hooks for test in development This matches the behavior in Rails' ActiveRecord::Tasks::DatabaseTasks.each_current_configuration, which would otherwise break `rake db:setup` in development. It also moves some functionality out to a library, which will be a good place to put additional related functionality in the near future.	8 years ago
Yamagishi Kazutoshi	d40c9140e8	Fix undefined local variable (regression from #5114) (#5210)	8 years ago