472 Commits (bd915d9398816fd1fb44645eb6d7e2c9df0e6388)

Author	SHA1	Message	Date
Matt Jankowski	bf811e4d4a	Improve spec coverage and clean up api/v1/mutes controller (#3481)	9 years ago
Matt Jankowski	d6774d2ca3	Refactor and spec coverage for api/v1/timelines actions (#3482)	9 years ago
Matt Jankowski	79335e46fd	Refactor api/v1/apps controller (#3471)	9 years ago
Matt Jankowski	7c6e02aaf3	Refactor api/v1/reports controller (#3469)	9 years ago
Matt Jankowski	7f55430652	Refactor api/v1/search controller (#3468)	9 years ago
Matt Jankowski	8235623362	Improve spec coverage and clean up api/v1/media controller (#3467)	9 years ago
Matt Jankowski	83435c49ea	Clean up api/subscriptions controller (#3448)	9 years ago
Jack Jennings	33f669a5f8	Add status destroy authorization to policy (#3453) ... * Add status destroy authorization to policy * Create explicit unreblog status authorization	9 years ago
Matt Jankowski	3576fa0d59	Improve api oembed controller (#3450) ... * Add StreamEntryFinder class to parse URLs * Use StreamEntryFinder and clean up api/oembed controller	9 years ago
Matt Jankowski	1dcfb90202	Clean up api/salmon controller (#3449)	9 years ago
Matt Jankowski	0ebe7d6d23	Remove exports/base controller in favor of shared concern (#3444)	9 years ago
Jack Jennings	3a2003ba86	Extract authorization policy for viewing statuses (#3150)	9 years ago
Akihiko Odaki	922fb74197	Remove methods from ObfuscateFilename and spec (#3347) ... * Remove methods from ObfuscateFilename * Spec ObfuscateFilename	9 years ago
Atsushi Yamamoto	402c19a924	Add preference setting for delete toot modal (#3368) ... * Set delete_modal preference to true by default * Does not show confirmation modal if delete_modal is false * Add ja translation for preference setting page	9 years ago
unarist	ecef03bb15	Fix empty flash message on the settings page (#3345)	9 years ago
Akihiko Odaki	860e257a68	Remove redundant call of recent scope in AccountsController (#3330) ... recent is included in paginate_by_max_id.	9 years ago
Akinori MUSHA	f6a93fc150	Go to root after login in single user mode (#3289) ... In single user mode, visitors are redirected to the single user's profile page. So, if you are the owner without a session, you start from that page, click the login button and authenticate yourself expecting you'll soon get started with the home page, but in reality you'll get redirected back to where you started from -- your own profile page. This fixes the behavior by redirecting you home after login if you have started from your own profile page.	9 years ago
unarist	cf4fe6cab8	More use of next link header on account (media) timelines (#3311) ... This will reduce requests on who have only few statuses. - Use next link header to detect more items from first request - Omit next link header if result items are fewer than requested count (It had omit it only if result was empty before)	9 years ago
Yamagishi Kazutoshi	676ba50601	Show error message to suspended user (#3281)	9 years ago
unarist	3ce9ca4c99	Fix following/followers API to return correct link headers (#3268) ... Link headers in following/followers API should include follow_id as max_id/since_id. However, these API use current_user's account_id instead of follow_id from #3167. This causes irrelevant result on loading more users.	9 years ago
Eugen Rochko	2ca1f0737a	Fix Devise destroy method being available to delete user record (#3266) ... (You may think that we need account deletions, but this way would've just orphaned the db records)	9 years ago
alpaca-tc	7ee5fc5d68	Toggle sensitive from admin page (#3261)	9 years ago
Matt Jankowski	4289ed1d13	Refactor of API timeline actions (#3263) ... - Increase coverage to exercise all parts of each action - Move into namespace to share common code - Misc refactor of each action for smaller methods, simpler code	9 years ago
Akihiko Odaki	ea2ef16ea4	Cover StreamEntriesController more and remove redundant instructions (#3257) ... * Cover StreamEntriesController more * Remove redundant instructions in StreamEntriesController	9 years ago
Akihiko Odaki	bf575a1f5e	Introduce recent to Follow (#3247) ... Introduce recent to Follow, as Account and other models have. This change also adds specs for the scope and the dependents.	9 years ago
Akihiko Odaki	8fd174298d	Cover AccountsController more in spec (#3229) ... * Introduce recent scope to Status and StreamEntry Introduce recent scope to Status and StreamEntry as Account has. * Cover AccountsController more in AccountsController	9 years ago
Matt Jankowski	a28ce13b3e	Coverage for api/web/settings controller (#3238)	9 years ago
Tomonori Murakami	7966d3a872	Fix locale bug when change it on preferences (#3223) (#3232)	9 years ago
Immae	a94c152fd3	Allow alternate domains for mastodon handlers (#3187)	9 years ago
Yamagishi Kazutoshi	73e4468ff3	Change "Account.any?" to "Account.exists?" (#3217)	9 years ago
Akihiko Odaki	aa662cecad	single_user_mode? always returns boolean (#3215) ... This change also adds a specification for the method.	9 years ago
Akihiko Odaki	2af5cd96fe	Fix mutes_controller error and incorrect statuses_controller report (#3202) ... This commit fixes a regression in commit f554807563.	9 years ago
Akihiko Odaki	22cb286ad7	Fix regressions in api/v1 (#3178) ... The regressions are introduced at commit f554807563 by me (Akihiko Odaki)	9 years ago
Matt Jankowski	8f4b7c1820	Filter languages with opt out (#3175) ... * Remove allowed_languages and add filtered_languages * Use filtered_languages instead of allowed_languages	9 years ago
Yamagishi Kazutoshi	6c1122a1d9	Fix block list 500 (#3174)	9 years ago
Akihiko Odaki	f554807563	Use joins for account properties (#3167)	9 years ago
Eugen Rochko	f1ab70649b	Add buttons to block and unblock domain (#3127) ... * Add buttons to block and unblock domain * Relationship API now returns "domain_blocking" status for accounts, rename "block entire domain" to "hide entire domain", fix unblocking domain, do not block notifications from domain-blocked-but-followed people, do not send Salmons to domain blocked users * Add test * Personal domain blocks shouldn't affect Salmon after all, since in this direction of communication the control is very thin when it comes to public stuff. Best stay consistent and not affect federation in this way * Ignore followers and follow request from domain blocked folks, ensure account domain blocks are not created for empty domain, and avoid duplicates in validation * Purge followers when blocking domain (without soft-blocks, since they are useless here) * Add tests, fix local timeline being empty when having any domain blocks	9 years ago
Matt Jankowski	6e4c7d6211	Conditional validations no longer accept strings for if/unless (#3124)	9 years ago
Eugen Rochko	620d0d8029	Account domain blocks (#2381) ... * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation * Adding account domain blocks that filter notifications and public timelines * Add tests for domain blocks in notifications, public timelines Filter reblogs of blocked domains from home * Add API for listing and creating account domain blocks * API for creating/deleting domain blocks, tests for Status#ancestors and Status#descendants, filter domain blocks from them * Filter domains in streaming API * Update account_domain_block_spec.rb	9 years ago
alpaca-tc	e89e4355eb	Add filter to AccountFilter (#2968)	9 years ago
masarakki	1b0a5658f1	use-symbol-in-order (#3081)	9 years ago
Eugen Rochko	d0dd9eb5b5	Feature conversations muting (#3017) ... * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation	9 years ago
Matt Jankowski	04166c4a35	Specs for API push controller, with refactor (#2926) ... * Coverage for api push controller * Refactor the api/push controller	9 years ago
HANATANI Takuma	388e70b881	Remove unnecessary keep file. (#2902)	9 years ago
alpaca-tc	a0b1951791	Refactor domain_blocks_controller (#2843) ... * Set domain_block by before_action * Cast value with ActiveRecord::Type * Batch update	9 years ago
rch850	453fb84c9c	Use null as default oEmbed height (#2842) ... Height 640 is too big for most toots. Twitter use null value to support flexible height.	9 years ago
alpaca-tc	ddc34feb58	Optimize follower_accounts and following_accounts (#2820)	9 years ago
Matt Jankowski	2bd132d458	Replace best_in_place editor on admin settings page (#2789) ... * Remove best_in_place * Replace best_in_place usage with rails helpers * Move admin/settings#index to #edit action * Remove click_to__edit from i18n	9 years ago
Eugen Rochko	bafd22ecf4	Fix #2706 - Always respond with 200 to PuSH payloads (#2733) ... Fix #2196 - Respond with 201 when Salmon accepted, 400 when unverified Fix #2629 - Correctly handle confirm_domain? for local accounts Unify rules for extracting author acct from XML, prefer <email>, fall back to <name> + <uri> (see also #2017, #2172)	9 years ago
Matt Jankowski	268dd32d76	Auth sign out (#2511) ... * Add a spec for signing out * Add spec showing that suspended user gets a 403 forbidden on sign out * Allow suspended account users to sign out	9 years ago
Kaylee	7880671f35	Add option to disable two factor auth in admin accounts panel. (#2584) ... * Add option to disable two factor auth in admin accounts panel. Closes #2578 * Add @mjankowski's suggestions. * Moves destroy actions behind User#disable_two_factor! * Adds spec coverage for Admin:TwoFactorAuthenticationsController and User#disable_two_factor!	9 years ago
Matt Jankowski	b5eec34230	Add admin area view partials for each record type (#2700)	9 years ago
Matt Jankowski	a4859446ab	Coverage for remote follows (#2694) ... * Add coverage for create with empty acct value * Add coverage for create with webfinger failure * Add coverage for create with webfinger providing bad values * Add coverage for create when webfinger is good * Add coverage for session[:remote_follow] having data * Simplify how remote follow pulls acct from session * Remote follow behaves more like model * Move the discovery portions of remote follow out of controller * Check for suspended accounts	9 years ago
Matt Jankowski	7bffd16024	Error responses cleanup (#2692) ... * Use respond_with_error for forbidden errors * Wrap up common error code into single method	9 years ago
Matt Jankowski	f025cc6782	Filter on allowed user language preferences (#2361) ... * Naive approached to timeline filtering * Convert allowed_languages into a db column * Allow users to choose languages to see statuses in * Style list items as two columns * Add a hint to explain language filtering preference	9 years ago
yhirano	3988f2dade	Fix Rubocop offences (#2630) ... * disable Bundler/OrderedGems * fix rubocop Lint/UselessAssignment * fix rubocop Style/BlockDelimiters * fix rubocop Style/AlignHash * fix rubocop Style/AlignParameters, Style/EachWithObject * fix rubocop Style/SpaceInLambdaLiteral	9 years ago
Matt Jankowski	fdcf884cf7	Extract user tracking into concern (#2600)	9 years ago
Matt Jankowski	f48cb3eb17	More coverage yes more even more (#2627) ... * Add coverage for admin/confirmations controller * Coverage for statuses controller show action * Add coverage for admin/domain_blocks controller * Add coverage for settings/profiles#update	9 years ago
yhirano	8325866c61	Downgrade rubocop 0.48.1 => 0.46.0 (#2628) ... * downgrade rubocop 0.48.1 => 0.46.0 * exclude vendor/**/* from rubocop target files * add frozen_string_literal comment line * fix percent literal delimited by ( and ) * fix alignment * remove comment disabling unknown cop	9 years ago
alpaca-tc	7d36a76180	Remove uneeded `ORDER BY` query (#2615)	9 years ago
Matt Jankowski	429480bb77	Return missing page when tag does not exist (#2563)	9 years ago
Yamagishi Kazutoshi	c25426ca47	Fix Doorkeeper error (#2534) ... * Fix Doorkeeper error * use Doorkeeper::OAuth::Scopes.from_string	9 years ago
Matt Jankowski	b48f2cbc8b	Catch error when server decryption fails on 2FA (#2512)	9 years ago
Eugen Rochko	88725d6ce8	OEmbed support for PreviewCard (#2337) ... * OEmbed support for PreviewCard * Improve ProviderDiscovery code failure treatment * Do not crawl links if there is a content warning, since those don't display a link card anyway * Reset db schema * Fresh migrate * Fix rubocop style issues Fix #1681 - return existing access token when applicable instead of creating new * Fix test * Extract http client to helper * Improve oembed controller	9 years ago
Matt Jankowski	0618f09939	Add spec coverage and refactor authorize_follows controller (#2505)	9 years ago
alpaca-tc	9317ec8eb1	Localize with i18n for Devise::FailureApp (#2309) ... This PR fixes I18n.locale for rake middlewares. Mastodon uses Devise that depends on Warden. Warden::Manager can be found in rake middleware. It is outside of the controller. In the case of authentication failed, warden calls throw(:warden). At the time Warden::Manager delegates request to failure_app to generate response and flash[:alert] after catching it. Unfortunately, I18n.locale is already reset then because I18n.with_locale is enabled only inside the controller. If we used I18n.locale=, Devise::FailureApp could get the current locale.	9 years ago
Evan Minto	122d59ac41	Change ActivityPub paging to match spec. Clean up ActivityPub outbox changes. (#2410) ... * Change ActivityPub paging to match spec. Clean up ActivityPub outbox changes. * Fix code style and test failures for OutboxController. * Attempt to fix CI errors.	9 years ago
Eugen Rochko	8b5179d006	Fix #2402 - Add Idempotency-Key header to PostStatusService that prevents (#2419) ... duplicates. Web UI regenerates UUID for that header every time the compose form is changed or successfully submitted Also, fix Farsi i18n overwriting the English one	9 years ago
Eugen	17c591ffba	Punycode URI normalization (#2370) ... * Fix #2119 - Whenever about to send a HTTP request, normalize the URI * Add test for IDN request in FetchLinkCardService * Perform IDN normalization on domains before they are stored in the DB	9 years ago
Matt Jankowski	a0dd90a397	Return force_ssl to the controller (#2380)	9 years ago
Eugen	501514960a	Followers-only post federation (#2111) ... * Make private toots get PuSHed to subscription URLs that belong to domains where you have approved followers * Authorized followers controller, stub for bulk action * Soft block in the background * Add simple test for new controller * Rename Settings::FollowersController to Settings::FollowerDomainsController, paginate results, rename "private" post setting to "followers-only", fix pagination style, improve post privacy preferences style, improve warning style * Extract compose form warnings into own container, show warning when posting to followers-only with unlocked account	9 years ago
Evan Minto	66fd8e7821	ActivityPub: Add basic, read-only support for Outboxes, Notes, and Create/Announce Activities (#2197) ... * Clean up collapsible components * Expose user Outboxes and AS2 representations of statuses * Save work thus far. * Fix bad merge. * Save my work * Clean up pagination. * First test working. * Add tests. * Add Forbidden error template. * Revert yarn.lock changes. * Fix code style deviations and use localized instead of hardcoded English text.	9 years ago
Ash Furrow	723f25a999	Admin UI for confirming users (#2245) ... * Shows confirmed status in list. * Adds ability to confirm users in admin UI. * Added new english translations. * Addresses feedback from #2245. * More feedback.	9 years ago
Matt Jankowski	ee82d8a876	Move force_ssl check to production config (#2165) ... The force_ssl method from controllers does not add all of the options that the sitewide configuration in a config block does. For example, HSTS enforcement is not added by the controller method, but is added by this style.	9 years ago
Matt Jankowski	67dea31b0f	2FA controller cleanup (#2296) ... * Add spec coverage for settings/two_factor_auth area * extract setup method for qr code * Move otp required check to before action * Merge method only used once * Remove duplicate view * Consolidate creation of @codes for backup * Move settings/2fq#recovery_codes to settings/recovery_codes#create * Rename settings/two_factor_auth#disable to #destroy * Add coverage for the otp required path on 2fa#show * Clean up the recovery codes list styles * Move settings/two_factor_auth to settings/two_factor_authentication * Reorganize the settings two factor auth area Updated to use a flow like: - settings/two_factor_authentication goes to a #show view which has a button either enable or disable 2fa on the account - the disable button turns off the otp requirement for the user - the enable button cycles the user secret and redirects to a confirmation page - the confirmation page is a #new view which shows the QR code for user - that page posts to #create which verifies the code, and creates the recovery codes - that create action shares a view with a recovery codes controller which can be used separately to reset codes if needed	9 years ago
Ashley	05ac28f3e4	Added API for single notification dismissal (#2251) ... * Added API backend for notification dismissal * Added render statement * Changed statement	9 years ago
Takayoshi Nishida	5e33ad29d4	Fix #2195 - Set locale to error pages (#2255) ... * Fix #2195 - Set locale to error pages * Fix #2195 - Cut duplicate process into one method	9 years ago
Matt Jankowski	2dda356e3f	Clean up settings/preferences controller (#2237) ... * Add missing fields group on preferences page * Clean up settings/preferences controller * Extract a UserSettingsDecorator	9 years ago
Matt Jankowski	1ada494bb2	Admin settings controller refactor, add specs, cleanup (#2225) ... * Add render_views for admin/settings spec * Add coverage for admin/settings#update * Add coverage for admin/settings typecasting open_registrations setting * Simplify how admin/settings finds the value for updating * Rely on activerecord to not update a value that hasnt changed * Add coverage for non-existent setting * Use a constant for boolean settings	9 years ago
Eugen	cae2a26ee3	Fix #2120 - Use Status#as_tag_timeline on public hashtag page (#2182) ... * Fix #2120 - Use Status#as_tag_timeline on public hashtag page * Update tags_controller.rb	9 years ago
Matt Jankowski	a8e1afc30a	Simplify render in controllers (#2144)	9 years ago
Matt Jankowski	8bac0350d1	Restful refactor of accounts/ routes (#2133) ... * Add routing specs for accounts followers and following actions * Use more restful route naming for public account follow pages Moves two actions: - accounts#followers to accounts/follower_accounts#index - accounts#following to accounts/following_accounts#index Adds routing spec to ensure prior URLs are preserved.	9 years ago
happycoloredbanana	0a7588282a	Remove API authentication for public statuses (after review) (#1919)	9 years ago
Matt Jankowski	55e1503522	Instances list in admin (#2095) ... * Add admin/instances index action * Add link to instances admin page * View lists instances * Instances, grouped by domain, ordered by count * Use Account.remote scope * Extract method: Account.by_domain_accounts	9 years ago
Matt Jankowski	66d8f99a30	Admin reports with accounts (#2092) ... * Add a ReportFilter class * Add reports and targeted_reports relationships to Account * Use ReportFilter from admin/reports controller * Link to admin/reports filtered views from admin account show view * Add indexes to reports.account_id and reports.target_account_id	9 years ago
839	e2a1b574ab	Avoid dynamic methods due to processing speed (#2080)	9 years ago
Eugen Rochko	42d54dc9ea	Adjust visuals of non-autoplaying GIFV	9 years ago
Eugen Rochko	57d784f1e4	Merge branch 'pause-gif' of git://github.com/patf/mastodon into patf-pause-gif	9 years ago
Matt Jankowski	16d50f60d1	Remove unused methods (#1730) ... * Remove unused method #set_counters_maps from api controller * Remove unused method #set_account_counters_maps from api controller * Remove unused method Account#followers_domains * Remove unused User.prolific scope * Add mastodon:users:admins task to list all admin emails * Use interpolated query style in Account.triadic_closures * Coverage for Account.triadic_closures	9 years ago
Matt Jankowski	cc1361c149	Media controller specs (#2022) ... * Add spec for media controller * Add MediaAttachment.attached scope * Simplify methods in media controller	9 years ago
Eugen	e43071a2f9	Fix #1897 - Return reblogged: false on unreblog (was wrongly named variable) (#1989)	9 years ago
Matt Jankowski	21a767dcfa	Improve handling of HTTP_ACCEPT for webfinger (#2008) ... This change includes: - Improve the spec coverage for incoming request to the webfinger action - For requests without an accept header (ie, what a browser might look like), return a JSON response. - For requests with an explicit format of xml or json, return that format. - For requests using an accept header, return that format. Also adds failing spec showing webfinger does not return xml, which covers the issue described in: https://github.com/tootsuite/mastodon/issues/1983	9 years ago
Patrick Figel	ffb99325ca	Add gif auto-play/pause preference ... This introduces a new per-user preference called "Auto-play animated GIFs", which is enabled by default. When a user disables this setting, gifs in toots become click-to-play. Previews of animated gifs were changed to display the video play button so that users can distinguish them from regular images. This setting also affects account avatars in the detailed account view, which was changed to use the same hover-to-play mechanism that is used for animated avatars in timelines. Fixes #1652	9 years ago
saturday06	d87ee1167e	Assign user locale on signup (#1982)	9 years ago
Eugen	6d70a80263	Onboarding modal (#1883) ... * Basic onboarding modal that's shown to users once * Lay out pages 2 through 5, add images, style modals (#1509) * Lay out pages 2 through 5 Added images and laid out pages 2 through 5 in the jsx file. SCSS will come, still working on just seeing if this works at all. * Fix jsx errors, add images to modal pages, style modal pages * Add animations to onboarding pager changes, improve wording and styling * Finishing touches on the onboarding * Add missing propTypes * Update wording	9 years ago
Matt Jankowski	f87b51fda8	I18n health warnings (#1949) ... * Rename admin.domain_block to admin.domain_blocks in prep for i18n improvement * Use implicit controller/action path for i18n in admin/domain_blocks * Add DomainBlock#accounts has_many * Avoid i18n health warning for `en` locale by using symbol scope with :count * Remove unused i18n key: plaintext_secret_html * Remove unused i18n key two_factor_auth.warning * Remove final will_paginate i18n keys * Remove unused key two_factor_auth.recovery_codes * Remove unused key: admin.reports.comment.none * Remove unused reports. i18n namespace (moved to admin.reports) * Ignore keys from locales which override activemodel and activerecord errors * Revert "Remove unused key: admin.reports.comment.none" This reverts commit 350ef2685f. * Update i18n key reference to match moved location * Add missing `en` keys to i18n * Tell i18n-tasks to ignore missing attributes that dont need overwriting * Add i18n-tasks unused to travis	9 years ago
Eugen	5d710b1139	Make file attachment on MediaAttachment optional (#1865) ... Create MediaAttachment but without actual file download when domain is blocked with reject_media set to true Clean up old media files when creating a new domain block with reject_media set to true Return remote_url in media attachments API if local file is not present Undo domain block action in admin UI Ability to enable reject_media from admin UI	9 years ago
alpaca-tc	00392d3c63	ActiveRecord::NotFound is not defined (#1864)	9 years ago
Marcin Cieślak	1c8477eab2	Give SINGLE_USER a chance to register (#1820) ... An attempt to open a brand new Mastodon instance configured as SINGLE_USER_MODE=true will cause an exception. Enable temporary registration if we have no users in the database Fixes #1817	9 years ago
Matt Jankowski	6670e6d33f	Add password reset for users from admin accounts area (#1841)	9 years ago