Commit Graph

2150 Commits (b8bd94ca8edb5a675ef70aac9c941ed340efc127)

Author SHA1 Message Date
Claire 5f4643b895
Add `PAPERCLIP_ROOT_URL` to Content-Security-Policy when used ()
Matt Jankowski 964a0ecf37
Add sleep statement to nudge thread scheduler in request pool spec ()
Matt Jankowski f06c1f1552
Fix `Capybara/ClickLinkOrButtonStyle` cop in spec/features ()
Claire dfdadb92e8
Add ability to require approval when users sign up using specific email domains ()
Matt Jankowski f92d8c654d
Standardize on Thor methods in CLI classes ()
Matt Jankowski 5c769de096
Add spec coverage for `CLI::Media#remove_orphans` command ()
Matt Jankowski 74a0d81e90
Add coverage for CLI `self-destruct` command ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Claire 092bb8a27a
Fix Mastodon not correctly processing HTTP Signatures with query strings ()
Claire bd415af9a1
Change streaming API host to not be overridden to localhost in development mode ()
Claire a2624ff739
Convert signature verification specs to request specs ()
Matt Jankowski bb8077e784
Fix `RSpec/LetSetup` cop in models/account_status_cleanup_policy ()
Claire 2bf84b93d4
Fix media attachment order of remote posts ()
Matt Jankowski a4d49c236d
Fix `RSpec/LetSetup` cop in ap/fetch_featured_collection_service ()
Matt Jankowski e6e217fedd
Clean up `tagged_with_*` Status specs, fix `RSpec/LetSetup` cop ()
Matt Jankowski 513d35969e
Fix `RSpec/LetSetup` cop in auth controller specs ()
Matt Jankowski 9251779d75
Fix `RSpec/LetSetup` cop in spec/services ()
Matt Jankowski efd16f3c2c
Clean up of `RSpec/LetSetup` within `spec/services/activitypub` ()
Matt Jankowski c99f88e1a8
Clean up of `RSpec/LetSetup` within `spec/lib` ()
Matt Jankowski cd64a5b2ec
Clean up of `RSpec/LetSetup` within `api/` ()
Matt Jankowski f32d672d2f
Clean up of `RSpec/LetSetup` within `spec/controllers` ()
Matt Jankowski c753b1ad35
Clean up of `RSpec/LetSetup` within `spec/models` ()
Matt Jankowski 2463b53363
More duplicates in cli maintenance spec, misc bug fixes ()
Matt Jankowski 961d65aba6
Add coverage to CLI Maintenance for duplicate users on `confirmation_token` and `reset_password_token` values ()
Claire 6fed0fcbaa
Remove unneeded settings cleanup from specs ()
Matt Jankowski c7c727994a
Add spec for `CLI::Maintenance#fix_duplicates` ()
Eugen Rochko b5ac61b2c5
Change algorithm of follow recommendations ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski c28976d89e
Handle negative offset param in `api/v2/search` ()
Matt Jankowski 476d1237d4
Typo fix in json ld helper spec ()
Claire 7d9b209fe8
Fix call to inefficient `delete_matched` cache method in domain blocks ()
Matt Jankowski af366f65ee
Add spec coverage for `models/form/custom_emoji_batch` class ()
Matt Jankowski 1820bad646
Fix `Performance/StringIdentifierArgument` cop ()
Matt Jankowski b1dec09d20
Fix `Style/InverseMethods` cop ()
Matt Jankowski db897eaa5a
Unwind `map` on single-item array in `spec/services/delete_account_service` spec ()
Matt Jankowski ef9797a395
Un-nest contexts in `settings/2fa/webauthn` spec ()
Matt Jankowski adbfd40a1b
Convert `api/v1/directories` controller spec to request spec ()
Matt Jankowski 28e1a7a394
Improve spec coverage for `models/announcement` class ()
Matt Jankowski 8a3d8c6c14
Remove the `stub_stdout` wrapper around CLI specs ()
Claire 89a496b42f
Fix status edits not always being streamed to mentioned users ()
Matt Jankowski b5a1013ae3
Combine `CLI::...` spec example subjects ()
Matt Jankowski 0e4233de9d
Controller spec to request spec: `api/v2/suggestions` ()
Matt Jankowski 0c64092500
Controller spec to request spec: `api/v1/accounts/search` ()
Matt Jankowski 16ede59d0a
Controller spec to request spec: `api/v1/featured_tags/suggestions` ()
Matt Jankowski 809506bdd4
Controller spec to request spec: `api/v1/accounts/pins` ()
Matt Jankowski 94cc707ab3
Controller spec to request spec: `api/v1/accounts/notes` ()
Matt Jankowski e544b6df42
Controller spec to request spec: `api/v1/accounts/lookup` ()
Matt Jankowski a968898dc7
Controller spec to request spec: `api/v1/accounts/lists` ()
Matt Jankowski 8f94502e7d
Controller spec to request spec: `api/v1/accounts/identify_proofs` ()
Matt Jankowski 78347d2556
Controller spec to request spec: `api/v1/accounts/familiar_followers` ()
Matt Jankowski 11d2bd9716
Fix intermittent failure from unspecified order in `api/v1/accounts/relationships` spec ()
Matt Jankowski a3cbb4b2f1
Add spec for `CLI::Search#deploy` command ()
Matt Jankowski 8de86eabbf
Add spec for `CLI::Domains#crawl` command ()
Matt Jankowski 7e514688b3
Convert `api/v2/search` controller spec to request spec ()
Matt Jankowski 8d8ae05a18
Add spec coverage for `CLI::Media#lookup` command ()
Matt Jankowski ad34d33bfd
Formalize some patterns in cli specs ()
Matt Jankowski 0b4a3a0437
Remove remaining `without_partial_double_verification` usage ()
Claire 658ad7a6ca
Fix flaky tests related to file creation ()
Matt Jankowski 0e8ba19113
Add spec coverage for `CLI::Emoji` class ()
Matt Jankowski ed7b5c091b
Remove double subject call in `services/delete_account_service` spec ()
Matt Jankowski be6bb1a10d
Remove double subject call in `services/suspend_account_service` spec ()
Matt Jankowski 5517df61de
Remove double subject call in `services/activitypub/process_account_service` spec ()
Matt Jankowski faffd81976
Remove double subject call in `services/unsuspend_account_service` spec ()
Matt Jankowski 89a8e6e622
Remove 2x double subject call in `models/form/account_batch` spec ()
Matt Jankowski 71e5a16eba
Remove triple subject call in `api/v1/lists` spec ()
Matt Jankowski cca19f5fbb
Use the `Admin::ActionLog` fabricator in admin/action_logs spec ()
Matt Jankowski b3b009e6aa
Add spec coverage for `CLI::EmailDomainBlocks` commands ()
Matt Jankowski 9603198982
Add spec coverage for `CLI::Domains#purge` command ()
Matt Jankowski 1bf2230fd1
Add spec coverage for `CLI::Upgrade#storage_schema` command ()
Matt Jankowski 19ad51253d
Prevent triple-subject run in admin/domain_blocks spec ()
Matt Jankowski d848d8d87c
Add helper methods for domains allow and export blocks files ()
Matt Jankowski 5631f139c1
Fix `Lint/SymbolConversion` cop ()
Matt Jankowski aa8563d43d
Fix `Style/SuperWithArgsParentheses` cop ()
Matt Jankowski 1564799952
Add spec coverage for media CLI `refresh` command ()
Matt Jankowski 7753e5f715
Add shared example for CLI command specs ()
Matt Jankowski 92fa9b109f
Add spec coverage for media CLI usage command ()
Matt Jankowski 440b80b2e7
Model concerns organization into module namespaces ()
Matt Jankowski b751078fcd
Eliminate double subject call in admin/ controller specs ()
Matt Jankowski 1f1c75bba5
File cleanup/organization in `controllers/concerns` ()
Matt Jankowski 0530ce5e95
Convert accounts controller spec to request spec ()
Matt Jankowski e7c340a634
Spec coverage for missing `q` param and error conditions in `api/v2/search` controller ()
Claire 85662a5a57
Change `img-src` and `media-src` CSP directives to not include `https:` ()
Matt Jankowski bb0efe16e6
Remove `default_scope` from `MediaAttachment` class ()
Matt Jankowski ce78a9c9ac
Clean up `two_factor_authentication/confirmations` controller spec ()
Filippo Giunchedi e6fd9a59e6
Fix FamiliarFollowersController test response comparison ()
Co-authored-by: Filippo Giunchedi <filippo@debian.org>
Matt Jankowski e48ecd2929
Remove `default_scope` from `Admin::ActionLog` ()
Matt Jankowski 291dc04e67
Remove un-needed `action` and `template` options to `render` in controllers ()
Emelia Smith 603b245cc6
Add VAPID public key to instance serializer ()
Co-authored-by: Renaud Chaput <renchap@gmail.com>
Matt Jankowski 6b46bf9953
Handle scenario when webfinger response `subject` is missing host value ()
Matt Jankowski 19baf22683
Add missing email previews for `AdminMailer` ()
Kevin Bongart 7877fcd83c
Deduplicate IDs in relationships and familiar_followers APIs ()
Matt Jankowski 973597c6f1
Consolidate configuration of `Sidekiq::Testing.fake!` setup ()
Matt Jankowski 9742bccbe7
Add coverage for `api/v2/media` endpoint ()
Eugen Rochko cdc57c74b7
Fix unsupported time zone or locale preventing sign-up ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 67fd3187b3
Update rspec fixture path config to silence deprecation warning ()
Matt Jankowski 30ee4aaff4
Convert measurement `api/v1/admin/*` controller specs to request specs ()
Matt Jankowski 32e19e3af6
Reduce `.times` usage in request and controller specs ()
Matt Jankowski f7cb64a184
Add coverage for `settings/privacy` controller ()
Matt Jankowski b2e8af8889
Add coverage for `settings/verifications` controller ()
Matt Jankowski 6d51ac246b
Update partials for the `AdminMailer.new_trends` mailer ()
Matt Jankowski a6d446e6a7
Add coverage for `remote_interaction_helper` ()
Matt Jankowski 876f5b1d12
Convert `/instances/*` controller specs to request specs ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 718c95e7af
Convert `api/v1/custom_emojis` controller spec to request spec ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Claire c260a68f54
Clean up some `Mastodon::CLI::Accounts` tests ()
Matt Jankowski 17582d36d5
Convert `api/v1/preferences` controller spec to request spec ()
Matt Jankowski 9a01a260a0
Convert `api/v1/scheduled_statuses` controller spec to request spec ()
Matt Jankowski b9fb47aeb1
Convert `api/v1/endorsements` controller spec to request spec ()
Matt Jankowski 371f355719
Reduce `.times` usage in `AccountStatusesCleanupPolicy` ()
Matt Jankowski d2aacea8da
Reduce `.times` usage in AccountSearch spec, use constant for default limit ()
Matt Jankowski 00c6ebd86f
Reduce `.times` usage in `StatusPin` and add `PIN_LIMIT` constant in validator ()
Matt Jankowski 1fabf20a88
Reduce `.times` usage in `lib/mastodon/cli/accounts` spec ()
Matt Jankowski 09a2db3f6c
Move api/v2/filters spec to correct path location ()
Matt Jankowski e892efbc40
Configure elastic search integration with rspec tag ()
Claire 297839c10c
Rewrite `/api/v1/statuses` tests as request specs ()
Claire 9257737675
Rewrite `/api/v1/accounts` tests as request specs ()
Matt Jankowski 549e8e7baf
Add `email_spec` and speedup/cleanup to `spec/mailers` ()
Matt Jankowski 1526e54ac6
Add spec coverage for `workers/redownload_*` worker classes ()
Matt Jankowski cb1a4a8713
Reduce expectations for `RSpec/MultipleExpectations` cop in `spec/presenters` specs ()
Matt Jankowski 155fb84141
Improve spec coverage for collection of `workers/` classes ()
Matt Jankowski 8a285413f7
Reduce expectations for `RSpec/MultipleExpectations` cop in `MoveWorker` spec ()
Matt Jankowski 3f0c1566c3
Reduce expectations for `RSpec/MultipleExpectations` cop in `api/v1/accounts/relationships` spec ()
Matt Jankowski c1f93def40
Reduce expectations for `RSpec/MultipleExpectations` cop in `controllers/statuses` spec ()
Matt Jankowski 04121bd020
Disable simplecov `enable_coverage_for_eval` option, move to standalone file ()
Matt Jankowski 3de9145613
Move controller specs for `well-known` endpoints to request specs ()
Matt Jankowski 12a5b7391d
Add spec for well known change password endpoint ()
Matt Jankowski fe58ac8d9f
Improve spec coverage for `api/web/push_subscriptions` controller ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 7c72944661
Use `Lcov` simplecov formatter on CI and `HTML` elsewhere ()
Nick Schonning 36d7d1781f
Add CodeCov for Ruby coverage reports ()
Matt Jankowski b2c5b20ef2
Fix `RSpec/AnyInstance` cop ()
Matt Jankowski d562fb8459
Specs for minimal CSP policy in `Api::` controllers ()
Matt Jankowski 5e2ecc736d
Remove double `subject` in api/v1/accounts/relationships spec ()
Matt Jankowski b7807f3d84
Use `normalizes` to prepare `Webhook#events` value ()
Matt Jankowski 49ba5a9f94
Use `hash_including` to check `AccountFilter` setup in `admin/accounts` controller spec ()
Matt Jankowski a36b59be8a
Spec coverage for `api/v1/trends` controllers ()
Claire 07a4059901
Add support for invite codes in the registration API ()
Eugen Rochko 0d14fcebae
Change link previews to keep original URL from the status ()
Matt Jankowski 9dc3ce878b
Speed-up in `Settings::` controllers specs ()
Matt Jankowski e79bf1b1e7
Minor speed improvement on `controllers/accounts` spec ()
Claire c451bbe249
Allow viewing and severing relationships with suspended accounts ()
Matt Jankowski 548bb30b2a
Consolidate html page title output logic into helper ()
Matt Jankowski 63c9102f8a
Fix `RSpec/MessageChain` cop ()
Matt Jankowski c9204b792c
Fix `Rails/I18nLocaleTexts` cop ()
Matt Jankowski 69d00e2721
Fix `RSpec/InstanceVariable` cop ()
Matt Jankowski 4329616c53
Ignore block result of `send` method and remove `rubocop:disable` in deepl spec ()
Matt Jankowski b05575e242
Move RSpec config for streaming/search managers to be near classes ()
Matt Jankowski ce91d14d48
Fix `Style/WordArray` cop ()
Matt Jankowski c03bd2a238
Don't stub SUT in `FollowLimitValidator` spec ()
Matt Jankowski 9b7b4d748f
Simplify request cache spec shared examples ()
Claire 23e32a4b30
Fix format-dependent redirects being cached regardless of requested format ()
Matt Jankowski e545978076
Use framework helpers instead of i-vars in controller specs ()
Matt Jankowski ee57bb4b44
Account statuses filter spec speedup ()
Matt Jankowski ae7c20b00c
Move search and streaming spec manager classes to separate support files ()
Matt Jankowski 370802ce48
Add coverage for `CLI::Maintenance#fix_duplicates` command ()
Matt Jankowski 1d51e10510
Consolidate JSON parsing in serializers specs ()
Matt Jankowski a688a9ed20
Use strings instead of numeric literals and remove `rubocop:disable` in cache spec ()
Matt Jankowski dc0bf87090
Remove unused before block from settings/branding spec ()
Matt Jankowski 45770c9306
Fix `Performance/MapMethodChain` cop ()
Matt Jankowski 49e2772064
Fix `RSpec/MessageSpies` cop ()
Matt Jankowski 2862ad701f
Stub controller methods and remove `rubocop:disable` in captcha feature spec ()
Matt Jankowski cfa14ec6d1
Fix `Lint/EmptyBlock` cop ()
Matt Jankowski b06284c572
Fix `RSpec/HookArgument` cop ()
Matt Jankowski d6f50839e1
Fix `RSpec/SpecFilePathFormat` cops ()
Matt Jankowski fe26f33e0a
Fix `Rails/RedundantActiveRecordAllMethod` cop ()
Matt Jankowski 949f5eb860
Fix `RSpec/MetadataStyle` cop in spec/ ()
Claire c0989b78f8
Fix incoming status creation date not being restricted to standard ISO8601 ()
Renaud Chaput 6712bf86cd
Fixes website not loading for unlogged users ()
Claire 0337df3a42
Fix posts from threads received out-of-order sometimes not being inserted into timelines ()
Claire d649bbf28f
Add some more tests and clean up domain block controller ()
Matt Jankowski beee9ea991
Fix `RSpec/LetSetup` cop in spec/controllers/admin area ()
Matt Jankowski eae5c7334a
Extract class from CSP configuration/initialization ()
Matt Jankowski 2e6bf60f15
Use `deliveries.size` in mailer-related examples in controller specs ()
Claire 93e4cdc31b
Fix hashtag matching pattern matching some URLs ()
Matt Jankowski 1f5187e2e2
Misc spec/refactor to user mailer and user mailer spec ()
Claire bbf46cc418
Fix error and incorrect URLs in `/api/v1/accounts/:id/featured_tags` for remote accounts ()
Jeong Arm 8f998cd96a
Handle featured collections without items ()
Claire 49b8433c56
Fix confusing screen when visiting a confirmation link for an already-confirmed email ()
Matt Jankowski e93a75f1a1
Rails 7.1 update ()
Daniel M Brasil 26d2a2a0cc
Migrate to request specs in `/api/v1/media` ()
Claire bcae744275
Fix some link anchors being recognized as hashtags ()
Matt Jankowski b0213472df
Validate allowed schemes on preview card URLs ()
Matt Jankowski ab0fb81479
Configure brakeman to ignore url safe preview card urls ()
Claire 13688539bc
Fix processing LDSigned activities from actors with unknown public keys ()
Matt Jankowski 9f218c9924
Refactor appeal partial to avoid brakeman XSS warning ()
Matt Jankowski bcd0171e5e
Fix `Lint/UselessAssignment` cop ()
Daniel M Brasil 7bc8f03162
Add test coverage for `Mastodon::CLI::Accounts#migrate` ()
Matt Jankowski a1b27d8b61
Fix `Naming/VariableNumber` cop ()
Emelia Smith 7c3fea7275
Feature: Allow token introspection without read scope ()
Daniel M Brasil 091a21e1bc
Add test coverage for `Mastodon::CLI::Accounts#prune` ()
Claire e9dc30cdba
Fix duplicate github annotations for rspec failures ()
Nick Schonning 5ef26d8fd5
Add RSpec GitHub annotations gem ()
Matt Jankowski 71447ab19f
Fix `Capybara/ClickLinkOrButtonStyle` cop in spec/features/admin area ()
Matt Jankowski 2528a0721f
Update `rubocop-capybara` to version 2.19.0 ()
Claire b34a2b1b33
Fix errors in CLI specs ()
Victor Lee c4bddc9855
Add spec for poll model ()
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 12bb7be8b5
Spec speed ups on `AccountsController` spec ()
Matt Jankowski d54fec24e5
Add coverage for `CLI::PreviewCards#remove` command ()
Matt Jankowski 19900f647e
Add coverage for `UnreservedUsernameValidator` ()
Matt Jankowski fc9ab61448
Expand spec coverage of `CLI::Media` ()
Matt Jankowski 893b2f33fd
Extract shared example for cacheable response in specs ()
Matt Jankowski 708299bb0d
Misc coverage improvements for `Admin::` and `Settings::` controllers ()
Daniel M Brasil e0ed0f8c7c
Migrate to request specs in `/api/v1/notifications` ()
Daniel M Brasil cafdaec6cf
Migrate to request specs in `/api/v1/lists/:id/accounts` ()