Commit Graph

2020 Commits (b68f185573158dedabe4b78bdf86a0cfaa5abb96)

Author SHA1 Message Date
Matt Jankowski bb0efe16e6
Remove `default_scope` from `MediaAttachment` class ()
Matt Jankowski ce78a9c9ac
Clean up `two_factor_authentication/confirmations` controller spec ()
Filippo Giunchedi e6fd9a59e6
Fix FamiliarFollowersController test response comparison ()
Co-authored-by: Filippo Giunchedi <filippo@debian.org>
Matt Jankowski e48ecd2929
Remove `default_scope` from `Admin::ActionLog` ()
Matt Jankowski 291dc04e67
Remove un-needed `action` and `template` options to `render` in controllers ()
Emelia Smith 603b245cc6
Add VAPID public key to instance serializer ()
Co-authored-by: Renaud Chaput <renchap@gmail.com>
Matt Jankowski 6b46bf9953
Handle scenario when webfinger response `subject` is missing host value ()
Matt Jankowski 19baf22683
Add missing email previews for `AdminMailer` ()
Kevin Bongart 7877fcd83c
Deduplicate IDs in relationships and familiar_followers APIs ()
Matt Jankowski 973597c6f1
Consolidate configuration of `Sidekiq::Testing.fake!` setup ()
Matt Jankowski 9742bccbe7
Add coverage for `api/v2/media` endpoint ()
Eugen Rochko cdc57c74b7
Fix unsupported time zone or locale preventing sign-up ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 67fd3187b3
Update rspec fixture path config to silence deprecation warning ()
Matt Jankowski 30ee4aaff4
Convert measurement `api/v1/admin/*` controller specs to request specs ()
Matt Jankowski 32e19e3af6
Reduce `.times` usage in request and controller specs ()
Matt Jankowski f7cb64a184
Add coverage for `settings/privacy` controller ()
Matt Jankowski b2e8af8889
Add coverage for `settings/verifications` controller ()
Matt Jankowski 6d51ac246b
Update partials for the `AdminMailer.new_trends` mailer ()
Matt Jankowski a6d446e6a7
Add coverage for `remote_interaction_helper` ()
Matt Jankowski 876f5b1d12
Convert `/instances/*` controller specs to request specs ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 718c95e7af
Convert `api/v1/custom_emojis` controller spec to request spec ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Claire c260a68f54
Clean up some `Mastodon::CLI::Accounts` tests ()
Matt Jankowski 17582d36d5
Convert `api/v1/preferences` controller spec to request spec ()
Matt Jankowski 9a01a260a0
Convert `api/v1/scheduled_statuses` controller spec to request spec ()
Matt Jankowski b9fb47aeb1
Convert `api/v1/endorsements` controller spec to request spec ()
Matt Jankowski 371f355719
Reduce `.times` usage in `AccountStatusesCleanupPolicy` ()
Matt Jankowski d2aacea8da
Reduce `.times` usage in AccountSearch spec, use constant for default limit ()
Matt Jankowski 00c6ebd86f
Reduce `.times` usage in `StatusPin` and add `PIN_LIMIT` constant in validator ()
Matt Jankowski 1fabf20a88
Reduce `.times` usage in `lib/mastodon/cli/accounts` spec ()
Matt Jankowski 09a2db3f6c
Move api/v2/filters spec to correct path location ()
Matt Jankowski e892efbc40
Configure elastic search integration with rspec tag ()
Claire 297839c10c
Rewrite `/api/v1/statuses` tests as request specs ()
Claire 9257737675
Rewrite `/api/v1/accounts` tests as request specs ()
Matt Jankowski 549e8e7baf
Add `email_spec` and speedup/cleanup to `spec/mailers` ()
Matt Jankowski 1526e54ac6
Add spec coverage for `workers/redownload_*` worker classes ()
Matt Jankowski cb1a4a8713
Reduce expectations for `RSpec/MultipleExpectations` cop in `spec/presenters` specs ()
Matt Jankowski 155fb84141
Improve spec coverage for collection of `workers/` classes ()
Matt Jankowski 8a285413f7
Reduce expectations for `RSpec/MultipleExpectations` cop in `MoveWorker` spec ()
Matt Jankowski 3f0c1566c3
Reduce expectations for `RSpec/MultipleExpectations` cop in `api/v1/accounts/relationships` spec ()
Matt Jankowski c1f93def40
Reduce expectations for `RSpec/MultipleExpectations` cop in `controllers/statuses` spec ()
Matt Jankowski 04121bd020
Disable simplecov `enable_coverage_for_eval` option, move to standalone file ()
Matt Jankowski 3de9145613
Move controller specs for `well-known` endpoints to request specs ()
Matt Jankowski 12a5b7391d
Add spec for well known change password endpoint ()
Matt Jankowski fe58ac8d9f
Improve spec coverage for `api/web/push_subscriptions` controller ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 7c72944661
Use `Lcov` simplecov formatter on CI and `HTML` elsewhere ()
Nick Schonning 36d7d1781f
Add CodeCov for Ruby coverage reports ()
Matt Jankowski b2c5b20ef2
Fix `RSpec/AnyInstance` cop ()
Matt Jankowski d562fb8459
Specs for minimal CSP policy in `Api::` controllers ()
Matt Jankowski 5e2ecc736d
Remove double `subject` in api/v1/accounts/relationships spec ()
Matt Jankowski b7807f3d84
Use `normalizes` to prepare `Webhook#events` value ()
Matt Jankowski 49ba5a9f94
Use `hash_including` to check `AccountFilter` setup in `admin/accounts` controller spec ()
Matt Jankowski a36b59be8a
Spec coverage for `api/v1/trends` controllers ()
Claire 07a4059901
Add support for invite codes in the registration API ()
Eugen Rochko 0d14fcebae
Change link previews to keep original URL from the status ()
Matt Jankowski 9dc3ce878b
Speed-up in `Settings::` controllers specs ()
Matt Jankowski e79bf1b1e7
Minor speed improvement on `controllers/accounts` spec ()
Claire c451bbe249
Allow viewing and severing relationships with suspended accounts ()
Matt Jankowski 548bb30b2a
Consolidate html page title output logic into helper ()
Matt Jankowski 63c9102f8a
Fix `RSpec/MessageChain` cop ()
Matt Jankowski c9204b792c
Fix `Rails/I18nLocaleTexts` cop ()
Matt Jankowski 69d00e2721
Fix `RSpec/InstanceVariable` cop ()
Matt Jankowski 4329616c53
Ignore block result of `send` method and remove `rubocop:disable` in deepl spec ()
Matt Jankowski b05575e242
Move RSpec config for streaming/search managers to be near classes ()
Matt Jankowski ce91d14d48
Fix `Style/WordArray` cop ()
Matt Jankowski c03bd2a238
Don't stub SUT in `FollowLimitValidator` spec ()
Matt Jankowski 9b7b4d748f
Simplify request cache spec shared examples ()
Claire 23e32a4b30
Fix format-dependent redirects being cached regardless of requested format ()
Matt Jankowski e545978076
Use framework helpers instead of i-vars in controller specs ()
Matt Jankowski ee57bb4b44
Account statuses filter spec speedup ()
Matt Jankowski ae7c20b00c
Move search and streaming spec manager classes to separate support files ()
Matt Jankowski 370802ce48
Add coverage for `CLI::Maintenance#fix_duplicates` command ()
Matt Jankowski 1d51e10510
Consolidate JSON parsing in serializers specs ()
Matt Jankowski a688a9ed20
Use strings instead of numeric literals and remove `rubocop:disable` in cache spec ()
Matt Jankowski dc0bf87090
Remove unused before block from settings/branding spec ()
Matt Jankowski 45770c9306
Fix `Performance/MapMethodChain` cop ()
Matt Jankowski 49e2772064
Fix `RSpec/MessageSpies` cop ()
Matt Jankowski 2862ad701f
Stub controller methods and remove `rubocop:disable` in captcha feature spec ()
Matt Jankowski cfa14ec6d1
Fix `Lint/EmptyBlock` cop ()
Matt Jankowski b06284c572
Fix `RSpec/HookArgument` cop ()
Matt Jankowski d6f50839e1
Fix `RSpec/SpecFilePathFormat` cops ()
Matt Jankowski fe26f33e0a
Fix `Rails/RedundantActiveRecordAllMethod` cop ()
Matt Jankowski 949f5eb860
Fix `RSpec/MetadataStyle` cop in spec/ ()
Claire c0989b78f8
Fix incoming status creation date not being restricted to standard ISO8601 ()
Renaud Chaput 6712bf86cd
Fixes website not loading for unlogged users ()
Claire 0337df3a42
Fix posts from threads received out-of-order sometimes not being inserted into timelines ()
Claire d649bbf28f
Add some more tests and clean up domain block controller ()
Matt Jankowski beee9ea991
Fix `RSpec/LetSetup` cop in spec/controllers/admin area ()
Matt Jankowski eae5c7334a
Extract class from CSP configuration/initialization ()
Matt Jankowski 2e6bf60f15
Use `deliveries.size` in mailer-related examples in controller specs ()
Claire 93e4cdc31b
Fix hashtag matching pattern matching some URLs ()
Matt Jankowski 1f5187e2e2
Misc spec/refactor to user mailer and user mailer spec ()
Claire bbf46cc418
Fix error and incorrect URLs in `/api/v1/accounts/:id/featured_tags` for remote accounts ()
Jeong Arm 8f998cd96a
Handle featured collections without items ()
Claire 49b8433c56
Fix confusing screen when visiting a confirmation link for an already-confirmed email ()
Matt Jankowski e93a75f1a1
Rails 7.1 update ()
Daniel M Brasil 26d2a2a0cc
Migrate to request specs in `/api/v1/media` ()
Claire bcae744275
Fix some link anchors being recognized as hashtags ()
Matt Jankowski b0213472df
Validate allowed schemes on preview card URLs ()
Matt Jankowski ab0fb81479
Configure brakeman to ignore url safe preview card urls ()
Claire 13688539bc
Fix processing LDSigned activities from actors with unknown public keys ()
Matt Jankowski 9f218c9924
Refactor appeal partial to avoid brakeman XSS warning ()
Matt Jankowski bcd0171e5e
Fix `Lint/UselessAssignment` cop ()
Daniel M Brasil 7bc8f03162
Add test coverage for `Mastodon::CLI::Accounts#migrate` ()
Matt Jankowski a1b27d8b61
Fix `Naming/VariableNumber` cop ()
Emelia Smith 7c3fea7275
Feature: Allow token introspection without read scope ()
Daniel M Brasil 091a21e1bc
Add test coverage for `Mastodon::CLI::Accounts#prune` ()
Claire e9dc30cdba
Fix duplicate github annotations for rspec failures ()
Nick Schonning 5ef26d8fd5
Add RSpec GitHub annotations gem ()
Matt Jankowski 71447ab19f
Fix `Capybara/ClickLinkOrButtonStyle` cop in spec/features/admin area ()
Matt Jankowski 2528a0721f
Update `rubocop-capybara` to version 2.19.0 ()
Claire b34a2b1b33
Fix errors in CLI specs ()
Victor Lee c4bddc9855
Add spec for poll model ()
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 12bb7be8b5
Spec speed ups on `AccountsController` spec ()
Matt Jankowski d54fec24e5
Add coverage for `CLI::PreviewCards#remove` command ()
Matt Jankowski 19900f647e
Add coverage for `UnreservedUsernameValidator` ()
Matt Jankowski fc9ab61448
Expand spec coverage of `CLI::Media` ()
Matt Jankowski 893b2f33fd
Extract shared example for cacheable response in specs ()
Matt Jankowski 708299bb0d
Misc coverage improvements for `Admin::` and `Settings::` controllers ()
Daniel M Brasil e0ed0f8c7c
Migrate to request specs in `/api/v1/notifications` ()
Daniel M Brasil cafdaec6cf
Migrate to request specs in `/api/v1/lists/:id/accounts` ()
Daniel M Brasil 8e6116503d
Migrate to request specs in `/api/v1/blocks` ()
Daniel M Brasil d9caa6ed24
Migrate to request specs in `/api/v1/admin/accounts` ()
Matt Jankowski f5bc1f20e2
Add coverage for `ExistingUsernameValidator` ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski f8afa0f614
Remove unused stub json ld context ()
Matt Jankowski 00e92b4038
Add coverage for `CLI::Statuses` command ()
Claire 299aa71c8f
Fix handling of `inLanguage` attribute in preview card processing ()
Daniel M Brasil 82beeb2f7e
Migrate to request specs in `/api/v1/admin/trends/links` ()
Matt Jankowski 1b195ce115
Speed-up on `Rack::Attack` spec ()
Claire 71cfdd7865
Fix duplicate tests ()
Matt Jankowski cad8cc90ba
Speed-up on `MoveWorker` spec ()
Daniel M Brasil 058f73a4f5
Add request specs for `/api/v1/reports` ()
Matt Jankowski abf0e1fa39
Move `SignedReqestHelpers` rspec config to separate file ()
Daniel M Brasil bc6cd27d9e
Migrate to request specs in `/api/v1/followed_tags` ()
Matt Jankowski fd9dea21d0
DB speedup in `API::` controller/request specs ()
Daniel M Brasil ecdb31d479
Migrate to request specs in `/api/v1/favourites` ()
Daniel M Brasil 7664e3b692
Migrate to request specs in `/api/v1/statuses/:status_id/source` ()
Daniel M Brasil 4230d1ee0a
Migrate to request specs in `/api/v1/timelines/tag/:hashtag` ()
KMY(雪あすか) 45bdd60f3c
Fix when unfollow a tag, my post also disappears from the home timeline ()
Matt Jankowski 133f218a4d
Add system specs for admin area `batch` actions ()
Claire 27e84c0691
Fix duplicate reports being sent when reporting some remote posts ()
Claire 3262d1f1b6
Fix incorrect serialization of regional languages in `contentMap` ()
Claire 340c390849
Fix crash when filtering for “dormant” relationships ()
Claire 40ba6e119b
Fix Vary headers not being set on some redirects ()
Matt Jankowski 72cec47c13
Silence deprecation warning in CacheBuster spec ()
gunchleoc 68ec1d180a
Fix language sorting in settings ()
Matt Jankowski c676bc91e9
Dont match mention in url query string ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Claire ceb365c419
Fix boosts of local users being filtered in account timelines ()
Claire 828eebad48
Add `hide_collections`, `discoverable` and `indexable` attributes to credentials API ()
Claire 94893cf24f
Merge pull request from GHSA-hcqf-fw2r-52g4
* Revert "Fix request URL normalisation for bare domain and 8-bit characters ()"

This reverts commit 8891d8945d.

* Revert "Do not normalize URL before fetching it ()"

This reverts commit fd284311e7.
Claire 6273416292
Fix post edits not being forwarded as expected ()