mastodon

Commit Graph

Author	SHA1	Message	Date
Eugen Rochko	8f6c67bfde	Fix performance of account timelines (#17709 ) * Fix performance of account timelines * Various fixes and improvements * Fix duplicate results being returned Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Fix grouping for pinned statuses scope Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Claire	472bc89611	Fix some flaky tests that randomly failed because of item ordering (#17509 )	3 years ago
Claire	0a120d86d2	Fix error-prone SQL queries (#15828 ) * Fix error-prone SQL queries in Account search While this code seems to not present an actual vulnerability, one could easily be introduced by mistake due to how the query is built. This PR parameterises the `to_tsquery` input to make the query more robust. * Harden code for Status#tagged_with_all and Status#tagged_with_none Those two scopes aren't used in a way that could be vulnerable to an SQL injection, but keeping them unchanged might be a hazard. * Remove unneeded spaces surrounding tsquery term * Please CodeClimate * Move advanced_search_for SQL template to its own function This avoids one level of indentation while making clearer that the SQL template isn't build from all the dynamic parameters of advanced_search_for. * Add tests covering tagged_with, tagged_with_all and tagged_with_none * Rewrite tagged_with_none to avoid multiple joins and make it more robust * Remove obsolete brakeman warnings * Revert "Remove unneeded spaces surrounding tsquery term" The two queries are not strictly equivalent. This reverts commit `86f16c537e`.	3 years ago
Eugen Rochko	e8bc187845	Refactor how public and tag timelines are queried (#14728 )	4 years ago
Takeshi Umeda	26b08a3c54	Add remote only to public timeline (#13504 ) * Add remote only to public timeline * Fix code style	5 years ago
ThibG	a4240fd027	Improve RSS entries for statuses (#13592 ) * Improve RSS entries for statuses - Render polls in both accounts and tags serializers - Refactor RSS serializers - Change title preview to include ellipsis when truncated - Change title preview to show CW instead of toot text - Add tests * Remove title from OEmbed serialization Twitter doesn't serialize title either, and tihs allows us to move the title formatting code to the RSS serializers.	5 years ago
Yamagishi Kazutoshi	e223fd8c61	Revert "improve status title (#8596 )" (#13591 ) This reverts commit `05756c9a14`.	5 years ago
Alexander	05756c9a14	improve status title (#8596 ) * improve shown status title, useful for atom/rss * use single quotes to satisfy codeclimate * fix tests, make message more pretty * fix tests * fix codestyle * fix codestyle * remove atom_serializer_spec Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	5 years ago
Eugen Rochko	f665901e3c	Fix performance of home feed regeneration (#12084 ) Fetching statuses from all followed accounts at once takes too long within Postgres. Fetching them one by one and merging in Ruby could be a lot less resource-intensive Because the query for dynamically fetching the home timeline is so heavy, we can no longer offer it when the home timeline is missing	5 years ago
Eugen Rochko	3fd6ab99e6	Remove deprecated REST API `GET /api/v1/timelines/direct` (#11212 )	6 years ago
ashleyhull-versent	f194857ac9	rubocop issues - Cleaning up (#8912 ) * cleanup pass * undo mistakes * fixed. * revert	6 years ago
masarakki	4bdab203ac	exclude-other-silenced-accounts (#7528 )	7 years ago
Eugen Rochko	d010816ba8	Fix error when trying to update counters for statuses that are gone (#8251 )	7 years ago
Eugen Rochko	7eec279c7f	Change language opt-out to language opt-in (#7823 ) * Switch filtered_languages to chosen_languages * Adjust interface * Remove unused translations	7 years ago
Eugen Rochko	a7d726c383	Improve counter caches on Status and Account (#7644 ) Do not touch statuses_count on accounts table when mass-destroying statuses to reduce load when removing accounts, same for reblogs_count and favourites_count Do not count statuses with direct visibility in statuses_count Fix #828	7 years ago
tateisu	b87a1229c7	optimize direct timeline (#7614 ) * optimize direct timeline * fix typo in class name * change filter condition for direct timeline * fix codestyle issue * revoke index_accounts_not_silenced because direct timeline does not use it. * revoke index_accounts_not_silenced because direct timeline does not use it. * fix rspec test condition. * fix rspec test condition. * fix rspec test condition. * revoke adding column and partial index * (direct timeline) move merging logic to model * fix pagination parameter * add method arguments that switches return array of status or cache_ids * fix order by * returns ActiveRecord.Relation in default behavor * fix codestyle issue	7 years ago
Kaito Sinclaire	156b916caf	Direct messages column (#4514 ) * Added a timeline for Direct statuses * Lists all Direct statuses you've sent and received * Displayed in Getting Started * Streaming server support for direct TL * Changes to match other timelines in 2.0	7 years ago
ysksn	9d9b1aff1e	Add tests for Status#title (#5718 )	7 years ago
ysksn	556c07df1f	Add tests for Status#verb (#5717 )	7 years ago
ysksn	3023725936	Add tests for Status#hidden? (#5719 )	7 years ago
Akihiko Odaki	0de82dd316	Do not filter statuses with unknown languages (#5045 )	8 years ago
unarist	dd6f9a1b82	Validate uri presence for remote status (#4985 )	8 years ago
Akihiko Odaki	198a9a4fa4	Remove local_only scope in Status (#4977 )	8 years ago
Eugen Rochko	e7adbf572a	Switch to static URIs, new URI format in both protocols for new statuses (#4815 ) * Decouple Status#local? from uri being nil * Replace on-the-fly URI generation with stored URIs - Generate URI in after_save hook for local statuses - Use static value in TagManager when available, fallback to tag format - Make TagManager use ActivityPub::TagManager to understand new format - Adjust tests * Use other heuristic for locality of old statuses, do not perform long query * Exclude tombstone stream entries from Atom feed * Prevent nil statuses from landing in Pubsubhubbub::DistributionWorker * Fix URI not being saved (#4818) * Add more specs for Status * Save generated uri immediately and also fix method order to minimize diff. * Fix alternate HTML URL in Atom * Fix tests * Remove not-null constraint from statuses migration to speed it up	8 years ago
Eugen Rochko	53b2b1b238	Count all URLs in text as 23 characters flat, do not count domain part of usernames (#4427 ) * Count all URLs in text as 23 characters flat, do not count domain part of usernames * Add new status text counting logic to web UI	8 years ago
Eugen Rochko	0190aac240	Fix regression from #3842 (#3892 ) * Fix regression from #3842 Simplify the query by omitting all direct statuses. Private statuses are allowed because they are from accounts we are following (so by definition) Resolves #3887 (alternative) * Adjust test	8 years ago
Akihiko Odaki (@fn_aki@pawoo.net)	bab5a18232	Filter direct statuses in Status.as_home_timeline (#3842 ) The classes using Status.as_home_timeline, namely Feed and PrecomputeFeedService are expected to filter direct statuses as FanOutWriteService does, but their filtering were incomplete or missing. This commit solves the problem by filtering direct statuses in as_home_timeline as the other similar methods such as as_public_timeline does.	8 years ago
Matt Jankowski	6201f96b8a	Introduce StatusThreadingConcern (#3490 ) * Add a StatusFilter class to identify visibility of statuses by accounts * Extract StatusThreadingConcern from Status * Clarify purpose of checking for nil account	8 years ago
Jack Jennings	3a2003ba86	Extract authorization policy for viewing statuses (#3150 )	8 years ago
Matt Jankowski	8f4b7c1820	Filter languages with opt out (#3175 ) * Remove allowed_languages and add filtered_languages * Use filtered_languages instead of allowed_languages	8 years ago
Eugen Rochko	d3be2b582a	More tests for public timeline method (#3171 )	8 years ago
Eugen Rochko	620d0d8029	Account domain blocks (#2381 ) * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation * Adding account domain blocks that filter notifications and public timelines * Add tests for domain blocks in notifications, public timelines Filter reblogs of blocked domains from home * Add API for listing and creating account domain blocks * API for creating/deleting domain blocks, tests for Status#ancestors and Status#descendants, filter domain blocks from them * Filter domains in streaming API * Update account_domain_block_spec.rb	8 years ago
alpaca-tc	a2a2af244c	Optimize Status#permitted_for 24x (#3069 ) * Build query with arel node * Add spec for current Status#permitted_for implementation * Refactor status.rb * Order by visibility to optimize query	8 years ago
Eugen Rochko	d0dd9eb5b5	Feature conversations muting (#3017 ) * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation	8 years ago
alpaca-tc	e9810cbad6	Fixes NoMethodError: undefined method 'first' for nil:NilClass (#3036 )	8 years ago
Eugen Rochko	5abdc77c80	Add conversation model, <ostatus:conversation /> (#3016 ) * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Fix conversation migration * More spec coverage for status before_create * Prevent n+1 query when generating Atom with the new conversations * Improve code style * Remove redundant local variable	8 years ago
Jack Jennings	2d000e9c4e	Add specs for current Status#permitted? implementation (#2982 )	8 years ago
Matt Jankowski	bba537a7be	Improve allowed language handling (#2897 ) * Dont allow empty value in user allowed languages * Sanitize language input to reject blank values in array	8 years ago
Matt Jankowski	f025cc6782	Filter on allowed user language preferences (#2361 ) * Naive approached to timeline filtering * Convert allowed_languages into a db column * Allow users to choose languages to see statuses in * Style list items as two columns * Add a hint to explain language filtering preference	8 years ago
Akihiko Odaki	a6788662b0	Revert "Use PostgreSQL inheritance for blocks and mutes (#2520 )" (#2634 ) This reverts commit `5135d609b7`.	8 years ago
Akihiko Odaki	5135d609b7	Use PostgreSQL inheritance for blocks and mutes (#2520 )	8 years ago
Matt Jankowski	effb08edbb	More status specs (#2564 ) * Add rough outline of coverage needed for public timeline * Specs for visibility, replies, boosts * Specs for silenced account * Specs for local_only option * Specs for blocks and mutes * Add tentative spec around including other silenced account statuses * Add with_public_visibility scope * Add simple coverage for tag_timeline * Tag timeline includes replies * Replace tag.statuses with a tagged_with scope in tag timeline method * Use with_public_visibility in tag timeline * Extract common scope between public and tag timelines to method * Extract local domain check to local_only scope * Extract local_only check to starting scope method * Move list of excluded from timeline account ids to account model * Simplify excluded accounts list on account model * Only join accounts when needed * Rename method for account specific filtering * Extract method for account exclusions * Fix bug where silenced accounts were not including statuses from other silenced accounts * DRY up filter application from account or no account * timeline_scope can be private * Add spec showing that account can find its excluded accounts ids * Add spec which fails if local_only does not have a left outer join * rubocop	8 years ago
Matt Jankowski	affd75936e	Add spec for Status.as_home_timeline (#2451 )	8 years ago
Eugen	338df98ddf	Add more FeedManager#filter? tests (#2413 )	8 years ago
Eugen	32748c0f71	Merge pull request #1184 from thoughtbot/extract-proper-status DRY up reblog vs original status check	8 years ago
Joël Quenneville	4fdeac21f4	Implement pending specs on Status Implement the two pending specs on `Status`: `reblogs_count` and `favourites_count`.	8 years ago
Joël Quenneville	d4c94fa004	DRY up reblog vs original status check Checking reblog vs original status was happening in multiple places across the app. For views, this logic was encapsulated in a helper method named `proper_status` but in the other layers of the app, the logic was duplicated. Because the logic is used at all layers of the app, we extracted it into a `Status#proper` method on the model and changed all uses of the logic to use this method. There is now a single source of truth for this condition. We added test coverage to untested methods that got refactored.	8 years ago
Eugen Rochko	a08e724476	Fix subscriptions:clear task, refactor feeds, refactor streamable activites and atom feed generation to some extent, as well as the way mentions are stored	9 years ago
Eugen Rochko	c8999a116e	Sanitize remote html in atom feeds, API (not just UI), use cached mention relations on Status#mentions	9 years ago
Eugen Rochko	d4892ace62	Adding more test stubs	9 years ago

1 2

53 Commits (b3496583e0d85be80b84657dcfed9c354e5aebe2)