mastodon

Commit Graph

Author	SHA1	Message	Date
ThibG	b1feb47055	Improve searching for private toots from URL (#14856 ) * Improve searching for private toots from URL Most of the time, when sharing toots, people use the toot URL rather than the toot URI, which makes sense since it is the user-facing URL. In Mastodon's case, the URL and URI are different, and Mastodon does not have an index on URL, which means searching a private toot by URL is done with a slow query that will only succeed for very recent toots. This change gets rid of the slow query, and attempts to guess the URI from URL instead, as Mastodon's are predictable. * Add tests * Only return status with guessed uri if url matches Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	1390cc194b	Add indication to admin UI of whether a report has been forwarded (#13237 ) * Add indication to admin UI of whether a report has been forwarded * Rework how forwarded status is displayed Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	e7e099d1a0	Fix deletes not reaching every server that interacted with status (#15200 ) Extract logic for determining ActivityPub inboxes to send deletes to to its own class and explicitly include the person the status replied to (even if not mentioned), people who favourited it, and people who replied to it (though that one is still not recursive)	4 years ago
ThibG	66832cbf33	Undo outgoing follows when suspending a remote account (#15188 )	4 years ago
ThibG	8b8004a962	Fix webfinger redirect handling in ResolveAccountService (#15187 ) * Fix webfinger redirect handling in ResolveAccountService ResolveAccountService#process_webfinger! handled a one-step webfinger redirection, but only accepting the result if it matched the exact URI passed as input, defeating the point of a redirection check. Instead, use the same logic as in `ActivityPub::FetchRemoteAccountService`, updating the resulting `acct:` URI with the result of the first webfinger query. * Add tests	4 years ago
ThibG	96c1e71329	Add import/export feature for bookmarks (#14956 ) * Add ability to export bookmarks * Add support for importing bookmarks * Add bookmark import tests * Add bookmarks export test	4 years ago
ThibG	2f6831f318	Fix sending spurious Rejects when processing remote account deletion (#15104 ) * Fix sending spurious Rejects when processing remote account deletion * Make skip_side_effects imply skip_activitypub	4 years ago
Eugen Rochko	df1653174b	Add cache buster feature for media files (#15155 ) Nginx can be configured to bypass proxy cache when a special header is in the request. If the response is cacheable, it will replace the cache for that request. Proxy caching of media files is desirable when using object storage as a way of minimizing bandwidth costs, but has the drawback of leaving deleted media files for a configured amount of cache time. A cache buster can make those media files immediately unavailable. This especially makes sense when suspending and unsuspending an account.	4 years ago
ThibG	966593393e	Fix DMs not appearing into timelines (#15182 ) Fixes #15179	4 years ago
ThibG	1e64666662	Fix crash in SuspendAccountWorker (#15106 ) * Fix crash in SuspendAccountWorker `follows` is an array thanks to `to_a` * Fix code style issue Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>	4 years ago
Eugen Rochko	3134691948	Add support for reversible suspensions through ActivityPub (#14989 )	4 years ago
ThibG	ee8cf246cf	Fix crashes in SuspendAccountService/UnsuspendAccountService (#15100 ) * Fix crashes in SuspendAccountService/UnsuspendAccountService * Catch filesystem errors	4 years ago
ThibG	f84239ecab	Fix suspension/unsuspension not working because of FeedManager change (#15099 )	4 years ago
ThibG	1f945e7390	Fix followers synchronization mechanism not being triggered on mentions (#15026 ) e.g. if someone on an instance that previously had followers gets mentioned in a private toot, before this PR, they would not receive a Collection-Synchronization header and may show the toot to the former followers in addition to the mentioned person.	4 years ago
ThibG	fb586584f2	Fix account processing failing because of large collections (#15027 ) Fixes #15025	4 years ago
ThibG	ca56527140	Add follower synchronization mechanism (#14510 ) * Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each	4 years ago
OSAMU SATO	96761752ec	Add duration parameter to muting. (#13831 ) * Adding duration to muting. * Remove useless checks	4 years ago
Eugen Rochko	5e1364c448	Add IP-based rules (#14963 )	4 years ago
Eugen Rochko	7d985f2aac	Remove dependency on goldfinger gem (#14919 ) There are edge cases where requests to certain hosts timeout when using the vanilla HTTP.rb gem, which the goldfinger gem uses. Now that we no longer need to support OStatus servers, webfinger logic is so simple that there is no point encapsulating it in a gem, so we can just use our own Request class. With that, we benefit from more robust timeout code and IPv4/IPv6 resolution. Fix #14091	4 years ago
Eugen Rochko	974b1b79ce	Add option to be notified when a followed user posts (#13546 ) * Add bell button Fix #4890 * Remove duplicate type from post-deployment migration * Fix legacy class type mappings * Improve query performance with better index * Fix validation * Remove redundant index from notifications	5 years ago
Eugen Rochko	ed099d8bdc	Change account suspensions to be reversible by default (#14726 )	5 years ago
Eugen Rochko	65760f59df	Refactor feed manager (#14761 )	5 years ago
Eugen Rochko	e8bc187845	Refactor how public and tag timelines are queried (#14728 )	5 years ago
Eugen Rochko	1c308af84c	Change own direct-visibility statuses to be in the home feed again (#14711 ) And remove highlighting in web UI Full circle from #8940	5 years ago
dependabot[bot]	8972e5f7f6	Bump rubocop from 0.86.0 to 0.88.0 (#14412 ) * Bump rubocop from 0.86.0 to 0.88.0 Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.88.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.86.0...v0.88.0) Signed-off-by: dependabot[bot] <support@github.com> * Fix for latest RuboCop Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	5 years ago
Takeshi Umeda	b1bb1906be	Fix limited follower id in fan-out-on-write service (#14709 )	5 years ago
Eugen Rochko	ce8f33dd2f	Fix inefficiencies in fan-out-on-write service (#14682 )	5 years ago
Akihiko Odaki	41eeb9ebaa	Use Status.group instead of Status.distinct in HashQueryService (#14662 ) DISTINCT clause removes duplicated records according to all the selected attributes. In reality, it can remove duplicated records only looking at statuses.id, but the clause confuses the query planner and yields insufficient performance. The behavior is also problematic if the scope produced by HashQueryService is used to query columns without id (using pluck method, for example). The scope is expected to contain unique statuses, but the uniquness will be evaluated with some arbitrary columns other than id. GROUP BY clause resolves those problem by explicitly specifying the column to take into account for the record distinction. A workaround for the problem of DISTINCT clause in Api::V1::Timelines::TagController is no longer necessary and removed.	5 years ago
Takeshi Umeda	156af70e4d	Fix following restriction not working when exact match in account search (#14394 )	5 years ago
Takeshi Umeda	939a47393c	Fix duplicate notification and delivery of mentions (#14378 )	5 years ago
Takeshi Umeda	7540e235a2	Fix movie width and frame_rate returning nil (#14357 ) * Fix movie width and frame_rate returning nil * Add StreamValidationError and raise * Fix code style	5 years ago
ThibG	d658af7ff8	Fix removing allowed domains being done synchronously (#14302 ) * Fix removing allowed domains being done synchronously * Add tests	5 years ago
Eugen Rochko	98b3b80d6b	Fix account domain block not properly unfollowing accounts from domain (#14304 ) Fix #14303	5 years ago
ThibG	ee5a4030f7	Fix removing a DomainAllow rule wiping known accounts in open federation mode (#14298 ) Fixes #14296	5 years ago
Eugen Rochko	ed04697510	Change User-Agent of link preview fetching service to include "Bot" (#14248 ) This forces Twitter to render OpenGraph tags in the response	5 years ago
Eugen Rochko	64aac30733	Add customizable thumbnails for audio and video attachments (#14145 ) - Change audio files to not be stripped of metadata - Automatically extract cover art from audio if it exists - Add `thumbnail` parameter to `POST /api/v1/media`, `POST /api/v2/media` and `PUT /api/v1/media/:id` - Add `icon` to represent it in attachments in ActivityPub - Fix `preview_url` containing URL of missing missing image when there is no thumbnail instead of null - Fix duration of audio not being displayed on public pages until the file is loaded	5 years ago
ThibG	89f40b6c3e	Make domain block/silence/reject-media code more robust (#13424 ) * Split media cleanup from reject-media domain blocks to its own service * Slightly improve ClearDomainMediaService error handling * Lower DomainClearMediaWorker to lowest-priority queue * Do not catch ActiveRecord::RecordNotFound in domain block workers * Fix DomainBlockWorker spec labels * Add some specs * Change domain blocks to immediately mark accounts as suspended Rather than doing so sequentially, account after account, while cleaning their data. This doesn't change much about the time the block takes to complete, but it immediately prevents interaction with the blocked domain, while up to now, it would only be guaranteed when the process ends.	5 years ago
Takeshi Umeda	d890abfcab	Fix performance of follow import (#13836 )	5 years ago
Takeshi Umeda	643065799b	Fix activity not being signed (#13948 )	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820 )	5 years ago
ThibG	27ea7c13a5	Fix hashtag search performing account search as well (#13758 )	5 years ago
Takeshi Umeda	d8bad8fbf6	Fix not publishing update of remote timeline (#13745 ) * Fix not publishing update of remote timeline * fix @ missing * if/unless to if/else	5 years ago
Eugen Rochko	4b766f9846	Refactor monkey-patching of Goldfinger (#12561 )	5 years ago
Eugen Rochko	2744f61696	Fix not being able to resolve public resources in development environment (#13505 )	5 years ago
Eugen Rochko	c3965e28b3	Fix returning results when searching for URL with non-zero offset (#13377 ) Fix #13083	5 years ago
Takeshi Umeda	11169367e4	Fix incorrect deletion of local accounts imported by overwriting (#13350 )	5 years ago
ThibG	f08f880f58	Fix media not being marked sensitive when client sets a CW but no text (#13277 ) Mastodon enforces the “sensitive” flag on media attachments whenever a toot is posted with a Content Warning. However, it does so after potentially converting the Content Warning to toot text (when there is no toot text), which leads to inconsistent and surprising behavior for API clients. This commit fixes this inconsistency.	5 years ago
ThibG	cb12a2cdd3	Fix some timeouts when searching URLs by limiting some database queries (#13253 ) Only look up private toots from database if the request failed because of 401, 403 or 404 errors, as those may indicate a private toot, rather than something that isn't a toot or cannot be processed.	5 years ago
ThibG	b154428e14	Add federation support for the "hide network" preference (#11673 ) * Change ActivityPub follower/following collections to not link first page * Add support for hiding followers and following of remote users * Switch to using a single `hide_collections` column * Address code style remarks	5 years ago
Eugen Rochko	9660aa4543	Change local media attachments to perform heavy processing asynchronously (#13210 ) Fix #9106	5 years ago

1 2 3 4 5 ...

806 Commits (b1feb47055c121c1b6949bd7ef6734bf56c847bd)