1252 Commits (ac9fb0d654440ce1179bab4071941450aa994d2c)

Author	SHA1	Message	Date
Claire	02851848e9	Revamp post filtering system (#18058) ... * Add model for custom filter keywords * Use CustomFilterKeyword internally Does not change the API * Fix /filters/edit and /filters/new * Add migration tests * Remove whole_word column from custom_filters (covered by custom_filter_keywords) * Redesign /filters Instead of a list, present a card that displays more information and handles multiple keywords per filter. * Redesign /filters/new and /filters/edit to add and remove keywords This adds a new gem dependency: cocoon, as well as a npm dependency: cocoon-js-vanilla. Those are used to easily populate and remove form fields from the user interface when manipulating multiple keyword filters at once. * Add /api/v2/filters to edit filter with multiple keywords Entities: - `Filter`: `id`, `title`, `filter_action` (either `hide` or `warn`), `context` `keywords` - `FilterKeyword`: `id`, `keyword`, `whole_word` API endpoits: - `GET /api/v2/filters` to list filters (including keywords) - `POST /api/v2/filters` to create a new filter `keywords_attributes` can also be passed to create keywords in one request - `GET /api/v2/filters/:id` to read a particular filter - `PUT /api/v2/filters/:id` to update a new filter `keywords_attributes` can also be passed to edit, delete or add keywords in one request - `DELETE /api/v2/filters/:id` to delete a particular filter - `GET /api/v2/filters/:id/keywords` to list keywords for a filter - `POST /api/v2/filters/:filter_id/keywords/:id` to add a new keyword to a filter - `GET /api/v2/filter_keywords/:id` to read a particular keyword - `PUT /api/v2/filter_keywords/:id` to edit a particular keyword - `DELETE /api/v2/filter_keywords/:id` to delete a particular keyword * Change from `irreversible` boolean to `action` enum * Remove irrelevent `irreversible_must_be_within_context` check * Fix /filters/new and /filters/edit with update for filter_action * Fix Rubocop/Codeclimate complaining about task names * Refactor FeedManager#phrase_filtered? This moves regexp building and filter caching to the `CustomFilter` class. This does not change the functional behavior yet, but this changes how the cache is built, doing per-custom_filter regexps so that filters can be matched independently, while still offering caching. * Perform server-side filtering and output result in REST API * Fix numerous filters_changed events being sent when editing multiple keywords at once * Add some tests * Use the new API in the WebUI - use client-side logic for filters we have fetched rules for. This is so that filter changes can be retroactively applied without reloading the UI. - use server-side logic for filters we haven't fetched rules for yet (e.g. network error, or initial timeline loading) * Minor optimizations and refactoring * Perform server-side filtering on the streaming server * Change the wording of filter action labels * Fix issues pointed out by linter * Change design of “Show anyway” link in accordence to review comments * Drop “irreversible” filtering behavior * Move /api/v2/filter_keywords to /api/v1/filters/keywords * Rename `filter_results` attribute to `filtered` * Rename REST::LegacyFilterSerializer to REST::V1::FilterSerializer * Fix systemChannelId value in streaming server * Simplify code by removing client-side filtering code The simplifcation comes at a cost though: filters aren't retroactively applied anymore.	3 years ago
Eugen Rochko	2936f42a14	Add notifications for new reports (#18697)	3 years ago
Claire	35588d09e2	Add /api/v1/admin/domain_allows (#18668) ... - `GET /api/v1/admin/domain_allows` lists allowed domains - `GET /api/v1/admin/domain_allows/:id` shows one by ID - `DELETE /api/v1/admin/domain_allows/:id` deletes a given domain from the list of allowed domains - `POST /api/v1/admin/domain_allows` to allow a new domain: if that domain is already allowed, the existing DomainAllow will be returned	3 years ago
Eugen Rochko	a2871cd747	Add administrative webhooks (#18510) ... * Add administrative webhooks * Fix error when webhook is deleted before delivery worker runs	3 years ago
Claire	9d4861b498	Remove dependency on running Redis server for db:setup (#18560)	3 years ago
Claire	28329ba62f	Add /api/v1/admin/domain_blocks (#18247) ... * Add /api/v1/admin/domain_blocks Fixes #18140 - `GET /api/v1/admin/domain_blocks` lists domain blocks - `GET /api/v1/admin/domain_blocks/:id` shows one by ID - `DELETE /api/v1/admin/domain_blocks/:id` deletes a given domain block - `POST /api/v1/admin/domain_blocks` to create a new domain block: if it conflicts with an existing one, returns an error with an attribute `existing_domain_block` with the rendered domain block * Simplify conflict handling as suggested in review	3 years ago
Alexander Ivanov	379a7a7ca7	Add support for webp uploads (#18506)	3 years ago
Claire	e34dd3644c	Remove unused `filtered_languages` column (#18533) ... * Remove unused `filtered_languages` column Fixes #18522 * Fix tests	3 years ago
Eugen Rochko	c4d2c39a75	Fix being able to report otherwise inaccessible statuses (#18528)	3 years ago
Eugen Rochko	3e0e7a1cfb	Fix follower and other counters being able to go negative (#18517)	3 years ago
Eugen Rochko	088dc0ec5a	Fix regression in `tootctl search deploy` caused by unloaded attribute (#18514)	3 years ago
Claire	440eb71310	Change unapproved and unconfirmed account to not be accessible in the REST API (#17530) ... * Change unapproved and unconfirmed account to not be accessible in the REST API * Change Account#searchable? to reject unconfirmed and unapproved users * Disable search for unapproved and unconfirmed users in Account.search_for * Disable search for unapproved and unconfirmed users in Account.advanced_search_for * Remove unconfirmed and unapproved accounts from Account.searchable scope * Prevent mentions to unapproved/unconfirmed accounts * Fix some old tests for Account.advanced_search_for * Add some Account.advanced_search_for tests for existing behaviors * Add some tests for Account.search_for * Add Account.advanced_search_for tests unconfirmed and unapproved accounts * Add Account.searchable tests * Fix Account.without_unapproved scope potentially messing with previously-applied scopes * Allow lookup of unconfirmed/unapproved accounts through /api/v1/accounts/lookup This is so that the API can still be used to check whether an username is free to use.	3 years ago
Claire	25dda3061e	Fix unnecessary query on status creation (#17901)	3 years ago
Claire	e5997a1956	Fix warning an account outside of a report closing all reports for that account (#18387) ... * Fix warning an account outside of a report closing all reports for that account * Make it clear what actions solve other reports * Revert "Make it clear what actions solve other reports" This reverts commit ad006de821.	3 years ago
Eugen Rochko	a9b64b24d6	Change algorithm of `tootctl search deploy` to improve performance (#18463)	3 years ago
Eugen Rochko	6c699b1723	Fix preferred posting language returning unusable value in REST API (#18428)	3 years ago
Eugen Rochko	6cf57c6765	Refactor how Redis locks are created (#18400) ... * Refactor how Redis locks are created * Fix autorelease duration on account deletion lock	3 years ago
Claire	a53003c6f1	Fix account warnings not being recorded in audit log (#18338) ... * Fix account warnings not being recorded in audit log Fixes #18334 * Only record warnings if they are not associated to another action	3 years ago
Claire	6e4d932da5	Fix possible crash when a post references an invalid media attachment (#18211)	3 years ago
Eugen Rochko	f6d35ed57d	Remove IP matching from e-mail domain blocks (#18190) ... Clear out e-mail domain blocks created from automatically resolved DNS records	3 years ago
Eugen Rochko	7b0fe4aef9	Fix opening and closing Redis connections instead of using a pool (#18171) ... * Fix opening and closing Redis connections instead of using a pool * Fix Redis connections not being returned to the pool in CLI commands	3 years ago
Eugen Rochko	6476f7e4da	Change trending statuses to only show one status from each account (#18181) ... Calculate trends in temporary sets to avoid having to manage items that go below the decay threshold while not having any moments where a half-processed set is accessible to end-users	3 years ago
Eugen Rochko	6726d2933a	Change half-life of trending status scores from 6 hours to 2 hours (#18182)	3 years ago
Eugen Rochko	3917353645	Fix single Redis connection being used across all threads (#18135) ... * Fix single Redis connection being used across all Sidekiq threads * Fix tests	3 years ago
Claire	33cd80d69c	Fix instance actor being incorrectly created when running migrations (#18109) ... * Add migration test about instance actor key * Fix old migration * Work around incorrect database state	3 years ago
Jeong Arm	ea38327816	Let votes statuses are also searchable (#18070)	3 years ago
Claire	dc50347247	Fix crash in alias settings page (#18004)	3 years ago
Eugen Rochko	68273a7c6d	Fix dangling language-specific trends (#17997) ... - Change score half-life for trending statuses from 2 to 6 hours - Change score threshold for trimming old items from 1 to 0.3	3 years ago
Eugen Rochko	8e20e16cf0	Change e-mail notifications to only be sent when recipient is offline (#17984) ... * Change e-mail notifications to only be sent when recipient is offline Change the default for follow and mention notifications back on * Add preference to always send e-mail notifications * Change wording	3 years ago
Eugen Rochko	fd9a9b07c2	Fix trends returning less results per page when filtered in REST API (#17996) ... - Change filtering and pagination to occur in SQL instead of Redis - Change rank/score displayed on trends in admin UI to be locale-specific	3 years ago
Eugen Rochko	465ee7792f	Fix pagination header on empty trends responses in REST API (#17986)	3 years ago
Eugen Rochko	6221b36b27	Remove sign-in token authentication, instead send e-mail about new sign-in (#17970)	3 years ago
Claire	ef196c913c	Fix error MethodError in Chewy::Strategy::Sidekiq::Worker (#17912) ... Also refactor a bit to reduce code duplication.	3 years ago
Eugen Rochko	5554ff2a1d	Fix being able to bypass e-mail restrictions (#17909)	3 years ago
Claire	894956e20c	Fix /api/v1/admin/accounts (#17887) ... * Fix /api/v1/admin/accounts Compatibility was broken since #17009 which changed the underlying filter class without changing the controller. This commits restore support for the old parameters. * Add /api/v2/admin/accounts with the new parameters * Add tests * Add missing filter for `silenced` status Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>	3 years ago
Eugen Rochko	2dd30804b6	Change how unconfirmed accounts are displayed in admin UI (#17874) ... Fix #17815	3 years ago
Eugen Rochko	71f2b95106	Fix edits with no actual changes being allowed (#17843) ... * Fix edits with no actual changes being allowed locally * Fix edits with no actual changes being allowed through ActivityPub * Fix false positive changes caused by description processing in model * Fix not recording poll expiration update * Fix test * Revert changes to ProcessStatusUpdateService * Various fixes and improvements * Fix code style issues * Various changes and improvements * Add guard clause	3 years ago
Eugen Rochko	e3a2203061	Add offset pagination to trends in REST API (#17872)	3 years ago
Eugen Rochko	a794117679	Fix individually approved/rejected statuses/links showing as pending review (#17787)	3 years ago
Eugen Rochko	e6ffbfb5e7	Add `types` param to `GET /api/v1/notifications` in REST API (#17767) ... * Add `types` param to `GET /api/v1/notifications` in REST API * Improve tests	3 years ago
Eugen Rochko	eebafe24a8	Fix statuses not being referenced in strike when category is spam (#17786)	3 years ago
Eugen Rochko	5db1f377ea	Fix nil error when viewing suspended domain in admin UI (#17765)	3 years ago
Claire	642528f455	Update fix-duplicates maintenance task (#17731) ... * Update fix-duplicates task to 2022_02_10_153119 Also add support for Appeal to AccountMerging#merge_with! * Update fix-duplicates task to 2022_03_07_094650 * Update fix-duplicates task to 2022_03_09_213005 * Update fix-duplicates task to 2022_03_07_083603 * Update fix-duplicates task to 2022_03_10_060626 * Update fix-duplicates script to 2022_03_07_083603 * Update fix-duplicates task to 2022_03_10_060706 * Update fix-duplicates task to 2022_03_10_060959 * Silence CodeClimate	3 years ago
Eugen Rochko	ee8d4dd056	Fix moderator account leak in status edit history (#17746)	3 years ago
Jeong Arm	18e27e0488	Enable domain purge button on suspended domains too (#17741) ... Related: #17209	3 years ago
Takeshi Umeda	d7fab238a8	Fix a type error in domain_block policies (#17735)	3 years ago
Eugen Rochko	9f2791eb64	Add polls and media attachments to edit comparison modal in web UI (#17727)	3 years ago
Claire	2a56a890da	Fix rare race condition when rebloged status is deleted (#17693) ... * Fix rare race condition when rebloged status is deleted * Use INSERT INTO … SELECT	3 years ago
Eugen Rochko	b2cd34474b	Add rate limit for editing (#17728)	3 years ago
chandrn7	a6ed6845c9	Allow login through OpenID Connect (#16221) ... * added OpenID Connect as an SSO option * minor fixes * added comments, removed an option that shouldn't be set * fixed Gemfile.lock * added newline to end of Gemfile.lock * removed tab from Gemfile.lock * remove chomp * codeclimate changes and small name change to make function's purpose clearer * codeclimate fix * added SSO buttons to /about page * minor refactor * minor style change * removed spurious change * removed unecessary conditional from ensure_valid_username and added support for auth.info.name in user_params_from_auth * minor changes	3 years ago
Eugen Rochko	d17fb70131	Change how changes to media attachments are stored for edits (#17696) ... * Change how changes to media attachments are stored for edits Fix not being able to re-order media attachments * Fix not broadcasting updates when polls/media is changed through ActivityPub * Various fixes and improvements * Update app/models/report.rb Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Add tracking of media attachment description changes * Change poll in status edit to have a structure closer to the real one Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Eugen Rochko	bd53dd5210	Change design of federation pages in admin UI (#17704) ... * Change design of federation pages in admin UI * Fix query performance in instance media attachments measure * Fix reblogs being included in instance languages dimension	3 years ago
Eugen Rochko	318d34d528	Fix data integrity of featured tags (#17712)	3 years ago
Eugen Rochko	8f6c67bfde	Fix performance of account timelines (#17709) ... * Fix performance of account timelines * Various fixes and improvements * Fix duplicate results being returned Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Fix grouping for pinned statuses scope Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Eugen Rochko	292c75aa31	Fix nil error when submitting report without `rule_ids` (#17713)	3 years ago
Eugen Rochko	edf09ec747	Add `/api/v1/accounts/familiar_followers` to REST API (#17700) ... * Add `/api/v1/accounts/familiar_followers` to REST API * Change hide network preference to be stored consistently for local and remote accounts * Add dummy classes to migration * Apply suggestions from code review Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Claire	02dbc59c91	Add option to automatically delete toots after one week (#17691) ... Fixes #17658	3 years ago
Eugen Rochko	25d3dc4373	Add ability to mark statuses as sensitive from reports in admin UI (#17668) ... * Add ability to mark statuses as sensitive from reports in admin UI * Allow mark as sensitive action on statuses with preview cards	3 years ago
Claire	14919fe11e	Change old moderation strikes to be displayed in a separate page (#17566) ... * Change old moderation strikes to be displayed in a separate page Fixes #17552 This changes the moderation strikes displayed on `/auth/edit` to be those from the past 3 months, and make all moderation strikes targeting the current user available in `/disputes`. * Add short description of what the strikes page is for * Move link to list of strikes to “Account status” instead of navigation item * Normalize i18n file * Fix layout and styling of strikes link * Revert highlights_on regexp * Reintroduce account status summary - this way, “Account status” is never empty - account status is not necessarily bound to strikes, or recent strikes	3 years ago
Eugen Rochko	27965ce5ed	Add trending statuses (#17431) ... * Add trending statuses * Fix dangling items with stale scores in localized sets * Various fixes and improvements - Change approve_all/reject_all to approve_accounts/reject_accounts - Change Trends::Query methods to not mutate the original query - Change Trends::Query#skip to offset - Change follow recommendations to be refreshed in a transaction * Add tests for trending statuses filtering behaviour * Fix not applying filtering scope in controller	3 years ago
Eugen Rochko	a29a982eaa	Change e-mail domain blocks to block IPs dynamically (#17635) ... * Change e-mail domain blocks to block IPs dynamically * Update app/workers/scheduler/email_domain_block_refresh_scheduler.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> * Update app/workers/scheduler/email_domain_block_refresh_scheduler.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	3 years ago
Eugen Rochko	7b816eb5ae	Add notifications for new sign-ups (#16953)	3 years ago
Claire	166f6e4b50	Fix some media attachments being converted with too high framerates (#17619) ... Video files with variable framerates are converted to constant framerate videos and the output framerate picked by ffmpeg is based on the original file's container framerate (which can be different from the average framerate). This means that an input video with variable framerate with about 30 frames per second on average, but a maximum of 120 fps will be converted to a constant 120 fps file, which won't be processed by other Mastodon servers. This commit changes it so that input files with VFR and a maximum framerate above the framerate threshold are converted to VFR files with the maximum frame rate enforced.	3 years ago
Claire	ac99f586bb	Fix issues when attempting to appeal an old strike (#17554) ... * Display an error when an appeal could not be submitted * Do not offer users to appeal old strikes * Fix 500 error when trying to appeal a strike that is too old * Avoid using an extra translatable string	3 years ago
Eugen Rochko	564efd0651	Add appeals (#17364) ... * Add appeals * Add ability to reject appeals and ability to browse pending appeals in admin UI * Add strikes to account page in settings * Various fixes and improvements - Add separate notification setting for appeals, separate from reports - Fix style of links in report/strike header - Change approving an appeal to not restore statuses (due to federation complexities) - Change style of successfully appealed strikes on account settings page - Change account settings page to only show unappealed or recently appealed strikes * Change appealed_at to overruled_at * Fix missing method error	3 years ago
Jeong Arm	d39df35441	Fix admin statuses page order with media (#17538)	3 years ago
Eugen Rochko	6240466866	Fix duplicate accounts when searching by IP range in admin UI (#17524)	3 years ago
Eugen Rochko	8f03b7a2fb	Add notifications when a reblogged status has been updated (#17404) ... * Add notifications when a reblogged status has been updated * Change wording to say "edit" instead of "update" and add missing controls * Replace previous update notifications with the most up-to-date one	3 years ago
Eugen Rochko	d0fcf07436	Change actions in reports to require only one click (#17487)	3 years ago
Eugen Rochko	a27729ee48	Change reblogs to not count towards hashtag trends anymore (#17501)	3 years ago
Claire	63854bee6c	Fix poll votes not being properly reset on poll change (#17498) ... * Fix poll votes not being properly reset on poll change * Fix and add tests * Fix poll update handling when the number of options changes	3 years ago
Eugen Rochko	63002cde03	Add editing for published statuses (#17320) ... * Add editing for published statuses * Fix change of multiple-choice boolean in poll not resetting votes * Remove the ability to update existing media attachments for now	3 years ago
Eugen Rochko	2f8159baad	Add `category` and `rule_ids` params to `POST /api/v1/reports` (#17492)	3 years ago
Eugen Rochko	fd3a45e348	Add edit history to web UI (#17390) ... * Add edit history to web UI * Change history reducer to store items per status * Fix missing loading prop	3 years ago
Eugen Rochko	2adcad04ff	Fix error in suggestions API due to typo (#17486) ... Regression from #17479	3 years ago
Eugen Rochko	b6d7726ecb	Remove language detection through cld3 (#17478) ... * Remove language detection through cld3 * Update app/helpers/languages_helper.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	3 years ago
Eugen Rochko	35850f8195	Fix localization of cold-start follow recommendations (#17479)	3 years ago
Claire	987d88ea56	Fix requiring an extra restart after recent post-deployment migrations (#17422) ... Follow-up to #16409	3 years ago
Claire	03d59340da	Fix Sidekiq warnings about JSON serialization (#17381) ... * Fix Sidekiq warnings about JSON serialization This occurs on every symbol argument we pass, and every symbol key in hashes, because Sidekiq expects strings instead. See https://github.com/mperham/sidekiq/pull/5071 We do not need to change how workers parse their arguments because this has not changed and we were already converting to symbols adequately or using `with_indifferent_access`. * Set Sidekiq to raise on unsafe arguments in test mode In order to more easily catch issues that would produce warnings in production code.	3 years ago
Claire	0a120d86d2	Fix error-prone SQL queries (#15828) ... * Fix error-prone SQL queries in Account search While this code seems to not present an actual vulnerability, one could easily be introduced by mistake due to how the query is built. This PR parameterises the `to_tsquery` input to make the query more robust. * Harden code for Status#tagged_with_all and Status#tagged_with_none Those two scopes aren't used in a way that could be vulnerable to an SQL injection, but keeping them unchanged might be a hazard. * Remove unneeded spaces surrounding tsquery term * Please CodeClimate * Move advanced_search_for SQL template to its own function This avoids one level of indentation while making clearer that the SQL template isn't build from all the dynamic parameters of advanced_search_for. * Add tests covering tagged_with, tagged_with_all and tagged_with_none * Rewrite tagged_with_none to avoid multiple joins and make it more robust * Remove obsolete brakeman warnings * Revert "Remove unneeded spaces surrounding tsquery term" The two queries are not strictly equivalent. This reverts commit 86f16c537e.	3 years ago
Claire	8a07ecd377	Remove leftover database columns from Devise::Models::Rememberable (#17191) ... * Remove leftover database columns from Devise::Models::Rememberable * Update fix-duplication maintenance script * Improve errors/warnings in the fix-duplicates maintenance script	3 years ago
Eugen Rochko	1060666c58	Add support for editing for published statuses (#16697) ... * Add support for editing for published statuses * Fix references to stripped-out code * Various fixes and improvements * Further fixes and improvements * Fix updates being potentially sent to unauthorized recipients * Various fixes and improvements * Fix wrong words in test * Fix notifying accounts that were tagged but were not in the audience * Fix mistake	3 years ago
Eugen Rochko	14f436c457	Add notifications for statuses deleted by moderators (#17204)	3 years ago
Eugen Rochko	8e84ebf0cb	Remove IP tracking columns from users table (#16409)	3 years ago
Jeong Arm	720e8ab0f5	Fix duplicate record on admin/accounts when searching with IP (#17150)	3 years ago
Claire	76761d5fc0	Add ability for admins to delete canonical email blocks (#16644) ... * Add admin option to remove canonical email blocks from a deleted account * Add tootctl canonical_email_blocks to inspect and remove canonical email blocks	3 years ago
Claire	7f803c41e2	Add ability to purge undeliverable domains from admin interface (#16686) ... * Add ability to purge undeliverable domains from admin interface * Add tests	3 years ago
Eugen Rochko	fe45184b36	Change trending hashtags threshold back from 15 to 5 (#17122)	3 years ago
Eugen Rochko	0fb9536d38	Add batch suspend for accounts in admin UI (#17009)	3 years ago
Eugen Rochko	7de0ee7aba	Remove Keybase integration (#17045)	3 years ago
Eugen Rochko	12b3ff6c6d	Fix error on trending hashtags/links pages in admin UI due to missing constant (#17044)	3 years ago
Eugen Rochko	6e50134a42	Add trending links (#16917) ... * Add trending links * Add overriding specific links trendability * Add link type to preview cards and only trend articles Change trends review notifications from being sent every 5 minutes to being sent every 2 hours Change threshold from 5 unique accounts to 15 unique accounts * Fix tests	3 years ago
Claire	02a87431cf	Fix error when suspending user with an already-existing canonical email block (#17036) ... * Fix error when suspending user with an already-existing canonical email block Fixes #17033 While attempting to create a `CanonicalEmailBlock` with an existing hash would raise an `ActiveRecord::RecordNotUnique` error, this being done within a transaction would cancel the whole transaction. For this reason, checking for uniqueness in Rails would query the database within the transaction and avoid invalidating the whole transaction for this reason. A race condition is still possible, where multiple accounts sharing a canonical email would be blocked in concurrent transactions, in which only one would succeed, but that is way less likely to happen that the current issue, and can always be retried after the first failure, unlike the current situation. * Add tests	3 years ago
Takeshi Umeda	3419d3ec84	Bump chewy from 5.2.0 to 7.2.3 (supports Elasticsearch 7.x) (#16915) ... * Bump chewy from 5.2.0 to 7.2.2 * fix style (codeclimate) * fix style * fix style * Bump chewy from 7.2.2 to 7.2.3	3 years ago
Claire	6da135a493	Fix reviving revoked sessions and invalidating login (#16943) ... Up until now, we have used Devise's Rememberable mechanism to re-log users after the end of their browser sessions. This mechanism relies on a signed cookie containing a token. That token was stored on the user's record, meaning it was shared across all logged in browsers, meaning truly revoking a browser's ability to auto-log-in involves revoking the token itself, and revoking access from *all* logged-in browsers. We had a session mechanism that dynamically checks whether a user's session has been disabled, and would log out the user if so. However, this would only clear a session being actively used, and a new one could be respawned with the `remember_user_token` cookie. In practice, this caused two issues: - sessions could be revived after being closed from /auth/edit (security issue) - auto-log-in would be disabled for *all* browsers after logging out from one of them This PR removes the `remember_token` mechanism and treats the `_session_id` cookie/token as a browser-specific `remember_token`, fixing both issues.	3 years ago
Claire	87085a5152	Fix AccountNote not having a maximum length (#16942)	3 years ago
Claire	989c67d29d	Fix handling announcements with links (#16941) ... Broken since #15827	3 years ago
Takeshi Umeda	17f4e457b3	Add remove from followers api (#16864) ... * Add followed_by? to account_interactions * Add RemoveFromFollowersService * Fix AccountBatch to use RemoveFromFollowersService * Add remove from followers API	3 years ago
Jeong Arm	f4081d1564	Allow keeping only 1 boosts/favs on auto deleting posts (#16653) ... * Allow keeping 1 boosts/favs on auto deleting posts * Fix tests	3 years ago
Claire	9b978872cc	Fix 404 error when filtering admin action logs by non-existent target account (#16643) ... Currently, there is no way for an admin to delete an account record. However, should that happen in the future, or should an admin mistype an account id, `/admin/action_logs?target_account_id=<non-existent-account-id>` currently returns a 404 instead of an empty list. With this commit, the aforementioned page returns a correct list instead (potentially non-empty if the account has been manually deleted)	3 years ago