506 Commits (ac9fb0d654440ce1179bab4071941450aa994d2c)

Author	SHA1	Message	Date
Eugen Rochko	e24b14cc74	Fix leak of existence of otherwise inaccessible statuses in REST API (#17684)	3 years ago
Eugen Rochko	02b8d63fce	Fix report category not being saved in REST API (#17682)	3 years ago
Eugen Rochko	50ea54b3ed	Change authorized applications page (#17656) ... * Change authorized applications page * Hide revoke button for superapps and suspended accounts * Clean up db/schema.rb	3 years ago
Eugen Rochko	27965ce5ed	Add trending statuses (#17431) ... * Add trending statuses * Fix dangling items with stale scores in localized sets * Various fixes and improvements - Change approve_all/reject_all to approve_accounts/reject_accounts - Change Trends::Query methods to not mutate the original query - Change Trends::Query#skip to offset - Change follow recommendations to be refreshed in a transaction * Add tests for trending statuses filtering behaviour * Fix not applying filtering scope in controller	3 years ago
Eugen Rochko	7b816eb5ae	Add notifications for new sign-ups (#16953)	3 years ago
Eugen Rochko	8f03b7a2fb	Add notifications when a reblogged status has been updated (#17404) ... * Add notifications when a reblogged status has been updated * Change wording to say "edit" instead of "update" and add missing controls * Replace previous update notifications with the most up-to-date one	3 years ago
Eugen Rochko	63002cde03	Add editing for published statuses (#17320) ... * Add editing for published statuses * Fix change of multiple-choice boolean in poll not resetting votes * Remove the ability to update existing media attachments for now	3 years ago
Eugen Rochko	2f8159baad	Add `category` and `rule_ids` params to `POST /api/v1/reports` (#17492)	3 years ago
Eugen Rochko	fd3a45e348	Add edit history to web UI (#17390) ... * Add edit history to web UI * Change history reducer to store items per status * Fix missing loading prop	3 years ago
Claire	03d59340da	Fix Sidekiq warnings about JSON serialization (#17381) ... * Fix Sidekiq warnings about JSON serialization This occurs on every symbol argument we pass, and every symbol key in hashes, because Sidekiq expects strings instead. See https://github.com/mperham/sidekiq/pull/5071 We do not need to change how workers parse their arguments because this has not changed and we were already converting to symbols adequately or using `with_indifferent_access`. * Set Sidekiq to raise on unsafe arguments in test mode In order to more easily catch issues that would produce warnings in production code.	3 years ago
Claire	bddd9ba36d	Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288) ... * Remove support for OAUTH_REDIRECT_AT_SIGN_IN Fixes #15959 Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form to instead redirect to the external OmniAuth login provider. However, it did not prevent the log-in form on /about introduced by #10232 from appearing, and completely broke with the introduction of #15228. As I restoring that previous log-in flow without introducing a security vulnerability may require extensive care and knowledge of how OmniAuth works, this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time being. * Add OMNIAUTH_ONLY environment variable to enforce external log-in only * Disable user registration when OMNIAUTH_ONLY is set to true * Replace log-in links When OMNIAUTH_ONLY is set with exactly one OmniAuth provider	3 years ago
Eugen Rochko	1060666c58	Add support for editing for published statuses (#16697) ... * Add support for editing for published statuses * Fix references to stripped-out code * Various fixes and improvements * Further fixes and improvements * Fix updates being potentially sent to unauthorized recipients * Various fixes and improvements * Fix wrong words in test * Fix notifying accounts that were tagged but were not in the audience * Fix mistake	3 years ago
Eugen Rochko	14f436c457	Add notifications for statuses deleted by moderators (#17204)	3 years ago
Claire	d5c9feb7b7	Add support for private pinned posts (#16954) ... * Add support for private pinned toots * Allow local user to pin private toots * Change wording to avoid "direct message"	3 years ago
Eugen Rochko	8e84ebf0cb	Remove IP tracking columns from users table (#16409)	3 years ago
Eugen Rochko	7de0ee7aba	Remove Keybase integration (#17045)	3 years ago
Eugen Rochko	6e50134a42	Add trending links (#16917) ... * Add trending links * Add overriding specific links trendability * Add link type to preview cards and only trend articles Change trends review notifications from being sent every 5 minutes to being sent every 2 hours Change threshold from 5 unique accounts to 15 unique accounts * Fix tests	3 years ago
Takeshi Umeda	17f4e457b3	Add remove from followers api (#16864) ... * Add followed_by? to account_interactions * Add RemoveFromFollowersService * Fix AccountBatch to use RemoveFromFollowersService * Add remove from followers API	3 years ago
Eugen Rochko	07341e7aa6	Add graphs and retention metrics to admin dashboard (#16829)	3 years ago
Claire	d8629e7b86	Add logging of S3-related errors (#16381)	4 years ago
Eugen Rochko	1410dffdf4	Fix e-mail confirmations API not working correctly (#16348) ... * Fix e-mail confirmations API not working correctly * Fix typo	4 years ago
Claire	566fc90913	Add Ruby 3.0 support (#16046) ... * Fix issues with POSIX::Spawn, Terrapin and Ruby 3.0 Also improve the Terrapin monkey-patch for the stderr/stdout issue. * Fix keyword argument handling throughout the codebase * Monkey-patch Paperclip to fix keyword arguments handling in validators * Change validation_extensions to please CodeClimate * Bump microformats from 4.2.1 to 4.3.1 * Allow Ruby 3.0 * Add Ruby 3.0 test target to CircleCI * Add test for admin dashboard warnings * Fix admin dashboard warnings on Ruby 3.0	4 years ago
abcang	d0fc69d721	Further improve the media attached status query for accounts (#16106)	4 years ago
abcang	1f47511023	Improve media attached status query (#16105)	4 years ago
Eugen Rochko	daccc07dc1	Change auto-following admin-selected accounts, show in recommendations (#16078)	4 years ago
Eugen Rochko	ce2148c571	Add `policy` param to `POST /api/v1/push/subscriptions` (#16040) ... With possible values `all`, `followed`, `follower`, and `none`, control from whom notifications will generate a Web Push alert	4 years ago
Eugen Rochko	f7117646af	Add cold-start follow recommendations (#15945)	4 years ago
Eugen Rochko	dd1eb9918a	Add `email` param to `POST /api/v1/emails/confirmations` (#15949) ... Allow changing e-mail as long as the account is unconfirmed	4 years ago
Eugen Rochko	ee1119208c	Add `POST /api/v1/emails/confirmations` to REST API (#15816) ... Only available to the application the user originally signed-up with	4 years ago
Eugen Rochko	9aa37b32c3	Add `details` to error response for `POST /api/v1/accounts` in REST API (#15803)	4 years ago
Eugen Rochko	8331fdf7e0	Add server rules (#15769)	4 years ago
Eugen Rochko	e31ed27485	Add `GET /api/v1/accounts/lookup` REST API (#15740)	4 years ago
Eugen Rochko	15ced8728f	Refactor Api::Web::SettingsController (#15717)	4 years ago
abcang	7ab53f221a	Improved performance of notification preloading (#15640) ... * Improved performance of notification preloading * Remove Cacheable from Notification * Fix test	4 years ago
ThibG	54d4e5252b	Use Rails' index_by where it makes sense (#15542) ... * Use Rails' index_by where it makes sense * Fix tests Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Levi Bard	11d603101a	Fix muting users with duration via the REST api (#15516)	4 years ago
luigi	087ed84367	Optimize map { ... }.compact calls (#15513) ... * Optimize map { ... }.compact using Enumerable#filter_map, supported since Ruby 2.7 * Add poyfill for Enumerable#filter_map	4 years ago
trwnh	4950e59cdc	Use existing FeaturedTag serializer and delete AccountFeaturedTag serializer (#15415) ... * Update featured_tags_controller.rb * Update featured_tag_serializer.rb * Update featured_tag_serializer.rb * Delete account_featured_tag_serializer.rb * please codeclimate * please codeclimate	4 years ago
Eugen Rochko	1045549f85	Add stoplight for object storage failures, return HTTP 503 (#13043)	4 years ago
Eugen Rochko	216b85b053	Fix performance on instances list in admin UI (#15282) ... - Reduce duplicate queries - Remove n+1 queries - Add accounts count to detailed view - Add separate action log entry for updating existing domain blocks	4 years ago
Takeshi Umeda	44d5c6bc8f	Fix incorrect conditions for suspended accounts in Get API for account featured tags (#15270)	4 years ago
ThibG	c43f4cd3bb	Fix not being able to unfavorite toots one has lost access to (#15192) ... Fixes #15191	4 years ago
Eugen Rochko	8532429af7	Fix 2FA/sign-in token sessions being valid after password change (#14802) ... If someone tries logging in to an account and is prompted for a 2FA code or sign-in token, even if the account's password or e-mail is updated in the meantime, the session will show the prompt and allow the login process to complete with a valid 2FA code or sign-in token	4 years ago
Takeshi Umeda	d6fe0c94ca	Add account sensitized (#14361) ... * Add account sensitized * Fix i18n normalize * Fix description and spec * Fix spec * Fix wording	4 years ago
OSAMU SATO	96761752ec	Add duration parameter to muting. (#13831) ... * Adding duration to muting. * Remove useless checks	4 years ago
Eugen Rochko	5e1364c448	Add IP-based rules (#14963)	4 years ago
Eugen Rochko	8c8bf0289f	Fix not being able to enable status notifications in Web Push API (#14822)	4 years ago
Eugen Rochko	974b1b79ce	Add option to be notified when a followed user posts (#13546) ... * Add bell button Fix #4890 * Remove duplicate type from post-deployment migration * Fix legacy class type mappings * Improve query performance with better index * Fix validation * Remove redundant index from notifications	4 years ago
Eugen Rochko	ed099d8bdc	Change account suspensions to be reversible by default (#14726)	4 years ago
Eugen Rochko	e6b272e5c9	Change REST API to return empty data for suspended accounts (#14765)	4 years ago
abcang	e79d719e92	Changed tag most_used to recently_used (#14760)	4 years ago
Eugen Rochko	e8bc187845	Refactor how public and tag timelines are queried (#14728)	4 years ago
Takeshi Umeda	33ad850c98	Added account featured tags API (#11817)	4 years ago
ThibG	79305428a7	Add configuration option to filter replies in lists (#9205) ... * Add database support for list show-reply preferences * Add backend support to read and update list-specific show_replies settings * Add basic UI to set list replies setting * Add specs for list replies policy * Switch "cycling" reply policy link to a set of radio inputs * Capitalize replies_policy strings * Change radio button design to be consistent with that of the directory explorer	4 years ago
dependabot[bot]	8972e5f7f6	Bump rubocop from 0.86.0 to 0.88.0 (#14412) ... * Bump rubocop from 0.86.0 to 0.88.0 Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.88.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.86.0...v0.88.0) Signed-off-by: dependabot[bot] <support@github.com> * Fix for latest RuboCop Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	4 years ago
Akihiko Odaki	ae871c4d46	Make Array-creation behavior of Paginable more predictable (#14687) ... * Make Array-creation behavior of Paginable more predictable Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it returns an Array if min_id option is present. The behavior caused problems fixed with the following commits: - 552e886b64 - b63ede5005 - 64ef37b89d To prevent from recurring similar problems, this commit introduces two changes: - The scope now always returns an Array whether min_id option is present or not. - The scope is renamed to to_a_paginated_by_id to clarify it returns an Array. * Transform Paginable.to_a_paginated_by_id from a scope to a class method https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope > The method is intended to return an ActiveRecord::Relation object, which > is composable with other scopes. Paginable.to_a_paginated_by_id returns an Array and is not appropriate as a scope.	4 years ago
Akihiko Odaki	64ef37b89d	Introduce ApplicationController#cache_collection_paginated_by_id (#14677) ... * Replace incorrect use of distinct with group Some uses of ActiveRecord::QueryMethods#distinct pass field names but they are incorrect for the current version of Rails. ActiveRecord::QueryMethods#group provides the expected behavior and benefits performance. See commit 6da24aad4c. * Introduce ApplicationController#cache_collection_paginated_by_id ApplicationController#cache_collection_paginated_by_id fuses ApplicationController#cache_collection and Paginable.paginate_by_id. An advantage of this method is that it prevents from modifying scope which Paginable.paginate_by_id may provide. ApplicationController#cache_collection always return an array and there is no possibility of the scope modification. It is also clear for a programmer, considering the implication of "cache". This method can also emit more efficient queries by using Cacheable.cache_ids before calling Paginable.paginate_by_id.	4 years ago
Akihiko Odaki	b63ede5005	Eagerly load statuses with the main query in Api::V1::BookmarksController (#14674) ... This is same with commit 552e886b64 except that it was for Api::V1::FavouritesController while this is for Api::V1::BookmarksController.	4 years ago
Akihiko Odaki	e26e7a1cb5	Replace incorrect use of distinct with group (#14675) ... Some uses of ActiveRecord::QueryMethods#distinct pass field names but they are incorrect for the current version of Rails. ActiveRecord::QueryMethods#group provides the expected behavior and benefits performance. See commit 6da24aad4c.	4 years ago
Akihiko Odaki	552e886b64	Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673) ... The old implementation had two queries: 1. The query constructed in Api::V1::FavouritesController#results 2. The query constructed in #cached_favourites, which is merged with 1. Both of them are issued againt PostgreSQL. The combination of the two queries caused the following problems: - The small window between the two queries involves race conditions. - Minor performance inefficiency. Moreover, the construction of query 2, which involves merging with query 1 has a bug. Query 1 is finalized with paginate_by_id, but paginate_by_id returns an array when min_id parameter is specified. The behavior prevents from merging the query, and in the real world, ActiveRecord simply ignores the merge (!), which results in querying the entire scan of statuses and favourites table. This change fixes these issues by simply letting query 1 get all the works done.	4 years ago
Akihiko Odaki	41eeb9ebaa	Use Status.group instead of Status.distinct in HashQueryService (#14662) ... DISTINCT clause removes duplicated records according to all the selected attributes. In reality, it can remove duplicated records only looking at statuses.id, but the clause confuses the query planner and yields insufficient performance. The behavior is also problematic if the scope produced by HashQueryService is used to query columns without id (using pluck method, for example). The scope is expected to contain unique statuses, but the uniquness will be evaluated with some arbitrary columns other than id. GROUP BY clause resolves those problem by explicitly specifying the column to take into account for the record distinction. A workaround for the problem of DISTINCT clause in Api::V1::Timelines::TagController is no longer necessary and removed.	4 years ago
ThibG	f6a82cb2cd	Fix not being able to unbookmark toots when blocked by their author (#14604) ... * Fix not being able to unbookmark toots when blocked by their author * Add tests	4 years ago
Ariel	2ada2ae18a	Fix/14021 behaviour on add or remove toots (#14212) ... * Add toot send by current user at local state after send a new toot Related to #14021 * Decrement toot counter at profile when remove a toot Related to #14021 * Remove semicolon at end of line	5 years ago
ThibG	0a8a3fe595	Fix being unable to unboost when blocked by their author (#14308) ... Fixes #14307	5 years ago
ThibG	65506bac3f	Add user notes on accounts (#14148) ... * Add UserNote model * Add UI for user notes * Put comment in relationships entity * Add API to create user notes * Copy user notes to new account when receiving a Move activity * Address some of the review remarks * Replace modal by inline edition * Please CodeClimate * Button design changes * Change design again * Cancel note edition when pressing Escape * Fixes * Tweak design again * Move “Add note” item, and allow users to add notes to themselves * Rename UserNote into AccountNote, rename “comment” Relationship attribute to “note”	5 years ago
Eugen Rochko	64aac30733	Add customizable thumbnails for audio and video attachments (#14145) ... - Change audio files to not be stripped of metadata - Automatically extract cover art from audio if it exists - Add `thumbnail` parameter to `POST /api/v1/media`, `POST /api/v2/media` and `PUT /api/v1/media/:id` - Add `icon` to represent it in attachments in ActivityPub - Fix `preview_url` containing URL of missing missing image when there is no thumbnail instead of null - Fix duration of audio not being displayed on public pages until the file is loaded	5 years ago
ThibG	ac8a788370	Fix functional user requirements in whitelist mode (#14093) ... Fixes #14092	5 years ago
Eugen Rochko	f669b8bcce	Fix wrong route helper in encrypted messages controller (#13952) ... And add `created_at` to encrypted message serializer	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820)	5 years ago
Takeshi Umeda	26b08a3c54	Add remote only to public timeline (#13504) ... * Add remote only to public timeline * Fix code style	5 years ago
ThibG	f1e0fa80f6	Fix own following/followers not showing muted users (#13614) ... Fixes #13612	5 years ago
Eugen Rochko	988b0493fe	Add more tests for ActivityPub controllers (#13585)	5 years ago
Eugen Rochko	c9efb400b4	Add rate limit for reporting (#13390)	5 years ago
ThibG	0d117c106a	Fix 404 and 410 API errors being silently discarded in WebUI (#13279) ... * Fix 404 and 410 API errors being silently discarded in WebUI Fixes #13278 * Return more appropriate error when user replies to a deleted toot * Please CodeClimate * Fix 404/410 errors on fetching account timelines & identity proofs * Refactor error handling * Move error message string to statuses.errors	5 years ago
ThibG	b154428e14	Add federation support for the "hide network" preference (#11673) ... * Change ActivityPub follower/following collections to not link first page * Add support for hiding followers and following of remote users * Switch to using a single `hide_collections` column * Address code style remarks	5 years ago
Eugen Rochko	9660aa4543	Change local media attachments to perform heavy processing asynchronously (#13210) ... Fix #9106	5 years ago
Eugen Rochko	339ce1c4e9	Add specific rate limits for posting and following (#13172)	5 years ago
Eugen Rochko	0ae5c6312f	Remove useless `respond_to` calls (#13208)	5 years ago
Eugen Rochko	0c28a505dd	Fix leak of arbitrary statuses through unfavourite action in REST API (#13161)	5 years ago
ThibG	7face973fa	Fix dismissing an announcement twice raising an obscure error (#13124)	5 years ago
Eugen Rochko	a64973aecf	Fix malformed HTML causing uncaught error (#13042) ... Fix OEmbed preview API leaking existence of private statuses (see #12930)	5 years ago
ThibG	3adc722d1c	Change how unread announcements are handled (#13020) ... * Change meaning of /api/v1/announcements/:id/dismiss to mark an announcement as read * Change how unread announcements are counted in UI * Add unread marker to announcements and mark announcements as unread as they are displayed * Fixups	5 years ago
Eugen Rochko	c4c315ea40	Fix OEmbed leaking information about existence of non-public statuses (#12930)	5 years ago
Eugen Rochko	f52c988e12	Add announcements (#12662) ... * Add announcements Fix #11006 * Add reactions to announcements * Add admin UI for announcements * Add unit tests * Fix issues - Add `with_dismissed` param to announcements API - Fix end date not being formatted when time range is given - Fix announcement delete causing reactions to send streaming updates - Fix announcements container growing too wide and mascot too small - Fix `all_day` being settable when no time range is given - Change text "Update" to "Announcement" * Fix scheduler unpublishing announcements before they are due * Fix filter params not being passed to announcements filter	5 years ago
Eugen Rochko	02d272cf49	Fix access to OEmbed endpoint in secure mode (#12864)	5 years ago
Eugen Rochko	49b2f7c0a2	Fix base64-encoded file uploads not being possible (#12748) ... Fix #3804, Fix #5776	5 years ago
ThibG	3b3bdc7293	Hide blocked users from more places (#12733) ... * Hide blocked, muted, and blocked-by users from toot favourite lists * Hide blocked, muted, and blocked-by users from toot reblog lists * Hide blocked, muted, and blocked-by users from followers/following (API) * Fix tests * Hide blocked, muted, and blocked-by users from followers/following on public pages	5 years ago
Eugen Rochko	2999c95596	Fix error when fetching followers/following from REST API when user has network hidden (#12716) ... Fix #12510	5 years ago
Eugen Rochko	6d7daf6154	Fix generic HTTP 500 error on duplicate records (#12563) ... Fix #12551 Fix #12547	5 years ago
ThibG	911cc14481	Add follow_request notification type (#12198) ... * Add follow_request notification type The notification type already existed in the backend but was never pushed to the front-end. This also means translation strings were also available for the backend, from the notification mailer. Unlike other notification types, these are off by default, to match what I remember of Gargron's view on the topic: that follow requests should not clutter notifications and should instead be reviewed at the user's own leisure in the dedicated column. Since follow requests have their own column, I've deemed it unnecessary to add a specific tab for them in the notification quick filter. * Show follow request link in single-column if there are pending requests, even if account isn't locked * Push follow requests from notifications to the follow_requests list * Offer to accept or reject follow request from the notification * Redesign follow request notification	5 years ago
Eugen Rochko	d9793b2367	Fix proofs API being inaccessible in secure mode (#12495)	5 years ago
Gomasy	5a2c0707f1	Support min_id-based pagination for bookmarks (#12381) ... * Support min_id-based pagination for bookmarks * Fix spec	5 years ago
Jennifer Glauche	fd93a9c871	make it not return http 400 when passing and empty source argument (#12259) ... * make it not return http 400 when passing and empty source argument * create a spec for the empty source hash bug * compact checks for nil, empty? parameters * use nil.blank? instead checking for nil	5 years ago
ThibG	dfea7368c9	Add bookmarks (#7107) ... * Add backend support for bookmarks Bookmarks behave like favourites, except they aren't shared with other users and do not have an associated counter. * Add spec for bookmark endpoints * Add front-end support for bookmarks * Introduce OAuth scopes for bookmarks * Add bookmarks to archive takeout * Fix migration * Coding style fixes * Fix rebase issue * Update bookmarked_statuses to latest UI changes * Update bookmark actions to properly reflect status changes in state * Add bookmarks item to single-column layout * Make active bookmarks red	5 years ago
Eugen Rochko	354fdd317e	Fix attachment not being re-downloaded even if file is not stored (#12125) ... Change the behaviour of remotable concern. Previously, it would skip downloading an attachment if the stored remote URL is identical to the new one. Now it would not be skipped if the attachment is not actually currently stored by Paperclip.	5 years ago
Eugen Rochko	a582185625	Fix `GET /api/v1/instance` REST APIs being unavailable in secure mode (#12089)	5 years ago
Eugen Rochko	f665901e3c	Fix performance of home feed regeneration (#12084) ... Fetching statuses from all followed accounts at once takes too long within Postgres. Fetching them one by one and merging in Ruby could be a lot less resource-intensive Because the query for dynamically fetching the home timeline is so heavy, we can no longer offer it when the home timeline is missing	5 years ago
Eugen Rochko	eb83d6256e	Add `reason` param to `POST /api/v1/accounts` REST API (#12064) ... For approval-required registrations mode	5 years ago
Eugen Rochko	ab33c4df94	Add `exclude_unreviewed` param to `GET /api/v2/search` REST API (#11977) ... Make it so normal search returns even unreviewed matches, but autosuggestions do not. Fix #11960	5 years ago
ThibG	18b451c0e6	Change silences to always require approval on follow (#11975) ... * Change silenced accounts to require approval on follow * Also require approval for follows by people explicitly muted by target accounts * Do not auto-accept silenced or muted accounts when switching from locked to unlocked * Add `follow_requests_count` to verify_credentials * Show “Follow requests” menu item if needed even if account is locked * Add tests * Correctly reflect that follow requests weren't auto-accepted when local account is silenced * Accept follow requests from user-muted accounts to avoid leaking mutes	5 years ago