Commit Graph

2507 Commits (a11b599fface2a4fcd39d3c54ec9ed0aa4b5c8f7)

Author SHA1 Message Date
Renaud Chaput 5d04e29775
Disable Chrome's search engine selection screen when running system specs (#31437) 7 months ago
Renaud Chaput 4545b8d6cb
Add the ability to ignore specific browser errors for a spec (#31436) 7 months ago
Jeong Arm 95c11d365d
Don't push to cache buster if attachment path is nil (#31414) 7 months ago
Claire 7996a9543d
Change notification request acceptance to immediately delete the request (#31256) 7 months ago
Renaud Chaput c3e1d86d58
Fix log out from user menu not working on Safari (#31402) 7 months ago
Matt Jankowski 02df1b4e4a
Finish email allow/deny list naming migration (#30530) 7 months ago
Claire 8a5b57f668
Revert "Support JSON-LD named graph (#31288)" (#31355) 7 months ago
Claire cbdd8edf68
Revamp notification policy options (#31343) 7 months ago
Claire 994ef16b72
Bust CDN cache on media deletion (#31353) 7 months ago
Matt Jankowski 52a626f39b
Replace more `font-awesome` icons in `app/helpers` (#30962) 7 months ago
Claire 670e4655d1
Change dismissing a notification to clear existing filtered notifications for that account (#31329) 7 months ago
Claire af2aec1a82
Change notification requests to only count mentions (#31322) 7 months ago
Claire 719cabe024
Fix logic of block/mute bypass for mentions from moderators (#31271) 7 months ago
Claire 438dac99d6
Add option to request partial accounts in grouped notifications API (#31299) 7 months ago
Christian Schmidt 9d0cafd06b
Check Content-Length in ResponseWithLimitAdapter (#31285) 7 months ago
Christian Schmidt e9e63ed203
Support JSON-LD named graph (#31288) 7 months ago
Claire da5b45a573
Add endpoints to accept and dismiss multiple notification requests at once (#31242) 7 months ago
Claire 549ab089ee
Change grouped notifications API shape (take 2) (#31214) 7 months ago
Claire 598ae4f2da
Add endpoints for unread notifications count (#31191) 7 months ago
Tim Rogers 2ce99c51dd
Fixed Rails route covering %40-encoded profile URL paths to not 404 (#31184) 7 months ago
Emelia Smith c40e481169
Implement UI for Admin Search of Hashtags (#30880) 7 months ago
Matt Jankowski 95eadabe44
Extrude `fill_in_auth_details` method to `ProfileStories` spec support module (#31163) 7 months ago
David Roetzel dd53792714
Move UI tests from controller to system spec (#31158) 7 months ago
Emelia Smith 693d9b03ed
Enable OAuth PKCE Extension (#31129) 7 months ago
Adam Niedzielski 887e64efd4
Allow @ at the end of an URL (#31124) 7 months ago
Adam Niedzielski fbf95216c5
Fix LinkCrawlWorker NoMethodError: undefined method `[]' for nil (#31144) 7 months ago
Matt Jankowski bfaa53343a
Improve failure message on pagination matcher (#31146) 7 months ago
Adam Niedzielski 337a7fcf30
Fix ß bug in regexp for mentions and tags (#31122) 7 months ago
Matt Jankowski e881a59671
Add `User.unconfirmed` scope, reduce factories in `scheduler/user_cleanup` spec (#31063) 7 months ago
Adam Niedzielski cd0ca4b994
Select correct self link when parsing Webfinger response (#31110) 7 months ago
Emelia Smith bb2e5a4b58
Add audit logs to Admin::InstancesController (#27386) 7 months ago
Claire ced5e853c7
Fix duplicate `orderedItems` in user archive's `outbox.json` (#31099) 7 months ago
Matt Jankowski 6e4305de69
Fix spec descriptions around configurable limit values (#31079) 7 months ago
Matt Jankowski ef796446e5
Ignore manifest JS parse/interrupt error on CI (#31080) 7 months ago
kyori19 3a00f89aa1
Respect `Account::DISPLAY_NAME_LENGTH_LIMIT` in account spec correctly (#31075) 7 months ago
Matt Jankowski 05342529dd
Reduce factory creation in AP activity move spec (#31064) 8 months ago
Matt Jankowski 848b59c8ae
Reduce factory creation in `MediaAttachment` model spec (#31058) 8 months ago
Matt Jankowski 47ea83d246
Reduce factory creation in `AP::ProcessStatusUpdateService` spec (#31051) 8 months ago
Matt Jankowski 2616fde9e6
Use change-requiring records in admin/reports controller spec (#31052) 8 months ago
Matt Jankowski c5f8256801
Reduce extra factories in `FanOutOnWriteService` spec (#31053) 8 months ago
Matt Jankowski 76c2c5c748
Reduce extra round trips in `activitypub` controller specs (#31041) 8 months ago
Matt Jankowski f5e90f3de3
Reduce extra round trips in `AP::SynchronizeFollowersService` spec (#31044) 8 months ago
Matt Jankowski 81877e7950
Reduce extra round trips in `AP::FetchRemoteStatusService` spec (#31045) 8 months ago
Emelia Smith aa88aca0ad
Add optional OAuth application to reports (#30539) 8 months ago
Matt Jankowski 91ef4a6fc5
Add assertion about key columns to account key generate spec (#30635) 8 months ago
Claire 1dd8262071
Add optional `filtered` attribute to notification entities in REST API (#31011) 8 months ago
Matt Jankowski 00cb4a0313
Avoid repeated factory creation in media_attachments_vacuum_spec (#31000) 8 months ago
David Roetzel 35a437a03f
Destroy `NotificationRequest`s that are dismissed (#31008) 8 months ago
Matt Jankowski 43e24dbb13
Use `include_pagination_headers` in more places (#30999) 8 months ago
Matt Jankowski 73d53827ea
Add change assertion to invites destroy spec (#31004) 8 months ago
David Roetzel 2ea9336b68
Do not pass unknown encoding names to nokogiri. (#30987) 8 months ago
David Roetzel 967505ee9b
Add size limit for all PreviewCard URLs (#30973) 8 months ago
Daniel M Brasil 3875bd138d
Fix HTTP 500 in `/api/v1/polls/:id/votes` (#25598) 8 months ago
David Roetzel fa8e972722
Fix author names as arrays in linked data. (#30957) 8 months ago
Matt Jankowski f1300ad284
Rename jobs/attachments rspec tag names (#29762) 8 months ago
Claire d41b43ed4f
Limit attachments to `MEDIA_ATTACHMENTS_LIMIT` when returning posts through the API (#30932) 8 months ago
David Roetzel 97eddb5906
Fix details extraction when no title exists. (#30933) 8 months ago
David Roetzel 016c1e4e78
Improve handling of encoding problems when creating link previews (#30929) 8 months ago
Claire 502cf75b16
Merge pull request from GHSA-58x8-3qxw-6hm7
* Fix insufficient permission checking for public timeline endpoints

Note that this changes unauthenticated access failure code from 401 to 422

* Add more tests for public timelines

* Require user token in `/api/v1/statuses/:id/translate` and `/api/v1/scheduled_statuses`
8 months ago
Claire 395f17ca17
Merge pull request from GHSA-vp5r-5pgw-jwqx
* Fix streaming sessions not being closed when revoking access to an app

* Add tests for GHSA-7w3c-p9j8-mq3x
8 months ago
Emelia Smith 47f0faebc9
Implement HTML ruby tags for east-asian languages (#30897) 8 months ago
David Roetzel 9be77fc0db
Revert "Add system check for missing database indexes" (#30909) 8 months ago
David Roetzel ebd8e1bbb6
Add system check for missing database indexes (#30888) 8 months ago
Matt Jankowski 836c0477ac
Use vips setting instead of env var in media processing spec (#30859) 8 months ago
David Roetzel ff08d99d4d
Catch encoding errors when creating link previews. (#30853) 8 months ago
David Roetzel 42adb6eaee
Add size limit for link preview URLs (#30854) 8 months ago
Matt Jankowski f6390c3326
Use flatware to parallelize CI specs (#30284) 8 months ago
Claire 7a84b76bb1
Drop favicon.ico generation (#30375) 8 months ago
Matt Jankowski 8ef59729a1
Ignore intermittent chrome/manifest/icon interaction failure (#30793) 8 months ago
Emelia Smith 30ae5952d2
Fix: Ensure "With Media" is highlighted from Admin Accounts page (#30812) 8 months ago
Claire 8827cd597e
Fix `/admin/accounts/:account_id/statuses/:id` for edited posts with media attachments (#30819) 8 months ago
Matt Jankowski 72484a194f
Remove `CacheBuster` default options (#30718) 8 months ago
David Roetzel 2cab1c7b09
Improve encoding detection for link cards (#30780) 8 months ago
Matt Jankowski 84a31319e9
Add `match_json_values` and use in AP worker specs (#30720) 8 months ago
Claire 8098d27f84
Stop calling Webpacker in full-stack tests (#30763) 9 months ago
Claire 58ace2e45e
Fix SQL error in admin measures API (#30753) 9 months ago
Matt Jankowski 38c6825eda
Remove unused `Extractor#extract_cashtags_with_indices` method (#30742) 9 months ago
Matt Jankowski d7b7617321
Use `class_names` in admin/account_moderation_notes helper (#30719) 9 months ago
Matt Jankowski f287462f76
Fix repeated Delete/Undo assertion in remove status service spec (#30715) 9 months ago
Claire 45abddb302
Fix pagination attributes not being returned in ungroupable-only pages (#30688) 9 months ago
Claire bf56e982a9
Fix notifications from limited users being outright dropped (#30559) 9 months ago
Claire 1dfd516284
Fix duplicate `@context` attribute in user export (#30653) 9 months ago
Matt Jankowski d818ddd687
Extract `SIGN_COUNT_LIMIT` constant in `WebauthnCredential` class (#30636) 9 months ago
Matt Jankowski 62d070c438
Check both before/after state in `AccountDomainBlock` spec (#30640) 9 months ago
Matt Jankowski 1622f7aeb9
Remove duplicate fabricator validity checks (#29667) 9 months ago
Matt Jankowski edf6d64eeb
Use correct params in `settings/preferences/appearance` spec (#30379) 9 months ago
Matt Jankowski b2496177e0
Use correct params in `v1/admin/domain_allows` spec (#30378) 9 months ago
Matt Jankowski cfd4823b65
Use fabricator in follow_spec (#30642) 9 months ago
Matt Jankowski 9cc4040308
Extract `COMMENT_SIZE_LIMIT` constant in `AP::Activity::Flag` class (#30637) 9 months ago
Matt Jankowski 9bf2e2eda0
Extract `TEXT_LENGTH_LIMIT` constant in `Appeal` class (#30638) 9 months ago
Matt Jankowski 3e3f3d7580
Match report validation spec to extracted constant (#30633) 9 months ago
Matt Jankowski 92b3004bf3
Reference constants from account validation specs (#30634) 9 months ago
Daniel M Brasil 28f9a8f2ec
Add Specs for Scheduled Status Model Validations (#30585) 9 months ago
Daniel M Brasil 77c2216e47
fix: Return HTTP 422 when scheduled status time is less than 5 minutes (#30584) 9 months ago
Matt Jankowski 827e36ff9e
Fix `Capybara/NegationMatcher` cop in spec/system (#30616) 9 months ago
Claire 1408733386
Fix Mastodon relying on ImageMagick even with `MASTODON_USE_LIBVIPS` (#30590) 9 months ago
Matt Jankowski 04ebbe3077
Add `sidekiq_inline` to appeal service spec (#30562) 9 months ago
Matt Jankowski 07cc94e05f
Use `sidekiq_inline` in requests/api/v1/admin/account_actions spec (#30563) 9 months ago
Matt Jankowski 9b9b0e25b6
Use `sidekiq_inline` in requests/api/v1/reports spec (#30564) 9 months ago
Matt Jankowski a662c6d1d8
Use `sidekiq_inline` in admin/account_action model spec (#30565) 9 months ago
Eugen Rochko a2505e8611
Add timeline of public posts about a trending link to REST API (#30381) 9 months ago
Emelia Smith e02d23b549
Change `read:me` scope to `profile` scope (#30357)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
9 months ago
Emelia Smith 4655be0da6
Fix add validation to webpush subscription keys (#30542) 9 months ago
Eugen Rochko 5f15a892fa
Add support for libvips in addition to ImageMagick (#30090)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
9 months ago
Emelia Smith eef2cc054f
Add url validation to Web::PushSubscription endpoints (#30540) 9 months ago
Matt Jankowski 249cbc449c
Use existing config access to `local_domain` value (#30509) 9 months ago
Claire 974335e414
Add experimental server-side notification grouping (#29889) 9 months ago
Matt Jankowski 4d047b95ae
Use more direct attribute handling in `User` fabricator (#30495) 9 months ago
Claire 16249946ae
Merge pull request from GHSA-q3rg-xx5v-4mxh 9 months ago
Claire 3ea4275ae3
Merge pull request from GHSA-5fq7-3p3j-9vrf 9 months ago
Emelia Smith d20a5c3ec9
Fix: remove broken OAuth Application vacuuming & throttle OAuth Application registrations (#30316)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
9 months ago
Claire 36fe8f8566
Change `ids` param to `id` in `/api/v1/statuses` and `/api/v1/accounts` for consistency (#30465) 9 months ago
Matt Jankowski c61e356475
Add `Status::MEDIA_ATTACHMENTS_LIMIT` configuration constant (#30433) 9 months ago
Matt Jankowski 564ebfefcf
Remove hard reference from status pin validator spec (#30432) 9 months ago
Claire 133d98fb25
Normalize language code of incoming posts (#30403) 9 months ago
Matt Jankowski 3a862439df
Remove unused account record in api/v2/admin/accounts spec (#30397) 9 months ago
Claire 32223863a5
Add coverage to `/admin/accounts/:id` (#30386) 9 months ago
Claire 89f89d738f
Revert "Allow unblocking email addresses from any matching account (#29305)" (#30385) 9 months ago
Matt Jankowski 0a2110b9af
Add coverage for custom filters (#30347) 9 months ago
Claire de4815afda
Add more tests for self-destruct mode (#30374) 10 months ago
Matt Jankowski def6b686ff
Fix `Rails/WhereRange` cop (#30343) 10 months ago
Matt Jankowski 70608f824e
Add coverage for `AdminMailer#auto_close_registrations` (#30349) 10 months ago
Emelia Smith 2da2a1dae9
Support multiple redirect_uris when creating OAuth 2.0 Applications (#29192) 10 months ago
Matt Jankowski 65e82211cd
Rename `cache_*` methods to `preload_*` in controller concern (#30209) 10 months ago
Emelia Smith 5fd56512de
Improve Report Notes and Account Moderation Notes (#30288) 10 months ago
Jason Punyon 85c625d319
Fix repetitive database queries from #30040 (#30259) 10 months ago
Matt Jankowski 6beead3867
Move `simplecov` config into `rails_helper` (#30302) 10 months ago
Renaud Chaput 40639510f8
Retain unconfirmed users longer (1 week) (#30285) 10 months ago
Matt Jankowski 0d397db5dd
Consolidate system specs into single directory, use rspec tags for configuration (#30206) 10 months ago
Matt Jankowski fa43a6c835
Use more accurate `redirect_uri` in oauth spec (#30212) 10 months ago
Claire 2fe1b8d169
Add API to get multiple accounts and statuses (#27871)
Co-authored-by: noellabo <noel.yoshiba@gmail.com>
10 months ago
Fawaz Farid bc24c4792d
Allow admins to configure instance favicon and logo (#30040) 10 months ago
Emelia Smith 116f01ec7d
Implement RFC 8414 for OAuth 2.0 server metadata (#29191) 10 months ago
Claire 30ef9fccf0
Fix hashtag matching pattern matching some link anchors (#30190) 10 months ago
Matt Jankowski dbaa4ed891
Use `chewy` which relaxes ES version reqs (#30157) 10 months ago
Claire e5062b7135
Fix post deletion not being deferred when those are part of an account warning (#30163) 10 months ago
Claire 253ead3aa7
Fix not being able to block a subdomain of an already-blocked domain through the API (#30119) 10 months ago
Matt Jankowski 1e7d5d2957
Update `devise-two-factor` to version 5.0.0 (#28325)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
10 months ago
Matt Jankowski 2447497a4c
Status length validation spec updates (#30132) 10 months ago
Claire 91ca90e25b
Fix Idempotency-Key ignored when scheduling a post (#30084) 10 months ago
Claire e845594878
Fix moderator account being exposed in account moderation notification (#30082) 10 months ago
Claire 4ef0b48b95
Add in-app notifications for moderation actions/warnings (#30065) 10 months ago
Emelia Smith 049b159beb
Add read:me OAuth 2.0 scope, allowing more limited access to user data (#29087) 10 months ago
Matt Jankowski a15139bc02
Fix intermittent order based failure in `UpdateStatusService` spec (#30008) 10 months ago
Matt Jankowski f5d341382e
Add `any_args` to have_enqueued_sidekiq_job call (quiets deprecation) (#29999) 11 months ago
Matt Jankowski 11e0049b08
Use enum-generated scopes/queries for `BulkImport` (#29975) 11 months ago
Claire 8bece467f8
Change `have_enqueued_sidekiq_job` usage to always make argument expectations explicit (#29974) 11 months ago
Matt Jankowski 650c548c31
Add `not_featured_by` scope to Tag (#28815) 11 months ago
Matt Jankowski 9ce2db4136
Combine double subject runs and DRY up change check in bulk import service spec (#29402) 11 months ago
Matt Jankowski 6fed108703
Use Rails `upsert` to generate update_count! query in Counters concern (#28738)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
11 months ago
Matt Jankowski 7fed4a9740
Pull out repeated setup to shared setup in statusus/show view spec (#29927) 11 months ago
Matt Jankowski 61d108f415
Extract `header_tags` method in statuses/show view spec (#29907) 11 months ago
Matt Jankowski da6b9238f5
Expand coverage for admin/metrics/measure/* classes (#29914) 11 months ago
Matt Jankowski ec5a0e0f5e
Expand coverage for admin/metrics/dimension/* classes (#29913) 11 months ago
Matt Jankowski 449f99e168
Fix repeated concat output buffer duplicating layout markup (#29918) 11 months ago
Matt Jankowski 576554b19b
Use fabrication sequence in domain values (#29895) 11 months ago
Matt Jankowski 285f63c02e
Use composable query in `User.active` scope (#29775) 11 months ago
Claire babbf6017d
Remove caching in `cache_collection` (#29862) 11 months ago
Claire e73cf356d2
Move OAuth flow tests from feature tests to system tests (#29837) 11 months ago
Matt Jankowski b61ae28f8d
Separate methods for theme style and meta color tags (#29802) 11 months ago
Matt Jankowski 59da591d13
Improve spec for dimension/languages admin metric (#29842) 11 months ago
Claire 38b9d31f63
Improve email address validation (#29838) 11 months ago
Claire 1f11aa5f04
Add stub for trending tags in user mailer spec (#29850) 11 months ago
Matt Jankowski 191bf5876e
Add coverage for sanitize failure path in api/web/embeds spec (#29851) 11 months ago
Matt Jankowski f87959ab50
Fix `RSpec/LetSetup` cop in api/v1/timelines/public spec (#28972) 11 months ago
Matt Jankowski 34489591ec
Add `max_pinned_statuses` to instances serializer and api response (#29441) 11 months ago
Renaud Chaput b4d991adaa
Use integers and not numbers in notification policy API counters (#29810) 11 months ago
renovate[bot] 589e34d00c
Update dependency selenium-webdriver to v4.19.0 (#29776)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
11 months ago
Claire 9c24f2d6b1
Undo notification permissions on individual and domain blocks (#29570) 11 months ago
Claire 81a04ac25c
Improve specs for severed relationships (#29688) 11 months ago
Matt Jankowski 34f293475e
Fix results/query in `api/v1/featured_tags/suggestions` (#29597) 11 months ago
Claire 05eda8d193
Remove severed relationship notifications for single account suspensions (#29700) 11 months ago
Claire 814a48517f
Add some more tests for notification policies (#29698) 11 months ago
Claire 7434c9c276
Fix the relationships controller spec, since it requires an extra model now (#29671) 12 months ago
Claire 44bf7b8128
Add notifications of severed relationships (#27511) 12 months ago
Claire 8a1423a474
Allow unblocking email addresses from any matching account (#29305) 12 months ago
Matt Jankowski 6d2986017e
Remove unused `active_nav_class` helper method (#29617) 12 months ago
Claire d5063072c3
Revert friends-of-friends follow recommendation query to using a CTE (#29619) 12 months ago
Matt Jankowski 92855948a0
Remove unused `show_landing_strip?` helper method (#29618) 12 months ago
Matt Jankowski ecdbf15ebe
Remove unused `link_to_older` and `link_to_newer` helper methods (#29620) 12 months ago
Matt Jankowski 4f4132f1a1
Add diagnostic message for failure during CLI search deploy (#29462) 12 months ago
Matt Jankowski 2e91a9bd34
Add `include_pagination_headers` matcher to check `Link` header in api specs (#29596) 12 months ago
Matt Jankowski e75b55a6d7
Extract target account on list method in bulk import row service spec (#29601) 12 months ago
Matt Jankowski 974c7672e5
Extract shared behavior methods in oauth feature spec (#28360) 12 months ago
Matt Jankowski 0bc17a3d48
Use enum-generated `public_visibility` scope on Status (#28156) 12 months ago
Matt Jankowski 681a89f684
Readability clean up in `ImportVacuum` spec (#28955) 12 months ago
Matt Jankowski f9100743ec
Add `Api::ErrorHandling` concern for api/base controller (#29574) 12 months ago
Matt Jankowski 42875fee52
Add coverage for bad args/options in `CLI::Domains#purge` (#29578) 12 months ago
Matt Jankowski 71e5f0f48c
Add coverage for suspended instance actor scenario (#29571) 12 months ago
Matt Jankowski 6262ceeb70
Fix `RSpec/DescribedClass` cop (#29472) 12 months ago
Matt Jankowski c09b8a7164
Add `Account.without_internal` scope (#29559)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
12 months ago
Matt Jankowski 46e902f1f3
Merge `api/v1/accounts/credentials` controller spec into existing request spec (#29006) 12 months ago
Matt Jankowski 01b624c4a0
Use `normalizes` on `CustomFilter#context` value (#27602) 12 months ago
Matt Jankowski 71eecbfa1f
Move `api/v2/filters/*` to request spec (#28956) 12 months ago
Matt Jankowski 8349b45d60
Accept extra args that we wont verify in `ap/activity/add_spec` (#29005) 12 months ago
Matt Jankowski 469028b6d3
Remove unneeded `type: :service` from spec/services files (#29304) 12 months ago
Matt Jankowski 3eaac3af73
Use `before_all` block to setup `requests/cache_spec` data (#29437) 12 months ago
Matt Jankowski 19f0590795
Add basic coverage for `TagSearchService` class (#29319) 12 months ago
Matt Jankowski 96013cd576
Reduce `RSpec/ExampleLength` in CSP request spec (#29104) 12 months ago
Matt Jankowski 216cea1e27
Fix incorrect frequency value in `FriendsOfFriendsSource` data (#29550) 12 months ago