104 Commits (9eb775a9d1fd39bc2d255679bb12b2ff6f98080d)

Author	SHA1	Message	Date
Eugen Rochko	d412a8d1f2	Fix error when processing poll updates (#17333) ... Regression from #16697	3 years ago
Eugen Rochko	1060666c58	Add support for editing for published statuses (#16697) ... * Add support for editing for published statuses * Fix references to stripped-out code * Various fixes and improvements * Further fixes and improvements * Fix updates being potentially sent to unauthorized recipients * Various fixes and improvements * Fix wrong words in test * Fix notifying accounts that were tagged but were not in the audience * Fix mistake	3 years ago
Jeong Arm	2d1f082bb6	Fix NameError on ActivityPub::FetchFeaturedCollectionService (#17326) ... Related: #16954	3 years ago
Claire	d5c9feb7b7	Add support for private pinned posts (#16954) ... * Add support for private pinned toots * Allow local user to pin private toots * Change wording to avoid "direct message"	3 years ago
Eugen Rochko	7de0ee7aba	Remove Keybase integration (#17045)	3 years ago
Claire	3f9b28ce26	Add support for fetching Create and Announce activities by URI (#16383) ... * Add support for fetching Create and Announce activities by URI This should improve compatibility with ZAP and offer a way to fetch boosts, which is currently not possible. * Add tests	3 years ago
Claire	9a19227f17	Fix some RedisLocks auto-releasing too fast (#16276) ... * Fix Delete and Create-related locks expiring too fast Fixes #16238 By default, RedisLock expires after 10 seconds, which may not be enough to process statuses, especially when those have attached media files. This commit extends those 10 seconds to 15 minutes, which should be plenty enough to handle any status, while being short enough to not waste many sidekiq job retries in the exceedingly rare case in which a sidekiq process would crash when processing a `Create` or `Delete`. * Fix other RedisLock autorelease durations Fixes #15645 - things that only perform a few simple database queries (e.g. finding and saving a record) have been left unchanged, so they'll still use the default 10s duration - things that perform significantly more complex database queries have been changed to a 5 minutes timeout - things that perform multiple HTTP queries have been changed to a 15 minutes timeout	4 years ago
Takeshi Umeda	c403c3695b	Fix to be able to redownload avatar and header (#16190) ... * Fix to reset if header and avatar download fails * Add RedownloadAvatarWorker and RedownloadHeaderWorker	4 years ago
Eugen Rochko	2c77d97e0d	Add joined date to profiles in web UI (#16169)	4 years ago
Eugen Rochko	f627d2eb93	Fix trying to fetch key from empty URI when verifying HTTP signature (#16100)	4 years ago
luigi	7ea9588520	Use Enumerable#filter_map in more places (#15527)	4 years ago
luigi	087ed84367	Optimize map { ... }.compact calls (#15513) ... * Optimize map { ... }.compact using Enumerable#filter_map, supported since Ruby 2.7 * Add poyfill for Enumerable#filter_map	4 years ago
ThibG	a60d9335d8	Fix resolving accounts sometimes creating duplicate records for a given AP id (#15364) ... * Fix ResolveAccountService accepting mismatching acct: URI * Set attributes that should be updated regardless of suspension * Fix key fetching * Automatically merge remote accounts with duplicate `uri` * Add tests * Add "tootctl accounts fix-duplicates" Finds duplicate accounts sharing a same ActivityPub `id`, re-fetch them and merge them under the canonical `acct:` URI. Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	3134691948	Add support for reversible suspensions through ActivityPub (#14989)	4 years ago
ThibG	fb586584f2	Fix account processing failing because of large collections (#15027) ... Fixes #15025	5 years ago
ThibG	ca56527140	Add follower synchronization mechanism (#14510) ... * Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each	5 years ago
Eugen Rochko	7d985f2aac	Remove dependency on goldfinger gem (#14919) ... There are edge cases where requests to certain hosts timeout when using the vanilla HTTP.rb gem, which the goldfinger gem uses. Now that we no longer need to support OStatus servers, webfinger logic is so simple that there is no point encapsulating it in a gem, so we can just use our own Request class. With that, we benefit from more robust timeout code and IPv4/IPv6 resolution. Fix #14091	5 years ago
Eugen Rochko	64aac30733	Add customizable thumbnails for audio and video attachments (#14145) ... - Change audio files to not be stripped of metadata - Automatically extract cover art from audio if it exists - Add `thumbnail` parameter to `POST /api/v1/media`, `POST /api/v2/media` and `PUT /api/v1/media/:id` - Add `icon` to represent it in attachments in ActivityPub - Fix `preview_url` containing URL of missing missing image when there is no thumbnail instead of null - Fix duration of audio not being displayed on public pages until the file is loaded	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820)	5 years ago
Eugen Rochko	4b766f9846	Refactor monkey-patching of Goldfinger (#12561)	5 years ago
ThibG	b154428e14	Add federation support for the "hide network" preference (#11673) ... * Change ActivityPub follower/following collections to not link first page * Add support for hiding followers and following of remote users * Switch to using a single `hide_collections` column * Address code style remarks	5 years ago
ThibG	3704402dcc	Fix duplicate accounts being created when fetching an account for its key only (#13147) ... Fixes #13136 When a user's canonical acct domain is different from its id's domain (WEB_DOMAIN ≠ LOCAL_DOMAIN), two webfinger queries are required to find the canonical domain from the URI. However, we skip webfinger queries when updating only the key of a remote user, which led to the creation of a duplicate account, using the URI's domain instead of the canonical acct: one.	5 years ago
Daigo 3 Dango	206dfd7dad	Clarify keyword arguments with ** (#12769) ... This change is to suppress the warning below on on ruby-2.7.0: - warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/	5 years ago
ThibG	00c219aa45	Fix empty poll options not being filtered on remote poll update (#12484) ... If a poll contains empty options (which is apparently possible on Pleroma), it is created without them. However, the poll update code doesn't filter empty options, and thus: 1. Clear known votes, as it assumes the set of options has changed 2. Errors out because it tries adding empty options, which fails validation This commit fixes that by filtering them out the same way they are filtered out at poll creation time.	5 years ago
ThibG	3babf8464b	Add voters count support (#11917) ... * Add voters count to polls * Add ActivityPub serialization and parsing of voters count * Add support for voters count in WebUI * Move incrementation of voters count out of redis lock * Reword “voters” to “people”	6 years ago
Eugen Rochko	cb447b28c4	Add profile directory to web UI (#11688) ... * Add profile directory to web UI * Add a line of bio to the directory	6 years ago
Eugen Rochko	5d3feed191	Refactor fetching of remote resources (#11251)	6 years ago
Eugen Rochko	4e92183227	Refactor domain block checks (#11268)	6 years ago
Eugen Rochko	2cfa427ea7	Change domain block behaviour to prevent creation of accounts from suspended domains (#11219)	6 years ago
Eugen Rochko	707ddf7808	Change domain blocks to automatically support subdomains (#11138) ... * Change domain blocks to automatically support subdomains If a more authoritative domain is blocked (example.com), then the same block will be applied to a subdomain (foo.example.com) * Match subdomains of existing accounts when blocking/unblocking domains * Improve code style	6 years ago
ThibG	14f6ce2885	Record account suspend/silence time and keep track of domain blocks (#10660) ... * Record account suspend/silence time and keep track of domain blocks * Also unblock users who were suspended/silenced before dates were recorded * Add tests * Keep track of suspending date for users suspended through the CLI * Show accurate number of accounts that would be affected by unsuspending an instance * Change migration to set silenced_at and suspended_at * Revert "Also unblock users who were suspended/silenced before dates were recorded" This reverts commit a015c65d2d. * Switch from using suspended and silenced to suspended_at and silenced_at * Add post-deployment migration script to remove `suspended` and `silenced` columns * Use Account#silence! and Account#suspend! instead of updating the underlying property * Add silenced_at and suspended_at migration to post-migration * Change account fabricator to translate suspended and silenced attributes * Minor fixes * Make unblocking domains always retroactive	6 years ago
Eugen Rochko	1714ea5978	Add ActivityPub representation for identity proofs (#10414) ... * Add ActivityPub representation for identity proofs * Add tests	6 years ago
ThibG	62dd0b7f9c	Fix processing poll Updates (#10333) ... ActivityPub::ProcessPollService was checking the JSON-LD context although it was passed only the `Question` object embedded in the `Update` activity.	6 years ago
Eugen Rochko	9f5b55ad4f	Fix poll update handler calling method was that was not available (#10246) ... * Fix poll update handler calling method was that was not available Fix regression from #10209 * Refactor VoteService * Refactor ActivityPub::DistributePollUpdateWorker and optimize it * Fix typo * Fix typo	6 years ago
ThibG	3a92885a86	Support pushing and receiving updates to poll tallies (#10209) ... * Process incoming poll tallies update * Send Update on poll vote * Do not send Updates for a poll more often than once every 3 minutes * Include voters in people to notify of results update * Schedule closing poll worker on poll creation * Add new notification type for ending polls * Add front-end support for ended poll notifications * Fix UpdatePollSerializer * Fix Updates not being triggered by local votes * Fix tests failure * Fix web push notifications for closing polls * Minor cleanup * Notify voters of both remote and local polls when those close * Fix delivery of poll updates to mentioned accounts and voters	6 years ago
ThibG	09c042aa10	Handle StaleObjectError when retrieving polls (#10208)	6 years ago
ThibG	df5924a1db	Do not error out on unsalvageable errors in FetchRepliesService (#10175) ... * Do not error out on unsalvageable errors in FetchRepliesService Fixes #10152 * Fix FetchRepliesWorker erroring out on deleted statuses	6 years ago
Eugen Rochko	4037b5eb1e	Fix last_fetched_at not being set on polls (#10170)	6 years ago
Eugen Rochko	e6900b167b	Fix another typo in ActivityPub::FetchRemotePollService (#10146)	6 years ago
Eugen Rochko	878a75ba21	Fix typo in ActivityPub::FetchRemotePollService (#10145)	6 years ago
Eugen Rochko	ae1b9cf70a	Fix remote poll expiration time (#10144)	6 years ago
ThibG	e13d3792f3	Make sure the poll is created before storing its id (#10142) ... * Make sure the poll is created before storing its id * Fix updating poll results * Support fetching Question activities from the search bar	6 years ago
Eugen Rochko	230a012f00	Add polls (#10111) ... * Add polls Fix #1629 * Add tests * Fixes * Change API for creating polls * Use name instead of content for votes * Remove poll validation for remote polls * Add polls to public pages * When updating the poll, update options just in case they were changed * Fix public pages showing both poll and other media	6 years ago
ThibG	9d3c6f1849	Improved remote thread fetching (#10106) ... * Fetch up to 5 replies when discovering a new remote status This is used for resolving threads downwards. The originating server must add a “replies” attributes with such replies for it to be useful. * Add some tests for ActivityPub::FetchRepliesWorker * Add specs for ActivityPub::FetchRepliesService * Serialize up to 5 public self-replies for ActivityPub notes * Add specs for ActivityPub::NoteSerializer * Move exponential backoff logic to a worker concern * Fetch first page of paginated collections when fetching thread replies * Add specs for paginated collections in replies * Move Note replies serialization to a first CollectionPage The collection isn't actually paginable yet as it has no id nor a `next` field. This may come in another PR. * Use pluck(:uri) instead of map(&:uri) to improve performances * Fix fetching replies when they are in a CollectionPage	6 years ago
Eugen Rochko	dad339da6d	Filter incoming Create activities by relation to local activity (#10005) ... Reject those from accounts with no local followers, from relays that are not enabled, which do not address local accounts and are not replies to accounts that do have local followers	6 years ago
abcang	e186bd2fb0	Fix Tombstone.delete_all ArgumentError (#9978)	6 years ago
ThibG	75b1488cf4	Add tombstones for remote statuses (#9830) ... * Add Tombstone model to remember object deletion * Do not recreate a status if it has been deleted * Record Tombstone for remote deleted items Also, only record deleted items from same-host actors * Clear an user's tombstones when their key change	6 years ago
ThibG	28b482874a	Improvements to signature verification (#9667) ... * Refactor signature verification a bit * Rescue signature verification if recorded public key is invalid Fixes #8822 * Always re-fetch AP signing key when HTTP Signature verification fails But when the account is not marked as stale, avoid fetching collections and media, and avoid webfinger round-trip. * Apply stoplight to key/account update as well as initial key retrieval	6 years ago
ThibG	290932602b	Reduce usage of LD signatures (#9659) ... * Do not LDS-sign Follow, Accept, Reject, Undo, Block * Do not use LDS for Create activities of private toots * Minor cleanup * Ignore unsigned activities instead of misattributing them * Use status.distributable? instead of querying visibility directly	6 years ago
Eugen Rochko	0f938ff29c	Add handler for Move activity (#9629)	6 years ago