Commit Graph

2229 Commits (9920f41c0fd8ad0030d2818c8271aa3cf24b4391)

Author SHA1 Message Date
Matt Jankowski f70905f127
Add basic coverage for `UnmuteService` class ()
Matt Jankowski a69fe534e3
Add basic coverage for `WebhookService` class ()
Matt Jankowski d1602c017d
Add basic coverage for `ApproveAppealService` class ()
Matt Jankowski ab2ef63a03
Add basic coverage for `VoteService` class ()
Claire 2751acb6cd
Automatically switch from open to approved registrations in absence of moderators ()
Matt Jankowski 08342ad40c
Add basic coverage for `AfterUnallowDomainService` class ()
Matt Jankowski 8f61e32569
Add basic coverage for `AppealService` class ()
Matt Jankowski b73932461f
Add basic coverage for `CreateFeaturedTagService` class ()
Matt Jankowski 5f19e7e799
Add basic coverage for `ProcessHashtagsService` class ()
Matt Jankowski 1f648fdf1a
Remove erroneous service type on `TagFeed` model spec ()
Matt Jankowski 64f9939e39
Use `capture_emails` helper to improve email assertions in specs ()
Wolfgang Fournès 86627ea2e4
Add a missing thread example to the statuses spec ()
Matt Jankowski 245064bb98
Move "everyone" role and "instance actor" account magic number IDs to constants ()
Claire 96ddf1d482
Fix flaky end-to-end OCR test ()
Matt Jankowski 1946e171e6
Reduce round trips in admin/disputes/appeals spec ()
Matt Jankowski 3454fcbd71
Reduce round trips in auth/sessions spec ()
Matt Jankowski a316c0e38d
Reduce round trips in disputes/appeals spec ()
Matt Jankowski 117b507df5
Extract `subject` from `User#mark_email_as_confirmed!` spec ()
Matt Jankowski 1690fb39e6
Reduce `RSpec/MultipleExpectations` in instance_actors_controller spec ()
Matt Jankowski bba488c189
Reduce `RSpec/MultipleExpectations` in media_attachment spec ()
Claire 9fee5e8526
Merge pull request from GHSA-jhrq-qvrm-qr36
* Fix insufficient Content-Type checking of fetched ActivityStreams objects

* Allow JSON-LD documents with multiple profiles
Matt Jankowski a9f9b0097b
Reduce `RSpec/MultipleExpectations` in captcha feature spec ()
Matt Jankowski 4b7f04e3ea
Reduce `RSpec/MultipleExpectations` in post_status_service spec ()
Matt Jankowski ed4939296a
Reduce `RSpec/MultipleExpectations` in ap/activity/create spec ()
Matt Jankowski 1df2ffc3ee
Use `subject` in blacklist email validator spec ()
Matt Jankowski fc4f823464
Avoid local block var assignment in ap/process_status_update_service spec ()
Claire d4d0565b0f
Fix user creation failure handling in OAuth paths ()
Claire bbbbf00084
Fix OmniAuth tests ()
Claire b31af34c97
Merge pull request from GHSA-vm39-j3vx-pch3
* Prevent different identities from a same SSO provider from accessing a same account

* Lock auth provider changes behind `ALLOW_UNSAFE_AUTH_PROVIDER_REATTACH=true`

* Rename methods to avoid confusion between OAuth and OmniAuth
Emelia Smith 68eaa804c9
Merge pull request from GHSA-7w3c-p9j8-mq3x
* Ensure destruction of OAuth Applications notifies streaming

Due to doorkeeper using a dependent: delete_all relationship, the destroy of an OAuth Application bypassed the existing AccessTokenExtension callbacks for announcing destructing of access tokens.

* Ensure password resets revoke access to Streaming API

* Improve performance of deleting OAuth tokens

---------

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Emelia Smith 46142cdbdd
Disable administrative doorkeeper routes ()
Claire ca8fbda5d0
Add end-to-end test for OCR in media uploads ()
Matt Jankowski a9e91eb955
Add common stub setup for resolv dns in email mx validator spec ()
Matt Jankowski 15437e4ad9
Add `context` and `before` to lengthy tag manager spec examples ()
Matt Jankowski 5271131658
Extract helper method for repeated form fill in admin/domain_blocks feature spec ()
Claire eff447a455
Rewrite signature verification using regexps and `StringScanner` ()
Matt Jankowski 95da28d201
Add common `ThreadingHelper` module for specs ()
Claire 7efc33b909
Move HTTP Signature parsing code to its own class ()
Matt Jankowski da50217b88
Combine repeated requests in `admin/accounts` controller spec ()
Claire 7ee93b7431
Change `source` attribute of `Suggestion` entity in `/api/v2/suggestions` back to a string ()
Matt Jankowski 0df86d77fd
Reduce `RSpec/ExampleLength` in PostStatusService spec example ()
Matt Jankowski 2d6ab44556
Reduce request/response round-trips in ap/collections controller spec ()
Matt Jankowski 978fdc71ca
Reduce expectation count in example from `ProcessAccountService` spec ()
Matt Jankowski 577520b637
Replace deprecated `Sidekiq::Testing` block style ()
Matt Jankowski df7acdcee5
Update markers API spec for error case ()
Emelia Smith 4fb7f611de
Return domain block digests from admin domain blocks API ()
Matt Jankowski 4cf07ed78c
Add missing action logging to `api/v1/admin/reports#update` ()
Claire 66dda7c762
Fix already-invalid reports failing to resolve ()
Claire 1726085db5
Merge pull request from GHSA-3fjr-858r-92rw
* Fix insufficient origin validation

* Bump version to 4.3.0-alpha.1
Matt Jankowski 8b7b0ee598
Configure selenium to use Chrome version 120 ()
Matt Jankowski 86fbde7b46
Fix `Style/NumericLiterals` cop in ProfileStories support module ()
Matt Jankowski f91acba70a
Combine repeated requests in account controller concern spec ()
Matt Jankowski ff8937aa2c
Move `api/v1/statuses/*` to request spec ()
Matt Jankowski 44f6d285af
Combine repeated subject in ap fetch remote actor service spec ()
Matt Jankowski 239244e2ed
Combine repeated subject in ap fetch remote account service spec ()
Matt Jankowski 5119fbc9b7
Move `api/v1/admin/trends/links/preview_card_providers` to request spec ()
Matt Jankowski b6baab447d
Move `api/v2/admin/accounts` to request spec ()
Matt Jankowski 7adcc0aae3
Move `api/v1/trends/*` to request specs ()
Matt Jankowski 0b0ca6f3b8
Move `api/v1/timelines/list` to request spec ()
Matt Jankowski e519f113e8
Combine repeated subject in `cacheable response` shared example ()
Matt Jankowski d791bca11b
Combine double subject in `well_known/webfinger` shared example ()
Matt Jankowski 09a3493fca
Combine double subject in `api/v1/media` shared example ()
Matt Jankowski 5fbdb2055b
Combine repeated `subject` in `cli/accounts` spec shared example ()
Matt Jankowski 1a30a517d6
Combine repeated subjects in link details extractor spec ()
Matt Jankowski 685eaa04d4
Combine double subject in admin/statuses controller shared example ()
Matt Jankowski beb74fd71c
Combine double subjects in instance actors controller shared example ()
Matt Jankowski beaef4b672
Combine double subjects in application controller shared example ()
Matt Jankowski 6d35a77c92
Combine repeated subjects in `models/user` spec ()
Matt Jankowski 2f8656334d
Combine double subjects in `admin/accounts` controller spec ()
Matt Jankowski 9cc1817bb4
Fix intmermittent failure in `api/v1/accounts/statuses` controller spec ()
Matt Jankowski 0e0a94f483
Handle CLI failure exit status at the top-level script ()
Eugen Rochko 6936e5aa69
Change design of compose form in web UI ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 42ab855b23
Add specs for `Instance` model scopes and add `with_domain_follows` scope ()
Matt Jankowski 2866106ec1
Reduce factory creation in `spec/models/account_statuses_cleanup_policy` ()
Matt Jankowski 6b6586f5d0
Add `CustomFilterKeyword#to_regex` method ()
Matt Jankowski 7c9c6c7f80
Fix remaining `Rails/WhereExists` cop violations, regenerate todo ()
Claire 087415d0fe
Add tests for processing statuses using bearcap URIs ()
Claire 0471a78055
Add tests for redirect confirmations ()
Matt Jankowski a11a2fb052
Add error classes to api/base errors coverage ()
Matt Jankowski b0207d7757
Add coverage for `Tag.recently_used` scope ()
Claire e2d9635074
Add notification email on invalid second authenticator ()
Matt Jankowski 18004bf227
Add `Account.matches_uri_prefix` scope and use in activitypub/followers_synchronizations controller ()
Matt Jankowski 7ecf7f5403
Move controller->request specs for api/v1/statuses/* ()
Claire cf2a2ed71c
Fix processing of compacted single-item JSON-LD collections ()
Claire 3593ee2e36
Add rate-limit of TOTP authentication attempts at controller level ()
Matt Jankowski 329911b0a3
Migrate controller->request spec for api/v1/follow* ()
Matt Jankowski 1480573c83
Add `Account.auditable` scope, fix N+1 in admin/action_logs#index ()
Matt Jankowski d0b3bc23d7
Remove unused `matches_domain` scopes on Account, DomainAllow, DomainBlock ()
Matt Jankowski 0b853678a4
Add coverage for `api/v1/peers/search` endpoint and extract controller query to Instance scope ()
Matt Jankowski 3d82040b26
Reduced repeated setup in `UnallowDomainService` spec ()
Matt Jankowski 6c5a2d51bc
Reduced repeated setup in `PurgeDomainService` spec ()
Matt Jankowski 07e10e3747
Combine assertions about same setup in `Account#suspend!` spec ()
Matt Jankowski 9a475ea8b3
Finish up the CLI spec area pattern adoption for `CLI::Accounts#refresh` specs ()
Matt Jankowski 1b0cb3b54d
Announcement reactions query spec improvement and refactor ()
Matt Jankowski b4c332104a
Use top-level `warn` in JS errors check ()
Claire 98b5f85f10
Rename and refactor `User#confirm!` to `User#mark_email_as_confirmed!` ()
Claire e621c1c44c
Fix registrations not checking MX records for email domain blocks requiring approval ()
Matt Jankowski a2f02a0775
Disable `Rails/SkipsModelValidations` cop ()
Matt Jankowski e72676e83a
Improve `api/v1/markers#create` performance against simultaneous requests ()
MitarashiDango 2c05b8a60d
Fix Undo Announce activity is not sent, when not followed by the reblogged post author ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski a90696011e
Add coverage/bugfix for invalid appeal submission ()
Matt Jankowski 7801db7ba4
Spec coverage for custom css endpoint ()
Matt Jankowski df9e220364
Add JS console errors check ()
Matt Jankowski cd37048439
Move followable_by coverage to suggestions ()
Matt Jankowski 32eeca9c7b
Refresh instance counts in spec (fixes intermittent failure) ()
Matt Jankowski 8b26614fa7
Combine results include check in spec/models/account ()
Matt Jankowski 185c806d69
Extract spec helper for verifing to/from public AP collection namespace ()
Matt Jankowski 2954279e9c
Remove double subject call in `api/v1/admin/trends/links/links` spec ()
Matt Jankowski 95bd46d32a
Remove double subject call in `api/v1/admin/ip_blocks` spec ()
Matt Jankowski 4e08a4892f
Move streaming `around` config into manager class ()
Matt Jankowski 87097a227c
Clean up `settings/featured_tags/index` view ()
Matt Jankowski 55802242ce
Refactor login activity partial (remove inline ruby) ()
Matt Jankowski 0a7cff53c2
Add coverage for `Account.followable_by` scope ()
Claire d7e13e2483
Fix potential redirection loop of streaming endpoint ()
Matt Jankowski 8422b8ded0
Extract capybara config and improve headless_chrome driver config ()
Matt Jankowski 543d7890fd
Use normalizes to prepare `User` values ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 00341c70ff
Use Sidekiq `fake!` instead of `inline!` in specs ()
Matt Jankowski 742d8d30e2
Add coverage for `--days` option to CLI `media refresh` command ()
Renaud Chaput 63d0b52cf3
Add a system spec for the `/share` endpoint ()
Claire 10203bd57a
Clean up `Setting` model and remove dead code ()
Jean Boussier 1781849884
Inline what remains of the rails-settings-cached gem ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 5dc634796a
Misc coverage improvements re: sidekiq/inline ()
Matt Jankowski e677eb164c
Remove unused `Announcement#time_range?` ()
Matt Jankowski 3e43cd095c
Remove unused scope `Announcement.without_muted` ()
Claire 157fc69954
Make request_pool_spec tests more robust ()
Matt Jankowski aa6d07dbd9
Use normalizes to prepare CustomEmoji `domain` value ()
Matt Jankowski 832b92ac3e
Add attachment check to spec/service/suspend_account_service spec ()
Matt Jankowski 12bed81187
Add validation specs to `CustomFilter` model ()
Claire 6ad0fb5a77
Fix NULL MX handling and tighten DNS resolving specs ()
Claire 5f4643b895
Add `PAPERCLIP_ROOT_URL` to Content-Security-Policy when used ()
Matt Jankowski 964a0ecf37
Add sleep statement to nudge thread scheduler in request pool spec ()
Matt Jankowski f06c1f1552
Fix `Capybara/ClickLinkOrButtonStyle` cop in spec/features ()
Claire dfdadb92e8
Add ability to require approval when users sign up using specific email domains ()
Matt Jankowski f92d8c654d
Standardize on Thor methods in CLI classes ()
Matt Jankowski 5c769de096
Add spec coverage for `CLI::Media#remove_orphans` command ()
Matt Jankowski 74a0d81e90
Add coverage for CLI `self-destruct` command ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Claire 092bb8a27a
Fix Mastodon not correctly processing HTTP Signatures with query strings ()
Claire bd415af9a1
Change streaming API host to not be overridden to localhost in development mode ()
Claire a2624ff739
Convert signature verification specs to request specs ()
Matt Jankowski bb8077e784
Fix `RSpec/LetSetup` cop in models/account_status_cleanup_policy ()
Claire 2bf84b93d4
Fix media attachment order of remote posts ()
Matt Jankowski a4d49c236d
Fix `RSpec/LetSetup` cop in ap/fetch_featured_collection_service ()
Matt Jankowski e6e217fedd
Clean up `tagged_with_*` Status specs, fix `RSpec/LetSetup` cop ()
Matt Jankowski 513d35969e
Fix `RSpec/LetSetup` cop in auth controller specs ()
Matt Jankowski 9251779d75
Fix `RSpec/LetSetup` cop in spec/services ()
Matt Jankowski efd16f3c2c
Clean up of `RSpec/LetSetup` within `spec/services/activitypub` ()
Matt Jankowski c99f88e1a8
Clean up of `RSpec/LetSetup` within `spec/lib` ()
Matt Jankowski cd64a5b2ec
Clean up of `RSpec/LetSetup` within `api/` ()
Matt Jankowski f32d672d2f
Clean up of `RSpec/LetSetup` within `spec/controllers` ()
Matt Jankowski c753b1ad35
Clean up of `RSpec/LetSetup` within `spec/models` ()