290 Commits (8f0f4a861ae0968f9bd0e4ec15e6db2fddee7609)

Author	SHA1	Message	Date
Joël Quenneville	1cf9e14a41	Test embedded_view related code in a helper (#2282) ... The two methods `StreamEntriesHelper#stream_link_target` and `StreamEntriesHelper#acct` are based on checking whether we are running in an embedded view. This adds some test helper code to make the testing easier. We extracted some "magic strings" to constants to lower the coupling in the specs.	8 years ago
Joël Quenneville	0c2fe22bc1	Add test coverage to CSS class generation (#2285) ... The code that generates CSS is based on a lot of boolean conditions. The possible combinations of these grows exponentially as we add more conditions. Since most of the code is conditional on a single boolean, we tested the following: 1. All `false` 2. All `true` 3. Each individual flag set to `true` The methods tested are: * `StreamEntriesHelper#style_classes` * `StreamEntriesHelper#microformats_classes` * `StreamEntriesHelper#microformats_h_class`	8 years ago
Evan Minto	66fd8e7821	ActivityPub: Add basic, read-only support for Outboxes, Notes, and Create/Announce Activities (#2197) ... * Clean up collapsible components * Expose user Outboxes and AS2 representations of statuses * Save work thus far. * Fix bad merge. * Save my work * Clean up pagination. * First test working. * Add tests. * Add Forbidden error template. * Revert yarn.lock changes. * Fix code style deviations and use localized instead of hardcoded English text.	8 years ago
Ash Furrow	723f25a999	Admin UI for confirming users (#2245) ... * Shows confirmed status in list. * Adds ability to confirm users in admin UI. * Added new english translations. * Addresses feedback from #2245. * More feedback.	8 years ago
Wesley Ellis	a1174a6d7e	Add og:url tags (#2298) ... * add og:url to stream_item view * add og:url and text to about/show * add og:url to profile, followers and follows pages	8 years ago
Matt Jankowski	629d35e6f5	[WIP] Html lang on statuses (#2297) ... * Add html lang attributes around statuses * Remove urls from language detection	8 years ago
Matt Jankowski	67dea31b0f	2FA controller cleanup (#2296) ... * Add spec coverage for settings/two_factor_auth area * extract setup method for qr code * Move otp required check to before action * Merge method only used once * Remove duplicate view * Consolidate creation of @codes for backup * Move settings/2fq#recovery_codes to settings/recovery_codes#create * Rename settings/two_factor_auth#disable to #destroy * Add coverage for the otp required path on 2fa#show * Clean up the recovery codes list styles * Move settings/two_factor_auth to settings/two_factor_authentication * Reorganize the settings two factor auth area Updated to use a flow like: - settings/two_factor_authentication goes to a #show view which has a button either enable or disable 2fa on the account - the disable button turns off the otp requirement for the user - the enable button cycles the user secret and redirects to a confirmation page - the confirmation page is a #new view which shows the QR code for user - that page posts to #create which verifies the code, and creates the recovery codes - that create action shares a view with a recovery codes controller which can be used separately to reset codes if needed	8 years ago
Joël Quenneville	974ac467de	Add tests for StreamEntriesHelper#rtl? (#2286) ... We used some random Arabic characters to test that the various RTL conditions got triggered.	8 years ago
Matt Jankowski	ee0c897bba	User settings mutation (#2270) ... * Add user spec for settings, highlight global default mutation issue * Fix mutation issue caused by settings/preferences spec	8 years ago
Matt Jankowski	2dda356e3f	Clean up settings/preferences controller (#2237) ... * Add missing fields group on preferences page * Clean up settings/preferences controller * Extract a UserSettingsDecorator	8 years ago
Matt Jankowski	1ada494bb2	Admin settings controller refactor, add specs, cleanup (#2225) ... * Add render_views for admin/settings spec * Add coverage for admin/settings#update * Add coverage for admin/settings typecasting open_registrations setting * Simplify how admin/settings finds the value for updating * Rely on activerecord to not update a value that hasnt changed * Add coverage for non-existent setting * Use a constant for boolean settings	8 years ago
Marcin Cieślak	59a77923b3	Add static gif for upload testing (#2168)	8 years ago
Eugen	2e4afccd9d	Fix #2108 - Fix gif uploads (#2171) ... * Fix #2108 - Fix gif uploads Add specs for media attachment gifv conversion * Add ffmpeg to travis * Make travis install ffmpeg, not libav * Switch travis to trusty	8 years ago
Eugen	1d47910d3b	Fix possibility of unrightful webfinger redirect (#2147) ... * Fix possibility of unrightful webfinger redirect * Add more tests for FollowRemoteAccountService	8 years ago
abcang	70891a99a9	Fix html escape characters in the URL (#2138) ... * fix character escaping in URL * add tests * put a comma after the last item * add HTML escape test	8 years ago
Matt Jankowski	8bac0350d1	Restful refactor of accounts/ routes (#2133) ... * Add routing specs for accounts followers and following actions * Use more restful route naming for public account follow pages Moves two actions: - accounts#followers to accounts/follower_accounts#index - accounts#following to accounts/following_accounts#index Adds routing spec to ensure prior URLs are preserved.	8 years ago
Eugen	96268e76e6	Fix wording on admin instances view, fix typos in language detector spec (#2106)	8 years ago
Eugen	6bd1019235	Add more tests for AtomSerializer (#2096)	8 years ago
Matt Jankowski	297c11dba2	Language detection refactor (#2099) ... * Extract detect_language to separate class * Use default locale, not just en * Add spec to confirm that whatlanguage cant identify empty string * Allow account locale to override default in language detector * PostStatusService supplies an account to detect language	8 years ago
happycoloredbanana	0a7588282a	Remove API authentication for public statuses (after review) (#1919)	8 years ago
Matt Jankowski	55e1503522	Instances list in admin (#2095) ... * Add admin/instances index action * Add link to instances admin page * View lists instances * Instances, grouped by domain, ordered by count * Use Account.remote scope * Extract method: Account.by_domain_accounts	8 years ago
Matt Jankowski	66d8f99a30	Admin reports with accounts (#2092) ... * Add a ReportFilter class * Add reports and targeted_reports relationships to Account * Use ReportFilter from admin/reports controller * Link to admin/reports filtered views from admin account show view * Add indexes to reports.account_id and reports.target_account_id	8 years ago
Matt Jankowski	16d50f60d1	Remove unused methods (#1730) ... * Remove unused method #set_counters_maps from api controller * Remove unused method #set_account_counters_maps from api controller * Remove unused method Account#followers_domains * Remove unused User.prolific scope * Add mastodon:users:admins task to list all admin emails * Use interpolated query style in Account.triadic_closures * Coverage for Account.triadic_closures	8 years ago
Eugen	f03fb6c0ae	Add forgotten AtomSerializer spec (#2047)	8 years ago
Matt Jankowski	389f8f8249	Instance helper to replace site title helper (#2038) ... * Move site title helper to instance helper (name change only) * Remove newline in <title> tag * Add site_hostname helper method to wrap up local_domain value * Use site_hostname helper in places that need local_domain value	8 years ago
Matt Jankowski	4ed12cd89a	Remove i18n_spec file (#2014) ... These were being skipped with `xit`, but we also just added the `unused` task to the CI server, and it will be caught there. That seems good enough for this, instead of requiring a full keys check on every local spec suite run.	8 years ago
Matt Jankowski	cc1361c149	Media controller specs (#2022) ... * Add spec for media controller * Add MediaAttachment.attached scope * Simplify methods in media controller	8 years ago
Matt Jankowski	21a767dcfa	Improve handling of HTTP_ACCEPT for webfinger (#2008) ... This change includes: - Improve the spec coverage for incoming request to the webfinger action - For requests without an accept header (ie, what a browser might look like), return a JSON response. - For requests with an explicit format of xml or json, return that format. - For requests using an accept header, return that format. Also adds failing spec showing webfinger does not return xml, which covers the issue described in: https://github.com/tootsuite/mastodon/issues/1983	8 years ago
Tomohiro Suwa	3399dd7a66	Fix nil query_username (#2013)	8 years ago
saturday06	d87ee1167e	Assign user locale on signup (#1982)	8 years ago
Eugen	5d710b1139	Make file attachment on MediaAttachment optional (#1865) ... Create MediaAttachment but without actual file download when domain is blocked with reject_media set to true Clean up old media files when creating a new domain block with reject_media set to true Return remote_url in media attachments API if local file is not present Undo domain block action in admin UI Ability to enable reject_media from admin UI	8 years ago
Matt Jankowski	3834e1e69b	View spec fix (#1888) ... * Add option to disable verify partial doubles * Add show_landing_strip? helper method * Use show_landing_strip? helper in accounts and stream entries views * Fix naming in view specs	8 years ago
Matt Jankowski	6670e6d33f	Add password reset for users from admin accounts area (#1841)	8 years ago
Matt Jankowski	3b8908c114	About page contact email (#1839) ... * Correct site_contact_email typo * Separate about more page into partials, add specs	8 years ago
Matt Jankowski	355965c17b	Silence Devise deprecation warning about TestHelpers (#1840) ... Devise changed their approach - 3f3ec236bb This change silences a deprecation warning about `TestHelpers`	8 years ago
Patrick Figel	df4ff9a8e1	Add recovery code support for two-factor auth (#1773) ... * Add recovery code support for two-factor auth When users enable two-factor auth, the app now generates ten single-use recovery codes. Users are encouraged to print the codes and store them in a safe place. The two-factor prompt during login now accepts both OTP codes and recovery codes. The two-factor settings UI allows users to regenerated lost recovery codes. Users who have set up two-factor auth prior to this feature being added can use it to generate recovery codes for the first time. Fixes #563 and fixes #987 * Set OTP_SECRET in test enviroment * add missing .html to view file names	8 years ago
Matt Jankowski	40fd1de488	Account search service refactor (#1791) ... * Begin coverage for account search service * Coverage for hashtag query * Coverage for calling local vs remote find based on domain presence * Spec to check that exact matches are not duped * Coverage of resolve option * Coverage for account being provided * Start to refactor account search service * Isolate query username and domain methods * Isolate exact_match method * Extract methods for local and remote results * Simplify local vs remote and account isoliation * Extract methods for local and remote results * Simplify de-dupe of exact match * Simplify logic to check for non exact remotes * Cache some methods * Remove nil from exact_match from results array * Return exact matches first * Use find_remote even with no domain Account.find_local is just an alias for Account.find_remote(user, nil) - so we can not bother with the conditional here, and call find_remote directly.	8 years ago
ThibG	31f0bcf804	Refresh webfinger (#1323) ... * Refresh local info for remote accounts when webfinger returns new values It only refreshes account info if one of the URLs or the public-key changes, in which cases it refreshes the full info, re-downloading the feeds from that user. Some special handling should probably be done when the public key changes, but I have been unable to find any use for it in Mastodon yet. * Re-fetch remote users we aren't subscribed to. This might induce performance issues, we might want to only do that for users we explicitly attempted to subscribe but failed to. * Refactor changes * Do not refresh existing remote account details more than once a day * Avoid re-fetching webfinger info in tests unless otherwise specified	8 years ago
Matt Jankowski	09540192c9	Rename admin/accounts_helper to admin/filter_helper (#1816) ... - Add some spec coverage for both methods - Add explicit constant call-outs for where the params are from	8 years ago
Ben Roberts	89707ad0ac	add basic microformats tests (#1803) ... as suggested, moving to view tests rather than a controller test replaces https://github.com/tootsuite/mastodon/pull/1786 which i will close momentary	8 years ago
Chad Pytel	92cd207c50	Introduce capybara and first feature spec (#1801) ... This commit introduces Capybara and the first feature spec. I focused on coverage for log in for the first feature spec because that would have prevented 624a9a7136 causing #1236.	8 years ago
Matt Jankowski	f5cd138323	Improve i18n chooser (#1804) ... * Add locale spec with failing locale plus region check * Use a more accurate locale when supplied by browser headers Previously we were using a matching option which would use the first locale available which matched the locale portion, even if a region was specified. This changes to first try to find an exact match, and then fall back to the region, and then fall back to the default. * Clean up default_locale method	8 years ago
Matt Jankowski	8b74aa4217	Admin reports controller improvements (#1714) ... * Simplify admin/reports controller filtering for index * Rename parameter to resolved * Fix issue where reports view could not access filter_link_to * Add coverage for admin/reports controller * DRY up resolution of related reports for target account * Clean up admin/reports routes * Add Report#statuses method * DRY up current account action taken params * Rubocop styles	8 years ago
Matt Jankowski	b330d1f000	Organize coverage dirs (#1695) ... * Add `Presenters` group to SimpleCov configuration * Move validators to app/validators, add to simplecov config	8 years ago
Matt Jankowski	4fe5e04ea4	Fix csv export coverage in export spec (#1691)	8 years ago
Matt Jankowski	137100dcf3	Clean up well-known routes/controllers (#1649) ... * Add request spec for host meta route returning xml * Add routing spec for xrd routes * Update well-known routes * Move webfinger and host-meta actions to their own controllers	8 years ago
Matt Jankowski	3a9eb81a80	Admin accounts controller cleanup (#1664) ... * Remove unused account_params method in admin/accounts controller * Introduce AccountFilter to find accounts * Use AccountFilter in admin/accounts controller * Use more restful routes admin silence and suspension area * Add admin/silences and admin/suspensions controllers	8 years ago
Matt Jankowski	0e39cc6a35	Settings export refactor (#1646) ... * Refactor Export to take an account and know about the export types * Use Export instance in settings/exports#show	8 years ago
Matt Jankowski	f24daa399b	Remove pending specs for methods that dont exist (#1658) ... * Remote spec for non-existent entry_classes helper method This method no longer exists, and is handled by a local variable in a partial instead. * Remove spec for non-existent Account#ping! method	8 years ago
Eugen	5dc73339ae	Fix tests issue introduced in #1607 (#1639)	8 years ago
Matt Jankowski	aa90798386	Webfinger resource to extract username from resource string (#1607) ... * Add WebfingerResource class to extract usernames * Use WebfingerResource in xrd#webfinger	8 years ago
Matt Jankowski	7f0a865b05	Allow import/export of mutes list (#1541) ... * Allow export of mutes list * Allow importing of mutes list * Refactor to use Settings::Exports::BaseController and DRY up exports code	8 years ago
Henry Smith	08fce08217	Add unit tests for https://github.com/tootsuite/mastodon/pull/1574 (#1584)	8 years ago
Matt Jankowski	dd1ae3b109	Simplify the way the embed view is created (#1590) ... * Add coverage for embedded status view * Refactor embed view to eliminate @external_links variable	8 years ago
Matt Jankowski	b352a8e5d4	Default to json type for webfinger requests (#1583)	8 years ago
Matt Jankowski	b155e6ccf5	Fix issue with intermittent api/v1/notifications failure (#1606) ... The spec was checking the activity_id of the activities held in notifications within the controller. Because the activities are different models, it is possible that they are created with the same database IDs, and when they are this spec fails because an activity which should not count as a match is counted as one.	8 years ago
Matt Jankowski	3ddd936b03	Refactor exports controller (#1567) ... * Add basic coverage for settings/exports controller * Remove unused @account variable from settings/exports controller * Add coverage for download export actions * Remove deprecated `render :text` in favor of `send_data` for csv downloads * Add model to handle exports * Use Export class in settings/exports controller * Simplify settings/exports controller methods * Move settings/export to more restful routes	8 years ago
Matt Jankowski	89e8e110c8	Imports controller errors (#1553) ... * Add spec for settings/imports controller * Add failing spec for settings/imports#create * Fix broken imports * Refactor ImportWorker	8 years ago
Matt Jankowski	e60286a344	Remove unused methods from StreamEntriesHelper (#1365) ... Removes: - avatar_for_status_url - relative_time - reblogged_by_me_class - favourited_by_me_class	8 years ago
Matt Jankowski	53850bce93	Remove unused AtomBuilderHelper (#1364) ... This was used in the views/atom/user_stream.xml.ruby file, which no longer is used.	8 years ago
Matt Jankowski	4ada50985a	Pagination improvements (#1445) ... * Replace will_paginate with kaminari * Use #page instead of #paginate in controllers * Replace will_paginate.page_gap with pagination.truncate in i18n * Customize kaminari views to match prior styles * Set kaminari options to match prior behavior * Replace will_paginate with paginate in views	8 years ago
Eugen	12f72e1740	When avatar/header are GIF, generate static versions (#1428) ... * When avatar/header are GIF, generate static versions. Account API returns "avatar"/"avatar_static", "header"/"header_static" Static version is the same as original for other cases Web UI de-animates avatars in toots, lists of users Fix #441, fix #596, prerequisite for #1064 * Fix JS test * Add rake task to generate static avatars/headers from GIF ones, add test	8 years ago
Eugen	2810013b93	API param to exclude notification types from response (#1341) ... * Add exclude_types param to /api/v1/notifications * Exclude notification types in web UI through exclude_types in the API	8 years ago
Matt Jankowski	0687ab8ae3	Clean up generation of account webfinger string (#1477) ... * Consolidate webfinger string creation under Account#to_webfinger_s * Introduce Account#local_username_and_domain for consolidation	8 years ago
Matt Jankowski	dbe9f33fdc	Admin base controller (#1465) ... * Add Admin::BaseController to wrap admin area Extracts the setting of the `admin` layout and verifying that users are admins to a common base class for the admin/ controllers. * Add basic coverage for admin/reports and admin/settings controllers	8 years ago
Eugen	15d442cf9d	Fix /api/v1/accounts/update_credentials tests (#1357)	8 years ago
David Celis	d4fe6cd2bf	Allow users to update their Account in the API (#1179) ... * Allow users to update their Account in the API It would be nice for API clients to be able to allow users to update their accounts without having to wrap Mastodon in a web view. This patch adds an API endpoint to let users submit a PATCH for their account. Signed-off-by: David Celis <me@davidcel.is> * Add /api/v1/accounts/update_credentials to the API docs Signed-off-by: David Celis <me@davidcel.is>	8 years ago
Matt Jankowski	ea6c930c04	Helper cleanup (#1348) ... * Remove unused helper files * Add coverage for application helper * Add coverage for StreamEntriesHelper #display_name	8 years ago
Matt Jankowski	e5282e4ec0	Clean up about page (#1282) ... * Add InstancePresenter to expose site details * Clean up about controller, use instance presenter	8 years ago
Matt Jankowski	388ec0d5b6	Search cleanup (#1333) ... * Clean up SQL output in Tag and Account search methods * Add basic coverage for Tag.search_for * Add coverage for Account.search_for * Add coverage for Account.advanced_search_for	8 years ago
Matt Jankowski	71706f21c2	Ignore implied formats for catch all route requests (#1340) ... A request to `/test` would show the custom 404 page, but a request to `/test.test` would return a 404 with an empty body. This change ignores the format on incoming catch all route requests, so that the html 404 page is returned on these requests.	8 years ago
Eugen	982fef811e	Fix #1141, fix #1126 - Avatar/profile info fetching (#1215) ... * Fix #1141, fix #1126 - Work through UpdateRemoteProfileService for both <feed> and <entry> top-level tags * Improve code quality, remove line unrelated to fix	8 years ago
Matt Jankowski	ca44c13455	Use Setting.site_title value for `og:site_name` occurrences (#1194) ... * Add helper method to return Setting.site_title * Use site_title helper in application layout * Use site_title value for og:site_name	8 years ago
Eugen	1961825ff9	Merge pull request #1183 from thoughtbot/cp-post-status-service-specs ... Add specs for PostStatusService	8 years ago
Eugen	32748c0f71	Merge pull request #1184 from thoughtbot/extract-proper-status ... DRY up reblog vs original status check	8 years ago
Joël Quenneville	4fdeac21f4	Implement pending specs on Status ... Implement the two pending specs on `Status`: `reblogs_count` and `favourites_count`.	8 years ago
Chad Pytel	ad5ddd5e95	Use I18n for media attachment validation errors ... These are currently user facing errors, but are not localized. This adds the ability for these messages to be localized.	8 years ago
Chad Pytel	13c0077003	Add specs for PostStatusService ... This implements all pending specs, and adds additional coverage for the following functionality: * Normal status creation * Creating a reply status * Creating a sensitive status * Creating a status with spoiler text * A status with no spoiler text gets an empty string for spoiler text * Creating a status with custom visibility * Creating a status for an application * Processing mentions * Processing Hashtags * Pinging PuSH hubs * Crawling links * Attaching media	8 years ago
Joël Quenneville	d4c94fa004	DRY up reblog vs original status check ... Checking reblog vs original status was happening in multiple places across the app. For views, this logic was encapsulated in a helper method named `proper_status` but in the other layers of the app, the logic was duplicated. Because the logic is used at all layers of the app, we extracted it into a `Status#proper` method on the model and changed all uses of the logic to use this method. There is now a single source of truth for this condition. We added test coverage to untested methods that got refactored.	8 years ago
Chad Pytel	38bec79811	Add specs for media attachment validations ... There are currently not specs for the two media validations that are performed by `PostStatusService`. This adds specs for the validations that ensure that you cannot attach more than four files, and that a status cannot have both image and video attachments.	8 years ago
Eugen Rochko	5442083b3c	Split SalmonWorker into smaller parts, move profile updating into another job	8 years ago
Eugen Rochko	667ffafef8	Fix spec	8 years ago
Eugen	4c92f15664	Merge branch 'master' into add_more_tests_to_models	8 years ago
Eugen	117b22e905	Merge pull request #852 from peterkeen/email-whitelist-817 ... [#817] Add email whitelist	8 years ago
Samy KACIMI	073f92fc76	Merge branch 'master' into add_more_tests_to_models	8 years ago
Samy KACIMI	46c0e8b0e7	update account_spec	8 years ago
Samy KACIMI	81c76fe375	add more tests to models	8 years ago
Kurtis Rainbolt-Greene	9ae9ecdebe	Quick attempt to get pull requests passing	8 years ago
Pete Keen	e9a6da6bc7	[#817] Add email whitelist ... This adds the ability to filter user signup with a whitelist instead of or in addition to a blacklist. Fixes #817	8 years ago
Eugen Rochko	68f829e11c	Add basic logging of who resolved report	8 years ago
Eugen Rochko	e8875c6046	Import feature for following/blocking lists (addresses #62, #177, #201, #454)	8 years ago
Eugen Rochko	1c6b02f936	Fix #690 - Webfinger should handle new shortform profile URLs now (nice)	8 years ago
Eugen Rochko	d6ed2eb512	Prettier account and stream entry URLs	8 years ago
Eugen Rochko	4fb95c91fb	Fix wrongful matching of last period in extended usernames ... Fix anchor tags in some wikipedia URLs being matches as a hashtag	8 years ago
Eugen Rochko	6b81d10030	Add digest e-mails	8 years ago
Kit Redgrave	442fdbfc53	Mute button progress so far. WIP, doesn't entirely work correctly.	8 years ago
Eugen Rochko	3202bdd744	Fix #555 - Use a better URL parser	8 years ago
Eugen Rochko	3b81baaaaf	Adding POST /api/v1/reports API, and a UI for submitting reports	8 years ago
Eugen Rochko	720ff55262	Adding more unit tests. Fixing Salmon slaps XML	8 years ago
Eugen Rochko	0518492158	Stop trying to shoehorn all Salmon updates into the poor database-connected ... StreamEntry model. Simply render Salmon slaps as they are needed	8 years ago