Commit Graph

2189 Commits (86f999c1f2db7186c6d43670f78d05ebd9ccc042)

Author SHA1 Message Date
Matt Jankowski 6c5a2d51bc
Reduced repeated setup in `PurgeDomainService` spec (#28786) 1 year ago
Matt Jankowski 07e10e3747
Combine assertions about same setup in `Account#suspend!` spec (#28787) 1 year ago
Matt Jankowski 9a475ea8b3
Finish up the CLI spec area pattern adoption for `CLI::Accounts#refresh` specs (#28764) 1 year ago
Matt Jankowski 1b0cb3b54d
Announcement reactions query spec improvement and refactor (#28768) 1 year ago
Matt Jankowski b4c332104a
Use top-level `warn` in JS errors check (#28745) 1 year ago
Claire 98b5f85f10
Rename and refactor `User#confirm!` to `User#mark_email_as_confirmed!` (#28735) 1 year ago
Claire e621c1c44c
Fix registrations not checking MX records for email domain blocks requiring approval (#28608) 1 year ago
Matt Jankowski a2f02a0775
Disable `Rails/SkipsModelValidations` cop (#28712) 1 year ago
Matt Jankowski e72676e83a
Improve `api/v1/markers#create` performance against simultaneous requests (#28718) 1 year ago
MitarashiDango 2c05b8a60d
Fix Undo Announce activity is not sent, when not followed by the reblogged post author (#18482)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski a90696011e
Add coverage/bugfix for invalid appeal submission (#28703) 1 year ago
Matt Jankowski 7801db7ba4
Spec coverage for custom css endpoint (#28706) 1 year ago
Matt Jankowski df9e220364
Add JS console errors check (#28682) 1 year ago
Matt Jankowski cd37048439
Move followable_by coverage to suggestions (#28697) 1 year ago
Matt Jankowski 32eeca9c7b
Refresh instance counts in spec (fixes intermittent failure) (#28698) 1 year ago
Matt Jankowski 8b26614fa7
Combine results include check in spec/models/account (#28471) 1 year ago
Matt Jankowski 185c806d69
Extract spec helper for verifing to/from public AP collection namespace (#28472) 1 year ago
Matt Jankowski 2954279e9c
Remove double subject call in `api/v1/admin/trends/links/links` spec (#28695) 1 year ago
Matt Jankowski 95bd46d32a
Remove double subject call in `api/v1/admin/ip_blocks` spec (#28696) 1 year ago
Matt Jankowski 4e08a4892f
Move streaming `around` config into manager class (#28684) 1 year ago
Matt Jankowski 87097a227c
Clean up `settings/featured_tags/index` view (#28688) 1 year ago
Matt Jankowski 55802242ce
Refactor login activity partial (remove inline ruby) (#28687) 1 year ago
Matt Jankowski 0a7cff53c2
Add coverage for `Account.followable_by` scope (#28689) 1 year ago
Claire d7e13e2483
Fix potential redirection loop of streaming endpoint (#28665) 1 year ago
Matt Jankowski 8422b8ded0
Extract capybara config and improve headless_chrome driver config (#28681) 1 year ago
Matt Jankowski 543d7890fd
Use normalizes to prepare `User` values (#28650)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 00341c70ff
Use Sidekiq `fake!` instead of `inline!` in specs (#25369) 1 year ago
Matt Jankowski 742d8d30e2
Add coverage for `--days` option to CLI `media refresh` command (#28669) 1 year ago
Renaud Chaput 63d0b52cf3
Add a system spec for the `/share` endpoint (#28672) 1 year ago
Claire 10203bd57a
Clean up `Setting` model and remove dead code (#28661) 1 year ago
Jean Boussier 1781849884
Inline what remains of the rails-settings-cached gem (#28618)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 5dc634796a
Misc coverage improvements re: sidekiq/inline (#28651) 1 year ago
Matt Jankowski e677eb164c
Remove unused `Announcement#time_range?` (#28648) 1 year ago
Matt Jankowski 3e43cd095c
Remove unused scope `Announcement.without_muted` (#28645) 1 year ago
Claire 157fc69954
Make request_pool_spec tests more robust (#28610) 1 year ago
Matt Jankowski aa6d07dbd9
Use normalizes to prepare CustomEmoji `domain` value (#28624) 1 year ago
Matt Jankowski 832b92ac3e
Add attachment check to spec/service/suspend_account_service spec (#28619) 1 year ago
Matt Jankowski 12bed81187
Add validation specs to `CustomFilter` model (#28600) 1 year ago
Claire 6ad0fb5a77
Fix NULL MX handling and tighten DNS resolving specs (#28607) 1 year ago
Claire 5f4643b895
Add `PAPERCLIP_ROOT_URL` to Content-Security-Policy when used (#28561) 1 year ago
Matt Jankowski 964a0ecf37
Add sleep statement to nudge thread scheduler in request pool spec (#28596) 1 year ago
Matt Jankowski f06c1f1552
Fix `Capybara/ClickLinkOrButtonStyle` cop in spec/features (#28576) 1 year ago
Claire dfdadb92e8
Add ability to require approval when users sign up using specific email domains (#28468) 1 year ago
Matt Jankowski f92d8c654d
Standardize on Thor methods in CLI classes (#28566) 1 year ago
Matt Jankowski 5c769de096
Add spec coverage for `CLI::Media#remove_orphans` command (#28267) 1 year ago
Matt Jankowski 74a0d81e90
Add coverage for CLI `self-destruct` command (#28565)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Claire 092bb8a27a
Fix Mastodon not correctly processing HTTP Signatures with query strings (#28476) 1 year ago
Claire bd415af9a1
Change streaming API host to not be overridden to localhost in development mode (#28557) 1 year ago
Claire a2624ff739
Convert signature verification specs to request specs (#28443) 1 year ago
Matt Jankowski bb8077e784
Fix `RSpec/LetSetup` cop in models/account_status_cleanup_policy (#28470) 1 year ago
Claire 2bf84b93d4
Fix media attachment order of remote posts (#28469) 1 year ago
Matt Jankowski a4d49c236d
Fix `RSpec/LetSetup` cop in ap/fetch_featured_collection_service (#28461) 1 year ago
Matt Jankowski e6e217fedd
Clean up `tagged_with_*` Status specs, fix `RSpec/LetSetup` cop (#28462) 1 year ago
Matt Jankowski 513d35969e
Fix `RSpec/LetSetup` cop in auth controller specs (#28464) 1 year ago
Matt Jankowski 9251779d75
Fix `RSpec/LetSetup` cop in spec/services (#28459) 1 year ago
Matt Jankowski efd16f3c2c
Clean up of `RSpec/LetSetup` within `spec/services/activitypub` (#28445) 1 year ago
Matt Jankowski c99f88e1a8
Clean up of `RSpec/LetSetup` within `spec/lib` (#28447) 1 year ago
Matt Jankowski cd64a5b2ec
Clean up of `RSpec/LetSetup` within `api/` (#28448) 1 year ago
Matt Jankowski f32d672d2f
Clean up of `RSpec/LetSetup` within `spec/controllers` (#28446) 1 year ago
Matt Jankowski c753b1ad35
Clean up of `RSpec/LetSetup` within `spec/models` (#28444) 1 year ago
Matt Jankowski 2463b53363
More duplicates in cli maintenance spec, misc bug fixes (#28449) 1 year ago
Matt Jankowski 961d65aba6
Add coverage to CLI Maintenance for duplicate users on `confirmation_token` and `reset_password_token` values (#28434) 1 year ago
Claire 6fed0fcbaa
Remove unneeded settings cleanup from specs (#28425) 1 year ago
Matt Jankowski c7c727994a
Add spec for `CLI::Maintenance#fix_duplicates` (#28326) 1 year ago
Eugen Rochko b5ac61b2c5
Change algorithm of follow recommendations (#28314)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski c28976d89e
Handle negative offset param in `api/v2/search` (#28282) 1 year ago
Matt Jankowski 476d1237d4
Typo fix in json ld helper spec (#28417) 1 year ago
Claire 7d9b209fe8
Fix call to inefficient `delete_matched` cache method in domain blocks (#28374) 1 year ago
Matt Jankowski af366f65ee
Add spec coverage for `models/form/custom_emoji_batch` class (#28388) 1 year ago
Matt Jankowski 1820bad646
Fix `Performance/StringIdentifierArgument` cop (#28399) 1 year ago
Matt Jankowski b1dec09d20
Fix `Style/InverseMethods` cop (#28377) 1 year ago
Matt Jankowski db897eaa5a
Unwind `map` on single-item array in `spec/services/delete_account_service` spec (#28358) 1 year ago
Matt Jankowski ef9797a395
Un-nest contexts in `settings/2fa/webauthn` spec (#28359) 1 year ago
Matt Jankowski adbfd40a1b
Convert `api/v1/directories` controller spec to request spec (#28356) 1 year ago
Matt Jankowski 28e1a7a394
Improve spec coverage for `models/announcement` class (#28350) 1 year ago
Matt Jankowski 8a3d8c6c14
Remove the `stub_stdout` wrapper around CLI specs (#28340) 1 year ago
Claire 89a496b42f
Fix status edits not always being streamed to mentioned users (#28324) 1 year ago
Matt Jankowski b5a1013ae3
Combine `CLI::...` spec example subjects (#28285) 1 year ago
Matt Jankowski 0e4233de9d
Controller spec to request spec: `api/v2/suggestions` (#28297) 1 year ago
Matt Jankowski 0c64092500
Controller spec to request spec: `api/v1/accounts/search` (#28299) 1 year ago
Matt Jankowski 16ede59d0a
Controller spec to request spec: `api/v1/featured_tags/suggestions` (#28298) 1 year ago
Matt Jankowski 809506bdd4
Controller spec to request spec: `api/v1/accounts/pins` (#28300) 1 year ago
Matt Jankowski 94cc707ab3
Controller spec to request spec: `api/v1/accounts/notes` (#28301) 1 year ago
Matt Jankowski e544b6df42
Controller spec to request spec: `api/v1/accounts/lookup` (#28302) 1 year ago
Matt Jankowski a968898dc7
Controller spec to request spec: `api/v1/accounts/lists` (#28303) 1 year ago
Matt Jankowski 8f94502e7d
Controller spec to request spec: `api/v1/accounts/identify_proofs` (#28304) 1 year ago
Matt Jankowski 78347d2556
Controller spec to request spec: `api/v1/accounts/familiar_followers` (#28305) 1 year ago
Matt Jankowski 11d2bd9716
Fix intermittent failure from unspecified order in `api/v1/accounts/relationships` spec (#28306) 1 year ago
Matt Jankowski a3cbb4b2f1
Add spec for `CLI::Search#deploy` command (#28272) 1 year ago
Matt Jankowski 8de86eabbf
Add spec for `CLI::Domains#crawl` command (#28271) 1 year ago
Matt Jankowski 7e514688b3
Convert `api/v2/search` controller spec to request spec (#28269) 1 year ago
Matt Jankowski 8d8ae05a18
Add spec coverage for `CLI::Media#lookup` command (#28266) 1 year ago
Matt Jankowski ad34d33bfd
Formalize some patterns in cli specs (#28255) 1 year ago
Matt Jankowski 0b4a3a0437
Remove remaining `without_partial_double_verification` usage (#28127) 1 year ago
Claire 658ad7a6ca
Fix flaky tests related to file creation (#28248) 1 year ago
Matt Jankowski 0e8ba19113
Add spec coverage for `CLI::Emoji` class (#28182) 1 year ago
Matt Jankowski ed7b5c091b
Remove double subject call in `services/delete_account_service` spec (#28212) 1 year ago
Matt Jankowski be6bb1a10d
Remove double subject call in `services/suspend_account_service` spec (#28213) 1 year ago
Matt Jankowski 5517df61de
Remove double subject call in `services/activitypub/process_account_service` spec (#28214) 1 year ago
Matt Jankowski faffd81976
Remove double subject call in `services/unsuspend_account_service` spec (#28215) 1 year ago
Matt Jankowski 89a8e6e622
Remove 2x double subject call in `models/form/account_batch` spec (#28209) 1 year ago
Matt Jankowski 71e5a16eba
Remove triple subject call in `api/v1/lists` spec (#28210) 1 year ago
Matt Jankowski cca19f5fbb
Use the `Admin::ActionLog` fabricator in admin/action_logs spec (#28194) 1 year ago
Matt Jankowski b3b009e6aa
Add spec coverage for `CLI::EmailDomainBlocks` commands (#28181) 1 year ago
Matt Jankowski 9603198982
Add spec coverage for `CLI::Domains#purge` command (#28179) 1 year ago
Matt Jankowski 1bf2230fd1
Add spec coverage for `CLI::Upgrade#storage_schema` command (#28180) 1 year ago
Matt Jankowski 19ad51253d
Prevent triple-subject run in admin/domain_blocks spec (#28195) 1 year ago
Matt Jankowski d848d8d87c
Add helper methods for domains allow and export blocks files (#28196) 1 year ago
Matt Jankowski 5631f139c1
Fix `Lint/SymbolConversion` cop (#28175) 1 year ago
Matt Jankowski aa8563d43d
Fix `Style/SuperWithArgsParentheses` cop (#28174) 1 year ago
Matt Jankowski 1564799952
Add spec coverage for media CLI `refresh` command (#28166) 1 year ago
Matt Jankowski 7753e5f715
Add shared example for CLI command specs (#28165) 1 year ago
Matt Jankowski 92fa9b109f
Add spec coverage for media CLI usage command (#28167) 1 year ago
Matt Jankowski 440b80b2e7
Model concerns organization into module namespaces (#28149) 1 year ago
Matt Jankowski b751078fcd
Eliminate double subject call in admin/ controller specs (#28158) 1 year ago
Matt Jankowski 1f1c75bba5
File cleanup/organization in `controllers/concerns` (#27846) 1 year ago
Matt Jankowski 0530ce5e95
Convert accounts controller spec to request spec (#28126) 1 year ago
Matt Jankowski e7c340a634
Spec coverage for missing `q` param and error conditions in `api/v2/search` controller (#27842) 1 year ago
Claire 85662a5a57
Change `img-src` and `media-src` CSP directives to not include `https:` (#28025) 1 year ago
Matt Jankowski bb0efe16e6
Remove `default_scope` from `MediaAttachment` class (#28043) 1 year ago
Matt Jankowski ce78a9c9ac
Clean up `two_factor_authentication/confirmations` controller spec (#28128) 1 year ago
Filippo Giunchedi e6fd9a59e6
Fix FamiliarFollowersController test response comparison (#28121)
Co-authored-by: Filippo Giunchedi <filippo@debian.org>
1 year ago
Matt Jankowski e48ecd2929
Remove `default_scope` from `Admin::ActionLog` (#28026) 1 year ago
Matt Jankowski 291dc04e67
Remove un-needed `action` and `template` options to `render` in controllers (#28022) 1 year ago
Emelia Smith 603b245cc6
Add VAPID public key to instance serializer (#28006)
Co-authored-by: Renaud Chaput <renchap@gmail.com>
1 year ago
Matt Jankowski 6b46bf9953
Handle scenario when webfinger response `subject` is missing host value (#28088) 1 year ago
Matt Jankowski 19baf22683
Add missing email previews for `AdminMailer` (#28044) 1 year ago
Kevin Bongart 7877fcd83c
Deduplicate IDs in relationships and familiar_followers APIs (#27982) 1 year ago
Matt Jankowski 973597c6f1
Consolidate configuration of `Sidekiq::Testing.fake!` setup (#28046) 1 year ago
Matt Jankowski 9742bccbe7
Add coverage for `api/v2/media` endpoint (#28027) 1 year ago
Eugen Rochko cdc57c74b7
Fix unsupported time zone or locale preventing sign-up (#28035)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 67fd3187b3
Update rspec fixture path config to silence deprecation warning (#28018) 1 year ago
Matt Jankowski 30ee4aaff4
Convert measurement `api/v1/admin/*` controller specs to request specs (#28005) 1 year ago
Matt Jankowski 32e19e3af6
Reduce `.times` usage in request and controller specs (#27949) 1 year ago
Matt Jankowski f7cb64a184
Add coverage for `settings/privacy` controller (#28000) 1 year ago
Matt Jankowski b2e8af8889
Add coverage for `settings/verifications` controller (#28001) 1 year ago
Matt Jankowski 6d51ac246b
Update partials for the `AdminMailer.new_trends` mailer (#28011) 1 year ago
Matt Jankowski a6d446e6a7
Add coverage for `remote_interaction_helper` (#28002) 1 year ago
Matt Jankowski 876f5b1d12
Convert `/instances/*` controller specs to request specs (#27988)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 718c95e7af
Convert `api/v1/custom_emojis` controller spec to request spec (#27985)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Claire c260a68f54
Clean up some `Mastodon::CLI::Accounts` tests (#27473) 1 year ago
Matt Jankowski 17582d36d5
Convert `api/v1/preferences` controller spec to request spec (#27987) 1 year ago
Matt Jankowski 9a01a260a0
Convert `api/v1/scheduled_statuses` controller spec to request spec (#27986) 1 year ago
Matt Jankowski b9fb47aeb1
Convert `api/v1/endorsements` controller spec to request spec (#27984) 1 year ago
Matt Jankowski 371f355719
Reduce `.times` usage in `AccountStatusesCleanupPolicy` (#27947) 1 year ago
Matt Jankowski d2aacea8da
Reduce `.times` usage in AccountSearch spec, use constant for default limit (#27946) 1 year ago
Matt Jankowski 00c6ebd86f
Reduce `.times` usage in `StatusPin` and add `PIN_LIMIT` constant in validator (#27945) 1 year ago
Matt Jankowski 1fabf20a88
Reduce `.times` usage in `lib/mastodon/cli/accounts` spec (#27944) 1 year ago
Matt Jankowski 09a2db3f6c
Move api/v2/filters spec to correct path location (#27950) 1 year ago
Matt Jankowski e892efbc40
Configure elastic search integration with rspec tag (#27882) 1 year ago
Claire 297839c10c
Rewrite `/api/v1/statuses` tests as request specs (#27891) 1 year ago
Claire 9257737675
Rewrite `/api/v1/accounts` tests as request specs (#27888) 1 year ago
Matt Jankowski 549e8e7baf
Add `email_spec` and speedup/cleanup to `spec/mailers` (#27902) 1 year ago
Matt Jankowski 1526e54ac6
Add spec coverage for `workers/redownload_*` worker classes (#27892) 1 year ago
Matt Jankowski cb1a4a8713
Reduce expectations for `RSpec/MultipleExpectations` cop in `spec/presenters` specs (#27881) 1 year ago
Matt Jankowski 155fb84141
Improve spec coverage for collection of `workers/` classes (#27874) 1 year ago
Matt Jankowski 8a285413f7
Reduce expectations for `RSpec/MultipleExpectations` cop in `MoveWorker` spec (#27880) 1 year ago
Matt Jankowski 3f0c1566c3
Reduce expectations for `RSpec/MultipleExpectations` cop in `api/v1/accounts/relationships` spec (#27879) 1 year ago
Matt Jankowski c1f93def40
Reduce expectations for `RSpec/MultipleExpectations` cop in `controllers/statuses` spec (#27875) 1 year ago
Matt Jankowski 04121bd020
Disable simplecov `enable_coverage_for_eval` option, move to standalone file (#27869) 1 year ago
Matt Jankowski 3de9145613
Move controller specs for `well-known` endpoints to request specs (#27855) 1 year ago
Matt Jankowski 12a5b7391d
Add spec for well known change password endpoint (#27856) 1 year ago
Matt Jankowski fe58ac8d9f
Improve spec coverage for `api/web/push_subscriptions` controller (#27858)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 7c72944661
Use `Lcov` simplecov formatter on CI and `HTML` elsewhere (#27859) 1 year ago
Nick Schonning 36d7d1781f
Add CodeCov for Ruby coverage reports (#23868) 1 year ago
Matt Jankowski b2c5b20ef2
Fix `RSpec/AnyInstance` cop (#27810) 1 year ago
Matt Jankowski d562fb8459
Specs for minimal CSP policy in `Api::` controllers (#27845) 1 year ago
Matt Jankowski 5e2ecc736d
Remove double `subject` in api/v1/accounts/relationships spec (#27839) 1 year ago
Matt Jankowski b7807f3d84
Use `normalizes` to prepare `Webhook#events` value (#27605) 1 year ago
Matt Jankowski 49ba5a9f94
Use `hash_including` to check `AccountFilter` setup in `admin/accounts` controller spec (#27838) 1 year ago
Matt Jankowski a36b59be8a
Spec coverage for `api/v1/trends` controllers (#27837) 1 year ago
Claire 07a4059901
Add support for invite codes in the registration API (#27805) 1 year ago
Eugen Rochko 0d14fcebae
Change link previews to keep original URL from the status (#27312) 1 year ago
Matt Jankowski 9dc3ce878b
Speed-up in `Settings::` controllers specs (#27808) 1 year ago
Matt Jankowski e79bf1b1e7
Minor speed improvement on `controllers/accounts` spec (#27679) 1 year ago
Claire c451bbe249
Allow viewing and severing relationships with suspended accounts (#27667) 1 year ago
Matt Jankowski 548bb30b2a
Consolidate html page title output logic into helper (#27563) 1 year ago
Matt Jankowski 63c9102f8a
Fix `RSpec/MessageChain` cop (#27776) 1 year ago
Matt Jankowski c9204b792c
Fix `Rails/I18nLocaleTexts` cop (#27779) 1 year ago
Matt Jankowski 69d00e2721
Fix `RSpec/InstanceVariable` cop (#27766) 1 year ago
Matt Jankowski 4329616c53
Ignore block result of `send` method and remove `rubocop:disable` in deepl spec (#27741) 1 year ago
Matt Jankowski b05575e242
Move RSpec config for streaming/search managers to be near classes (#27761) 1 year ago
Matt Jankowski ce91d14d48
Fix `Style/WordArray` cop (#27770) 1 year ago
Matt Jankowski c03bd2a238
Don't stub SUT in `FollowLimitValidator` spec (#27760) 1 year ago
Matt Jankowski 9b7b4d748f
Simplify request cache spec shared examples (#27673) 1 year ago
Claire 23e32a4b30
Fix format-dependent redirects being cached regardless of requested format (#27632) 1 year ago
Matt Jankowski e545978076
Use framework helpers instead of i-vars in controller specs (#27767) 1 year ago
Matt Jankowski ee57bb4b44
Account statuses filter spec speedup (#27674) 1 year ago
Matt Jankowski ae7c20b00c
Move search and streaming spec manager classes to separate support files (#27727) 1 year ago
Matt Jankowski 370802ce48
Add coverage for `CLI::Maintenance#fix_duplicates` command (#25252) 1 year ago
Matt Jankowski 1d51e10510
Consolidate JSON parsing in serializers specs (#27693) 1 year ago
Matt Jankowski a688a9ed20
Use strings instead of numeric literals and remove `rubocop:disable` in cache spec (#27742) 1 year ago
Matt Jankowski dc0bf87090
Remove unused before block from settings/branding spec (#27759) 1 year ago
Matt Jankowski 45770c9306
Fix `Performance/MapMethodChain` cop (#27744) 1 year ago
Matt Jankowski 49e2772064
Fix `RSpec/MessageSpies` cop (#27751) 1 year ago
Matt Jankowski 2862ad701f
Stub controller methods and remove `rubocop:disable` in captcha feature spec (#27743) 1 year ago
Matt Jankowski cfa14ec6d1
Fix `Lint/EmptyBlock` cop (#27748) 1 year ago
Matt Jankowski b06284c572
Fix `RSpec/HookArgument` cop (#27747) 1 year ago
Matt Jankowski d6f50839e1
Fix `RSpec/SpecFilePathFormat` cops (#27730) 1 year ago
Matt Jankowski fe26f33e0a
Fix `Rails/RedundantActiveRecordAllMethod` cop (#26885) 1 year ago