mastodon

Commit Graph

Author	SHA1	Message	Date
Eugen Rochko	23aeef52cc	Remove Salmon and PubSubHubbub (#11205 ) * Remove Salmon and PubSubHubbub endpoints * Add error when trying to follow OStatus accounts * Fix new accounts not being created in ResolveAccountService	6 years ago
Akihiko Odaki	40e5d2303b	Validate HTTP response length while receiving (#6891 ) to_s method of HTTP::Response keeps blocking while it receives the whole content, no matter how it is big. This means it may waste time to receive unacceptably large files. It may also consume memory and disk in the process. This solves the inefficency by checking response length while receiving.	7 years ago
Akihiko Odaki	54b273bf99	Close http connection in perform method of Request class (#6889 ) HTTP connections must be explicitly closed in many cases, and letting perform method close connections makes its callers less redundant and prevent them from forgetting to close connections.	7 years ago
ThibG	10f6793fd0	Fix PuSH workers (#6200 )	7 years ago
abcang	2eab41cd1a	Close connection when succeeded posting (#5390 ) * Close connection when succeeded posting * Update webmock	7 years ago
abcang	3d9b8847d2	Flush body when POST requests (#5128 )	7 years ago
Eugen Rochko	e528114c53	Follow-up to #4582 and #5027 , removing dead code (#5101 )	7 years ago
Daigo 3 Dango	a0bbeafb04	Suppress backtrace when failed to communicate with a remote instance (#5076 )	7 years ago
abcang	1aad015bbb	Revert unique retry job (#4937 ) * Revert "Enable UniqueRetryJobMiddleware even when called from sidekiq worker (#4836)" This reverts commit `6859d4c028`. * Revert "Do not execute the job with the same arguments as the retry job (#4814)" This reverts commit `be7ffa2d75`.	8 years ago
Eugen Rochko	e7adbf572a	Switch to static URIs, new URI format in both protocols for new statuses (#4815 ) * Decouple Status#local? from uri being nil * Replace on-the-fly URI generation with stored URIs - Generate URI in after_save hook for local statuses - Use static value in TagManager when available, fallback to tag format - Make TagManager use ActivityPub::TagManager to understand new format - Adjust tests * Use other heuristic for locality of old statuses, do not perform long query * Exclude tombstone stream entries from Atom feed * Prevent nil statuses from landing in Pubsubhubbub::DistributionWorker * Fix URI not being saved (#4818) * Add more specs for Status * Save generated uri immediately and also fix method order to minimize diff. * Fix alternate HTML URL in Atom * Fix tests * Remove not-null constraint from statuses migration to speed it up	8 years ago
abcang	be7ffa2d75	Do not execute the job with the same arguments as the retry job (#4814 )	8 years ago
Eugen Rochko	4c76402ba1	Serialize ActivityPub alternate link into OStatus deletes, handle it (#4730 ) Requires moving Atom rendering from DistributionWorker (where `stream_entry.status` is already nil) to inline (where `stream_entry.status.destroyed?` is true) and distributing that. Unfortunately, such XML renderings can no longer be easily chained together into one payload of n items.	8 years ago
Eugen Rochko	cf615abbf9	Add configuration to disable private status federation over PuSH (#4582 )	8 years ago
Eugen Rochko	6e9eda5331	ActivityPub migration procedure (#4617 ) * ActivityPub migration procedure Once one account is detected as going from OStatus to ActivityPub, invalidate WebFinger cache for other accounts from the same domain * Unsubscribe from PuSH updates once we receive an ActivityPub payload * Re-subscribe to PuSH unless already unsubscribed, regardless of protocol	8 years ago
Yamagishi Kazutoshi	3e7a541e09	Change RuboCop rules to loose (#4464 )	8 years ago
Eugen Rochko	6e186b9c77	When PuSH subscribe attempts are exhausted, unsubscribe (#4422 )	8 years ago
Clworld	994d948c39	Add callback_url/acct information for Sidekiq PuSH workers Exception. (#4281 ) * Add destination informations to exception on SubscribeWorker and DeliveryWorker. * Simplify delivery error message. * Prevent changing Exception type... * fix typo.	8 years ago
Eugen Rochko	1fcdaafa6f	Fix webfinger retries (#4275 ) * Do not raise unretryable exceptions in ResolveRemoteAccountService * Removed fatal exceptions from ResolveRemoteAccountService Exceptions that cannot be retried should not be raised. New exception class for those that can be retried (Mastodon::UnexpectedResponseError)	8 years ago
Eugen Rochko	a5a07da892	Correct OStatus inflection (Ostatus -> OStatus) (#4255 )	8 years ago
Akihiko Odaki	89b988cab5	Introduce Ostatus name space (#4164 ) * Wrap methods of ProcessFeedService::ProcessEntry in classes This is a change same with `425acecfdb`, except that it has the following changes: * Revert irrelevant change in find_or_create_conversation * Fix error handling for RemoteActivity * Introduce Ostatus name space	8 years ago
ThibG	05cd37097c	Optimize uri normalization (#4212 ) * Add dependency on idn-ruby to speed up URI normalization * Use normalized_host instead of normalize.host when applicable When we are only interested in the normalized host, calling normalized_host avoids normalizing the other components of the URI as well as creating a new object	8 years ago
Eugen Rochko	cd9b2ab2f7	Fix #2672 - Connect signed PuSH subscription requests to instance domain (#4205 ) * Fix #2672 - Connect signed PuSH subscription requests to instance domain Resolves #2739 * Fix return of locate_subscription * Fix tests	8 years ago
Eugen Rochko	1618b68bfa	HTTP signatures (#4146 ) * Add Request class with HTTP signature generator Spec: https://tools.ietf.org/html/draft-cavage-http-signatures-06 * Add HTTP signature verification concern * Add test for SignatureVerification concern * Add basic test for Request class * Make PuSH subscribe/unsubscribe requests use new Request class Accidentally fix lease_seconds not being set and sent properly, and change the new minimum subscription duration to 1 day * Make all PuSH workers use new Request class * Make Salmon sender use new Request class * Make FetchLinkService use new Request class * Make FetchAtomService use the new Request class * Make Remotable use the new Request class * Make ResolveRemoteAccountService use the new Request class * Add more tests * Allow +-30 seconds window for signed request to remain valid * Disable time window validation for signed requests, restore 7 days as PuSH subscription duration (which was previous default due to a bug)	8 years ago
Eugen Rochko	34ccc058fa	Limit total subscribe retries to 10, but space them out more (#4142 ) Since there is little point in retrying so often when a service is down or does not exist anymore. Subscriptions are renewed 1 day before they should expire, so retrying in 30 minutes, then 2 hours, then 12 hours is fine. If even after that, the remote server does not work, there is little sense in retrying more often than once a day Also, uniqueness of the job should ensure that failed retries will not result in multiple retries for the same endpoint when the next resubscription cycle comes	8 years ago
Akihiko Odaki (@fn_aki@pawoo.net)	e27f792c24	Some minor change and spec for Account (#3813 ) * Introduce domains method to Account relation Account had followers_domains method, which was excessively specific. Let relation of Account have domains method instead. * Move follow_mapping in Account to AccountInteractions * Introduce shared examples for AccountAvatar inclusion * Cover Account more	8 years ago
Eugen Rochko	e17c2e5da5	Batched remove status service (#3735 ) * Make Pubsubhubbub::DistributionWorker handle both single stream entry arguments, as well as arrays of stream entries * Add BatchedRemoveStatusService, make SuspendAccountService use it * Improve method names * Add test * Add more tests * Use PuSH payloads of 100 to have a clear mapping of 1000 input statuses -> 10 PuSH payloads It was nice while it lasted	8 years ago
Eugen Rochko	657496b5a9	Do not cancel PuSH subscriptions after encountering "permanent" error… (#3046 ) * Do not cancel PuSH subscriptions after encountering "permanent" error response After talking with MMN about it, turns out some servers/php setups do return 4xx errors while rebooting, so this anti-feature that was meant to take load off of the hub is doing more harm than good in terms of breaking subscriptions * Update delivery_worker.rb	8 years ago
Matt Jankowski	0d70fe2659	Spec coverage and refactor for pubsub/delivery worker (#3021 ) * Framework for delivery worker spec * Refactor of pubsub delivery worker	8 years ago
Matt Jankowski	08949cca41	Pubsub confirmation worker spec (#2974 ) * Add specs for valid challenge response from pubsub confirmation worker * Refactor the pubsub confirmation worker	8 years ago
Eugen Rochko	3a38322a54	Add spec for Pubsubhubbub::DistributionWorker. PuSH-deliver public items (#2954 ) to all subscribers. IDN-normalize callback URLs for subscriptions on insert.	8 years ago
haoyayoi	2fba94b36e	add content-type in pubsubhubhub request header (#2943 ) * add content-type in pubsubhubhub request header * fix type	8 years ago
Eugen Rochko	b8e166894b	Fix Scheduler::SubscriptionsScheduler (#2834 ) * Fix Scheduler::SubscriptionsScheduler, add worker test for it * Change production log level of Sidekiq to "warn" instead of "info"	8 years ago
Eugen Rochko	81584779cb	More robust PuSH subscription refreshes (#2799 ) * Fix #2473 - Use sidekiq scheduler to refresh PuSH subscriptions instead of cron Fix an issue where / in domain would raise exception in TagManager#normalize_domain PuSH subscriptions refresh done in a round-robin way to avoid hammering a single server's hub in sequence. Correct handling of failures/retries through Sidekiq (see also #2613). Optimize Account#with_followers scope. Also, since subscriptions are now delegated to Sidekiq jobs, an uncaught exception will not stop the entire refreshing operation halfway through Fix #2702 - Correct user agent header on outgoing http requests * Add test for SubscribeService * Extract #expiring_accounts into method * Make mastodon:push:refresh no-op * Queues are now defined in sidekiq.yml * Queues are now in sidekiq.yml	8 years ago
Eugen	17c591ffba	Punycode URI normalization (#2370 ) * Fix #2119 - Whenever about to send a HTTP request, normalize the URI * Add test for IDN request in FetchLinkCardService * Perform IDN normalization on domains before they are stored in the DB	8 years ago
Eugen	501514960a	Followers-only post federation (#2111 ) * Make private toots get PuSHed to subscription URLs that belong to domains where you have approved followers * Authorized followers controller, stub for bulk action * Soft block in the background * Add simple test for new controller * Rename Settings::FollowersController to Settings::FollowerDomainsController, paginate results, rename "private" post setting to "followers-only", fix pagination style, improve post privacy preferences style, improve warning style * Extract compose form warnings into own container, show warning when posting to followers-only with unlocked account	8 years ago
Matt Jankowski	c44a700252	Quick best practice cleanup of views/helpers (#1546 ) * Remove trailing whitespace * Use query methods instead of explicit .blank? checks	8 years ago
Eugen	6d6a429af8	Rewrite Atom generation from stream entries to use Ox instead of Nokogiri (#1124 ) * Rewrite Atom generation from stream entries to use Ox instead of Nokogiri::Builder StreamEntry is now limited to only statuses, which allows some optimization. Removed extra queries on AccountsController#show. AtomSerializer instead of AtomBuilderHelper used in AccountsController#show, StreamEntriesController#show, StreamEntryRenderer and PubSubHubbub::DistributionWorker PubSubHubbub::DistributionWorker moves n+1 DomainBlock query to PubSubHubbub::DeliveryWorker instead. All Salmon slaps that aren't based on StreamEntry still use AtomBuilderHelper and Nokogiri * All Salmon slaps now use Ox instead of Nokogiri. No touch from status on account	8 years ago
Eugen Rochko	bda37489ac	Remove PuSH subscriptions when delivery is answered with a 4xx error	8 years ago
Eugen Rochko	40a4053732	Disable PuSH for blocked domains	8 years ago
Eugen Rochko	db814543c0	Take out private toot distribution out of PuSH again	8 years ago
Eugen Rochko	446aad4ce2	Make PuSH only distribute to subscriptions that match follower domains Allow PuSH to distribute private toots with that condition	8 years ago
Eugen Rochko	6c28886317	Improve background jobs params and error handling	8 years ago
Eugen Rochko	86be6d48c9	Fix accidental distribution of hidden stream entries to PuSH subscribers	8 years ago
Eugen Rochko	4c6809f6ab	Adding some rescues to workers, e.g. don't fail removal job when status can't be found in the first place (already removed)	8 years ago
Eugen Rochko	668013265c	Restoring old async behaviour of thread resolving as it proved to be more robust	8 years ago
Eugen Rochko	4a2347da41	Track successful PuSH deliveries	8 years ago
Eugen Rochko	cc70f28f19	Adding rack timeout of 30sec, PuSH jobs moved to push queue so they can be processed separately	8 years ago
Eugen Rochko	4e351baf88	Fix URLs in inline-rendered XML	8 years ago
Eugen Rochko	3ba6531611	Fix setting of confirmed=true on successful confirmation	8 years ago
Eugen Rochko	50638174c8	More logging to ConfirmationWorker	8 years ago

1 2

51 Commits (85eb418e1f9ae40ce5fbdc837a354444eec94655)