mastodon

Commit Graph

Author	SHA1	Message	Date
Joël Quenneville	27301312a6	Add tests to the Feed model (#2594 ) This adds a test for the `Feed#get` method. While the data transformations in `Feed#get` may seem redundant, they are important to maintain the order from Redis. The tests I wrote will fail if someone tries to refactor away this "redundancy" (as I tried to do in the first iteration of this change).	8 years ago
Patrick Figel	8ac7fca5d0	Set correct attachment type for rejected media (#2599 ) In #2110, a new attachment type "unknown" was introduced for attachments that were rejected due to a domain being blocked using reject_media. However, the "type" field was never set to "unknown" because a default value of "0" (image) is set for that column, causing the `type.blank?` expression to always equal false. This version uses type_changed? instead, causing the type to be set to "unknown" unless a type has been explicitly set. This introduces a small change in behaviour causing the type to be set to unknown before paperclip calls `before_post_process`. Presumably this behaviour is more appropriate than the current one because the attachment type has not been determined by that point. Included are new tests for `ProcessFeedService` and `UpdateRemoteProfileService` which now check that remote media is downloaded for non-blocked domains and is rejected for others.	8 years ago
Matt Jankowski	a823509b99	Fix broken view spec for about/links (#2591 )	8 years ago
Matt Jankowski	9262f6968b	Fix broken spec for about/links view partial (#2586 )	8 years ago
Yamagishi Kazutoshi	71e73e36cd	Fix spec for hide get started (#2585 )	8 years ago
Matt Jankowski	9566893cc9	More controller specs (#2561 ) * Add render_views in more places * Delegate methods from account to user with allow nil true, so that admin accounts show view renders when missing a user * Use actual account instances in authorize follow controller spec	8 years ago
Matt Jankowski	429480bb77	Return missing page when tag does not exist (#2563 )	8 years ago
Matt Jankowski	effb08edbb	More status specs (#2564 ) * Add rough outline of coverage needed for public timeline * Specs for visibility, replies, boosts * Specs for silenced account * Specs for local_only option * Specs for blocks and mutes * Add tentative spec around including other silenced account statuses * Add with_public_visibility scope * Add simple coverage for tag_timeline * Tag timeline includes replies * Replace tag.statuses with a tagged_with scope in tag timeline method * Use with_public_visibility in tag timeline * Extract common scope between public and tag timelines to method * Extract local domain check to local_only scope * Extract local_only check to starting scope method * Move list of excluded from timeline account ids to account model * Simplify excluded accounts list on account model * Only join accounts when needed * Rename method for account specific filtering * Extract method for account exclusions * Fix bug where silenced accounts were not including statuses from other silenced accounts * DRY up filter application from account or no account * timeline_scope can be private * Add spec showing that account can find its excluded accounts ids * Add spec which fails if local_only does not have a left outer join * rubocop	8 years ago
Matt Jankowski	a39e719b39	Add render_views to admin/reports controller spec (#2548 )	8 years ago
Matt Jankowski	9736753985	Fix remote follow (#2547 ) * Add coverage for remote_follow#new * Fix reference to authorize_follows/card partial	8 years ago
Eugen Rochko	2af4f3c4e2	Improve shared status verification (#2525 ) * Instead of parsing shared status contents verbatim, make roundtrip to purported original URL. Confirm that the "original" URL is from the same domain as the author it claims to be from. * Fix obvious typo, add comment * Use URI look-up first * Add test, update Goldfinger dependency to make less useless HTTP requests per Webfinger lookup	8 years ago
Matt Jankowski	b48f2cbc8b	Catch error when server decryption fails on 2FA (#2512 )	8 years ago
Eugen Rochko	88725d6ce8	OEmbed support for PreviewCard (#2337 ) * OEmbed support for PreviewCard * Improve ProviderDiscovery code failure treatment * Do not crawl links if there is a content warning, since those don't display a link card anyway * Reset db schema * Fresh migrate * Fix rubocop style issues Fix #1681 - return existing access token when applicable instead of creating new * Fix test * Extract http client to helper * Improve oembed controller	8 years ago
Matt Jankowski	0618f09939	Add spec coverage and refactor authorize_follows controller (#2505 )	8 years ago
Matt Jankowski	8857cabca4	Domain block service cleanup (#2490 ) * Add coverage for domain block service with silence * Get rid of warning about find_each and order * Move domain_block to attr_reader * Move optional clear_media into silence_accounts method * Use blocked_domain method to reduce passed vars * Extract blocked_domain_accounts method to find accounts on the domain * Extract media_from_blocked_domain method to find relevant attachments * Separate destruction of account images and account attachments	8 years ago
Matt Jankowski	affd75936e	Add spec for Status.as_home_timeline (#2451 )	8 years ago
Francis Chong	193dddb433	Add media dimensions (#2448 ) * Fixes #1985 - add migration AddMediaAttachmentMeta, which add meta field to media_attachments - before saving attachment, set file meta if needed - add meta in api * add spec * align the “size” format for image and video * fix code climate * fixes media_attachment_spec.rb	8 years ago
Guillaume Lo Re	7177e37b99	Stricter whitelist rules (#2213 ) * Stricter whitelist rules * Linting * Added spec for blacklisting * Test subdomain blacklist on domain whitelist * No need to split * Change spec name	8 years ago
alpaca-tc	9317ec8eb1	Localize with i18n for Devise::FailureApp (#2309 ) This PR fixes I18n.locale for rake middlewares. Mastodon uses Devise that depends on Warden. Warden::Manager can be found in rake middleware. It is outside of the controller. In the case of authentication failed, warden calls throw(:warden). At the time Warden::Manager delegates request to failure_app to generate response and flash[:alert] after catching it. Unfortunately, I18n.locale is already reset then because I18n.with_locale is enabled only inside the controller. If we used I18n.locale=, Devise::FailureApp could get the current locale.	8 years ago
Evan Minto	122d59ac41	Change ActivityPub paging to match spec. Clean up ActivityPub outbox changes. (#2410 ) * Change ActivityPub paging to match spec. Clean up ActivityPub outbox changes. * Fix code style and test failures for OutboxController. * Attempt to fix CI errors.	8 years ago
Eugen Rochko	8b5179d006	Fix #2402 - Add Idempotency-Key header to PostStatusService that prevents (#2419 ) duplicates. Web UI regenerates UUID for that header every time the compose form is changed or successfully submitted Also, fix Farsi i18n overwriting the English one	8 years ago
Yamagishi Kazutoshi	3ea5b948a4	Decodes URL containing IDN (#2436 )	8 years ago
178inaba	d2159deaf2	Optimize account search (#2421 )	8 years ago
Eugen	17c591ffba	Punycode URI normalization (#2370 ) * Fix #2119 - Whenever about to send a HTTP request, normalize the URI * Add test for IDN request in FetchLinkCardService * Perform IDN normalization on domains before they are stored in the DB	8 years ago
Eugen	338df98ddf	Add more FeedManager#filter? tests (#2413 )	8 years ago
Matt Jankowski	092fdc89fa	Fix flashes partial render error for controllers which don't inherit from application controller (#2400 ) * Add failing spec for oauth/authorized_applications controller * Use explicit reference to flashes partial from admin layout Because some of the controllers which use the admin layout do not inherit from application controller, this partial is not in their view path.	8 years ago
Eugen	501514960a	Followers-only post federation (#2111 ) * Make private toots get PuSHed to subscription URLs that belong to domains where you have approved followers * Authorized followers controller, stub for bulk action * Soft block in the background * Add simple test for new controller * Rename Settings::FollowersController to Settings::FollowerDomainsController, paginate results, rename "private" post setting to "followers-only", fix pagination style, improve post privacy preferences style, improve warning style * Extract compose form warnings into own container, show warning when posting to followers-only with unlocked account	8 years ago
Matt Jankowski	948dd26931	Fix deprecation warnings on activitypub controller specs (#2357 )	8 years ago
Matt Jankowski	55e1e12b7d	Ensure i18n matches options (#2358 ) * Add failing spec showing that human_locales does not match what i18n knows about * Add missing `ar` key for arabic to human locales * Remove duplicate `id` key from available locales * Sort keys in human locales list * Add spec for human_locale helper	8 years ago
Joël Quenneville	1cf9e14a41	Test embedded_view related code in a helper (#2282 ) The two methods `StreamEntriesHelper#stream_link_target` and `StreamEntriesHelper#acct` are based on checking whether we are running in an embedded view. This adds some test helper code to make the testing easier. We extracted some "magic strings" to constants to lower the coupling in the specs.	8 years ago
Joël Quenneville	0c2fe22bc1	Add test coverage to CSS class generation (#2285 ) The code that generates CSS is based on a lot of boolean conditions. The possible combinations of these grows exponentially as we add more conditions. Since most of the code is conditional on a single boolean, we tested the following: 1. All `false` 2. All `true` 3. Each individual flag set to `true` The methods tested are: * `StreamEntriesHelper#style_classes` * `StreamEntriesHelper#microformats_classes` * `StreamEntriesHelper#microformats_h_class`	8 years ago
Evan Minto	66fd8e7821	ActivityPub: Add basic, read-only support for Outboxes, Notes, and Create/Announce Activities (#2197 ) * Clean up collapsible components * Expose user Outboxes and AS2 representations of statuses * Save work thus far. * Fix bad merge. * Save my work * Clean up pagination. * First test working. * Add tests. * Add Forbidden error template. * Revert yarn.lock changes. * Fix code style deviations and use localized instead of hardcoded English text.	8 years ago
Ash Furrow	723f25a999	Admin UI for confirming users (#2245 ) * Shows confirmed status in list. * Adds ability to confirm users in admin UI. * Added new english translations. * Addresses feedback from #2245. * More feedback.	8 years ago
Wesley Ellis	a1174a6d7e	Add og:url tags (#2298 ) * add og:url to stream_item view * add og:url and text to about/show * add og:url to profile, followers and follows pages	8 years ago
Matt Jankowski	629d35e6f5	[WIP] Html lang on statuses (#2297 ) * Add html lang attributes around statuses * Remove urls from language detection	8 years ago
Matt Jankowski	67dea31b0f	2FA controller cleanup (#2296 ) * Add spec coverage for settings/two_factor_auth area * extract setup method for qr code * Move otp required check to before action * Merge method only used once * Remove duplicate view * Consolidate creation of @codes for backup * Move settings/2fq#recovery_codes to settings/recovery_codes#create * Rename settings/two_factor_auth#disable to #destroy * Add coverage for the otp required path on 2fa#show * Clean up the recovery codes list styles * Move settings/two_factor_auth to settings/two_factor_authentication * Reorganize the settings two factor auth area Updated to use a flow like: - settings/two_factor_authentication goes to a #show view which has a button either enable or disable 2fa on the account - the disable button turns off the otp requirement for the user - the enable button cycles the user secret and redirects to a confirmation page - the confirmation page is a #new view which shows the QR code for user - that page posts to #create which verifies the code, and creates the recovery codes - that create action shares a view with a recovery codes controller which can be used separately to reset codes if needed	8 years ago
Joël Quenneville	974ac467de	Add tests for StreamEntriesHelper#rtl? (#2286 ) We used some random Arabic characters to test that the various RTL conditions got triggered.	8 years ago
Matt Jankowski	ee0c897bba	User settings mutation (#2270 ) * Add user spec for settings, highlight global default mutation issue * Fix mutation issue caused by settings/preferences spec	8 years ago
Matt Jankowski	2dda356e3f	Clean up settings/preferences controller (#2237 ) * Add missing fields group on preferences page * Clean up settings/preferences controller * Extract a UserSettingsDecorator	8 years ago
Matt Jankowski	1ada494bb2	Admin settings controller refactor, add specs, cleanup (#2225 ) * Add render_views for admin/settings spec * Add coverage for admin/settings#update * Add coverage for admin/settings typecasting open_registrations setting * Simplify how admin/settings finds the value for updating * Rely on activerecord to not update a value that hasnt changed * Add coverage for non-existent setting * Use a constant for boolean settings	8 years ago
Marcin Cieślak	59a77923b3	Add static gif for upload testing (#2168 )	8 years ago
Eugen	2e4afccd9d	Fix #2108 - Fix gif uploads (#2171 ) * Fix #2108 - Fix gif uploads Add specs for media attachment gifv conversion * Add ffmpeg to travis * Make travis install ffmpeg, not libav * Switch travis to trusty	8 years ago
Eugen	1d47910d3b	Fix possibility of unrightful webfinger redirect (#2147 ) * Fix possibility of unrightful webfinger redirect * Add more tests for FollowRemoteAccountService	8 years ago
abcang	70891a99a9	Fix html escape characters in the URL (#2138 ) * fix character escaping in URL * add tests * put a comma after the last item * add HTML escape test	8 years ago
Matt Jankowski	8bac0350d1	Restful refactor of accounts/ routes (#2133 ) * Add routing specs for accounts followers and following actions * Use more restful route naming for public account follow pages Moves two actions: - accounts#followers to accounts/follower_accounts#index - accounts#following to accounts/following_accounts#index Adds routing spec to ensure prior URLs are preserved.	8 years ago
Eugen	96268e76e6	Fix wording on admin instances view, fix typos in language detector spec (#2106 )	8 years ago
Eugen	6bd1019235	Add more tests for AtomSerializer (#2096 )	8 years ago
Matt Jankowski	297c11dba2	Language detection refactor (#2099 ) * Extract detect_language to separate class * Use default locale, not just en * Add spec to confirm that whatlanguage cant identify empty string * Allow account locale to override default in language detector * PostStatusService supplies an account to detect language	8 years ago
happycoloredbanana	0a7588282a	Remove API authentication for public statuses (after review) (#1919 )	8 years ago
Matt Jankowski	55e1503522	Instances list in admin (#2095 ) * Add admin/instances index action * Add link to instances admin page * View lists instances * Instances, grouped by domain, ordered by count * Use Account.remote scope * Extract method: Account.by_domain_accounts	8 years ago

1 2 3 4 5 ...

269 Commits (7d36a76180ce6bb207c6755bdffeba0b4edb6824)