Commit Graph

254 Commits (7c7dfe7de33c27b65805960061bd5d0a42733722)

Author SHA1 Message Date
Matt Jankowski 4c5aa0e470
Update rubocop-rspec to version 2.22.0, fix `RSpec/IndexedLet` cop ()
Matt Jankowski 31d5bc89d1
Speed improvement for `AccountsStatusesCleanupScheduler` spec ()
Nick Schonning 72590e601a
Update Rubocop 1.52.1 ()
Matt Jankowski 62c996b52d
Reduce `RSpec/MultipleExpectations` cop max to 8 ()
Matt Jankowski b85c387c5c
Remove reference to deleted statsd config file ()
Matt Jankowski 6c0e3f490a
Fix RSpec/MissingExampleGroupArgument cop ()
Nick Schonning c66250abf1
Autofix Rubocop Regex Style rules ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski c42591356d
Fix `RSpec/DescribedClass` cop ()
Renaud Chaput b7d995cb00
Disable some metrics cops ()
Matt Jankowski 1baf40077b
Fix FormatStringToken cop in CLI ()
Matt Jankowski 80c7de9984
Fix Rails/WhereExists cop in CLI ()
Matt Jankowski 0f2c16ac4b
Fix RSpec/NoExpectationExample cop ()
Matt Jankowski d2e5430d4a
Fix RSpec/ExpectChange cop ()
Matt Jankowski b896b16cb3
Fix RSpec/PredicateMatcher cop ()
Matt Jankowski 778e4a7bf7
Fix RSpec/ExpectInHook cop ()
Matt Jankowski b6b4ea4ca5
Move the mastodon/*_cli files to mastodon/cli/* ()
Matt Jankowski 541f64b2bb
Fix Rails/Exit cop ()
Matt Jankowski e387175fc9
Fix RSpec/RepeatedExample cop ()
Matt Jankowski 9f5deb310b
Fix Performance/MapCompact cop ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski 0664704cd9
Fix Performance/StartWith cop ()
Matt Jankowski 325d5f0183
Regenerate rubocop-todo ()
Nick Schonning c0b9664a31
Autofix Rubocop spacing in config ()
Nick Schonning cee4369cf5
Autofix Rubocop Lint/AmbiguousOperatorPrecedence ()
Matt Jankowski 2c2d924942
Fix RSpec/RepeatedExampleGroupDescription cop ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski bf3ebeb42f
Fix RSpec/SharedContext cop ()
Matt Jankowski a610a02d4f
Fix RSpec/ScatteredSetup cop ()
Matt Jankowski 0b249ebdb0
Extract StatusSafeReblogInsert concern from Status ()
Nick Schonning 569b39256b
Bump rubocop-rails 2.19.1 with update .rubocop_todo.yml ()
Nick Schonning e1ebcc007d
Regenerate rubocop-todo ()
Nick Schonning ff3b7069cf
Autofix Rubocop Style/ConcatArrayLiterals ()
Nick Schonning da3bd913ae
Autofix Rubocop Style/HashSyntax ()
Nick Schonning d5a185d721
Autofix Rubocop Style/CaseLikeIf ()
Nick Schonning 1fe04f740a
Enable Rubocop Rails/FilePath ()
Matt Jankowski c97b611b6b
Fix RSpec/InferredSpecType cop ()
Matt Jankowski 710745e16b
Fix RSpec/ContextWording cop ()
Matt Jankowski cf18cc2891
Fix RSpec/MultipleSubjects cop ()
Matt Jankowski 2c6c398c60
Fix Performance/CollectionLiteralInLoop cop ()
Matt Jankowski d9a958fcf7
Fix Performance/RedundantMerge cop ()
Matt Jankowski 3df665fd23
Fix Lint/ConstantDefinitionInBlock cop ()
Matt Jankowski a0c9f2447e
Fix Performance/MethodObjectAsBlock cop ()
Matt Jankowski 97385f27bd
Fix Performance/RedundantEqualityComparisonBlock cop ()
Matt Jankowski 668a19a2f3
Fix Performance/DeletePrefix cop ()
Matt Jankowski 05e3abe9d9
Fix Lint/EmptyClass cop ()
Matt Jankowski 24491abf6d
Fix Rails/DeprecatedActiveModelErrorsMethods cop ()
Matt Jankowski b5c4b47746
Fix Rails/ActiveRecordCallbacksOrder cop ()
Matt Jankowski 38b2974a83
Extract AccountSearch concern from Account ()
Matt Jankowski f1c1dd0118
Rename `with_lock` to `with_redis_lock` to avoid confusion with ActiveRecord's method ()
Matt Jankowski 570079f8ce
Fix Performance/TimesMap cop ()
Matt Jankowski bae694108a
Fix Performance/Count cop ()
Matt Jankowski 5e060e1f44
Fix Performance/Sum cop ()
Matt Jankowski 88d33f361f
Fix Lint/DuplicateBranch cop ()
Claire 32a030dd74
Rewrite import feature ()
Matt Jankowski c53fe9b753
Fix RSpec/BeforeAfterAll cop ()
Matt Jankowski d902a707a3
Fix Rails/CompactBlank cop ()
Matt Jankowski d00e45a7d3
Fix Rails/I18nLocaleAssignment cop ()
Matt Jankowski af824db398
Fix Rails/InverseOf cop ()
Matt Jankowski 2e43461100
Fix Rails/Output cop ()
Matt Jankowski 5a2aa06a51
Fix Rails/Present cop ()
Matt Jankowski bdc74086e6
Fix Rails/ContentTag cop ()
Matt Jankowski 6e226f5a32
Fix Rails/ActionOrder cop ()
Matt Jankowski 60ac9e8634
Fix Rails/SquishedSQLHeredocs cop ()
Matt Jankowski 8dcfb6e0ea
Fix Rails/HttpPositionalArguments cop ()
Matt Jankowski 4cfe52635c
Add pending spec for User.those_who_can ()
Nick Schonning 49fad26eca
Drop EOL Ruby 2.7 ()
Nick Schonning 5841f1af8c
Autofix Rubocop RSpec/MatchArray ()
Nick Schonning a3393d0d07
Autofix Rubocop RSpec/MatchArray ()
Nick Schonning 90beba57d8
Autofix Rubocop Rails/ResponseParsedBody ()
Matt Jankowski 0a5f0a8b20
Remove instance variables from helper usage ()
Nick Schonning 4687967176
Autofix Rubocop Style/NumericLiterals ()
Eugen Rochko e98c86050a
Refactor `Cache-Control` and `Vary` definitions ()
Nick Schonning cb2ce842b0
Autofix Rubocop Rails/IgnoredColumnsAssignment ()
Nick Schonning 500d6f93be
Autofix Rubocop Style/IdenticalConditionalBranches ()
Nick Schonning 83fc97285b
Enable Rubocop Metrics/BlockLength with Excludes ()
Eugen Rochko a9b5598c97
Change user settings to be stored in a more optimal way ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Nick Schonning 503022d6f9
Exclude files for Rubocop Metrics/ClassLength ()
Matt Jankowski 7bef11630d
Remove references to non-existent actions ()
Vyr Cossont 94cbd808b5
Webhooks for local status.create, status.update, account.update ()
Nick Schonning b22b4bac03
Include config/ and update all rubcop deps ()
Nick Schonning 681dcd3fa3
Ignore additional Style/OptionalBooleanParameter ()
Matt Jankowski edc7ca5920
Roll back unintentionally activated rubocop rules ()
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Christian Schmidt bd047acc35
Replace `Status#translatable?` with language matrix in separate endpoint ()
Nick Schonning aa947a143b
Regen rubocop-todo without Max shadowing ()
Nick Schonning 25d36b6edd
Autofix Rubocop Style/RedundantArgument ()
Nick Schonning a38f67c1c3
Autofix Rubocop Style/PreferredHashMethods ()
Nick Schonning e762a14c0a
Enable Rubocop Performance/DeleteSuffix ()
Nick Schonning 3ea0856f70
Enable RSpec/FilePath ()
Matt Jankowski 688287c59d
Coverage improvement round-out following up previous work ()
Matt Jankowski 56bddfbfa3
Serializers spec coverage ()
Claire aa98c8fbeb
Disable Style/SymbolArray ()
Nick Schonning 56489cdc4f
Autofix Rubocop Style/HashConversion ()
Matt Jankowski 730bb3e211
Remove unused HTML Validator ()
Nick Schonning 19614ba247
Rename ActivityPub Serializer Specs ()
Nick Schonning 6bd7003799
Fix mispelled spec filenames ()
Nick Schonning 4ff44be134
Autofix Rubocop Rails/Blank ()
Nick Schonning 8fd3fc404d
Autofix Rubocop Rails/RootPathnameMethods ()
Nick Schonning 0cfdd1a401
Enable Rubocop Style/StringConcatenation defaults ()
Nick Schonning 434770f580
Autofix Rubocop Rails/FindById ()
Nick Schonning 35d032500b
Autofix Rubocop Security/IoMethods ()
Nick Schonning 9909b4b653
Autofix Rubocop Rails/WhereEquals ()
Nick Schonning 59c8d43d94
Autofix Rubocop Style/RescueStandardError ()
Nick Schonning 2c3c734bcc
Autofix Rubocop Style/SymbolProc ()
Nick Schonning af4c95100c
Autofix Rubocop Style/FormatString ()
Nick Schonning 717683d1c3
Autofix Rubocop remaining Layout rules ()
Nick Schonning d2dcb6c45a
Autofix Rubocop Style/UnpackFirst ()
Nick Schonning 5116347eb7
Autofix Rubocop RSpec/BeEq ()
Nick Schonning bf785df9fe
Audofix Rubocop Style/WordArray ()
Nick Schonning 4552685f6b
Autofix Rubocop RSpec/LeadingSubject ()
Nick Schonning 4ea1e0fceb
Enable Rubocop RSpec/ExpectActual ()
Nick Schonning 38a1d8bb85
Autofix Rubocop RSpec/ImplicitSubject ()
Nick Schonning 63e6353886
Autofix Rubocop Rails/EnumHash ()
Nick Schonning f0e1b12c10
Autofix Rubocop Style/ExplicitBlockArgument ()
Nick Schonning 5179c47087
Autofix Rubocops RSpec/ScatteredLet ()
Nick Schonning aef0051fd0
Enable Rubocop HTTP status rules ()
Nick Schonning bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject ()
Nick Schonning dbc6d7b276
Autofix Rubocop Lint/UnusedBlockArgument ()
Nick Schonning 65ba0d92ef
Enable Rubocop RSpec/NotToNot ()
Nick Schonning a2fdb388eb
Autofix Rubocop RSpec/ReturnFromStub ()
Nick Schonning 21bf326356
Autofix Rubocop Rails/Pluck ()
Nick Schonning 597767a9f7
Autofix Rubocop Rails/RedundantForeignKey ()
Nick Schonning 8ef09813a2
Autofix Rubocop Style/EmptyMethod ()
Nick Schonning e0e63b73ee
Autofix Rubocop RSpec/EmptyLineAfterHook ()
Nick Schonning 81ad6c2e39
Autofix Rubocop Style/StringLiterals ()
Nick Schonning ac3561098e
Autofix Rubocop RSpec/LetBeforeExamples ()
Nick Schonning 1a02101100
Autofix Rubocop Style/EmptyLambdaParameter ()
Nick Schonning 3680e032b4
Autofix Rubocop RSpec/EmptyLineAfterFinalLet ()
Nick Schonning 2177daeae9
Autofix Rubocop Style/RedundantBegin ()
Nick Schonning 167709f6b0
Autofix Rubocop Style/BlockDelimiters ()
Nick Schonning c0d7c855b3
Autofix Rubocop RSpec/Capybara/FeatureMethods ()
Nick Schonning 08289a38fa
Autofix Rubocop Style/TrailingCommaInArrayLiteral ()
Nick Schonning 5069769cbe
Autofix Rubocop Style/TrailingCommaInHashLiteral ()
Nick Schonning b4cbfff3eb
Autofix Rubocop RSpec/ExcessiveDocstringSpacing ()
Nick Schonning c38bd17657
Autofix Rubocop Style/TrailingCommaInArguments ()
Nick Schonning ab7816a414
Autofix Rubocop Style/Lambda ()
Nick Schonning e2a3ebb271
Autofix Rubocop Style/IfUnlessModifier ()
Nick Schonning 8aee4de034
Autofix Rubocop Style/PerlBackrefs ()
Nick Schonning a6f77aa28a
Autofix Rubocop Lint/AmbiguousOperatorPrecedence ()
Nick Schonning e2567df860
Enable Lint/RedundantCopDisableDirective ()
Nick Schonning d65b2c1924
Apply Rubocop Style/RedundantConstantBase ()
Nick Schonning a7db0b41cd
Autofix Rubocop Lint/ParenthesesAsGroupedExpression ()
Nick Schonning e5cf23cf3a
Enable Rubocop RSpec/HooksBeforeExamples ()
Nick Schonning efd424506a
Autofix Rubocop Style/RedundantPercentQ ()
Nick Schonning c0a645f647
Autofix Rubocop RSpec/ExampleWording ()
Nick Schonning 7a3d4c3d4b
Enable Rubocop RSpec/MultipleDescribes ()
Nick Schonning 54318dcd6d
Autofix Rubocop RSpec/ClassCheck ()
Nick Schonning 634368c491
Autofix Rubocop Lint/SymbolConversion ()
Nick Schonning 6d42820e5d
Autofix Rubocop Lint/AmbiguousOperator ()
Nick Schonning ac59d6f19f
Enable Rubocop Style/NumericLiterals ()
Nick Schonning 669f6d2c0a
Run rubocop formatting except line length ()
Nick Schonning 593bb8ce99
Autofix Rubocop Style/RaiseArgs ()
Nick Schonning 6ed6c41724
Autofix Rubocop RSpec/EmptyLineAfterExample ()