mastodon

Commit Graph

Author	SHA1	Message	Date
dependabot[bot]	8972e5f7f6	Bump rubocop from 0.86.0 to 0.88.0 (#14412 ) * Bump rubocop from 0.86.0 to 0.88.0 Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.88.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.86.0...v0.88.0) Signed-off-by: dependabot[bot] <support@github.com> * Fix for latest RuboCop Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	5 years ago
Akihiko Odaki	ae871c4d46	Make Array-creation behavior of Paginable more predictable (#14687 ) * Make Array-creation behavior of Paginable more predictable Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it returns an Array if min_id option is present. The behavior caused problems fixed with the following commits: - `552e886b64` - `b63ede5005` - `64ef37b89d` To prevent from recurring similar problems, this commit introduces two changes: - The scope now always returns an Array whether min_id option is present or not. - The scope is renamed to to_a_paginated_by_id to clarify it returns an Array. * Transform Paginable.to_a_paginated_by_id from a scope to a class method https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope > The method is intended to return an ActiveRecord::Relation object, which > is composable with other scopes. Paginable.to_a_paginated_by_id returns an Array and is not appropriate as a scope.	5 years ago
Akihiko Odaki	64ef37b89d	Introduce ApplicationController#cache_collection_paginated_by_id (#14677 ) * Replace incorrect use of distinct with group Some uses of ActiveRecord::QueryMethods#distinct pass field names but they are incorrect for the current version of Rails. ActiveRecord::QueryMethods#group provides the expected behavior and benefits performance. See commit `6da24aad4c`. * Introduce ApplicationController#cache_collection_paginated_by_id ApplicationController#cache_collection_paginated_by_id fuses ApplicationController#cache_collection and Paginable.paginate_by_id. An advantage of this method is that it prevents from modifying scope which Paginable.paginate_by_id may provide. ApplicationController#cache_collection always return an array and there is no possibility of the scope modification. It is also clear for a programmer, considering the implication of "cache". This method can also emit more efficient queries by using Cacheable.cache_ids before calling Paginable.paginate_by_id.	5 years ago
Akihiko Odaki	b63ede5005	Eagerly load statuses with the main query in Api::V1::BookmarksController (#14674 ) This is same with commit `552e886b64` except that it was for Api::V1::FavouritesController while this is for Api::V1::BookmarksController.	5 years ago
Akihiko Odaki	e26e7a1cb5	Replace incorrect use of distinct with group (#14675 ) Some uses of ActiveRecord::QueryMethods#distinct pass field names but they are incorrect for the current version of Rails. ActiveRecord::QueryMethods#group provides the expected behavior and benefits performance. See commit `6da24aad4c`.	5 years ago
Akihiko Odaki	552e886b64	Eagerly load statuses with the main query in Api::V1::FavouritesController (#14673 ) The old implementation had two queries: 1. The query constructed in Api::V1::FavouritesController#results 2. The query constructed in #cached_favourites, which is merged with 1. Both of them are issued againt PostgreSQL. The combination of the two queries caused the following problems: - The small window between the two queries involves race conditions. - Minor performance inefficiency. Moreover, the construction of query 2, which involves merging with query 1 has a bug. Query 1 is finalized with paginate_by_id, but paginate_by_id returns an array when min_id parameter is specified. The behavior prevents from merging the query, and in the real world, ActiveRecord simply ignores the merge (!), which results in querying the entire scan of statuses and favourites table. This change fixes these issues by simply letting query 1 get all the works done.	5 years ago
Akihiko Odaki	41eeb9ebaa	Use Status.group instead of Status.distinct in HashQueryService (#14662 ) DISTINCT clause removes duplicated records according to all the selected attributes. In reality, it can remove duplicated records only looking at statuses.id, but the clause confuses the query planner and yields insufficient performance. The behavior is also problematic if the scope produced by HashQueryService is used to query columns without id (using pluck method, for example). The scope is expected to contain unique statuses, but the uniquness will be evaluated with some arbitrary columns other than id. GROUP BY clause resolves those problem by explicitly specifying the column to take into account for the record distinction. A workaround for the problem of DISTINCT clause in Api::V1::Timelines::TagController is no longer necessary and removed.	5 years ago
ThibG	f6a82cb2cd	Fix not being able to unbookmark toots when blocked by their author (#14604 ) * Fix not being able to unbookmark toots when blocked by their author * Add tests	5 years ago
Ariel	2ada2ae18a	Fix/14021 behaviour on add or remove toots (#14212 ) * Add toot send by current user at local state after send a new toot Related to #14021 * Decrement toot counter at profile when remove a toot Related to #14021 * Remove semicolon at end of line	5 years ago
ThibG	0a8a3fe595	Fix being unable to unboost when blocked by their author (#14308 ) Fixes #14307	5 years ago
ThibG	65506bac3f	Add user notes on accounts (#14148 ) * Add UserNote model * Add UI for user notes * Put comment in relationships entity * Add API to create user notes * Copy user notes to new account when receiving a Move activity * Address some of the review remarks * Replace modal by inline edition * Please CodeClimate * Button design changes * Change design again * Cancel note edition when pressing Escape * Fixes * Tweak design again * Move “Add note” item, and allow users to add notes to themselves * Rename UserNote into AccountNote, rename “comment” Relationship attribute to “note”	5 years ago
Eugen Rochko	64aac30733	Add customizable thumbnails for audio and video attachments (#14145 ) - Change audio files to not be stripped of metadata - Automatically extract cover art from audio if it exists - Add `thumbnail` parameter to `POST /api/v1/media`, `POST /api/v2/media` and `PUT /api/v1/media/:id` - Add `icon` to represent it in attachments in ActivityPub - Fix `preview_url` containing URL of missing missing image when there is no thumbnail instead of null - Fix duration of audio not being displayed on public pages until the file is loaded	5 years ago
ThibG	ac8a788370	Fix functional user requirements in whitelist mode (#14093 ) Fixes #14092	5 years ago
Eugen Rochko	f669b8bcce	Fix wrong route helper in encrypted messages controller (#13952 ) And add `created_at` to encrypted message serializer	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820 )	5 years ago
Takeshi Umeda	26b08a3c54	Add remote only to public timeline (#13504 ) * Add remote only to public timeline * Fix code style	5 years ago
ThibG	f1e0fa80f6	Fix own following/followers not showing muted users (#13614 ) Fixes #13612	5 years ago
Eugen Rochko	988b0493fe	Add more tests for ActivityPub controllers (#13585 )	5 years ago
Eugen Rochko	c9efb400b4	Add rate limit for reporting (#13390 )	5 years ago
ThibG	0d117c106a	Fix 404 and 410 API errors being silently discarded in WebUI (#13279 ) * Fix 404 and 410 API errors being silently discarded in WebUI Fixes #13278 * Return more appropriate error when user replies to a deleted toot * Please CodeClimate * Fix 404/410 errors on fetching account timelines & identity proofs * Refactor error handling * Move error message string to statuses.errors	5 years ago
ThibG	b154428e14	Add federation support for the "hide network" preference (#11673 ) * Change ActivityPub follower/following collections to not link first page * Add support for hiding followers and following of remote users * Switch to using a single `hide_collections` column * Address code style remarks	5 years ago
Eugen Rochko	9660aa4543	Change local media attachments to perform heavy processing asynchronously (#13210 ) Fix #9106	5 years ago
Eugen Rochko	339ce1c4e9	Add specific rate limits for posting and following (#13172 )	5 years ago
Eugen Rochko	0ae5c6312f	Remove useless `respond_to` calls (#13208 )	5 years ago
Eugen Rochko	0c28a505dd	Fix leak of arbitrary statuses through unfavourite action in REST API (#13161 )	5 years ago
ThibG	7face973fa	Fix dismissing an announcement twice raising an obscure error (#13124 )	5 years ago
Eugen Rochko	a64973aecf	Fix malformed HTML causing uncaught error (#13042 ) Fix OEmbed preview API leaking existence of private statuses (see #12930)	5 years ago
ThibG	3adc722d1c	Change how unread announcements are handled (#13020 ) * Change meaning of /api/v1/announcements/:id/dismiss to mark an announcement as read * Change how unread announcements are counted in UI * Add unread marker to announcements and mark announcements as unread as they are displayed * Fixups	5 years ago
Eugen Rochko	c4c315ea40	Fix OEmbed leaking information about existence of non-public statuses (#12930 )	5 years ago
Eugen Rochko	f52c988e12	Add announcements (#12662 ) * Add announcements Fix #11006 * Add reactions to announcements * Add admin UI for announcements * Add unit tests * Fix issues - Add `with_dismissed` param to announcements API - Fix end date not being formatted when time range is given - Fix announcement delete causing reactions to send streaming updates - Fix announcements container growing too wide and mascot too small - Fix `all_day` being settable when no time range is given - Change text "Update" to "Announcement" * Fix scheduler unpublishing announcements before they are due * Fix filter params not being passed to announcements filter	5 years ago
Eugen Rochko	02d272cf49	Fix access to OEmbed endpoint in secure mode (#12864 )	5 years ago
Eugen Rochko	49b2f7c0a2	Fix base64-encoded file uploads not being possible (#12748 ) Fix #3804, Fix #5776	5 years ago
ThibG	3b3bdc7293	Hide blocked users from more places (#12733 ) * Hide blocked, muted, and blocked-by users from toot favourite lists * Hide blocked, muted, and blocked-by users from toot reblog lists * Hide blocked, muted, and blocked-by users from followers/following (API) * Fix tests * Hide blocked, muted, and blocked-by users from followers/following on public pages	5 years ago
Eugen Rochko	2999c95596	Fix error when fetching followers/following from REST API when user has network hidden (#12716 ) Fix #12510	5 years ago
Eugen Rochko	6d7daf6154	Fix generic HTTP 500 error on duplicate records (#12563 ) Fix #12551 Fix #12547	5 years ago
ThibG	911cc14481	Add follow_request notification type (#12198 ) * Add follow_request notification type The notification type already existed in the backend but was never pushed to the front-end. This also means translation strings were also available for the backend, from the notification mailer. Unlike other notification types, these are off by default, to match what I remember of Gargron's view on the topic: that follow requests should not clutter notifications and should instead be reviewed at the user's own leisure in the dedicated column. Since follow requests have their own column, I've deemed it unnecessary to add a specific tab for them in the notification quick filter. * Show follow request link in single-column if there are pending requests, even if account isn't locked * Push follow requests from notifications to the follow_requests list * Offer to accept or reject follow request from the notification * Redesign follow request notification	5 years ago
Eugen Rochko	d9793b2367	Fix proofs API being inaccessible in secure mode (#12495 )	5 years ago
Gomasy	5a2c0707f1	Support min_id-based pagination for bookmarks (#12381 ) * Support min_id-based pagination for bookmarks * Fix spec	5 years ago
Jennifer Glauche	fd93a9c871	make it not return http 400 when passing and empty source argument (#12259 ) * make it not return http 400 when passing and empty source argument * create a spec for the empty source hash bug * compact checks for nil, empty? parameters * use nil.blank? instead checking for nil	5 years ago
ThibG	dfea7368c9	Add bookmarks (#7107 ) * Add backend support for bookmarks Bookmarks behave like favourites, except they aren't shared with other users and do not have an associated counter. * Add spec for bookmark endpoints * Add front-end support for bookmarks * Introduce OAuth scopes for bookmarks * Add bookmarks to archive takeout * Fix migration * Coding style fixes * Fix rebase issue * Update bookmarked_statuses to latest UI changes * Update bookmark actions to properly reflect status changes in state * Add bookmarks item to single-column layout * Make active bookmarks red	5 years ago
Eugen Rochko	354fdd317e	Fix attachment not being re-downloaded even if file is not stored (#12125 ) Change the behaviour of remotable concern. Previously, it would skip downloading an attachment if the stored remote URL is identical to the new one. Now it would not be skipped if the attachment is not actually currently stored by Paperclip.	6 years ago
Eugen Rochko	a582185625	Fix `GET /api/v1/instance` REST APIs being unavailable in secure mode (#12089 )	6 years ago
Eugen Rochko	f665901e3c	Fix performance of home feed regeneration (#12084 ) Fetching statuses from all followed accounts at once takes too long within Postgres. Fetching them one by one and merging in Ruby could be a lot less resource-intensive Because the query for dynamically fetching the home timeline is so heavy, we can no longer offer it when the home timeline is missing	6 years ago
Eugen Rochko	eb83d6256e	Add `reason` param to `POST /api/v1/accounts` REST API (#12064 ) For approval-required registrations mode	6 years ago
Eugen Rochko	ab33c4df94	Add `exclude_unreviewed` param to `GET /api/v2/search` REST API (#11977 ) Make it so normal search returns even unreviewed matches, but autosuggestions do not. Fix #11960	6 years ago
ThibG	18b451c0e6	Change silences to always require approval on follow (#11975 ) * Change silenced accounts to require approval on follow * Also require approval for follows by people explicitly muted by target accounts * Do not auto-accept silenced or muted accounts when switching from locked to unlocked * Add `follow_requests_count` to verify_credentials * Show “Follow requests” menu item if needed even if account is locked * Add tests * Correctly reflect that follow requests weren't auto-accepted when local account is silenced * Accept follow requests from user-muted accounts to avoid leaking mutes	6 years ago
abcang	059945c97c	Improve status pin query (#11972 )	6 years ago
Eugen Rochko	18331fefa2	Remove deprecated `GET /api/v1/search` API (#11823 ) Use `GET /api/v2/search` instead	6 years ago
ThibG	225edac118	Change /api/v1/timelines/public to require auth when public preview is off (#11802 ) Fixes #11289	6 years ago
Eugen Rochko	59da5ccb8e	Change unlisted custom emoji to not appear in autosuggestions (#11818 ) Fix #11669	6 years ago

1 2 3 4 5 ...

402 Commits (71085987e87df11c4e96a646182defcb5b68e31a)