mastodon

Commit Graph

Author	SHA1	Message	Date
ysksn	6d7e05ec1f	Add tests for StreamEntry (#5687 ) * Add tests for StreamEntry - `#object_type` - `#verb` - `#mentions` * Fix to test results instead of implementations	7 years ago
Eugen Rochko	fbef909c2a	Add option to block direct messages from people you don't follow (#5669 ) * Add option to block direct messages from people you don't follow Fix #5326 * If the DM responds to a toot by recipient, allow it through * i18n: Update Polish translation (for #5669) (#5673)	7 years ago
ysksn	48e27c47a7	Add a test for SiteUpload#cache_key (#5685 )	7 years ago
Yamagishi Kazutoshi	1f1838420f	Refactor remote_follow_spec.rb (#5690 )	7 years ago
Yamagishi Kazutoshi	20150659e6	Add uniqueness to block email domains (#5692 )	7 years ago
ysksn	4112a0631f	Add tests for Setting (#5683 )	7 years ago
ysksn	60f247c2e7	Add tests for SessionActivation (#5668 ) * Fabricate SessionActivation not only user_id but user association. * Add tests for SessionActivation	7 years ago
ysksn	2fb722397d	Add tests for RemoteProfile (#5665 )	7 years ago
ysksn	56720ba590	Add tests for RemoteFollow (#5651 ) * Add tests for RemoteFollow.initialize * Add tests for RemoteFollow#valid? * Add tests for RemoteFollow#subscribe_address_for	7 years ago
ysksn	07cca6e364	Add tests for Notification (#5640 ) * Add tests for Notification#target_status * Add tests for Notification#browserable? * Add tests for Notification.reload_stale_associations!	7 years ago
ysksn	54b42901df	Add and Remove tests for FollowRequest (#5622 ) * Add a test for FollowRequest#authorize! * Remove tests There is no need to test ActiveModel::Validations::ClassMethods#validates. * Make an alias of destroy! as reject! Instead of defining the method, make an alias of destroy! as reject! because of reducing test.	7 years ago
Nanamachi	d200e041fe	Rewrite account_controller_spec (#5633 ) * make accounts_controller_spec DRY * Add blocked user spec	7 years ago
ysksn	64cc129225	Add tests for MediaAttachment (#5620 ) - `#local?` - `#needs_redownload?` - `#to_param`	7 years ago
ysksn	97fc2da2e0	Add tests for CustomEmoji#local? and #object_type (#5621 )	7 years ago
ysksn	d307ee79e9	Implement tests for Account#refresh! (#5601 )	7 years ago
ysksn	cf01326cc1	Add test for Account#save_with_optional_media! (#5603 ) There was a test when some of the properties are invalid, but none when all of them are valid.	7 years ago
ysksn	15c0f6ae56	Implement tests for Account#possibly_stale? (#5591 )	7 years ago
unarist	4f337c020a	Fix Cocaine::ExitStatusError when upload small non-animated GIF (#5489 ) Looks like copied tempfile need to be flushed before further processing. This issue won't happen if the uploaded file has enough file size.	7 years ago
aschmitz	554c2fd8af	Clean up reblog tracking keys, related improvements (#5428 ) * Clean up reblog-tracking sets from FeedManager Builds on #5419, with a few minor optimizations and cleanup of sets after they are no longer needed. * Update tests, fix multiply-reblogged case Previously, we would have lost the fact that a given status was reblogged if the displayed reblog of it was removed, now we don't. Also added tests to make sure FeedManager#trim cleans up our reblog tracking keys, fixed up FeedCleanupScheduler to use the right loop, and fixed the test for it.	7 years ago
Eugen Rochko	34118169ac	Keep references to all reblogs of a status on home feed (#5419 ) * Keep references to all reblogs of a status on home feed When inserting reblog: Add to set of reblogs of this status on the feed, if original status was present in the feed, add it to that set as well. When removing a reblog: Remove it from that set. Take random remaining item from the set. If one exists, re-insert it into feed, otherwise do not re-insert anything. Fix #4210 * When original is removed, toss out reblog references	7 years ago
unarist	6f490b4bfe	Fix un-reblogged status being at wrong position in the home timeline (#5418 ) We've changed un-reblogging behavior when we implement Snowflake, to insert un-reblogged status at the position reblogging status existed. However, our API expects home timeline is ordered by status ids, and max_id/since_id filters by zset score. Due to this, un-reblogged status appears as a last item of result set, and timeline expansion may skips many statuses. So this reverts that change...reblogged status inserted at corresponding position to its id.	7 years ago
Yamagishi Kazutoshi	d5b767c374	Replace JavaScript Testing Framework from Mocha to Jest (#5412 )	7 years ago
unarist	8125fdc19f	Use atomUri in Undo activity of Announce (#5376 ) This allows deletion of reblogs which delivered before with OStatus URI.	7 years ago
Eugen Rochko	3283868e28	Improve spec of Feed and UserTrackingConcern (#5367 )	7 years ago
Lex Alexander	b8bae96647	Retoot count increases without reason (#5363 ) * Retoot count increases without reason -The store_uri method for Statuses was being called on after_create and causing reblogs to be incremented twice. -This calls it when the transaction is finished by using after_create_commit. -Fixes #4916. * Added test case for after_create_commit callback for checking reblog count. * Rewrote test to keep original, but added one for only the after_create_commit callback.	7 years ago
Akihiko Odaki	cc796298c9	Fix pagination in Api::V1::BlocksController (#5285 )	7 years ago
Eugen Rochko	0717d9b3e6	Set snowflake IDs for backdated statuses (#5260 ) - Rename Mastodon::TimestampIds into Mastodon::Snowflake for clarity - Skip for statuses coming from inbox, aka delivered in real-time - Skip for statuses that claim to be from the future	7 years ago
nullkal	633426b261	Add moderation note (#5240 ) * Add moderation note * Add frozen_string_literal * Make rspec pass	7 years ago
Eugen Rochko	f486ef2666	Redesign public hashtag pages (#5237 )	7 years ago
Eugen Rochko	3a3475450e	Encode custom emojis as resolveable objects in ActivityPub (#5243 ) * Encode custom emojis as resolveable objects in ActivityPub * Improve code style	7 years ago
Nolan Lawson	057db0ecd0	Update emoji-mart to v2.1.1 (#5256 )	7 years ago
Nolan Lawson	72d939b69f	Fix thinking_face emoji autocomplete (#5238 )	7 years ago
Nolan Lawson	fd7f0732fe	Compress and combine emoji data (#5229 )	7 years ago
ThibG	2559d9166c	Fix regression in FetchRemoteResourceService (#5217 ) * Fix regression in FetchRemoteResourceService * Update specs to match interface changes made in #5114	7 years ago
utam0k	b3af3f9f8c	Implement EmailBlackList (#5109 ) * Implement BlacklistedEmailDomain * Use Faker::Internet.domain_name * Remove note column * Add frozen_string_literal comment * Delete unnecessary codes * Sort alphabetically * Change of wording * Rename BlacklistedEmailDomain to EmailDomainBlock	7 years ago
Yamagishi Kazutoshi	178f718a9b	Separate notifications preferences from general preferences (#4447 ) * Separate notifications preferences from general preferences * Refine settings/notifications/show * remove preferences.notifications	7 years ago
aschmitz	468523f4ad	Non-Serial ("Snowflake") IDs (#4801 ) * Use non-serial IDs This change makes a number of nontrivial tweaks to the data model in Mastodon: * All IDs are now 8 byte integers (rather than mixed 4- and 8-byte) * IDs are now assigned as: * Top 6 bytes: millisecond-resolution time from epoch * Bottom 2 bytes: serial (within the millisecond) sequence number * See /lib/tasks/db.rake's `define_timestamp_id` for details, but note that the purpose of these changes is to make it difficult to determine the number of objects in a table from the ID of any object. * The Redis sorted set used for the feed will have values used to look up toots, rather than scores. This is almost always the same as the existing behavior, except in the case of boosted toots. This change was made because Redis stores scores as double-precision floats, which cannot store the new ID format exactly. Note that this doesn't cause problems with sorting/pagination, because ZREVRANGEBYSCORE sorts lexicographically when scores are tied. (This will still cause sorting issues when the ID gains a new significant digit, but that's extraordinarily uncommon.) Note a couple of tradeoffs have been made in this commit: * lib/tasks/db.rake is used to enforce many/most column constraints, because this commit seems likely to take a while to bring upstream. Enforcing a post-migrate hook is an easier way to maintain the code in the interim. * Boosted toots will appear in the timeline as many times as they have been boosted. This is a tradeoff due to the way the feed is saved in Redis at the moment, but will be handled by a future commit. This would effectively close Mastodon's #1059, as it is a snowflake-like system of generating IDs. However, given how involved the changes were simply within Mastodon, it may have unexpected interactions with some clients, if they store IDs as doubles (or as 4-byte integers). This was a problem that Twitter ran into with their "snowflake" transition, particularly in JavaScript clients that treated IDs as JS integers, rather than strings. It therefore would be useful to test these changes at least in the web interface and popular clients before pushing them to all users. * Fix JavaScript interface with long IDs Somewhat predictably, the JS interface handled IDs as numbers, which in JS are IEEE double-precision floats. This loses some precision when working with numbers as large as those generated by the new ID scheme, so we instead handle them here as strings. This is relatively simple, and doesn't appear to have caused any problems, but should definitely be tested more thoroughly than the built-in tests. Several days of use appear to support this working properly. BREAKING CHANGE: The major(!) change here is that IDs are now returned as strings by the REST endpoints, rather than as integers. In practice, relatively few changes were required to make the existing JS UI work with this change, but it will likely hit API clients pretty hard: it's an entirely different type to consume. (The one API client I tested, Tusky, handles this with no problems, however.) Twitter ran into this issue when introducing Snowflake IDs, and decided to instead introduce an `id_str` field in JSON responses. I have opted to not do that, and instead force all IDs to 64-bit integers represented by strings in one go. (I believe Twitter exacerbated their problem by rolling out the changes three times: once for statuses, once for DMs, and once for user IDs, as well as by leaving an integer ID value in JSON. As they said, "If you’re using the `id` field with JSON in a Javascript-related language, there is a very high likelihood that the integers will be silently munged by Javascript interpreters. In most cases, this will result in behavior such as being unable to load or delete a specific direct message, because the ID you're sending to the API is different than the actual identifier associated with the message." [1]) However, given that this is a significant change for API users, alternatives or a transition time may be appropriate. 1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html * Restructure feed pushes/unpushes This was necessary because the previous behavior used Redis zset scores to identify statuses, but those are IEEE double-precision floats, so we can't actually use them to identify all 64-bit IDs. However, it leaves the code in a much better state for refactoring reblog handling / coalescing. Feed-management code has been consolidated in FeedManager, including: * BatchedRemoveStatusService no longer directly manipulates feed zsets * RemoveStatusService no longer directly manipulates feed zsets * PrecomputeFeedService has moved its logic to FeedManager#populate_feed (PrecomputeFeedService largely made lots of calls to FeedManager, but didn't follow the normal adding-to-feed process.) This has the effect of unifying all of the feed push/unpush logic in FeedManager, making it much more tractable to update it in the future. Due to some additional checks that must be made during, for example, batch status removals, some Redis pipelining has been removed. It does not appear that this should cause significantly increased load, but if necessary, some optimizations are possible in batch cases. These were omitted in the pursuit of simplicity, but a batch_push and batch_unpush would be possible in the future. Tests were added to verify that pushes happen under expected conditions, and to verify reblog behavior (both on pushing and unpushing). In the case of unpushing, this includes testing behavior that currently leads to confusion such as Mastodon's #2817, but this codifies that the behavior is currently expected. * Rubocop fixes I could swear I made these changes already, but I must have lost them somewhere along the line. * Address review comments This addresses the first two comments from review of this feature: https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336735 https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336931 This adds an optional argument to FeedManager#key, the subtype of feed key to generate. It also tests to ensure that FeedManager's settings are such that reblogs won't be tracked forever. * Hardcode IdToBigints migration columns This addresses a comment during review: https://github.com/tootsuite/mastodon/pull/4801#discussion_r139337452 This means we'll need to make sure that all _id columns going forward are bigints, but that should happen automatically in most cases. * Additional fixes for stringified IDs in JSON These should be the last two. These were identified using eslint to try to identify any plain casts to JavaScript numbers. (Some such casts are legitimate, but these were not.) Adding the following to .eslintrc.yml will identify casts to numbers: ~~~ no-restricted-syntax: - warn - selector: UnaryExpression[operator='+'] > :not(Literal) message: Avoid the use of unary + - selector: CallExpression[callee.name='Number'] message: Casting with Number() may coerce string IDs to numbers ~~~ The remaining three casts appear legitimate: two casts to array indices, one in a server to turn an environment variable into a number. * Only implement timestamp IDs for Status IDs Per discussion in #4801, this is only being merged in for Status IDs at this point. We do this in a migration, as there is no longer use for a post-migration hook. We keep the initialization of the timestamp_id function as a Rake task, as it is also needed after db:schema:load (as db/schema.rb doesn't store Postgres functions). * Change internal streaming payloads to stringified IDs as well This is equivalent to `591a9af356` from #5019, with an extra change for the addition to FeedManager#unpush. * Ensure we have a status_id_seq sequence Apparently this is not a given when specifying a custom ID function, so now we ensure it gets created. This uses the generic version of this function to more easily support adding additional tables with timestamp IDs in the future, although it would be possible to cut this down to a less generic version if necessary. It is only run during db:schema:load or the relevant migration, so the overhead is extraordinarily minimal. * Transition reblogs to new Redis format This provides a one-way migration to transition old Redis reblog entries into the new format, with a separate tracking entry for reblogs. It is not invertible because doing so could (if timestamp IDs are used) require a database query for each status in each users' feed, which is likely to be a significant toll on major instances. * Address review comments from @akihikodaki No functional changes. * Additional review changes * Heredoc cleanup * Run db:schema:load hooks for test in development This matches the behavior in Rails' ActiveRecord::Tasks::DatabaseTasks.each_current_configuration, which would otherwise break `rake db:setup` in development. It also moves some functionality out to a library, which will be a good place to put additional related functionality in the near future.	7 years ago
Akihiko Odaki	63f0979799	Validate id of ActivityPub representations (#5114 ) Additionally, ActivityPub::FetchRemoteStatusService no longer parses activities. OStatus::Activity::Creation no longer delegates to ActivityPub because the provided ActivityPub representations are not signed while OStatus representations are.	7 years ago
ThibG	dfaa219f88	Fix HTTP responses for salmon and ActivityPub inbox processing (#5200 ) * Return sensible HTTP status for ActivityPub inbox processing * Return sensible HTTP status for salmon slap processing * Return additional information to debug signature verification failures	7 years ago
Nolan Lawson	813c5f2f52	Add spec for emoji_index_light.js (#5199 )	7 years ago
Nolan Lawson	334a446313	Fix emoji sequence bug in substring-trie (#5191 ) Fixes #5188	7 years ago
Eugen Rochko	47ecd652d3	Make Chrome splash screen same color as web UI's background color (#5169 )	7 years ago
Akihiko Odaki	cdacac8c6c	Fix order of paginated accounts in FollowerDomainsController and spec (#3357 ) * Fix order of paginated accounts in FollowerDomainsController Unordered pagination could result in unexpected behavior. * Cover Settings::FollowerDomainsController more	7 years ago
Eugen Rochko	eb605141ff	Fix #5104 - GET /api/v1/apps/verify_credentials to confirm app works (#5112 )	7 years ago
Eugen Rochko	ebb8c89207	Upgrade to React 16 (#5119 ) * Upgrade to React 16.0.0 * Disable some uncritical tests while chai-enzyme remains incompatible	7 years ago
Eugen Rochko	f4ca116ea8	After 7 days of repeated delivery failures, give up on inbox (#5131 ) - A successful delivery cancels it out - An incoming delivery from account of the inbox cancels it out	7 years ago
Eugen Rochko	887cd94e96	Increase attachment descriptions to 420 characters (#5139 ) Blaze it	7 years ago
Eugen Rochko	4ec1771165	Add ability to specify alternative text for media attachments (#5123 ) * Fix #117 - Add ability to specify alternative text for media attachments - POST /api/v1/media accepts `description` straight away - PUT /api/v1/media/:id to update `description` (only for unattached ones) - Serialized as `name` of Document object in ActivityPub - Uploads form adjusted for better performance and description input * Add tests * Change undo button blend mode to difference	7 years ago
Eugen Rochko	e528114c53	Follow-up to #4582 and #5027 , removing dead code (#5101 )	7 years ago
Eugen Rochko	cf7fbf2c56	Fix #5059 - Stop processing payload if it's from local account (#5100 )	7 years ago

1 2 3 4 5 ...

654 Commits (6d7e05ec1f27d2592cf15519c39141de857f65de)