134 Commits (6c7cdedb2460b3fed1000b1c84e6a1fdffda4c5c)

Author	SHA1	Message	Date
Claire	a5394980f2	Fix NameError in Webfinger redirect handling in ActivityPub::FetchRemoteActorService (#20260)	2 years ago
Eugen Rochko	e98833748e	Fix being able to spoof link verification (#20217) ... - Change verification to happen in `default` queue - Change verification worker to only be queued if there's something to do - Add `link` tags from metadata fields to page header of profiles	2 years ago
Claire	bbf74498f5	Fix validation error in SynchronizeFeaturedTagsCollectionWorker (#20018) ... * Fix followers count not being updated when migrating follows Fixes #19900 * Fix validation error in SynchronizeFeaturedTagsCollectionWorker Also saves remote user's chosen case for hashtags * Limit remote featured tags before validation	2 years ago
Yamagishi Kazutoshi	94feb2b93f	Fix `FetchFeaturedCollectionService` spec (#19401) ... Regression from #19380	2 years ago
Takeshi Umeda	b0e3f0312c	Add synchronization of remote featured tags (#19380) ... * Add LIMIT of featured tag to instance API response * Add featured_tags_collection_url to Account * Add synchronization of remote featured tags * Deliver update activity when updating featured tag * Remove featured_tags_collection_url * Revert "Add featured_tags_collection_url to Account" This reverts commit cff349fc27. * Add hashtag sync from featured collections * Fix tag name normalize * Add target option to fetch featured collection * Refactor fetch_featured_tags_collection_service * Add LIMIT of featured tag to v1/instance API response	2 years ago
Claire	85890bc80f	Fix crash in FetchRemoteKeyService (#19225) ... Fix regression from #19212	2 years ago
Claire	8cf7006d4e	Refactor ActivityPub handling to prepare for non-Account actors (#19212) ... * Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is specifically required to be an Account * Refactor SignatureVerification to allow non-Account actors * fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService * Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors * Refactor inbound ActivityPub payload processing to accept non-Account actors * Refactor inbound ActivityPub processing to accept activities relayed through non-Account * Refactor how Account key URIs are built * Refactor Request and drop unused key_id_format parameter * Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`	2 years ago
Claire	1145dbd327	Improve error reporting and logging when processing remote accounts (#15605) ... * Add a more descriptive PrivateNetworkAddressError exception class * Remove unnecessary exception class to rescue clause * Remove unnecessary include to JsonLdHelper * Give more neutral error message when too many webfinger redirects * Remove unnecessary guard condition * Rework how “ActivityPub::FetchRemoteAccountService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteAccountService#call (default/previous behavior). * Rework how “ActivityPub::FetchRemoteKeyService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteKeyService#call (default/previous behavior). * Fix Webfinger::RedirectError not being a subclass of Webfinger::Error * Add suppress_errors option to ResolveAccountService Defaults to true (to preserve previous behavior). If set to false, errors will be raised instead of caught, allowing the caller to be informed of what went wrong. * Return more precise error when failing to fetch account signing AP payloads * Add tests * Fixes * Refactor error handling a bit * Fix various issues * Add specific error when provided Digest is not 256 bits of base64-encoded data * Please CodeClimate * Improve webfinger error reporting	2 years ago
Jeong Arm	6aa83b13ba	Properly delete remote account's avatar/header when fetch/update (#18973)	3 years ago
Claire	e0bdaeab65	Fix NoMethodError when resolving a link that redirects to a local post (#18314) ... * Fix NoMethodError when resolving a link that redirects to a local post * Fix tests	3 years ago
Eugen Rochko	6cf57c6765	Refactor how Redis locks are created (#18400) ... * Refactor how Redis locks are created * Fix autorelease duration on account deletion lock	3 years ago
Claire	0597e5db68	Fix ArgumentError when processing pinned posts from Friendica (#18260) ... Follow-up to #18254	3 years ago
Claire	71d02ffcf3	Fix compatibility with Friendica regarding pinned posts (#18254) ... * Fix multiple database queries when fetching pinned posts for remote account * Fix compatibility with Friendica regarding pinned posts Fixes #18066 * Add tests	3 years ago
Eugen Rochko	3917353645	Fix single Redis connection being used across all threads (#18135) ... * Fix single Redis connection being used across all Sidekiq threads * Fix tests	3 years ago
Jeong Arm	1de748bf5e	Fix FetchFeaturedCollectionService (#18030)	3 years ago
Claire	8f91e304a5	Fix spurious edits and require incoming edits to be explicitly marked as such (#17918) ... * Change post text edit to not be considered significant if it's identical after reformatting * We don't need to clear previous change information anymore * Require status edits to be explicit, except for poll tallies * Fix tests * Add some tests * Add poll-related tests * Add HTML-formatting related tests	3 years ago
Claire	454ef42aab	Fix error when encountering invalid pinned posts (#17964)	3 years ago
Eugen Rochko	71f2b95106	Fix edits with no actual changes being allowed (#17843) ... * Fix edits with no actual changes being allowed locally * Fix edits with no actual changes being allowed through ActivityPub * Fix false positive changes caused by description processing in model * Fix not recording poll expiration update * Fix test * Revert changes to ProcessStatusUpdateService * Various fixes and improvements * Fix code style issues * Various changes and improvements * Add guard clause	3 years ago
Claire	92a86b958e	Fix issues with processing toot edits (#17748) ... * Fix searching for an already-known status by URL not working * Fix Update processing from statuses prior to 20220302232632 `ordered_media_attachment_ids_changed?` would return `true` when going from `nil` to anything (including `[]`). * Add tests	3 years ago
Claire	d3aa9cf774	Fix Updates being forwarded even when not processable or causing no change (#17699) ... * Fix Updates being forwarded even when not processable or causing no change * Refactor and ensure status edit is strictly newer than last known edit	3 years ago
Eugen Rochko	ddbe906c25	Fix not updating a status when newer version is fetched manually (#17745)	3 years ago
Eugen Rochko	b2cd34474b	Add rate limit for editing (#17728)	3 years ago
Eugen Rochko	d17fb70131	Change how changes to media attachments are stored for edits (#17696) ... * Change how changes to media attachments are stored for edits Fix not being able to re-order media attachments * Fix not broadcasting updates when polls/media is changed through ActivityPub * Various fixes and improvements * Update app/models/report.rb Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Add tracking of media attachment description changes * Change poll in status edit to have a structure closer to the real one Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Claire	63854bee6c	Fix poll votes not being properly reset on poll change (#17498) ... * Fix poll votes not being properly reset on poll change * Fix and add tests * Fix poll update handling when the number of options changes	3 years ago
Eugen Rochko	63002cde03	Add editing for published statuses (#17320) ... * Add editing for published statuses * Fix change of multiple-choice boolean in poll not resetting votes * Remove the ability to update existing media attachments for now	3 years ago
Eugen Rochko	b6d7726ecb	Remove language detection through cld3 (#17478) ... * Remove language detection through cld3 * Update app/helpers/languages_helper.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	3 years ago
Claire	c8b1e72a4f	Fix compacted JSON-LD possibly causing compatibility issues on forwarding (#17428)	3 years ago
Claire	d1ecc323e7	Compact JSON-LD signed incoming activities (#17426) ... Co-authored-by: Puck Meerburg <puck@puck.moe>	3 years ago
Claire	03d59340da	Fix Sidekiq warnings about JSON serialization (#17381) ... * Fix Sidekiq warnings about JSON serialization This occurs on every symbol argument we pass, and every symbol key in hashes, because Sidekiq expects strings instead. See https://github.com/mperham/sidekiq/pull/5071 We do not need to change how workers parse their arguments because this has not changed and we were already converting to symbols adequately or using `with_indifferent_access`. * Set Sidekiq to raise on unsafe arguments in test mode In order to more easily catch issues that would produce warnings in production code.	3 years ago
Eugen Rochko	6505b39e5d	Fix poll updates being saved as status edits (#17373) ... Fix #17344	3 years ago
Eugen Rochko	d412a8d1f2	Fix error when processing poll updates (#17333) ... Regression from #16697	3 years ago
Eugen Rochko	1060666c58	Add support for editing for published statuses (#16697) ... * Add support for editing for published statuses * Fix references to stripped-out code * Various fixes and improvements * Further fixes and improvements * Fix updates being potentially sent to unauthorized recipients * Various fixes and improvements * Fix wrong words in test * Fix notifying accounts that were tagged but were not in the audience * Fix mistake	3 years ago
Jeong Arm	2d1f082bb6	Fix NameError on ActivityPub::FetchFeaturedCollectionService (#17326) ... Related: #16954	3 years ago
Claire	d5c9feb7b7	Add support for private pinned posts (#16954) ... * Add support for private pinned toots * Allow local user to pin private toots * Change wording to avoid "direct message"	3 years ago
Eugen Rochko	7de0ee7aba	Remove Keybase integration (#17045)	3 years ago
Claire	3f9b28ce26	Add support for fetching Create and Announce activities by URI (#16383) ... * Add support for fetching Create and Announce activities by URI This should improve compatibility with ZAP and offer a way to fetch boosts, which is currently not possible. * Add tests	3 years ago
Claire	9a19227f17	Fix some RedisLocks auto-releasing too fast (#16276) ... * Fix Delete and Create-related locks expiring too fast Fixes #16238 By default, RedisLock expires after 10 seconds, which may not be enough to process statuses, especially when those have attached media files. This commit extends those 10 seconds to 15 minutes, which should be plenty enough to handle any status, while being short enough to not waste many sidekiq job retries in the exceedingly rare case in which a sidekiq process would crash when processing a `Create` or `Delete`. * Fix other RedisLock autorelease durations Fixes #15645 - things that only perform a few simple database queries (e.g. finding and saving a record) have been left unchanged, so they'll still use the default 10s duration - things that perform significantly more complex database queries have been changed to a 5 minutes timeout - things that perform multiple HTTP queries have been changed to a 15 minutes timeout	4 years ago
Takeshi Umeda	c403c3695b	Fix to be able to redownload avatar and header (#16190) ... * Fix to reset if header and avatar download fails * Add RedownloadAvatarWorker and RedownloadHeaderWorker	4 years ago
Eugen Rochko	2c77d97e0d	Add joined date to profiles in web UI (#16169)	4 years ago
Eugen Rochko	f627d2eb93	Fix trying to fetch key from empty URI when verifying HTTP signature (#16100)	4 years ago
luigi	7ea9588520	Use Enumerable#filter_map in more places (#15527)	4 years ago
luigi	087ed84367	Optimize map { ... }.compact calls (#15513) ... * Optimize map { ... }.compact using Enumerable#filter_map, supported since Ruby 2.7 * Add poyfill for Enumerable#filter_map	4 years ago
ThibG	a60d9335d8	Fix resolving accounts sometimes creating duplicate records for a given AP id (#15364) ... * Fix ResolveAccountService accepting mismatching acct: URI * Set attributes that should be updated regardless of suspension * Fix key fetching * Automatically merge remote accounts with duplicate `uri` * Add tests * Add "tootctl accounts fix-duplicates" Finds duplicate accounts sharing a same ActivityPub `id`, re-fetch them and merge them under the canonical `acct:` URI. Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	3134691948	Add support for reversible suspensions through ActivityPub (#14989)	4 years ago
ThibG	fb586584f2	Fix account processing failing because of large collections (#15027) ... Fixes #15025	4 years ago
ThibG	ca56527140	Add follower synchronization mechanism (#14510) ... * Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each	4 years ago
Eugen Rochko	7d985f2aac	Remove dependency on goldfinger gem (#14919) ... There are edge cases where requests to certain hosts timeout when using the vanilla HTTP.rb gem, which the goldfinger gem uses. Now that we no longer need to support OStatus servers, webfinger logic is so simple that there is no point encapsulating it in a gem, so we can just use our own Request class. With that, we benefit from more robust timeout code and IPv4/IPv6 resolution. Fix #14091	4 years ago
Eugen Rochko	64aac30733	Add customizable thumbnails for audio and video attachments (#14145) ... - Change audio files to not be stripped of metadata - Automatically extract cover art from audio if it exists - Add `thumbnail` parameter to `POST /api/v1/media`, `POST /api/v2/media` and `PUT /api/v1/media/:id` - Add `icon` to represent it in attachments in ActivityPub - Fix `preview_url` containing URL of missing missing image when there is no thumbnail instead of null - Fix duration of audio not being displayed on public pages until the file is loaded	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820)	5 years ago
Eugen Rochko	4b766f9846	Refactor monkey-patching of Goldfinger (#12561)	5 years ago