1386 Commits (626f9cf83199b75424f09589439ac4e92d1badc6)

Author	SHA1	Message	Date
Carl Schwan	f33e22ae4c	Allow changing hide_collections setting with the api (#22790) ... * Allow changing hide_collections setting with the api This is currently only possible with app/controllers/settings/profiles_controller.rb and is the only difference in the allowed parameter between the two controllers * Fix the lint issue * Use normal indent	3 years ago
Claire	aefefc74c4	Change referrer-policy to no-referrer application-wide (#23014)	3 years ago
Claire	18d00055f4	Add dropdown menu item to open admin interface for remote domains (#21895) ... * Allow /admin/instances/:domain to handle IDNs * Add dropdown menu item to open admin interface for remote domains	3 years ago
Claire	42f9693d00	Fix PermalinkRedirector not applying to users with moved accounts (#22497) ... Fixes #22262	3 years ago
Claire	8556a649d5	Fix changing domain block severity not undoing individual account effects (#22135) ... * Fix changing domain block severity not undoing individual account effects Fixes #22133 * Add tests	3 years ago
David Vega	1b5d207131	Fix single name variables on controller folder (#20092) ... Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com> Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com> Co-authored-by: Effy Elden <effy@effy.space>	3 years ago
Claire	623d3d2e32	Change CSP directives on API to be tight and concise (#20960)	3 years ago
nametoolong	63b379c2d9	Fix N+1 queries from in NotificationsController (#21202) ... Co-authored-by: Nonexistent <nx@example.org>	3 years ago
Effy Elden	441cac758f	Allow adding relays while secure mode & limited federation mode are enabled (#22324)	3 years ago
Francis Murillo	5fb1c3e934	Revoke all authorized applications on password reset (#21325) ... * Clear sessions on password change * Rename User::clear_sessions to revoke_access for a clearer meaning * Add reset paassword controller test * Use User.find instead of User.find_for_authentication for reset password test * Use redirect and render for better test meaning in reset password Co-authored-by: Effy Elden <effy@effy.space>	3 years ago
Francis Murillo	f6492a7c4d	Log admin approve and reject account (#22088) ... * Log admin approve and reject account * Add unit tests for approve and reject logging	3 years ago
Claire	69137f4a90	Fix irreversible and whole_word parameters handling in /api/v1/filters (#21988) ... Fixes #21965	3 years ago
Claire	68d1df8bc3	Fix some performance issues with /admin/instances (#21907) ... /admin/instances?availability=failing remains wholly unefficient	3 years ago
Claire	51a33ce77a	Fix not being able to follow more than one hashtag (#21285) ... Fixes regression from #20860	3 years ago
Claire	48e136605a	Fix form-action CSP directive for external login (#20962)	3 years ago
Claire	4ae97a2e4c	Fix OAuth flow being broken by recent CSP change (#20958)	3 years ago
lenore gilbert	c373148b3d	Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes (#20597) ... * Allow import/export of instance-level domain blocks/allows (#1754) * Allow import/export of instance-level domain blocks/allows. Fixes #15095 * Pacify circleci * Address simple code review feedback * Add headers to exported CSV * Extract common import/export functionality to AdminExportControllerConcern * Add additional fields to instance-blocked domain export * Address review feedback * Split instance domain block/allow import/export into separate pages/controllers * Address code review feedback * Pacify DeepSource * Work around Paperclip::HasAttachmentFile for Rails 6 * Fix deprecated API warning in export tests * Remove after_commit workaround (cherry picked from commit 94e98864e3) * Add confirmation page when importing blocked domains (#1773) * Move glitch-soc-specific strings to glitch-soc-specific locale files * Add confirmation page when importing blocked domains (cherry picked from commit b91196f4b7) * Fix authorization check in domain blocks controller (cherry picked from commit 7527937758) * Fix error strings for domain blocks and email-domain blocks Corrected issue with non-error message used for Mastodon:NotPermittedError in Domain Blocks Corrected issue Domain Blocks using the Email Domain Blocks message on ActionContoller::ParameterMissing Corrected issue with Email Domain Blocks using the not_permitted string from "custom emojii's" * Ran i18n-tasks normalize to address test failure * Removed unused admin.export_domain_blocks.not_permitted string Removing unused string as indicated by Check i18n * Fix tests (cherry picked from commit 9094c2f52c) * Fix domain block export not exporting blocks with only media rejection (cherry picked from commit 26ff48ee48) * Fix various issues with domain block import - stop using Paperclip for processing domain allow/block imports - stop leaving temporary files - better error handling - assume CSV files are UTF-8-encoded (cherry picked from commit cad824d8f501b95377e4f0a957e5a00d517a1902) Co-authored-by: Levi Bard <taktaktaktaktaktaktaktaktaktak@gmail.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Claire	cbb0153bd0	Fix invalid/empty RSS feed link on account pages (#20772) ... Fixes #20770	3 years ago
trwnh	7fdeed5fbc	Make tag following idempotent (#20860)	3 years ago
Claire	00b2720ef0	Change automatic post deletion configuration to be accessible to redirected users (#20774) ... Fixes #20550	3 years ago
trwnh	e1f819fd78	Fix pagination of followed tags (#20861) ... * Fix missing pagination headers on followed tags * Fix typo	3 years ago
Daniel Axtens	4d85c27d1a	Add 'private' to Cache-Control, match Rails expectations (#20608) ... Several controlers set quite intricate Cache-Control headers in order to hopefully not be cached by any intermediate proxies or local caches. Unfortunately, these headers are processed by ActionDispatch::HTTP::Cache in a way that squashes and discards any values set alongside no-store other than private: 8015c2c2cf/actionpack/lib/action_dispatch/http/cache.rb (L207-L209) We want to preserve no-store on these responses, but we might as well remove parts that are going to be dropped anyway. As many of the endpoints in these controllers are private to a particular user, we should also add "private", which will be preserved alongside no-store.	3 years ago
trwnh	b59ce0a60f	Move V2 Filter methods under /api/v2 prefix (#20622) ... * Move V2 Filter methods under /api/v2 prefix * move over the tests too	3 years ago
Eugen Rochko	b31afc6294	Fix error when passing unknown filter param in REST API (#20626) ... Fix #19156	3 years ago
Eugen Rochko	167d86d21d	Fix `role_ids` not accepting arrays in admin API (#20625) ... Fix #19157	3 years ago
Claire	86f6631d28	Remove dead code and refactor status threading code (#20357) ... * Remove dead code * Remove unneeded/broken parameters and refactor descendant computation	3 years ago
Claire	1615c3eb6e	Change logged out /api/v1/statuses/:id/context logged out limits (#20355)	3 years ago
James Tucker	78a6b871fe	Improve performance by avoiding regex construction (#20215) ... ```ruby 10.times { p /#{FOO}/.object_id } 10.times { p FOO_RE.object_id } ```	3 years ago
Eugen Rochko	0cd0786aef	Revert filtering public timelines by locale by default (#20294)	3 years ago
trwnh	89e1974f30	Make account endorsements idempotent (fix #19045) (#20118) ... * Make account endorsements idempotent (fix #19045) * Accept suggestion to use exists? instead of find_by + nil check Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> * fix logic (unless, not if) * switch to using `find_or_create_by!` Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	3 years ago
trwnh	68d9dcd425	Fix uncaught 500 error on invalid `replies_policy` (Fix #19097) (#20126)	3 years ago
Claire	1e1289b024	Fix crash when external auth provider has no display_name set (#19962) ... Fixes #19913	3 years ago
Claire	4cb2323458	Fix crash in legacy filter creation controller (#19878)	3 years ago
Eugen Rochko	3a41fccc43	Change `AUTHORIZED_FETCH` to not block unauthenticated REST API access (#19803) ... New environment variable `DISALLOW_UNAUTHENTICATED_API_ACCESS`	3 years ago
Claire	c2170991c7	Fix reblogs being discarded after the reblogged status (#19731)	3 years ago
Claire	125322718b	Fix inaccurate admin log entry for re-sending confirmation e-mails (#19674) ... Fixes #19593	3 years ago
Eugen Rochko	15bae3e0e4	Change post-processing to be deferred only for large media types (#19617)	3 years ago
Claire	bb1ef11c30	Change featured hashtag deletion to be done synchronously (#19590)	3 years ago
Eugen Rochko	26478f461c	Remove language filtering from hashtag timelines (#19563)	3 years ago
Claire	a529d6d93e	Fix invites (#19560) ... Fixes #19507 Fix regression from #19296	3 years ago
Eugen Rochko	276b85bc91	Fix admin APIs returning deleted object instead of empty object upon delete (#19479) ... Fix #19153	3 years ago
Eugen Rochko	5724da0780	Fix language not being saved when editing status (#19543) ... Fix #19542	3 years ago
Eugen Rochko	3e18e05330	Fix uncaught error when invalid date is supplied to API (#19480) ... Fix #19213	3 years ago
Eugen Rochko	f8ca3bb2a1	Add ability to view previous edits of a status in admin UI (#19462) ... * Add ability to view previous edits of a status in admin UI * Change moderator access to posts to be controlled by a separate policy	3 years ago
Eugen Rochko	1ae508bf2f	Change unauthenticated search to not support pagination in REST API (#19326) ... - Only exact search matches for queries with < 5 characters - Do not support queries with `offset` (pagination) - Return HTTP 401 on truthy `resolve` instead of overriding to false	3 years ago
Eugen Rochko	487d81fb92	Fix IP blocks not having a unique index (#19456)	3 years ago
Yamagishi Kazutoshi	45d3b32488	Fix `Settings::FeaturedTagsController` (#19418) ... Regression from #19409	3 years ago
Takeshi Umeda	74ead7d106	Change featured tag updates to add/remove activity (#19409) ... * Change featured tag updates to add/remove activity * Fix to check for the existence of feature tag * Rename service and worker * Merge AddHashtagSerializer with AddSerializer * Undo removal of sidekiq_options	3 years ago
Eugen Rochko	7c152acb2c	Change settings area to be separated into categories in admin UI (#19407) ... And update all descriptions	3 years ago
Eugen Rochko	839f893168	Change public accounts pages to mount the web UI (#19319) ... * Change public accounts pages to mount the web UI * Fix handling of remote usernames in routes - When logged in, serve web app - When logged out, redirect to permalink - Fix `app-body` class not being set sometimes due to name conflict * Fix missing `multiColumn` prop * Fix failing test * Use `discoverable` attribute to control indexing directives * Fix `<ColumnLoading />` not using `multiColumn` * Add `noindex` to accounts in REST API * Change noindex directive to not be rendered by default before a route is mounted * Add loading indicator for detailed status in web UI * Fix missing indicator appearing while account is loading in web UI	3 years ago
Takeshi Umeda	b0e3f0312c	Add synchronization of remote featured tags (#19380) ... * Add LIMIT of featured tag to instance API response * Add featured_tags_collection_url to Account * Add synchronization of remote featured tags * Deliver update activity when updating featured tag * Remove featured_tags_collection_url * Revert "Add featured_tags_collection_url to Account" This reverts commit cff349fc27. * Add hashtag sync from featured collections * Fix tag name normalize * Add target option to fetch featured collection * Refactor fetch_featured_tags_collection_service * Add LIMIT of featured tag to v1/instance API response	3 years ago
prplecake	c618d3a0a5	Make "No $entity selected" errors more accurate (#19356) ... Previously all controllers would use the single "No accounts changed as none were selected" message. This commit changes them to read "tags", "posts", "emojis", etc. where necessary.	3 years ago
Eugen Rochko	1bd00036c2	Change about page to be mounted in the web UI (#19345)	3 years ago
Eugen Rochko	45ebdb72ca	Add support for language preferences for trending statuses and links (#18288)	3 years ago
Eugen Rochko	a2ba011326	Change privacy policy to be rendered in web UI, add REST API (#19310) ... Source string no longer localized, Markdown instead of raw HTML	3 years ago
Eugen Rochko	93f340a4bf	Remove setting that disables account deletes (#17683)	3 years ago
Eugen Rochko	62782babd0	Change public statuses pages to mount the web UI (#19301)	3 years ago
Eugen Rochko	58d5b28cb0	Remove previous landing page (#19300)	3 years ago
Eugen Rochko	679274465b	Add server rules to sign-up flow (#19296)	3 years ago
Eugen Rochko	9f65909f42	Change public timelines to be filtered by current locale by default (#19291) ... In the absence of an opt-in to multiple specific languages in the preferences, it makes more sense to filter by the user's presumed language only (interface language or `lang` override)	3 years ago
Eugen Rochko	d2528b26b6	Add server banner to web app, add `GET /api/v2/instance` to REST API (#19294)	3 years ago
Claire	cedcece0cc	Fix deleted pinned posts potentially counting towards the pinned posts limit (#19005) ... Fixes #18938	3 years ago
Eugen Rochko	02ba9cfa35	Remove code for rendering public and hashtag timelines outside the web UI (#19257)	3 years ago
Eugen Rochko	36f4c32a38	Change path of privacy policy page (#19249)	3 years ago
Eugen Rochko	43b5d5e38d	Add logged-out access to the web UI (#18961)	3 years ago
Eugen Rochko	0d6b878808	Add user content translations with configurable backends (#19218)	3 years ago
Claire	8cf7006d4e	Refactor ActivityPub handling to prepare for non-Account actors (#19212) ... * Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is specifically required to be an Account * Refactor SignatureVerification to allow non-Account actors * fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService * Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors * Refactor inbound ActivityPub payload processing to accept non-Account actors * Refactor inbound ActivityPub processing to accept activities relayed through non-Account * Refactor how Account key URIs are built * Refactor Request and drop unused key_id_format parameter * Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`	3 years ago
Claire	84aff598ea	Fix typo in SignatureVerification (#19209) ... Fix regression from #15605	3 years ago
Eugen Rochko	50948b46aa	Add ability to filter followed accounts' posts by language (#19095)	3 years ago
Claire	1145dbd327	Improve error reporting and logging when processing remote accounts (#15605) ... * Add a more descriptive PrivateNetworkAddressError exception class * Remove unnecessary exception class to rescue clause * Remove unnecessary include to JsonLdHelper * Give more neutral error message when too many webfinger redirects * Remove unnecessary guard condition * Rework how “ActivityPub::FetchRemoteAccountService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteAccountService#call (default/previous behavior). * Rework how “ActivityPub::FetchRemoteKeyService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteKeyService#call (default/previous behavior). * Fix Webfinger::RedirectError not being a subclass of Webfinger::Error * Add suppress_errors option to ResolveAccountService Defaults to true (to preserve previous behavior). If set to false, errors will be raised instead of caught, allowing the caller to be informed of what went wrong. * Return more precise error when failing to fetch account signing AP payloads * Add tests * Fixes * Refactor error handling a bit * Fix various issues * Add specific error when provided Digest is not 256 bits of base64-encoded data * Please CodeClimate * Improve webfinger error reporting	3 years ago
Claire	2750a7a0e6	Fix REST API sometimes returning HTML on error (#19135) ... Fixes #19115	3 years ago
Eugen Rochko	c57907737a	Change search API to be accessible without being logged in (#18963) ... But with the resolve option turned off	3 years ago
Eugen Rochko	c99c106ef0	Change following and followers API to be accessible without being logged in (#18964)	3 years ago
Eugen Rochko	2a7766dcc9	Add admin API for managing e-mail domain blocks (#19066)	3 years ago
Eugen Rochko	c556c3a0d1	Add admin API for managing canonical e-mail blocks (#19067)	3 years ago
Eugen Rochko	b399d79545	Add admin API for managing IP blocks (#19065)	3 years ago
Eugen Rochko	0b3e4fd5de	Remove digest e-mails (#17985) ... * Remove digest e-mails * Remove digest-related code	3 years ago
Eugen Rochko	5b0e8cc92b	Add ability to select all accounts matching search for batch actions (#19053)	3 years ago
Eugen Rochko	0396acf39e	Add audit log entries for user roles (#19040) ... * Refactor audit log schema * Add audit log entries for user roles	3 years ago
Claire	50487db122	Add ability to filter individual posts (#18945) ... * Add database table for status-specific filters * Add REST endpoints, entities and attributes * Show status filters in /filters interface * Perform server-side filtering for individual posts filters * Fix filtering on context mismatch * Refactor `toServerSideType` by moving it to its own module * Move loupe and delete icons to their own module * Add ability to filter individual posts from WebUI * Replace keyword list by warnings (expired, context mismatch) * Refactor server-side filtering code * Add tests	3 years ago
Eugen Rochko	d83faa1a89	Add ability to block sign-ups from IP (#19037)	3 years ago
Claire	726931fe4a	Fix /api/v1/tags/:id route constraints (#18854) ... The constraint was applied prior to decoding, and rejected anything containing the '%' character, which would be used for anything with non-ASCII unicode characters.	3 years ago
Eugen Rochko	c3f0621a59	Add ability to follow hashtags (#18809)	3 years ago
Eugen Rochko	e7aa2be828	Change how hashtags are normalized (#18795) ... * Change how hashtags are normalized * Fix tests	3 years ago
Eugen Rochko	44b2ee3485	Add customizable user roles (#18641) ... * Add customizable user roles * Various fixes and improvements * Add migration for old settings and fix tootctl role management	3 years ago
Claire	02851848e9	Revamp post filtering system (#18058) ... * Add model for custom filter keywords * Use CustomFilterKeyword internally Does not change the API * Fix /filters/edit and /filters/new * Add migration tests * Remove whole_word column from custom_filters (covered by custom_filter_keywords) * Redesign /filters Instead of a list, present a card that displays more information and handles multiple keywords per filter. * Redesign /filters/new and /filters/edit to add and remove keywords This adds a new gem dependency: cocoon, as well as a npm dependency: cocoon-js-vanilla. Those are used to easily populate and remove form fields from the user interface when manipulating multiple keyword filters at once. * Add /api/v2/filters to edit filter with multiple keywords Entities: - `Filter`: `id`, `title`, `filter_action` (either `hide` or `warn`), `context` `keywords` - `FilterKeyword`: `id`, `keyword`, `whole_word` API endpoits: - `GET /api/v2/filters` to list filters (including keywords) - `POST /api/v2/filters` to create a new filter `keywords_attributes` can also be passed to create keywords in one request - `GET /api/v2/filters/:id` to read a particular filter - `PUT /api/v2/filters/:id` to update a new filter `keywords_attributes` can also be passed to edit, delete or add keywords in one request - `DELETE /api/v2/filters/:id` to delete a particular filter - `GET /api/v2/filters/:id/keywords` to list keywords for a filter - `POST /api/v2/filters/:filter_id/keywords/:id` to add a new keyword to a filter - `GET /api/v2/filter_keywords/:id` to read a particular keyword - `PUT /api/v2/filter_keywords/:id` to edit a particular keyword - `DELETE /api/v2/filter_keywords/:id` to delete a particular keyword * Change from `irreversible` boolean to `action` enum * Remove irrelevent `irreversible_must_be_within_context` check * Fix /filters/new and /filters/edit with update for filter_action * Fix Rubocop/Codeclimate complaining about task names * Refactor FeedManager#phrase_filtered? This moves regexp building and filter caching to the `CustomFilter` class. This does not change the functional behavior yet, but this changes how the cache is built, doing per-custom_filter regexps so that filters can be matched independently, while still offering caching. * Perform server-side filtering and output result in REST API * Fix numerous filters_changed events being sent when editing multiple keywords at once * Add some tests * Use the new API in the WebUI - use client-side logic for filters we have fetched rules for. This is so that filter changes can be retroactively applied without reloading the UI. - use server-side logic for filters we haven't fetched rules for yet (e.g. network error, or initial timeline loading) * Minor optimizations and refactoring * Perform server-side filtering on the streaming server * Change the wording of filter action labels * Fix issues pointed out by linter * Change design of “Show anyway” link in accordence to review comments * Drop “irreversible” filtering behavior * Move /api/v2/filter_keywords to /api/v1/filters/keywords * Rename `filter_results` attribute to `filtered` * Rename REST::LegacyFilterSerializer to REST::V1::FilterSerializer * Fix systemChannelId value in streaming server * Simplify code by removing client-side filtering code The simplifcation comes at a cost though: filters aren't retroactively applied anymore.	3 years ago
Claire	35588d09e2	Add /api/v1/admin/domain_allows (#18668) ... - `GET /api/v1/admin/domain_allows` lists allowed domains - `GET /api/v1/admin/domain_allows/:id` shows one by ID - `DELETE /api/v1/admin/domain_allows/:id` deletes a given domain from the list of allowed domains - `POST /api/v1/admin/domain_allows` to allow a new domain: if that domain is already allowed, the existing DomainAllow will be returned	3 years ago
tateisu	47f2ff617d	use Notification::TYPES for api push subscription alerts (#18709)	3 years ago
Claire	327eed0076	Fix suspicious sign-in mails never being sent (#18599) ... * Add tests * Fix suspicious sign-in mails never being sent	3 years ago
Eugen Rochko	a2871cd747	Add administrative webhooks (#18510) ... * Add administrative webhooks * Fix error when webhook is deleted before delivery worker runs	4 years ago
Claire	28329ba62f	Add /api/v1/admin/domain_blocks (#18247) ... * Add /api/v1/admin/domain_blocks Fixes #18140 - `GET /api/v1/admin/domain_blocks` lists domain blocks - `GET /api/v1/admin/domain_blocks/:id` shows one by ID - `DELETE /api/v1/admin/domain_blocks/:id` deletes a given domain block - `POST /api/v1/admin/domain_blocks` to create a new domain block: if it conflicts with an existing one, returns an error with an attribute `existing_domain_block` with the rendered domain block * Simplify conflict handling as suggested in review	4 years ago
Eugen Rochko	9f81b9f29a	Fix suspended users being able to access APIs that don't require a user (#18524)	4 years ago
Eugen Rochko	96129c2f10	Fix confirmation redirect to app without `Location` header (#18523)	4 years ago
Claire	440eb71310	Change unapproved and unconfirmed account to not be accessible in the REST API (#17530) ... * Change unapproved and unconfirmed account to not be accessible in the REST API * Change Account#searchable? to reject unconfirmed and unapproved users * Disable search for unapproved and unconfirmed users in Account.search_for * Disable search for unapproved and unconfirmed users in Account.advanced_search_for * Remove unconfirmed and unapproved accounts from Account.searchable scope * Prevent mentions to unapproved/unconfirmed accounts * Fix some old tests for Account.advanced_search_for * Add some Account.advanced_search_for tests for existing behaviors * Add some tests for Account.search_for * Add Account.advanced_search_for tests unconfirmed and unapproved accounts * Add Account.searchable tests * Fix Account.without_unapproved scope potentially messing with previously-applied scopes * Allow lookup of unconfirmed/unapproved accounts through /api/v1/accounts/lookup This is so that the API can still be used to check whether an username is free to use.	4 years ago
Eugen Rochko	6cf57c6765	Refactor how Redis locks are created (#18400) ... * Refactor how Redis locks are created * Fix autorelease duration on account deletion lock	4 years ago
Eugen Rochko	2b8dc58b7f	Change RSS feeds (#18356) ... * Change RSS feeds - Use date and time for titles instead of ellipsized text - Use full content in body, even when there is a content warning - Use media extensions * Change feed icons and add width and height attributes to custom emojis * Fix custom emoji animate on hover breaking * Fix tests	4 years ago
Claire	9a3be0ad68	Fix error when looking handle with surrounding spaces (#18225)	4 years ago
Eugen Rochko	33f3818d66	Fix double render error when authorizing interaction (#18203)	4 years ago
Eugen Rochko	5a48bf1085	Fix error when trying to revoke OAuth token without supplying a token (#18205)	4 years ago
Claire	66a63d79ea	Fix 500 error when a bookmark or favorite has been reported and deleted (#18174)	4 years ago
Eugen Rochko	3917353645	Fix single Redis connection being used across all threads (#18135) ... * Fix single Redis connection being used across all Sidekiq threads * Fix tests	4 years ago
0x2019	012537452a	Fix error resposes for `from` search prefix (#17963) ... * Fix error responses in `from` search prefix (addresses mastodon/mastodon#17941) Using unsupported prefixes now reports a 422; searching for posts from an account the instance is not aware of reports a 404. TODO: The UI for this on the front end is abysmal. Searching `from:username@domain` now succeeds when `domain` is the local domain; searching `from:@username(@domain)?` now works as expected. * Remove unused methods on new Error classes as they are not being used Currently when `raise`d there are error messages being supplied, but this is not actually being used. The associated `raise`s have been edited accordingly. * Remove needless comments * Satisfy rubocop * Try fixing tests being unable to find AccountFindingConcern methods * Satisfy rubocop * Simplify `from` prefix logic This incorporates @ClearlyClaire's suggestion (see https://github.com/mastodon/mastodon/pull/17963#pullrequestreview-933986737). Accepctable account strings in `from:` clauses are more lenient than before this commit; for example, `from:@user@example.org@asnteo +cat` will not error, and return posts by @user@example.org containing the word "cat". This is more consistent with how Mastodon matches mentions in statuses. In addition, `from` clauses will not be checked for syntatically invalid usernames or domain names, simply 404ing when `Account.find_remote!` raises ActiveRecord::NotFound. New code for this PR that is no longer used has been removed.	4 years ago
Claire	3906dd67ed	Fix extremely rare race condition when deleting a toot or account (#17994)	4 years ago
Eugen Rochko	8e20e16cf0	Change e-mail notifications to only be sent when recipient is offline (#17984) ... * Change e-mail notifications to only be sent when recipient is offline Change the default for follow and mention notifications back on * Add preference to always send e-mail notifications * Change wording	4 years ago
Eugen Rochko	465ee7792f	Fix pagination header on empty trends responses in REST API (#17986)	4 years ago
Eugen Rochko	6221b36b27	Remove sign-in token authentication, instead send e-mail about new sign-in (#17970)	4 years ago
Claire	62c6e12fa5	Fix admin API unconditionally requiring CSRF token (#17975) ... Fixes #17898 Since #17204, the admin API has only been available through the web application because of the unconditional requirement to provide a valid CSRF token. This commit changes it back to `null_session`, which should make it work both with session-based authentication (provided a CSRF token) and with a bearer token.	4 years ago
Eugen Rochko	d116cb7733	Fix `GET /api/v1/trends/tags` missing `offset` param in REST API (#17973)	4 years ago
Claire	894956e20c	Fix /api/v1/admin/accounts (#17887) ... * Fix /api/v1/admin/accounts Compatibility was broken since #17009 which changed the underlying filter class without changing the controller. This commits restore support for the old parameters. * Add /api/v2/admin/accounts with the new parameters * Add tests * Add missing filter for `silenced` status Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>	4 years ago
Eugen Rochko	cefa526c6d	Refactor formatter (#17828) ... * Refactor formatter * Move custom emoji pre-rendering logic to view helpers * Move more methods out of Formatter * Fix code style issues * Remove Formatter * Add inline poll options to RSS feeds * Remove unused helper method * Fix code style issues * Various fixes and improvements * Fix test	4 years ago
Eugen Rochko	e3a2203061	Add offset pagination to trends in REST API (#17872)	4 years ago
Eugen Rochko	67d550830b	Fix locale not being set in REST API (#17847)	4 years ago
Eugen Rochko	e6ffbfb5e7	Add `types` param to `GET /api/v1/notifications` in REST API (#17767) ... * Add `types` param to `GET /api/v1/notifications` in REST API * Improve tests	4 years ago
Eugen Rochko	bc320d6cec	Fix `POST /api/v1/emails/confirmations` not being available after sign-up (#17743)	4 years ago
Eugen Rochko	b2cd34474b	Add rate limit for editing (#17728)	4 years ago
chandrn7	a6ed6845c9	Allow login through OpenID Connect (#16221) ... * added OpenID Connect as an SSO option * minor fixes * added comments, removed an option that shouldn't be set * fixed Gemfile.lock * added newline to end of Gemfile.lock * removed tab from Gemfile.lock * remove chomp * codeclimate changes and small name change to make function's purpose clearer * codeclimate fix * added SSO buttons to /about page * minor refactor * minor style change * removed spurious change * removed unecessary conditional from ensure_valid_username and added support for auth.info.name in user_params_from_auth * minor changes	4 years ago
Eugen Rochko	bd53dd5210	Change design of federation pages in admin UI (#17704) ... * Change design of federation pages in admin UI * Fix query performance in instance media attachments measure * Fix reblogs being included in instance languages dimension	4 years ago
Eugen Rochko	8f6c67bfde	Fix performance of account timelines (#17709) ... * Fix performance of account timelines * Various fixes and improvements * Fix duplicate results being returned Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Fix grouping for pinned statuses scope Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	edf09ec747	Add `/api/v1/accounts/familiar_followers` to REST API (#17700) ... * Add `/api/v1/accounts/familiar_followers` to REST API * Change hide network preference to be stored consistently for local and remote accounts * Add dummy classes to migration * Apply suggestions from code review Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	2ea754b861	Fix duplicate notifications being possible after poll expiration (#17697)	4 years ago
Claire	ff43e54a49	Allow editing media attachments for scheduled toots (#17690) ... Fixes #17676	4 years ago
Eugen Rochko	631e495a79	Change `follow` scope to be covered by `read` and `write` scopes in REST API (#17678) ... Deprecate `follow` scope	4 years ago
Eugen Rochko	e24b14cc74	Fix leak of existence of otherwise inaccessible statuses in REST API (#17684)	4 years ago
Eugen Rochko	02b8d63fce	Fix report category not being saved in REST API (#17682)	4 years ago
Eugen Rochko	25d3dc4373	Add ability to mark statuses as sensitive from reports in admin UI (#17668) ... * Add ability to mark statuses as sensitive from reports in admin UI * Allow mark as sensitive action on statuses with preview cards	4 years ago
Claire	14919fe11e	Change old moderation strikes to be displayed in a separate page (#17566) ... * Change old moderation strikes to be displayed in a separate page Fixes #17552 This changes the moderation strikes displayed on `/auth/edit` to be those from the past 3 months, and make all moderation strikes targeting the current user available in `/disputes`. * Add short description of what the strikes page is for * Move link to list of strikes to “Account status” instead of navigation item * Normalize i18n file * Fix layout and styling of strikes link * Revert highlights_on regexp * Reintroduce account status summary - this way, “Account status” is never empty - account status is not necessarily bound to strikes, or recent strikes	4 years ago
Eugen Rochko	50ea54b3ed	Change authorized applications page (#17656) ... * Change authorized applications page * Hide revoke button for superapps and suspended accounts * Clean up db/schema.rb	4 years ago
Claire	6aef76b5cd	Fix error when a MX is shared across blocked domains (#17650)	4 years ago
Eugen Rochko	27965ce5ed	Add trending statuses (#17431) ... * Add trending statuses * Fix dangling items with stale scores in localized sets * Various fixes and improvements - Change approve_all/reject_all to approve_accounts/reject_accounts - Change Trends::Query methods to not mutate the original query - Change Trends::Query#skip to offset - Change follow recommendations to be refreshed in a transaction * Add tests for trending statuses filtering behaviour * Fix not applying filtering scope in controller	4 years ago
Eugen Rochko	a29a982eaa	Change e-mail domain blocks to block IPs dynamically (#17635) ... * Change e-mail domain blocks to block IPs dynamically * Update app/workers/scheduler/email_domain_block_refresh_scheduler.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> * Update app/workers/scheduler/email_domain_block_refresh_scheduler.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	4 years ago
Eugen Rochko	7b816eb5ae	Add notifications for new sign-ups (#16953)	4 years ago
dependabot[bot]	2e89067d21	Bump pundit from 2.1.1 to 2.2.0 (#17543) ... * Bump pundit from 2.1.1 to 2.2.0 Bumps [pundit](https://github.com/varvet/pundit) from 2.1.1 to 2.2.0. - [Release notes](https://github.com/varvet/pundit/releases) - [Changelog](https://github.com/varvet/pundit/blob/main/CHANGELOG.md) - [Commits](https://github.com/varvet/pundit/compare/v2.1.1...v2.2.0) --- updated-dependencies: - dependency-name: pundit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * `include Pundit` is deprecated Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	4 years ago
Eugen Rochko	de448ab1b5	Change global `locale` param to `lang` to avoid conflicts (#17592)	4 years ago
Claire	ac99f586bb	Fix issues when attempting to appeal an old strike (#17554) ... * Display an error when an appeal could not be submitted * Do not offer users to appeal old strikes * Fix 500 error when trying to appeal a strike that is too old * Avoid using an extra translatable string	4 years ago
Eugen Rochko	564efd0651	Add appeals (#17364) ... * Add appeals * Add ability to reject appeals and ability to browse pending appeals in admin UI * Add strikes to account page in settings * Various fixes and improvements - Add separate notification setting for appeals, separate from reports - Fix style of links in report/strike header - Change approving an appeal to not restore statuses (due to federation complexities) - Change style of successfully appealed strikes on account settings page - Change account settings page to only show unappealed or recently appealed strikes * Change appealed_at to overruled_at * Fix missing method error	4 years ago
Claire	7396a254c1	Fix empty batch statuses selection causing a 500 error (#17532) ... * Fix empty batch statuses selection causing a 500 error * Simplify current_params	4 years ago
Eugen Rochko	8f03b7a2fb	Add notifications when a reblogged status has been updated (#17404) ... * Add notifications when a reblogged status has been updated * Change wording to say "edit" instead of "update" and add missing controls * Replace previous update notifications with the most up-to-date one	4 years ago
Eugen Rochko	d0fcf07436	Change actions in reports to require only one click (#17487)	4 years ago
Eugen Rochko	63002cde03	Add editing for published statuses (#17320) ... * Add editing for published statuses * Fix change of multiple-choice boolean in poll not resetting votes * Remove the ability to update existing media attachments for now	4 years ago
Eugen Rochko	2f8159baad	Add `category` and `rule_ids` params to `POST /api/v1/reports` (#17492)	4 years ago
Eugen Rochko	fd3a45e348	Add edit history to web UI (#17390) ... * Add edit history to web UI * Change history reducer to store items per status * Fix missing loading prop	4 years ago
Eugen Rochko	85b86fe28c	Add global `locale` param (#17464) ... - Remove the session-based locale stickyness	4 years ago
Claire	73a782391c	Fix replies collection incorrectly looping (#17462) ... * Refactor tests * Add tests * Fix replies collection incorrectly looping	4 years ago
Claire	92658f0fb0	Fix instance actor not being dereferenceable (#17457) ... * Add tests * Fix instance actor not being dereferenceable * Fix tests * Fix tests for real	4 years ago
Eugen Rochko	e03e7ac290	Fix error on account relationships page in admin UI (#17444)	4 years ago
Claire	f5639e1cbe	Change public profile pages to be disabled for unconfirmed users (#17385) ... Fixes #17382 Note that unconfirmed and unapproved accounts can still be searched for and their (empty) account retrieved using the REST API.	4 years ago
Claire	03d59340da	Fix Sidekiq warnings about JSON serialization (#17381) ... * Fix Sidekiq warnings about JSON serialization This occurs on every symbol argument we pass, and every symbol key in hashes, because Sidekiq expects strings instead. See https://github.com/mperham/sidekiq/pull/5071 We do not need to change how workers parse their arguments because this has not changed and we were already converting to symbols adequately or using `with_indifferent_access`. * Set Sidekiq to raise on unsafe arguments in test mode In order to more easily catch issues that would produce warnings in production code.	4 years ago
Claire	bddd9ba36d	Add OMNIAUTH_ONLY environment variable to enforce externa log-in (#17288) ... * Remove support for OAUTH_REDIRECT_AT_SIGN_IN Fixes #15959 Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form to instead redirect to the external OmniAuth login provider. However, it did not prevent the log-in form on /about introduced by #10232 from appearing, and completely broke with the introduction of #15228. As I restoring that previous log-in flow without introducing a security vulnerability may require extensive care and knowledge of how OmniAuth works, this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time being. * Add OMNIAUTH_ONLY environment variable to enforce external log-in only * Disable user registration when OMNIAUTH_ONLY is set to true * Replace log-in links When OMNIAUTH_ONLY is set with exactly one OmniAuth provider	4 years ago
Claire	cfa583fa71	Remove support for OAUTH_REDIRECT_AT_SIGN_IN (#17287) ... Fixes #15959 Introduced in #6540, OAUTH_REDIRECT_AT_SIGN_IN allowed skipping the log-in form to instead redirect to the external OmniAuth login provider. However, it did not prevent the log-in form on /about introduced by #10232 from appearing, and completely broke with the introduction of #15228. As I restoring that previous log-in flow without introducing a security vulnerability may require extensive care and knowledge of how OmniAuth works, this commit removes support for OAUTH_REDIRECT_AT_SIGN_IN instead for the time being.	4 years ago
Eugen Rochko	1060666c58	Add support for editing for published statuses (#16697) ... * Add support for editing for published statuses * Fix references to stripped-out code * Various fixes and improvements * Further fixes and improvements * Fix updates being potentially sent to unauthorized recipients * Various fixes and improvements * Fix wrong words in test * Fix notifying accounts that were tagged but were not in the audience * Fix mistake	4 years ago