mastodon

Commit Graph

Author	SHA1	Message	Date
Eugen Rochko	a0d4129893	Refactor notifications to go through a separate stream in streaming API (#16765 ) Eliminate need to have custom notifications filtering logic in the streaming API code by publishing notifications into a separate stream and then simply using the multi-stream capability to subscribe to that stream when necessary	3 years ago
Claire	9ac7e6fef7	Fix remotely-suspended accounts' toots being merged back into timelines (#16628 ) * Fix remotely-suspended accounts' toots being merged back into timelines * Mark remotely-deleted accounts as remotely suspended	4 years ago
Holger	0cae6c07bb	Fix #16603 (#16605 ) Fix issue #16603 undefined method `serialize_payload' for Unsuspend Account Service error. It seems that this service forgot to `include Payloadable` so that `serialize_payload` could not be found in this service.	4 years ago
Claire	4ac78e2a06	Add feature to automatically delete old toots (#16529 ) * Add account statuses cleanup policy model * Record last inspected toot to delete to speed up successive calls to statuses_to_delete * Add service to cleanup a given account's statuses within a budget * Add worker to go through account policies and delete old toots * Fix last inspected status id logic All existing statuses older or equal to last inspected status id must be kept by the current policy. This is an invariant that must be kept so that resuming deletion from the last inspected status remains sound. * Add tests * Refactor scheduler and add tests * Add user interface * Add support for discriminating based on boosts/favs * Add UI support for min_reblogs and min_favs, rework UI * Address first round of review comments * Replace Snowflake#id_at_start with with_random parameter * Add tests * Add tests for StatusesCleanupController * Rework settings page * Adjust load-avoiding mechanisms * Please CodeClimate	4 years ago
Claire	763ab0c7eb	Fix owned account notes not being deleted when an account is deleted (#16579 ) * Add account_notes relationship * Add tests * Fix owned account notes not being deleted when an account is deleted * Add post-migration to clean up orphaned account notes	4 years ago
Claire	1d67acb72f	Fix scoped order warning in RemoveStatusService (#16531 ) Fixes “Scoped order is ignored, it's forced to be batch order.”	4 years ago
Claire	d8629e7b86	Add logging of S3-related errors (#16381 )	4 years ago
Claire	9a19227f17	Fix some RedisLocks auto-releasing too fast (#16276 ) * Fix Delete and Create-related locks expiring too fast Fixes #16238 By default, RedisLock expires after 10 seconds, which may not be enough to process statuses, especially when those have attached media files. This commit extends those 10 seconds to 15 minutes, which should be plenty enough to handle any status, while being short enough to not waste many sidekiq job retries in the exceedingly rare case in which a sidekiq process would crash when processing a `Create` or `Delete`. * Fix other RedisLock autorelease durations Fixes #15645 - things that only perform a few simple database queries (e.g. finding and saving a record) have been left unchanged, so they'll still use the default 10s duration - things that perform significantly more complex database queries have been changed to a 5 minutes timeout - things that perform multiple HTTP queries have been changed to a 15 minutes timeout	4 years ago
Takeshi Umeda	c403c3695b	Fix to be able to redownload avatar and header (#16190 ) * Fix to reset if header and avatar download fails * Add RedownloadAvatarWorker and RedownloadHeaderWorker	4 years ago
Claire	afb7882189	Fix blocking someone not clearing up list feeds (#16205 )	4 years ago
Takeshi Umeda	9da5e0b350	Fix webfinger_update_due to run WebFinger on stale activitypub-account (#16182 )	4 years ago
Eugen Rochko	74081433d0	Change trending hashtags to be affected be reblogs (#16164 ) If a status with a hashtag becomes very popular, it stands to reason that the hashtag should have a chance at trending Fix no stats being recorded for hashtags that are not allowed to trend, and stop ignoring bots Remove references to hashtags in profile directory from the code and the admin UI	4 years ago
Eugen Rochko	2c77d97e0d	Add joined date to profiles in web UI (#16169 )	4 years ago
Eugen Rochko	fab65848d2	Fix empty home feed before first follow has finished processing (#16152 ) Change queue of merge worker from pull to default	4 years ago
Eugen Rochko	f627d2eb93	Fix trying to fetch key from empty URI when verifying HTTP signature (#16100 )	4 years ago
Eugen Rochko	daccc07dc1	Change auto-following admin-selected accounts, show in recommendations (#16078 )	4 years ago
Claire	0b36e3419d	Fix processing of remote Delete activities (#16084 ) * Add tests * Ensure deleted statuses are marked as such * Save some redis memory by not storing URIs in delete_upon_arrival values * Avoid possible race condition when processing incoming Deletes * Avoid potential duplicate Delete forwards * Lower lock durations to reduce issues in case of hard crash of the Rails process * Check for `lock.aquired?` and improve comment * Refactor RedisLock usage in app/lib/activitypub * Fix using incorrect or non-existent sender for relaying Deletes	4 years ago
Eugen Rochko	ca3bc1b09f	Refactor StatusReachFinder to handle followers and relays as well (#16051 )	4 years ago
Eugen Rochko	6d6000f61f	Fix remote reporters not receiving suspend/unsuspend activities (#16050 )	4 years ago
Eugen Rochko	dde8739020	Fix reports of already suspended accounts being recorded (#16047 )	4 years ago
Eugen Rochko	619fad6cf8	Remove spam check and dependency on nilsimsa gem (#16011 )	4 years ago
Claire	cbd0ee1d07	Update Mastodon to Rails 6.1 (#15910 ) * Update devise-two-factor to unreleased fork for Rails 6 support Update tests to match new `rotp` version. * Update nsa gem to unreleased fork for Rails 6 support * Update rails to 6.1.3 and rails-i18n to 6.0 * Update to unreleased fork of pluck_each for Ruby 6 support * Run "rails app:update" * Add missing ActiveStorage config file * Use config.ssl_options instead of removed ApplicationController#force_ssl Disabled force_ssl-related tests as they do not seem to be easily testable anymore. * Fix nonce directives by removing Rails 5 specific monkey-patching * Fix fixture_file_upload deprecation warning * Fix yield-based test failing with Rails 6 * Use Rails 6's index_with when possible * Use ActiveRecord::Cache::Store#delete_multi from Rails 6 This will yield better performances when deleting an account * Disable Rails 6.1's automatic preload link headers Since Rails 6.1, ActionView adds preload links for javascript files in the Links header per default. In our case, that will bloat headers too much and potentially cause issues with reverse proxies. Furhermore, we don't need those links, as we already output them as HTML link tags. * Switch to Rails 6.0 default config * Switch to Rails 6.1 default config * Do not include autoload paths in the load path	4 years ago
Claire	5614e6724e	Fix URL scanning in note length validator and preview card fetching (#15827 ) * Add tests * Fix URL scanning in note length validator and preview card fetching	4 years ago
Claire	65db262550	Update twitter-text from 1.14 to 3.1.0 and fix toot character counting (#15382 ) * Update twitter-text from 1.14 to 3.1.0 * Disable emoji parsing * Properly depend on twitter-text for url detection * Fix some URLs being wrongly detected client-side * Add test for server-side validation of non-autolinkable URLs * Fix server-side status length counting	4 years ago
Claire	5f4c0b79c2	Change ResolveAccountService's handling of skip_webfinger (#15750 ) * Change ResolveAccountService's handling of skip_webfinger Change it so it never makes any webfinger query, as the name would imply. * Add tests * Change FollowService to not take an URI for target_account * Restore domain-block check in FollowService * Fix tests	4 years ago
Eugen Rochko	f8972d4503	Fix YouTube embeds failing due to YouTube serving wrong OEmbed URLs (#15716 )	4 years ago
Takeshi Umeda	7f1c56954b	Fix first return value of FetchLinkCardService.html method (#15630 )	4 years ago
luigi	7ea9588520	Use Enumerable#filter_map in more places (#15527 )	4 years ago
luigi	eb51e43fb4	Optimize some regex matching (#15528 ) * Use Regex#match? * Replace =~ too * Avoid to call match? from Nil * Keep value of Regexp.last_match	4 years ago
luigi	087ed84367	Optimize map { ... }.compact calls (#15513 ) * Optimize map { ... }.compact using Enumerable#filter_map, supported since Ruby 2.7 * Add poyfill for Enumerable#filter_map	4 years ago
abcang	efffdd3778	Fix rubocop config and warnings (#15503 ) * disable NewCops * update TargetRubyVersion * Fix Lint/MissingSuper for ActiveModelSerializers::Model * Fix Lint/MissingSuper for feed * Fix Lint/FloatComparison * Do not use instance variables	4 years ago
ThibG	f1f96ebf02	Fix being able to import more than allowed number of follows (#15384 ) * Fix being able to import more than allowed number of follows Without this commit, if someone tries importing a second list of accounts to follow before the first one has been processed, this will queue imports for the two whole lists, even if they exceed the account's allowed number of outgoing follows. This commit changes it so the individual queued imports aren't exempt from the follow limit check (they remain exempt from the rate-limiting check though). * Catch validation errors to not re-queue failed follows Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	e89648574f	Fix error when changing ACL on missing objects during suspension (#15420 )	4 years ago
Eugen Rochko	ba0b79fc5c	Fix undefined method error when batch-removing statuses with ElasticSearch on (#15421 )	4 years ago
ThibG	de57efd055	Fix mentions not being deleted efficiently (#15416 ) As a regression from the recent optimizations, mentions were left untouched until `account.destroy`, which would then delete them individually, and executing queries to find and delete associated notifications, resulting in a massive slowdown. Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	473abc35a1	Fix trying to privatize empty media attachments (#15414 )	4 years ago
ThibG	814b7775fb	Improve performances of deleting favourites when deleting accounts (#15412 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	2ab3e91eaf	Fix BatchedRemoveStatusService not working without ES in rails console (#15408 ) Not a huge deal but may cause surprising failures in custom scripts and development. Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	3249d35bdc	Improve account deletion performances further (#15407 ) * Delete status records by batches of 50 * Do not precompute values that are only used once * Do not generate redis events for removal of public toots older than two weeks * Filter reported toots a priori for polls and status deletion * Do not process reblogs when cleaning up public timelines As in Mastodon proper, reblogs don't appear in public TLs * Clean the deleted account's own feed in one go * Refactor Account#clean_feed_manager and List#clean_feed_manager * Delete instead of destroy a few more associations * Fix preloading Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	f18349640b	Fix batch order warnings in BatchedRemoveStatusService (#15409 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	9915d11c0d	Fix unnecessary queries when batch-removing statuses, 100x faster (#15387 )	4 years ago
ThibG	43961035a9	Fix some notifications not being deleted on poll/status deletion (#15402 ) * Fix deleting polls not deleting notifications * Fix fav notification deletion when deleting a toot * Refactor DeleteAccountService spec * Add DeleteAccountService tests for other associations and notifications * Add favourite handling spec in status removal Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	7bf3c6e57b	Fix AccountDeletionWorker crashing and clogging sidekiq queues (#15380 ) * Fix account deletion workers being queued multiple times for a single account * Fix poll votes being unnecessarily instantiated on poll deletion * Fix favourites being unnecessarily instantiated on status deletion * Remove inaccurate comments * Delete polls instead of destroying them Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	a60d9335d8	Fix resolving accounts sometimes creating duplicate records for a given AP id (#15364 ) * Fix ResolveAccountService accepting mismatching acct: URI * Set attributes that should be updated regardless of suspension * Fix key fetching * Automatically merge remote accounts with duplicate `uri` * Add tests * Add "tootctl accounts fix-duplicates" Finds duplicate accounts sharing a same ActivityPub `id`, re-fetch them and merge them under the canonical `acct:` URI. Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	eb35be0431	Fix follow limit preventing re-following of a moved account (#14207 )	4 years ago
ThibG	b1feb47055	Improve searching for private toots from URL (#14856 ) * Improve searching for private toots from URL Most of the time, when sharing toots, people use the toot URL rather than the toot URI, which makes sense since it is the user-facing URL. In Mastodon's case, the URL and URI are different, and Mastodon does not have an index on URL, which means searching a private toot by URL is done with a slow query that will only succeed for very recent toots. This change gets rid of the slow query, and attempts to guess the URI from URL instead, as Mastodon's are predictable. * Add tests * Only return status with guessed uri if url matches Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	1390cc194b	Add indication to admin UI of whether a report has been forwarded (#13237 ) * Add indication to admin UI of whether a report has been forwarded * Rework how forwarded status is displayed Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	e7e099d1a0	Fix deletes not reaching every server that interacted with status (#15200 ) Extract logic for determining ActivityPub inboxes to send deletes to to its own class and explicitly include the person the status replied to (even if not mentioned), people who favourited it, and people who replied to it (though that one is still not recursive)	4 years ago
ThibG	66832cbf33	Undo outgoing follows when suspending a remote account (#15188 )	4 years ago
ThibG	8b8004a962	Fix webfinger redirect handling in ResolveAccountService (#15187 ) * Fix webfinger redirect handling in ResolveAccountService ResolveAccountService#process_webfinger! handled a one-step webfinger redirection, but only accepting the result if it matched the exact URI passed as input, defeating the point of a redirection check. Instead, use the same logic as in `ActivityPub::FetchRemoteAccountService`, updating the resulting `acct:` URI with the result of the first webfinger query. * Add tests	4 years ago

1 2 3 4 5 ...

851 Commits (626eca4d56b574528d33ca553d5b8dab6fb9ac1d)