mastodon

Commit Graph

Author	SHA1	Message	Date
Bramus!	7fbc17afa2	Fix media markup (#21420 ) This brings the markup of the MediaItem component on par with the Item component from media_gallery. Co-authored-by: Effy Elden <effy@effy.space>	3 years ago
Shlee	99d2693071	Update circleci (#21880 ) * Update config.yml * Update config.yml	3 years ago
Claire	2644a28cb3	Change remote media files to be downloaded outside of transactions (#21796 )	3 years ago
Brian Campbell	2d12948220	Fix idempotency when database writes are slow (#21840 ) There is an idempotency key generated by clients when authoring a post, and stored in Redis, to ensure that if a user or client retries posting the same status, we don't get a duplicate. Hachyderm.io has been experiencing some filesystem and database performance issues, causing database writes to be slow. This can mean that there are successful posts, but the reverse proxy returns 504 Gateway Timeout before the idempotency status has been updated; users or clients who retry (such as Tusky which retries automatically, see tuskyapp/Tusky#2951) can re-try the same post with the same idempotency key before it has actually been recorded in Redis, leading to duplicate posts. To address this issue, move all of the database updates after the initial transaction that creates the status into the `postprocess_status!` method, so we can insert the idempotency key immediately after the status has been created, significantly reducing the window in which the status could be created but the idempotency key not yet stored. Note: this has not yet been tested; I'm submitting this PR for discussion and to offer to the Hachyderm.io admins to try out to fix the multiple posting problem. Co-authored-by: Brian Campbell <brcampbell@beta.team>	3 years ago
Claire	ebf1d74e40	Fix being stuck in edit mode when deleting the edited status (#22126 )	3 years ago
Claire	8556a649d5	Fix changing domain block severity not undoing individual account effects (#22135 ) * Fix changing domain block severity not undoing individual account effects Fixes #22133 * Add tests	3 years ago
Effy Elden	1e49be3328	Align everything to Node.js 16 (#22223 ) * Update nvmrc to Node.js 16 * Update package.json minimum Node engine to 16 * Update README requirements to Node.js 16 * Update devcontainer Node.js version to 16 * Update devcontainer Dockerfile Node.js choices to LTS versions that are still in support/maintenance * Pin CircleCI Node image to 16 * Fix YAML type issue * Update CircleCI Node.js to 16.18 to match #22019	3 years ago
Claire	fb1d9789db	Fix attachment rendering of edited posts in OpenGraph (#22270 ) Fixes #22241	3 years ago
Avdi Grimm	8a56587d62	Improve devcontainer for running tests (#22277 ) * Improve devcontainer for running tests - Pull devcontainer post-create out into its own script - Add asset precompilation - Add test-mode asset precompilation (needed to run tests without error) * Document Gemfile.lock re-checkout in devcontainer	3 years ago
Rens Groothuijsen	726c7dea31	Display search popout at fixed screen position (#16463 ) * Display search popout at fixed screen position * Attach search popout to search box	3 years ago
Terence Eden	ff414a5489	Add transparancy to modal background for accessibility (#18081 ) Fixes #18080 This keeps the `ui-base-lighter-color` but adds enough transparency so that text is more easily readable. Tested in Firefox and Chrome.	3 years ago
Arnout Engelen	9f63c428e1	Don't autofocus the compose form (#16517 ) When opening a page such as /web/timelines/home in a desktop browser, the cursor was automatically placed in the textarea of the compose form. When using the keyboard for navigation (using a browser plugin like vimium or vim vixen, or just to hit 'space' to scroll down a page), you have remember to leave the field before using that. Since you only visit the page to write a new post some of the time, this PR attempts to have nothing focused initially (and require the user to click or e.g. use 'tab' to focus the textarea). Tested: * /web/timeslines/home no longer autofocuses the compose box * pressing the 'n' hotkey still focuses the compose box * clicking 'reply' for a post still focuses the compose box * replying to a CW'ed post still focuses the compose box * introducing the CW field still focuses the CW field * introducing the CW field for a reply still focuses the CW field * removing the CW field still focuses the compose box * /web/statuses/new still autofocuses the compose box fixes #15862	3 years ago
Jeong Arm	3656a6b9cc	Add "disabled" user filter for admin/accounts UI (#21282 )	3 years ago
Mina Her	cedf138313	Fix margin for search field on medium window size (#21606 )	3 years ago
David Vega	1b5d207131	Fix single name variables on controller folder (#20092 ) Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com> Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com> Co-authored-by: Effy Elden <effy@effy.space>	3 years ago
Jeong Arm	d412147d02	Save avatar or header correctly even if other one fails (#18465 ) * Save avatar or header correctly if other one fails * Fix test	3 years ago
Luxiaba	8f8c0fe88c	Remove inline-css in logo (#20814 )	3 years ago
Yurii Izorkin	7972e5981c	Add brotli compression (#19025 )	3 years ago
Matthías Páll Gissurarson	1e95fa3df5	Fix punycoded local domains not being prettified in initial state (#21440 )	3 years ago
Meisam	059d64a59e	set activation for tag follow button (#21629 ) Co-authored-by: meisam <meisam@noreply.codeberg.org>	3 years ago
Claire	673c54f114	Fix inability to use local LibreTranslate without setting ALLOWED_PRIVATE_ADDRESSES (#21926 ) Fixes #20029	3 years ago
Claire	bbc49f15e0	Add explanation text to log-in page (#20946 )	3 years ago
Fries	725f21662f	Add Montenegrin (cnr) (#21013 )	3 years ago
Claire	38596e49d4	Fix the top action bar appearing in multi-column layout (#20943 )	3 years ago
Claire	623d3d2e32	Change CSP directives on API to be tight and concise (#20960 )	3 years ago
Kaspar V	19f78ea8fa	linting: RuboCop update, config fixes (#20574 ) * fix(rubocop): update gems and add performance and rspec fix(rubocop): update gems and add performance and rspec - update present rubocop gems - add rubocop-rspec and rubocop-performance gems - move rubocop gems to gem group :development, :test in order to make linting in a github action that runs with RAILS_ENV=test possible * feat(rubocop): disable some annoyance RSpec cops To mee these prooved to be more annoying than helpful. If not agreed, they can be enabled any time. * fix(rubocop): do not ignore spec/*/ Because rubocop-rspec should lint the specs as well, and they deserve to be readable in general. It is relevant code, after all. * fix(rubocop): change ignore db/*/ to db/schema.rb because rails cops do some lints for migrations. E.g. reversable migrations linting and more. * fix(rubocop): tune rules configs Bunch of commits squashed: fix(rubocop): enable Layout/LineLength cop Because this project has code with line lenghts > 500 chars. This is not good practice at all, so I strongly suggest to change the practice in the future. But allow heredoc, URI and comments to still be long lines and make the default Max: 120 explicit, by repeating it in the config. To me this max length seems reasonable. Perhaps a bit more could be ok for some. But > 500 chars in one line Seems to be way too long IMHO. fix(rubocop): Metrics/CyclomaticComplexity Max to 12 The default is 7, perhaps quite strict. But 25 is too loose, the rule becomes pointless like that. fix(rubocop): AllCops ruby version, cacheing and more info - fix the target ruby version from 2.5 to 3.0 - have the cop error messages to be more informative and helpful - enable cacheing in /tmp fix(rubocop): Metrics/AbcSize to 34 from 115 Rubocops default is 17. If the rule is at 115 is becomes pointless. fix(rubocop): Metrics/BlockLength improvements - instead of ignoring tasks completely, ignore only the long blocks that are specific to tasks (task, namespace) - ignore also concern specific block methods (included, class_methods) fix(rubocop): Metrics/ClassLength count heredoc array as one line fix(rubocop): Metrics/MethodLength Max to 25 - the default is 10, but 65 is too loose, so perhaps 25? fix(rubocop): Metrics/ModuleLength array and heredoc count as one fix(rubocop): Metrics/PerceivedComplexity to 16 from 25 Rubocops default is 8, so how about only doubling that, instead of > than tripple it? fix(rubocop): enable Style/RedundantAssignment Because I think that this rule would never really hurt, but improve code quality and readability. fix(rubocop): enable Style/RescueStandardError I think everyone that ever had to debug what this can bring will hopefully agree that this rule totally makes sense. In the super rare exeptions where this is totally needed, it can be excluded by disabling comment in that place. fix(rubocop): Metrics/ParameterLists add explicit defaults and some excludes	3 years ago
Neil Matatall	1f5740e65c	Use Rails tag API to build RSS feed for spoilers and polls (#20163 ) * Use Rails tag API to build RSS feed for spoilers and polls While the previous method did not contain a bug or a potential issue, the tag API can be very resilient against future problems and reduces the amount of manual management of the escape status of the content. I've added tests to ensure that the formatting is broken and still escapes control characters correctly. * this seems cleaner and passes * Incorporate feedback by moving the br to its own line and using the tag helper over the string constant for the br tag itself * whoops, tag helper doesn't use a self-closing tag	3 years ago
Dan Peterson	3d3429243f	Fix default S3_HOSTNAME used in mastodon:setup (#19932 ) s3-us-east-1.amazonaws.com does not exist. Co-authored-by: Effy Elden <effy@effy.space>	3 years ago
Colin Mitchell	22e36271c5	Add environment variable to configure sidekiq concurrency (#19589 ) Co-authored-by: Effy Elden <effy@effy.space>	3 years ago
Nick Schonning	72a8af8088	Fix typo in handler function call name (#21829 )	3 years ago
Connor Shea	08c0e43b6f	Increase the width of the unread notification border. (#21692 ) The smaller border is difficult to see for some users, especially when the browser window was thinner, and so the unread border is at the very left edge of the window.	3 years ago
Francis Murillo	c50e9d078a	Render current day formats in the client timezone (#21878 ) * Fix remaining plain %time to %time.formatted * Add %time.relative-formatted to client format dates on the current day * Add missing comma dangle to formats * Use client side message format instead of the server * Add fallback message to relatve_format.today * Remove unused translation key and fix js lint issue Co-authored-by: Effy Elden <effy@effy.space>	3 years ago
trwnh	f0cebaee00	Add localization for new admin scopes (#20979 ) * Add localization for new admin scopes * run bundle exec i18n-tasks normalize	3 years ago
Ikko Ashimine	baecdf2882	Fix typo in application_helper_spec.rb (#20981 ) enviroment -> environment	3 years ago
Yamagishi Kazutoshi	58200132d0	`FormattedMessage` must be used directly (#20982 ) * `FormattedMessage` must be used directly * rollback	3 years ago
Pleclown	3a59ffde8d	Adding 12 hours option for polls (#21131 ) * Adding 12 hours option for polls Adding 12 hours option for polls * Adding 12 hours option for polls Missing > on a line	3 years ago
Alex Stine	903e5a3f45	Fix hidden label causing accessibility issue for search inputs (#21275 ) * Try unhiding search label. * Use aria-label. Remove label as empty labels are useless. * Remove addition of package-lock.json.	3 years ago
Matt Hodges	4114a7088a	Embed js height fix (#22141 ) * only begin iframe reheight once document state is complete * format * lint fixes * Update public/embed.js to use readystatechange event listener Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Call loaded() if ready, otherwise add listenter * lint fix Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Jeremy Kescher	04c611daa1	Fix being unable to react with the keycap number sign emoji (#22231 ) #⃣ This bug is caused by the emoji consisting of: U+23 # U+FE0F U+20E3 ⃣ Because it starts with a #, it's interpreted as an anchor link, which is not passed to the API. Therefore, the API sees no emoji to react with and answers correctly with a 404.	3 years ago
nametoolong	63b379c2d9	Fix N+1 queries from in NotificationsController (#21202 ) Co-authored-by: Nonexistent <nx@example.org>	3 years ago
luzpaz	596923da4a	Fix typos in source documentation (#21046 ) Fixed 2 source comment/documentation typos	3 years ago
Moritz Heiber	a0813806d6	Add hadolint as Dockerfile linter (#20993 ) * Added hadolint as Dockerfile linter in pipeline and resolved remaining hadolint issues in Dockerfile * Use more specific version of hadolint Action * Bumpt hadolint Action version to latest version to avoid deprecation notice * Being _really_ specific now	3 years ago
Riedler	c3388f4ab1	Fix profile avatar being slightly offset into left border (fixes #20822 ) (#20994 ) * hotfix for #20822 I don't know why it was shifted in the first place or why the width is specified twice, but this fixes the problem, so it looks fine to me. * realigned pfp with content below * fixed formatting my bad * added comment to explain the negative margin before I forget - comments are important ! Co-authored-by: Riedler <riedler@gelse.eu>	3 years ago
s0	52540771b0	Fix crash in elasticsearch_check.rb (#21006 ) Nil unwrap causes the admin dashboard to crash/500 when the Chewy client info version number value is nil. This occurs when running another ES-compatible backend such as MeiliSearch. Obviously it would be good for chewy to recognise upstream but at least avoiding the crash would be fine.	3 years ago
Effy Elden	441cac758f	Allow adding relays while secure mode & limited federation mode are enabled (#22324 )	3 years ago
Claire	7b68e6409b	Fix invalid CSS for links in warning and strike cards (#22302 )	3 years ago
Jeong Arm	e8cc63105f	Don't delivery a reply to domains which are blocked by author (#22117 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Justin Hutchings	e5d15a5b56	Add CodeQL workflow (#21894 )	3 years ago
Claire	bae6ef315e	Fix missing Javascript in domain block import confirmation page (#21471 ) Follow-up to #20597	3 years ago
Francis Murillo	5fb1c3e934	Revoke all authorized applications on password reset (#21325 ) * Clear sessions on password change * Rename User::clear_sessions to revoke_access for a clearer meaning * Add reset paassword controller test * Use User.find instead of User.find_for_authentication for reset password test * Use redirect and render for better test meaning in reset password Co-authored-by: Effy Elden <effy@effy.space>	3 years ago

... 15 16 17 18 19 ...

13325 Commits (6028d047b9f7d14b2617f47b51f6098f686b1b4e) All Branches Search

13325 Commits (6028d047b9f7d14b2617f47b51f6098f686b1b4e)

All Branches