mastodon

Commit Graph

Author	SHA1	Message	Date
Claire	943f27f437	Remove unfollowed hashtag posts from home feed (#26028 )	2 years ago
Nick Schonning	1a6c2e450a	Update rubocop to v1.54.1 (#25627 )	2 years ago
Matt Jankowski	ce43ed144c	Rails 7.0 update (#25668 )	2 years ago
Matt Jankowski	2e1391fdd2	Fix `Naming/MemoizedInstanceVariableName` cop (#25928 )	2 years ago
Matt Jankowski	b8b2470cf8	Fix `Style/SlicingWithRange` cop (#25923 )	2 years ago
Eugen Rochko	93e8a15415	Add forwarding of reported replies to servers being replied to (#25341 )	2 years ago
Claire	b6d173b459	Fix crash in admin interface when viewing a remote user with verified links (#25796 )	2 years ago
Claire	610731b03d	Merge pull request from GHSA-55j9-c3mp-6fcq	2 years ago
Claire	c5929798bf	Merge pull request from GHSA-9pxv-6qvf-pjwc * Fix timeout handling of outbound HTTP requests * Use CLOCK_MONOTONIC instead of Time.now	2 years ago
Claire	eb2417ce99	Fix OAuth apps page crashing when listing apps with certain admin API scopes (#25713 )	2 years ago
Eugen Rochko	ba06a2f104	Revert "Rails 7 update" (#25667 )	2 years ago
Matt Jankowski	50c2a03695	Rails 7 update (#24241 )	2 years ago
Claire	0ccf6c0eb7	Fix batch attachment deletion leaving empty directories (#25587 )	2 years ago
S.H	7a25af64dd	Remove media attachment only when file was exist (#25586 )	2 years ago
Eugen Rochko	bb4756c823	Change files to be deleted in batches instead of one-by-one (#23302 )	2 years ago
Claire	c78280a8ce	Add translate="no" to outgoing mentions and links (#25524 )	2 years ago
Matt Jankowski	e1c9d52e91	Reduce `sleep` time in request pool spec (#25470 )	2 years ago
Nick Schonning	c66250abf1	Autofix Rubocop Regex Style rules (#23690 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Eugen Rochko	4eda233e09	Add webhook templating (#23289 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Matt Jankowski	af135bddd0	Update `Admin::Metrics::Measure` classes for Rails 7 (#25236 )	3 years ago
Matt Jankowski	3b21c13dcc	Rails 7 compatibility fix for `Admin::Metrics::Dimension` classes (#25277 )	3 years ago
Darius Kazemi	bacb674921	Add exclusive lists (#22048 ) Co-authored-by: Liam Cooke <liam@liamcooke.com> Co-authored-by: John Holdun <john@johnholdun.com> Co-authored-by: Effy Elden <effy@effy.space> Co-authored-by: Lina Reyne <git@lina.pizza> Co-authored-by: Lina <20880695+necropolina@users.noreply.github.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Matt Jankowski	f84037ae2b	Remove unused #hash_to_object method in SettingsHelper (#25213 )	3 years ago
Claire	e9385e93e9	Add a confirmation screen when suspending a domain (#25144 )	3 years ago
Christian Schmidt	69057467cb	Translate CW, poll options and media descriptions (#24175 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Matt Jankowski	00c222377d	Remove unused Settings::Extend module (#25214 )	3 years ago
Matt Jankowski	9f5deb310b	Fix Performance/MapCompact cop (#24797 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Matt Jankowski	0664704cd9	Fix Performance/StartWith cop (#24818 )	3 years ago
Claire	e13d2edd47	Fix “Authorized applications” inefficiently and incorrectly getting last use date (#25060 )	3 years ago
Emelia Smith	19f9098551	Allow reports with long comments from remote instances, but truncate (#25028 )	3 years ago
Claire	7bb8030cc1	Change OpenGraph-based embeds to allow fullscreen (#25058 )	3 years ago
Claire	9015c2d646	Change profile updates to be sent to recently-mentioned servers (#24852 )	3 years ago
Claire	6b0942d107	Change AccessTokensVacuum to also delete expired tokens (#24868 )	3 years ago
Nick Schonning	ff3b7069cf	Autofix Rubocop Style/ConcatArrayLiterals (#23755 )	3 years ago
Matt Jankowski	668a19a2f3	Fix Performance/DeletePrefix cop (#24796 )	3 years ago
Matt Jankowski	f1c1dd0118	Rename `with_lock` to `with_redis_lock` to avoid confusion with ActiveRecord's method (#24741 )	3 years ago
Matt Jankowski	bae694108a	Fix Performance/Count cop (#24793 )	3 years ago
Matt Jankowski	5e060e1f44	Fix Performance/Sum cop (#24788 )	3 years ago
Matt Jankowski	88d33f361f	Fix Lint/DuplicateBranch cop (#24766 )	3 years ago
Claire	32a030dd74	Rewrite import feature (#21054 )	3 years ago
dependabot[bot]	fa14976a5d	Bump connection_pool from 2.3.0 to 2.4.0 (#24290 ) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Nick Schonning	49fad26eca	Drop EOL Ruby 2.7 (#24237 )	3 years ago
Matt Jankowski	0a5f0a8b20	Remove instance variables from helper usage (#24203 )	3 years ago
Eugen Rochko	a9b5598c97	Change user settings to be stored in a more optimal way (#23630 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Matt Jankowski	e63524f457	Update retention model sql query (#24249 )	3 years ago
Claire	8fdf49b11d	Add warning for object storage misconfiguration (#24137 )	3 years ago
Christian Schmidt	bd047acc35	Replace `Status#translatable?` with language matrix in separate endpoint (#24037 )	3 years ago
Eugen Rochko	630436ab2d	Refactor monkey-patching of `PrivateAddressCheck` (#24122 )	3 years ago
Claire	9875be09fe	Fix dashboard crash on ElasticSearch server error (#23751 )	3 years ago
Claire	1d0ad558ff	Change sidekiq-bulk's batch size from 10,000 to 1,000 jobs in one Redis call (#24034 )	3 years ago
Christian Schmidt	684a970b3c	Unescape HTML entities (#24019 )	3 years ago
Matt Jankowski	dfa1be4ab4	Remove unused TOCGenerator (#23986 )	3 years ago
Jean byroot Boussier	922837dc96	Upgrade to latest redis-rb 4.x and fix deprecations (#23616 ) Co-authored-by: Jean Boussier <jean.boussier@gmail.com>	3 years ago
Christian Schmidt	5a8c651e8f	Only offer translation for supported languages (#23879 )	3 years ago
Nick Schonning	0cfdd1a401	Enable Rubocop Style/StringConcatenation defaults (#23792 )	3 years ago
Nick Schonning	59c8d43d94	Autofix Rubocop Style/RescueStandardError (#23745 )	3 years ago
Nick Schonning	717683d1c3	Autofix Rubocop remaining Layout rules (#23679 )	3 years ago
Nick Schonning	21bf326356	Autofix Rubocop Rails/Pluck (#23730 )	3 years ago
Nick Schonning	81ad6c2e39	Autofix Rubocop Style/StringLiterals (#23695 )	3 years ago
Nick Schonning	2177daeae9	Autofix Rubocop Style/RedundantBegin (#23703 )	3 years ago
Nick Schonning	e2a3ebb271	Autofix Rubocop Style/IfUnlessModifier (#23697 )	3 years ago
Nick Schonning	8aee4de034	Autofix Rubocop Style/PerlBackrefs (#23649 )	3 years ago
Nick Schonning	a6f77aa28a	Autofix Rubocop Lint/AmbiguousOperatorPrecedence (#23681 )	3 years ago
Nick Schonning	634368c491	Autofix Rubocop Lint/SymbolConversion (#23683 )	3 years ago
Nick Schonning	669f6d2c0a	Run rubocop formatting except line length (#23632 )	3 years ago
Claire	0c9eac80d8	Fix unbounded recursion in post discovery (#23506 ) * Add a limit to how many posts can get fetched as a result of a single request * Add tests * Always pass `request_id` when processing `Announce` activities --------- Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>	3 years ago
Nick Schonning	0592937264	Apply Rubocop Rails/WhereNot (#23448 ) * Apply Rubocop Rails/WhereNot * Update spec for where.not	3 years ago
Nick Schonning	0d1f192c54	Apply Rubocop Performance/BlockGivenWithExplicitBlock (#23441 ) * Apply Rubocop Performance/BlockGivenWithExplicitBlock * Unprefix used block parameter	3 years ago
Nick Schonning	203739dd3a	Apply Rubocop Performance/StringIdentifierArgument (#23444 )	3 years ago
Nick Schonning	ef8988aef2	Apply Rubocop Performance/DoubleStartEndWith (#23442 )	3 years ago
Nick Schonning	ed570050c6	Autofix Rails/EagerEvaluationLogMessage (#23429 ) * Autofix Rails/EagerEvaluationLogMessage * Update spec for debug block syntax	3 years ago
Eugen Rochko	4c919812b9	Change number of stored items in home feed from 400 to 800 (#23349 )	3 years ago
Claire	41517a4845	Fix spurious admin dashboard warning when using ElasticSearch 7.x (#23064 ) Some 7.x ElasticSearch versions support some 6.x nodes, thus the version check is inadequate. I am not sure there is a good way to check if a server implements all the 7.x APIs, so check server version and minimum wire version instead.	3 years ago
Markus Unterwaditzer	0c689b9d01	fix: allow verification when page size exceeds 1MB (using HTML5 parser) (#22879 ) * fix: allow verification when page size exceeds 1MB Truncates the page after 1MB instead Closes #15316 * switch to HTML5 parser, fix rubocop errors * undo rubocop fixes Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>	3 years ago
Kaspar V	ae62e5fa53	Fix/remove calling private method with send in model (#22951 ) * fix(status): remove send usage for private unlink_from_conversations - make unlink_from_conversations public method - rename unlink_from_conversations to unlink_from_conversations! - fix send call on private method in statuses_vacuum and batched_remove_status_service * fix(feeds_vacuum): replace find_in_batches with in_batches because active record query results should be a little more efficient than itterating with map and each. Postgres can grasp such lists of ids much quicker than ruby can. Will probably make allmost no difference, but cannot hurt either.	3 years ago
Vyr Cossont	06f979098c	Check OpenSearch compatibility version instead of regular version (#22422 ) Fixes #18535.	3 years ago
Jeong Arm	fdd1facba1	Fix home TL could contain post from who blocked me (#22849 ) * Fix home tl contains post from who blocked me * Add test * Fix feed_manager's build_crutches blocked_by was not includes status' owner * Add test for status from I blocked * Fix typo	3 years ago
Claire	d13702ac06	Fix status cache hydration discrepancy (#19879 )	3 years ago
Claire	673c54f114	Fix inability to use local LibreTranslate without setting ALLOWED_PRIVATE_ADDRESSES (#21926 ) Fixes #20029	3 years ago
s0	52540771b0	Fix crash in elasticsearch_check.rb (#21006 ) Nil unwrap causes the admin dashboard to crash/500 when the Chewy client info version number value is nil. This occurs when running another ES-compatible backend such as MeiliSearch. Obviously it would be good for chewy to recognise upstream but at least avoiding the crash would be fine.	3 years ago
Jeong Arm	e8cc63105f	Don't delivery a reply to domains which are blocked by author (#22117 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Claire	c8849d6cee	Fix unbounded recursion in account discovery (#22025 ) * Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts	3 years ago
Claire	68d1df8bc3	Fix some performance issues with /admin/instances (#21907 ) /admin/instances?availability=failing remains wholly unefficient	3 years ago
Kaspar V	47f0d7021e	refactor(vacuum statuses): reduce amount of db queries and load for each query - improve performance (#21487 ) * refactor(statuses_vacuum): remove dead code - unused Method is not called inside class and private. Clean up dead code. * refactor(statuses_vacuum): make retention_period present test explicit This private method only hides functionality. It is best practice to be as explicit as possible. * refactor(statuses_vacuum): improve query performance - fix statuses_scope having sub-select for Account.remote scope by `joins(:account).merge(Account.remote)` - fix statuses_scope unnecessary use of `Status.arel_table[:id].lt` because it is inexplicit, bad practice and even slower than normal `.where('statuses.id < ?'` - fix statuses_scope remove select(:id, :visibility) for having reusable active record query batches (no re queries) - fix vacuum_statuses! to use in_batches instead of find_in_batches, because in_batches delivers a full blown active record query result, in stead of an array - no requeries necessary - send(:unlink_from_conversations) not to perform another db query, but reuse the in_batches result instead. - remove now obsolete remove_from_account_conversations method - remove_from_search_index uses array of ids, instead of mapping the ids from an array - this should be more efficient - use the in_batches scope to call delete_all, instead of running another db query for this - because it is again more efficient - add TODO comment for calling models private method with send * refactor(status): simplify unlink_from_conversations - add `has_many through:` relation mentioned_accounts - use model scope local instead of method call `Status#local?` - more readable add account to inbox_owners when account.local? * refactor(status): searchable_by way less sub selects These queries all included a sub-select. Doing the same with a joins should be more efficient. Since this method does 5 such queries, this should be significant, since it technically halves the query count. This is how it was: ```ruby [3] pry(main)> Status.first.mentions.where(account: Account.local, silent: false).explain Status Load (1.6ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (1.5ms) SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ``` This is how it is with this change: ```ruby [4] pry(main)> Status.first.mentions.joins(:account).merge(Account.local).active.explain Status Load (1.7ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (0.7ms) SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ```	3 years ago
Claire	71c92d3f56	Fix emoji substitution not applying only to text nodes in backend code (#20641 ) Signed-off-by: Claire <claire.github-309c@sitedethib.com> Signed-off-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Bearice Ren	28cda42af5	fixes ArgumentError when proxy is used (#20420 ) * fixes ArgumentError when proxy is used * Update app/lib/request.rb Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Eugen Rochko	f8e8e622e5	Change incoming activity processing to happen in `ingress` queue (#20264 )	3 years ago
James Tucker	78a6b871fe	Improve performance by avoiding regex construction (#20215 ) ```ruby 10.times { p /#{FOO}/.object_id } 10.times { p FOO_RE.object_id } ```	3 years ago
Claire	c989faaa62	Change Request connection logic to try both IPv6 and IPv4 when available (#20108 ) Fixes #19751	3 years ago
James Tucker	833d9c2f1c	Improve performance by avoiding method cache busts (#19957 ) Switch to monkey-patching http.rb rather than a runtime extend of each response, so as to avoid busting the global method cache. A guard is included that will provide developer feedback in development and test environments should the monkey patch ever collide.	3 years ago
Claire	3114c826a7	Fix filter handling in status cache hydration (#19963 )	3 years ago
Claire	bb89f83cc0	Fix additional issues with status cache hydration (#19747 ) * Spare one SQL query when hydrating polls * Improve tests * Fix more discrepancies * Fix possible crash when the status has no application set	3 years ago
Claire	03b991de6c	Fix various issues with store hydration (#19746 ) - Improve tests - Fix possible crash when application of a reblogged post isn't set - Fix discrepancies around favourited and reblogged attributes - Fix discrepancies around pinned attribute - Fix polls not being hydrated	3 years ago
Claire	c2170991c7	Fix reblogs being discarded after the reblogged status (#19731 )	3 years ago
Eugen Rochko	5f9e47be34	Add caching for payload serialization during fan-out (#19642 )	3 years ago
Eugen Rochko	1546538de9	Fix improperly checking for blocked domain on followed hashtags (#19472 ) Fix #19469	3 years ago
Eugen Rochko	bf0ab3e0fa	Fix vacuum scheduler missing lock, locks never expiring (#19458 ) Remove vacuuming of orphaned preview cards	3 years ago
Eugen Rochko	8f07381856	Revert "Remove preference to aggregate reblogs in home/list feeds (#18112 )" (#19463 ) This reverts commit `af396fa35f`.	3 years ago
Claire	30453fab80	Add mention of the translation provider when translating a post (#19433 )	3 years ago
Claire	8046cf34d6	Change “Translate” button to only show up when a translation backend is configured (#19434 ) * Change “Translate” button to only show up when a translation backend is configured Fixes #19346 * Add `translation` attribute to /api/v2/instance to expose whether the translation feature is enabled Fixes #19328	3 years ago

1 2 3 4 5 ...

856 Commits (5ea3e8e765e0a0ae8e60c3e4e0b03cd3604ffdf1)