mastodon

Commit Graph

Author	SHA1	Message	Date
Claire	d1387579b9	Fix situations in which instance actor can be set to a Mastodon-incompatible name (#22307 ) * Validate internal actor * Use “internal.actor” by default for the server actor username * Fix instance actor username on the fly if it includes ':' * Change actor name from internal.actor to mastodon.internal	2 years ago
Darius Kazemi	264655c53a	Fix account search not returning followed accounts first (#22956 ) * Make autosuggest for mentions return followed accounts first This makes it so that (when elasticsearch is disabled) when a user types '@foo' in the compose box, they are first going to get accounts they follow ordered by the ranking algorithm, and then second they will get accounts they do not follow, also ordered by the ranking algorithm. This makes behavior more consistent with user expectation and also with results when elasticsearch is enabled. * Fix ranking order to correct direction * One more fixup per @gargron suggestion * Tweak to ranking to no longer include following modifier	2 years ago
Jeong Arm	d412147d02	Save avatar or header correctly even if other one fails (#18465 ) * Save avatar or header correctly if other one fails * Fix test	2 years ago
Jeong Arm	c4c1bee880	Fix trendable status without review (#20214 )	2 years ago
James Tucker	78a6b871fe	Improve performance by avoiding regex construction (#20215 ) ```ruby 10.times { p /#{FOO}/.object_id } 10.times { p FOO_RE.object_id } ```	2 years ago
Eugen Rochko	e98833748e	Fix being able to spoof link verification (#20217 ) - Change verification to happen in `default` queue - Change verification worker to only be queued if there's something to do - Add `link` tags from metadata fields to page header of profiles	2 years ago
Eugen Rochko	3151b260e2	Fix not using GIN index for account search queries (#19830 )	2 years ago
Eugen Rochko	ac9fb0d654	Add reputation and followers score boost to SQL-only account search (#19251 )	2 years ago
Eugen Rochko	5f733ad83a	Remove unused method `searchable?` on accounts (#19489 ) It called the wrong methods, but nothing uses it	2 years ago
Eugen Rochko	839f893168	Change public accounts pages to mount the web UI (#19319 ) * Change public accounts pages to mount the web UI * Fix handling of remote usernames in routes - When logged in, serve web app - When logged out, redirect to permalink - Fix `app-body` class not being set sometimes due to name conflict * Fix missing `multiColumn` prop * Fix failing test * Use `discoverable` attribute to control indexing directives * Fix `<ColumnLoading />` not using `multiColumn` * Add `noindex` to accounts in REST API * Change noindex directive to not be rendered by default before a route is mounted * Add loading indicator for detailed status in web UI * Fix missing indicator appearing while account is loading in web UI	2 years ago
Eugen Rochko	546672e292	Change "Allow trends without prior review" setting to include statuses (#17977 ) * Change "Allow trends without prior review" setting to include posts * Fix i18n-tasks	3 years ago
Eugen Rochko	0396acf39e	Add audit log entries for user roles (#19040 ) * Refactor audit log schema * Add audit log entries for user roles	3 years ago
Eugen Rochko	76ff452306	Fix unicode regression in #18809 (#18863 )	3 years ago
Eugen Rochko	e7aa2be828	Change how hashtags are normalized (#18795 ) * Change how hashtags are normalized * Fix tests	3 years ago
Eugen Rochko	44b2ee3485	Add customizable user roles (#18641 ) * Add customizable user roles * Various fixes and improvements * Add migration for old settings and fix tootctl role management	3 years ago
Claire	9d4861b498	Remove dependency on running Redis server for db:setup (#18560 )	3 years ago
Claire	440eb71310	Change unapproved and unconfirmed account to not be accessible in the REST API (#17530 ) * Change unapproved and unconfirmed account to not be accessible in the REST API * Change Account#searchable? to reject unconfirmed and unapproved users * Disable search for unapproved and unconfirmed users in Account.search_for * Disable search for unapproved and unconfirmed users in Account.advanced_search_for * Remove unconfirmed and unapproved accounts from Account.searchable scope * Prevent mentions to unapproved/unconfirmed accounts * Fix some old tests for Account.advanced_search_for * Add some Account.advanced_search_for tests for existing behaviors * Add some tests for Account.search_for * Add Account.advanced_search_for tests unconfirmed and unapproved accounts * Add Account.searchable tests * Fix Account.without_unapproved scope potentially messing with previously-applied scopes * Allow lookup of unconfirmed/unapproved accounts through /api/v1/accounts/lookup This is so that the API can still be used to check whether an username is free to use.	3 years ago
Claire	33cd80d69c	Fix instance actor being incorrectly created when running migrations (#18109 ) * Add migration test about instance actor key * Fix old migration * Work around incorrect database state	3 years ago
Eugen Rochko	2dd30804b6	Change how unconfirmed accounts are displayed in admin UI (#17874 ) Fix #17815	3 years ago
Eugen Rochko	edf09ec747	Add `/api/v1/accounts/familiar_followers` to REST API (#17700 ) * Add `/api/v1/accounts/familiar_followers` to REST API * Change hide network preference to be stored consistently for local and remote accounts * Add dummy classes to migration * Apply suggestions from code review Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Eugen Rochko	27965ce5ed	Add trending statuses (#17431 ) * Add trending statuses * Fix dangling items with stale scores in localized sets * Various fixes and improvements - Change approve_all/reject_all to approve_accounts/reject_accounts - Change Trends::Query methods to not mutate the original query - Change Trends::Query#skip to offset - Change follow recommendations to be refreshed in a transaction * Add tests for trending statuses filtering behaviour * Fix not applying filtering scope in controller	3 years ago
Eugen Rochko	564efd0651	Add appeals (#17364 ) * Add appeals * Add ability to reject appeals and ability to browse pending appeals in admin UI * Add strikes to account page in settings * Various fixes and improvements - Add separate notification setting for appeals, separate from reports - Fix style of links in report/strike header - Change approving an appeal to not restore statuses (due to federation complexities) - Change style of successfully appealed strikes on account settings page - Change account settings page to only show unappealed or recently appealed strikes * Change appealed_at to overruled_at * Fix missing method error	3 years ago
Claire	0a120d86d2	Fix error-prone SQL queries (#15828 ) * Fix error-prone SQL queries in Account search While this code seems to not present an actual vulnerability, one could easily be introduced by mistake due to how the query is built. This PR parameterises the `to_tsquery` input to make the query more robust. * Harden code for Status#tagged_with_all and Status#tagged_with_none Those two scopes aren't used in a way that could be vulnerable to an SQL injection, but keeping them unchanged might be a hazard. * Remove unneeded spaces surrounding tsquery term * Please CodeClimate * Move advanced_search_for SQL template to its own function This avoids one level of indentation while making clearer that the SQL template isn't build from all the dynamic parameters of advanced_search_for. * Add tests covering tagged_with, tagged_with_all and tagged_with_none * Rewrite tagged_with_none to avoid multiple joins and make it more robust * Remove obsolete brakeman warnings * Revert "Remove unneeded spaces surrounding tsquery term" The two queries are not strictly equivalent. This reverts commit `86f16c537e`.	3 years ago
Eugen Rochko	8e84ebf0cb	Remove IP tracking columns from users table (#16409 )	3 years ago
Eugen Rochko	0fb9536d38	Add batch suspend for accounts in admin UI (#17009 )	3 years ago
Takeshi Umeda	3419d3ec84	Bump chewy from 5.2.0 to 7.2.3 (supports Elasticsearch 7.x) (#16915 ) * Bump chewy from 5.2.0 to 7.2.2 * fix style (codeclimate) * fix style * fix style * Bump chewy from 7.2.2 to 7.2.3	3 years ago
Claire	fc3ae1343d	Switch from unmaintained paperclip to kt-paperclip (#16724 ) * Switch from unmaintained paperclip to kt-paperclip * Drop some compatibility monkey-patches not required by kt-paperclip * Drop media spoof check monkey-patching It's broken with kt-paperclip and hopefully it won't be needed anymore * Fix regression introduced by paperclip 6.1.0 * Do not rely on pathname to call FastImage * Add test for ogg vorbis file with cover art * Add audio/vorbis to the accepted content-types This seems erroneous as this would be the content-type for a vorbis stream without an ogg container, but that's what the `marcel` gem outputs, so… * Restore missing for_as_default method * Refactor Attachmentable concern and delay Paperclip's content-type spoof check Check for content-type spoofing after setting the extension ourselves, this fixes a regression with kt-paperclip's validations being more strict than paperclip 6.0.0 and rejecting some Pleroma uploads because of unknown extensions. * Please CodeClimate * Add audio/vorbis to the unreliable set It doesn't correspond to a file format and thus has no extension associated.	4 years ago
Claire	2b18f7a943	Fix processing mentions to domains with non-ascii TLDs (#16689 ) Fixes #16602	4 years ago
Claire	5efb1ff337	Fix followers synchronization mechanism not working when URI has empty path (#16510 ) * Fix followers synchronization mechanism not working when URI has empty path To my knowledge, there is no current implementation on the fediverse that can use bare domains (e.g., actor is at https://example.org instead of something like https://example.org/actor) that also plans to support the followers synchronization mechanism. However, Mastodon's current implementation would exclude such accounts from followers list. Also adds tests and rename them to reflect the proper method names. * Move url prefix regexp to its own constant	4 years ago
Claire	13b08610a0	Fix crash when encountering invalid account fields (#16598 ) * Add test * Fix crash when encountering invalid account fields	4 years ago
Claire	30ce6e395c	Fix user email address being banned on self-deletion (#16503 ) * Add tests * Fix user email address being banned on self-deletion Fixes #16498	4 years ago
Eugen Rochko	38b3419950	Fix not being able to suspend accounts that already have a canonical e-mail block (#16455 )	4 years ago
Eugen Rochko	1294f9ee4f	Remove PubSubHubbub-related columns from accounts table (#16170 )	4 years ago
Eugen Rochko	74081433d0	Change trending hashtags to be affected be reblogs (#16164 ) If a status with a hashtag becomes very popular, it stands to reason that the hashtag should have a chance at trending Fix no stats being recorded for hashtags that are not allowed to trend, and stop ignoring bots Remove references to hashtags in profile directory from the code and the admin UI	4 years ago
Eugen Rochko	b3ceb3dcc4	Add canonical e-mail blocks for suspended accounts (#16049 ) Prevent new accounts from being created using the same underlying e-mail as a suspended account using extensions and period permutations. Stores e-mails as a SHA256 hash	4 years ago
Eugen Rochko	f7117646af	Add cold-start follow recommendations (#15945 )	4 years ago
Claire	5cc45d22d3	Remove subscription_expires_at leftover from OStatus (#15857 )	4 years ago
ThibG	54d4e5252b	Use Rails' index_by where it makes sense (#15542 ) * Use Rails' index_by where it makes sense * Fix tests Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
luigi	087ed84367	Optimize map { ... }.compact calls (#15513 ) * Optimize map { ... }.compact using Enumerable#filter_map, supported since Ruby 2.7 * Add poyfill for Enumerable#filter_map	4 years ago
abcang	efffdd3778	Fix rubocop config and warnings (#15503 ) * disable NewCops * update TargetRubyVersion * Fix Lint/MissingSuper for ActiveModelSerializers::Model * Fix Lint/MissingSuper for feed * Fix Lint/FloatComparison * Do not use instance variables	4 years ago
ThibG	3249d35bdc	Improve account deletion performances further (#15407 ) * Delete status records by batches of 50 * Do not precompute values that are only used once * Do not generate redis events for removal of public toots older than two weeks * Filter reported toots a priori for polls and status deletion * Do not process reblogs when cleaning up public timelines As in Mastodon proper, reblogs don't appear in public TLs * Clean the deleted account's own feed in one go * Refactor Account#clean_feed_manager and List#clean_feed_manager * Delete instead of destroy a few more associations * Fix preloading Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	8357969559	Fix admins being able to suspend their instance actor (#14567 ) * Fix admin being able to suspend their own instance account * Add text about the instance's own actor in admin view * Change instance actor notice from flash message to template * Do not list local instance actor in account moderation list	4 years ago
Eugen Rochko	216b85b053	Fix performance on instances list in admin UI (#15282 ) - Reduce duplicate queries - Remove n+1 queries - Add accounts count to detailed view - Add separate action log entry for updating existing domain blocks	4 years ago
Eugen Rochko	48bef17cc9	Fix slow distinct queries where grouped queries are faster (#15287 ) About 2x speed-up on inboxes query	4 years ago
Eugen Rochko	f844386809	Add `tootctl accounts merge` (#15201 ) * Add `tootctl accounts merge` * Update lib/mastodon/accounts_cli.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	4 years ago
Eugen Rochko	3134691948	Add support for reversible suspensions through ActivityPub (#14989 )	4 years ago
Takeshi Umeda	d6fe0c94ca	Add account sensitized (#14361 ) * Add account sensitized * Fix i18n normalize * Fix description and spec * Fix spec * Fix wording	4 years ago
ThibG	ca56527140	Add follower synchronization mechanism (#14510 ) * Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each	4 years ago
Eugen Rochko	ed099d8bdc	Change account suspensions to be reversible by default (#14726 )	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820 )	5 years ago

1 2 3 4 5 ...

292 Commits (420f33ccb95081b960510af3c746a525a370f6bb)