1710 Commits (3b51581f1be3c7e825dd87fadbe0a7264c7bcddc)

Author	SHA1	Message	Date
Patrick Figel	8ac7fca5d0	Set correct attachment type for rejected media (#2599) ... In #2110, a new attachment type "unknown" was introduced for attachments that were rejected due to a domain being blocked using reject_media. However, the "type" field was never set to "unknown" because a default value of "0" (image) is set for that column, causing the `type.blank?` expression to always equal false. This version uses type_changed? instead, causing the type to be set to "unknown" unless a type has been explicitly set. This introduces a small change in behaviour causing the type to be set to unknown before paperclip calls `before_post_process`. Presumably this behaviour is more appropriate than the current one because the attachment type has not been determined by that point. Included are new tests for `ProcessFeedService` and `UpdateRemoteProfileService` which now check that remote media is downloaded for non-blocked domains and is rejected for others.	8 years ago
Yamagishi Kazutoshi	298d28af51	Fix API for Mastodon version (#2590) ... Fix #2589	8 years ago
Mingye Wang	439b2dceda	Minor updates to zh-CN JS translation (#2557) ... * Minor updates to zh-CN JS translation * removed "!" from "toot" per #2549 (it's a privacy indicator) * ellipsis work (from ... to some U+2026 horizontal ellipsis unicode stuff) * Spillcheck for zh-CN js translations (squash this) 部 [份→分]	8 years ago
Matt Jankowski	9262f6968b	Fix broken spec for about/links view partial (#2586)	8 years ago
Yamagishi Kazutoshi	01c206326f	Hide get started link when register closed (#2583)	8 years ago
Matt Jankowski	9566893cc9	More controller specs (#2561) ... * Add render_views in more places * Delegate methods from account to user with allow nil true, so that admin accounts show view renders when missing a user * Use actual account instances in authorize follow controller spec	8 years ago
Wonderfall	0e2589867f	Update en locale federation description (#2558)	8 years ago
Ratmir Karabut	4acc386dd5	Update Russian translation (pluralizations) (#2565) ... * Add Russian translation (ru) * Fix a missing comma * Fix the wording for better consistency * Update Russian translation * Arrange Russian setting alphabetically * Fix syntax error * Update Russian translation * Fix formatting error * Update Russian translation * Update Russian translation * Update ru.jsx * Fix syntax error * Remove two_factor_auth.warning (appears obsolete) * Add missing strings in ru.yml A lot of new strings translated, especially for the newly added admin section * Fix translation consistency * Update Russian translation * Update Russian translation (pluralizations)	8 years ago
Matt Jankowski	429480bb77	Return missing page when tag does not exist (#2563)	8 years ago
Matt Jankowski	effb08edbb	More status specs (#2564) ... * Add rough outline of coverage needed for public timeline * Specs for visibility, replies, boosts * Specs for silenced account * Specs for local_only option * Specs for blocks and mutes * Add tentative spec around including other silenced account statuses * Add with_public_visibility scope * Add simple coverage for tag_timeline * Tag timeline includes replies * Replace tag.statuses with a tagged_with scope in tag timeline method * Use with_public_visibility in tag timeline * Extract common scope between public and tag timelines to method * Extract local domain check to local_only scope * Extract local_only check to starting scope method * Move list of excluded from timeline account ids to account model * Simplify excluded accounts list on account model * Only join accounts when needed * Rename method for account specific filtering * Extract method for account exclusions * Fix bug where silenced accounts were not including statuses from other silenced accounts * DRY up filter application from account or no account * timeline_scope can be private * Add spec showing that account can find its excluded accounts ids * Add spec which fails if local_only does not have a left outer join * rubocop	8 years ago
Ratmir Karabut	d1b4ebe07d	Update Russian translation (#2570) ... New column subheadings	8 years ago
ButterflyOfFire	9a085e138e	Update settings_helper.rb (#2556) ... Correcting language name arabic = العربية	8 years ago
Wonderfall	546b5a9dcf	Update onboard federation description (#2555)	8 years ago
Shel Raphen	f51b2cb2e7	Copy edits to reflect changes in post privacy (#2552) ... There was still a reference to "private posts" and the phrasing of unlisted in contrast to the others now made it seem strangely more private.	8 years ago
Matt Jankowski	9736753985	Fix remote follow (#2547) ... * Add coverage for remote_follow#new * Fix reference to authorize_follows/card partial	8 years ago
Patrick Figel	074e9612a2	fix partial path in admin/reports (#2546) ... In #2505, the authorize_follow views were renamed to authorize_follows. This change was not applied in the show view of admin/reports, which causes a 500 when reports are viewed.	8 years ago
Eugen Rochko	7406404fa3	Hotfix remote status formatting (#2543)	8 years ago
unarist	ebbbcfef1c	Update Japanese translation (and English translation file) for JavaScript (#2538) ... * Update English translation file for JavaScript * Update Japanese translation for JavaScript	8 years ago
yhirano	3d776de2cb	Change permission from 0755 to 0644 (#2536) ... * chmod -x assets.rb * chmod -x assets/fonts * raname extname from jpeg to jpg	8 years ago
Yamagishi Kazutoshi	831ff60698	Fix broken oEmbed provider (#2537)	8 years ago
Yamagishi Kazutoshi	c25426ca47	Fix Doorkeeper error (#2534) ... * Fix Doorkeeper error * use Doorkeeper::OAuth::Scopes.from_string	8 years ago
jeroenpraat	09b93aaf85	Another (less urgent) Dutch string update (#2533) ... * Another (less urgent) update * Another (less urgent) update * Dutch strings: consistency: let's use 'voorkeuren' as a subset of 'instellingen'	8 years ago
Eugen Rochko	d4fedf84e0	Cache Status#ancestors recursive query results (#2527)	8 years ago
Eugen Rochko	2af4f3c4e2	Improve shared status verification (#2525) ... * Instead of parsing shared status contents verbatim, make roundtrip to purported original URL. Confirm that the "original" URL is from the same domain as the author it claims to be from. * Fix obvious typo, add comment * Use URI look-up first * Add test, update Goldfinger dependency to make less useless HTTP requests per Webfinger lookup	8 years ago
jeroenpraat	b8e7eee837	Last minute Dutch update and fix (after checking on live 1.3RC) (#2529) ... * Update and fix * Update and fix Dutch strings	8 years ago
Eugen Rochko	b48c9013aa	Bump version, improve how version is stored for better commit history (#2526)	8 years ago
Matt Jankowski	b48f2cbc8b	Catch error when server decryption fails on 2FA (#2512)	8 years ago
Ashley	1736badf28	Added '(dev)' to the title in development mode (#2524) ... * Added different title for dev * Changed indentation	8 years ago
Eugen Rochko	88725d6ce8	OEmbed support for PreviewCard (#2337) ... * OEmbed support for PreviewCard * Improve ProviderDiscovery code failure treatment * Do not crawl links if there is a content warning, since those don't display a link card anyway * Reset db schema * Fresh migrate * Fix rubocop style issues Fix #1681 - return existing access token when applicable instead of creating new * Fix test * Extract http client to helper * Improve oembed controller	8 years ago
Yamagishi Kazutoshi	be0a01145b	Sync a locale files for JavaScript (#2513) ... There are multiple messages missing in en.jsx. It is very troublesome when translating other languages.	8 years ago
Tomohiro Suwa	1f805a6377	Don't need to include ActiveModel::Validations (#2521)	8 years ago
Evan Minto	e595ccb294	Add ActivityPub Actor id to WebFinger JSON. (#2522)	8 years ago
Lindsey Bieda	43a29a9d0f	Add aria-label to icon driven dropdown menus (#2516)	8 years ago
Kaylee	0dd71af5fa	Copy over "Boost" hover text fix to detailed view. (#2508) ... from #1754, should close out #1394	8 years ago
Matt Jankowski	0618f09939	Add spec coverage and refactor authorize_follows controller (#2505)	8 years ago
Koala Yeung	a23eaf720e	Update Russian translation (rebased) (#2503) ... * Fix syntax error * Remove two_factor_auth.warning (appears obsolete) * Add missing strings in ru.yml A lot of new strings translated, especially for the newly added admin section * Update Russian translation * Fix merge conflicts Redid Works by @rkarabut	8 years ago
Matt Jankowski	8857cabca4	Domain block service cleanup (#2490) ... * Add coverage for domain block service with silence * Get rid of warning about find_each and order * Move domain_block to attr_reader * Move optional clear_media into silence_accounts method * Use blocked_domain method to reduce passed vars * Extract blocked_domain_accounts method to find accounts on the domain * Extract media_from_blocked_domain method to find relevant attachments * Separate destruction of account images and account attachments	8 years ago
Benedikt Geißler	0576daf5f9	Update German translation (#2485)	8 years ago
Yamagishi Kazutoshi	6004b143a8	Update Japanese translation (#2487) ... follow up #1309 & #2279	8 years ago
Lindsey Bieda	25cbb8454c	Red favicon for dev (#2470) ... * Set a dev specific favicon * Consistent spacing * Add trailing slash for consistency * Update to remove interpolation	8 years ago
Tomohiro Suwa	416c9675fc	Don't toot request with only blank characters (#2154) ... * Don't toot request with only blank characters * Enable toot button if no text	8 years ago
Yamagishi Kazutoshi	6a1e287053	Fix undefined variable in OnboardingModal (#2482)	8 years ago
Koala Yeung	5bda32e460	Update ar.jsx (#2469) ... Adding more missing strings.	8 years ago
Wonderfall	234e931db2	fix onboarding modal (#2477)	8 years ago
Eugen Rochko	fdcb55a0a6	Fix various regressions (#2466)	8 years ago
Eugen Rochko	d97a0525aa	Fix #2261 - noopener typo (#2463)	8 years ago
Francis Chong	193dddb433	Add media dimensions (#2448) ... * Fixes #1985 - add migration AddMediaAttachmentMeta, which add meta field to media_attachments - before saving attachment, set file meta if needed - add meta in api * add spec * align the “size” format for image and video * fix code climate * fixes media_attachment_spec.rb	8 years ago
Keiji, Yoshimi	8fe36654ef	attach_media should be in transaction of creation status (#2426)	8 years ago
JP DeVries	3ebaeccec9	Toolbar icons accessible names (#1424) ... Closes tootsuite/mastodon#1349 This is my first PR and I’m only checking in the source JSX file. Please let me know if it should be checked in after being built also.	8 years ago
Guillaume Lo Re	7177e37b99	Stricter whitelist rules (#2213) ... * Stricter whitelist rules * Linting * Added spec for blacklisting * Test subdomain blacklist on domain whitelist * No need to split * Change spec name	8 years ago
Amelia	fbc5099402	Make the getting started ui more intuitive (#1309)	8 years ago
Mingye Wang	6ae975996e	Refine CW placeholder in Chinese jsx files (#2447)	8 years ago
Ash Furrow	48652cb41e	Fixes string length issue for multibyte characters. (#2443)	8 years ago
Stephen Burgess	1ce951d0be	Adjust status action bar icons (#2424) ... Set status action bar to have display flex and center align items so dropdown icon appears center aligned with other icons. Make styles alpha organized. Add hover state to boost icon - lighten color on hover.	8 years ago
alpaca-tc	9317ec8eb1	Localize with i18n for Devise::FailureApp (#2309) ... This PR fixes I18n.locale for rake middlewares. Mastodon uses Devise that depends on Warden. Warden::Manager can be found in rake middleware. It is outside of the controller. In the case of authentication failed, warden calls throw(:warden). At the time Warden::Manager delegates request to failure_app to generate response and flash[:alert] after catching it. Unfortunately, I18n.locale is already reset then because I18n.with_locale is enabled only inside the controller. If we used I18n.locale=, Devise::FailureApp could get the current locale.	8 years ago
STJrInuyasha	1b9447853b	Login link for single user instances (#2393) ... * Login link for single user instances * Flip the if statement around Fixes AuthorizationController tests	8 years ago
Evan Minto	122d59ac41	Change ActivityPub paging to match spec. Clean up ActivityPub outbox changes. (#2410) ... * Change ActivityPub paging to match spec. Clean up ActivityPub outbox changes. * Fix code style and test failures for OutboxController. * Attempt to fix CI errors.	8 years ago
Eugen Rochko	8b5179d006	Fix #2402 - Add Idempotency-Key header to PostStatusService that prevents (#2419) ... duplicates. Web UI regenerates UUID for that header every time the compose form is changed or successfully submitted Also, fix Farsi i18n overwriting the English one	8 years ago
Yamagishi Kazutoshi	3ea5b948a4	Decodes URL containing IDN (#2436)	8 years ago
Ash Furrow	acc691851d	Username above toot box UI changes (#2418) ... * Makes username above toot box into a link. * Prepends username above toot box with an @.	8 years ago
178inaba	d2159deaf2	Optimize account search (#2421)	8 years ago
Eugen	17c591ffba	Punycode URI normalization (#2370) ... * Fix #2119 - Whenever about to send a HTTP request, normalize the URI * Add test for IDN request in FetchLinkCardService * Perform IDN normalization on domains before they are stored in the DB	8 years ago
Masoud Abkenar	bb04a9be52	Persian translation (#2405) ... * Persian translation * adding :fa to make the site use the rtl stylesheet based on [this comment](https://github.com/tootsuite/mastodon/pull/2405#issuecomment-296721105) * fix missing quotes * add 'fa' locale	8 years ago
Stephen Burgess	f098f55cab	fix(styles): Spoiler trigger zindex, close modal button position (#2406) ... #2338	8 years ago
Stephen Burgess	2d99c962df	Only show upload modal when drag event contains files (#2409) ... * fix(upload): Only show upload modal when drag even contains files * fix(firefox): Close drag window ondragend also Do not only end drag styles on drag leave, but also on drag end. Fixes firefox bug. #687 * fix(drag-modal): Remove drag modal trigger cruft * fix(upload-modal): Allow close with escape button	8 years ago
Eugen	e59f5c8e13	Add an RTL stylesheet for Arabic i18n (#2378)	8 years ago
Yamagishi Kazutoshi	b073b092c9	Force wrap long email address (#2395)	8 years ago
Matt Jankowski	092fdc89fa	Fix flashes partial render error for controllers which don't inherit from application controller (#2400) ... * Add failing spec for oauth/authorized_applications controller * Use explicit reference to flashes partial from admin layout Because some of the controllers which use the admin layout do not inherit from application controller, this partial is not in their view path.	8 years ago
Akihiko Odaki	cf845fed38	Hide some components rather than unmounting (#2271) ... Hide some components rather than unmounting them to allow to show again quickly and keep the view state such as the scrolled offset.	8 years ago
Yamagishi Kazutoshi	72c984e105	Fix background-size being overwritten (#2382)	8 years ago
Matt Jankowski	a0dd90a397	Return force_ssl to the controller (#2380)	8 years ago
Yamagishi Kazutoshi	549ce78cf5	Improve Japanese translation (#2376) ... ref #2359 - https://github.com/tootsuite/mastodon/pull/2359#discussion_r112838771 - https://github.com/tootsuite/mastodon/pull/2359#discussion_r112838772 - https://github.com/tootsuite/mastodon/pull/2359#discussion_r112838812 - https://github.com/tootsuite/mastodon/pull/2359#discussion_r112838823 - https://github.com/tootsuite/mastodon/pull/2359#discussion_r112838829	8 years ago
Effy Elden	1801a36414	Report processing improvements (#2349) ... * Expose media attachments on reported statuses directly * Comment out unused bulk report checkbox. Add title to report comment for viewing full comment. Add 'contents' column, with icons and numerical indicators to show the number of referenced statuses and media attachments in the report * Link account name on authorize_follow card back to account * Add localisation string for report_contents * Show new admin accounts card partial on report view. Apply simple_format to report comment so newlines are preserved. * Add new admin accounts card partial, for display quick useful admin stats (e.g. report history, moderation status). * Fix localized variable	8 years ago
Eugen	501514960a	Followers-only post federation (#2111) ... * Make private toots get PuSHed to subscription URLs that belong to domains where you have approved followers * Authorized followers controller, stub for bulk action * Soft block in the background * Add simple test for new controller * Rename Settings::FollowersController to Settings::FollowerDomainsController, paginate results, rename "private" post setting to "followers-only", fix pagination style, improve post privacy preferences style, improve warning style * Extract compose form warnings into own container, show warning when posting to followers-only with unlocked account	8 years ago
Ash Furrow	ef5937da1f	Fixes problem with showing non-local accounts. (#2371)	8 years ago
ymmtmdk	072c6f1527	Add link for domain in land strip (#2306) ... * Add link for domain in land strip * Use root_path * Avoid repeating code	8 years ago
Stephen Burgess	7ee8e50b9c	fix(style): Fix styles after classname refactor (#2368) ... Float detailed status display avatar left. Only apply display block to display names in status info, not in detailed status. Thanks to @nightpool for finding those. Make star icon in notification show up as gold. Add anchor selector back to status__content__spoiler-link in order to override default anchor style elsewhere.	8 years ago
Stephen Burgess	995f0ad51c	feat(cw-button): Add aria controls to CW trigger (#2303) ... Add an ID to the CW spoiler input field to give aria-controls a handle on it. Pass that id to the CW trigger button. Modify text icon button component to accept aria controls id value. Add aria-expanded value to text icon button to indicate when it is expanded.	8 years ago
Matt Jankowski	55e1e12b7d	Ensure i18n matches options (#2358) ... * Add failing spec showing that human_locales does not match what i18n knows about * Add missing `ar` key for arabic to human locales * Remove duplicate `id` key from available locales * Sort keys in human locales list * Add spec for human_locale helper	8 years ago
Yamagishi Kazutoshi	6e27e08cb4	Add Japanese translation to EmojiPicker component (#2359)	8 years ago
Yamagishi Kazutoshi	d670f72830	Show multibyte URI preview card (#2363)	8 years ago
178inaba	1244630ab4	Add simple_format to simplified_format (#2198)	8 years ago
ThibG	89dc29affb	Allow webfinger controller to reply to user@WEB_DOMAIN in addition to user@LOCAL_DOMAIN (#2351) ... This provides a hotfix for outbound salmon requests to other Mastodon instances as they currently will try to resovle user@WEB_DOMAIN instead of user@LOCAL_DOMAIN (see #2012 and #20312). Furthermore, this should ease transition from users switching from LOCAL_DOMAIN = WEB_DOMAIN to another LOCAL_DOMAIN when WEB_DOMAIN does not change.	8 years ago
Ashley	85e09518b9	Halved padding for emoji (#2344)	8 years ago
Stephen Burgess	663f090c45	fix(style): Fix regressions introduced by #2338 (#2345) ... Put Column Slim Back Button classnames in order so it is positioned right and top. Add icon button style back to privacy dropdown and upload buttons so they are positioned correctly and do not wiggle. Remove abstracted style from CSS. Add missed class for the upload form thumbnail. Add the missed styles for upload form thumnail. Alphabetize styles for column-back-button. Fix fontSize typo for media-spoiler-video-play-icon.	8 years ago
Joël Quenneville	1cf9e14a41	Test embedded_view related code in a helper (#2282) ... The two methods `StreamEntriesHelper#stream_link_target` and `StreamEntriesHelper#acct` are based on checking whether we are running in an embedded view. This adds some test helper code to make the testing easier. We extracted some "magic strings" to constants to lower the coupling in the specs.	8 years ago
Joël Quenneville	0c2fe22bc1	Add test coverage to CSS class generation (#2285) ... The code that generates CSS is based on a lot of boolean conditions. The possible combinations of these grows exponentially as we add more conditions. Since most of the code is conditional on a single boolean, we tested the following: 1. All `false` 2. All `true` 3. Each individual flag set to `true` The methods tested are: * `StreamEntriesHelper#style_classes` * `StreamEntriesHelper#microformats_classes` * `StreamEntriesHelper#microformats_h_class`	8 years ago
Koala Yeung	6f0b3b069f	Adding arabic string localization (rebased) (#1895) ... * Create ar.jsx * Preparing file for translation. * Create ar.yml * Preparing file for translation. * Create simple_form.ar.yml * Preparing file for translation. * Create devise.ar.yml * Preparing file for translation. * Create doorkeeper.ar.yml * Preparing file for translation. * Update index.jsx Preparing file for translation. * Update mastodon.jsx * Preparing file to translation. * Correction thanks to @Taekiro https://github.com/tootsuite/mastodon/pull/1798#pullrequestreview-32924922 * Update settings_helper.rb Preparing file to translation. * Update application.rb * Preparing file to translation. * Update simple_form.ar.yml * Update doorkeeper.ar.yml * Update devise.ar.yml * Update ar.yml * Fix i18n-tasks unused issue (ar) Remove unused translation strings * Update application.rb * Update ar.jsx * Fix various issues with Arabic translation * Fix duplication caused in merge * Fix syntax error in devise.ar.yml * Fix import error Duplicated incorrect import in mastodon.jsx * Fix duplication error in locales/index.jsx * Update ar.yml * Update ar.jsx * Update ar.yml * Update ar.jsx * Fix ar translation	8 years ago
Ashley	9cd20a7062	Tooltip for boosting depends on toot visibility (#1394) (#1754) ... * Made tooltip for boosting depend on visibility * Removed spaces that were added in merge conflict resolution * Try again :P * Added missing bracket * Changed 'toot' to 'status'	8 years ago
Yamagishi Kazutoshi	219fb317ee	Remove unnecessary variable in ColumnLink component (#2341) ... Fix bug in cca41ea544 .	8 years ago
Evan Minto	66fd8e7821	ActivityPub: Add basic, read-only support for Outboxes, Notes, and Create/Announce Activities (#2197) ... * Clean up collapsible components * Expose user Outboxes and AS2 representations of statuses * Save work thus far. * Fix bad merge. * Save my work * Clean up pagination. * First test working. * Add tests. * Add Forbidden error template. * Revert yarn.lock changes. * Fix code style deviations and use localized instead of hardcoded English text.	8 years ago
Ash Furrow	723f25a999	Admin UI for confirming users (#2245) ... * Shows confirmed status in list. * Adds ability to confirm users in admin UI. * Added new english translations. * Addresses feedback from #2245. * More feedback.	8 years ago
Eugen	59b1de0bcf	Add a confirmation modal: (#2279) ... - Deleting a toot - Muting, blocking someone - Clearing notifications Remove source map generation from development environment, as it is a huge performance sink hole with little gains	8 years ago
Akihiko Odaki	df46864b39	Alter Japanese translations for CW and NSFW (#2305) ... The previous translation for NSFW, "不適切" means "impertinent". This change suggests "閲覧注意", which means the content requires precaution, instead. However, "閲覧注意" was also a translation for CW. CW is now translated as "警告", which simply means "warnings".	8 years ago
Stephen Burgess	cca41ea544	Replace inline styles with CSS classes (BEM) (#2338) ... * fix(classnames): Status icon style classnames Take out inline css and put into classnames for the following components: account, avatar, icon button, status action bar, notification. * fix(status): Move styles from inline to classes for statuses Move styles to classnames in components.scss for the following components: display name media gallery status status content video player * fix(classnames): Add classnames to rest of components Take out inline styles and apply them to classnames in the sass for the following components: button column back button slim column back button collapsable column dropdown menu loading indicator status list * fix(classnames): Remove all non-dynamic inline styles Components affected: autosuggested permalink action bar header character counter compose form emoji dropdown privacy dropdown reply indicator upload form account auth followers getting started column settings mutes settings reblogs status checkbox report action bar status card boost modal media modal video modal * fix(permalink): Do not lose classname * fix(tests): Add space back in display name * fix(status__wrapper): Remove duplicate css name Remove incorrect style attribute. Remove style attribute all together. Cursor defaults to "auto" when not specified as 'default'. * fix(nl): do not lose translations	8 years ago
Matt Jankowski	532bec6e56	Clean up flash display in views (#2336) ... * Add flashes partial to DRY up admin/auth layouts * Further consolidate flash messages	8 years ago
Matt Jankowski	ee82d8a876	Move force_ssl check to production config (#2165) ... The force_ssl method from controllers does not add all of the options that the sitewide configuration in a config block does. For example, HSTS enforcement is not added by the controller method, but is added by this style.	8 years ago
mecab	1646ca75f0	Fix character images' sizing to make it robust (#2327)	8 years ago
jeroenpraat	f876665264	Translation emojis and sorted on alphabet (#2328)	8 years ago
Stephen Burgess	4cfc155560	Improve aria support - Columns and Navigation Drawer Icons (#2299) ... * feat(aria): Add aria-labels to underlabelled tab nav items The drawer tabs which control primary navigation are only labelled by a title which is not available to many screenreaders. Add an aria-label attribute to each link to improve readability with screenreaders. Organize link attributes so link target is first followed by classname. Issue #1349 * feat(aria): Replace abstract aria role of section with region Abstract aria roles such as section should not be used in content. Use non-abstract 'region' aria role instead. That role expects an aria-labelledby attribute with an id. Pass an ID to the column header. Remove the aria-label attribute on the ColumnHeader because the same value is output in plaintext as its child. Issue #1349 * fix(aria): Remove aria-controls attribute until solution is found Columns do not have wrappers, so these icons can't point to a column wrapper which it controls. Instead these icons function as triggers to show or hide individual columns. #1349 * fix(typo): Remove type of aria-labelledby instead of aria-label	8 years ago