Commit Graph

162 Commits (395f17ca17b27f9e722425a4d76ef1b02bcebea8)

Author SHA1 Message Date
Emelia Smith 30ae5952d2
Fix: Ensure "With Media" is highlighted from Admin Accounts page ()
Claire 8827cd597e
Fix `/admin/accounts/:account_id/statuses/:id` for edited posts with media attachments ()
Claire 32223863a5
Add coverage to `/admin/accounts/:id` ()
Emelia Smith 5fd56512de
Improve Report Notes and Account Moderation Notes ()
Matt Jankowski 8f3c91fc3c
Add `change` block expectation to `admin/invites#deactivate_all` spec ()
Matt Jankowski 64f9939e39
Use `capture_emails` helper to improve email assertions in specs ()
Matt Jankowski 1946e171e6
Reduce round trips in admin/disputes/appeals spec ()
Matt Jankowski da50217b88
Combine repeated requests in `admin/accounts` controller spec ()
Matt Jankowski 4cf07ed78c
Add missing action logging to `api/v1/admin/reports#update` ()
Matt Jankowski 685eaa04d4
Combine double subject in admin/statuses controller shared example ()
Matt Jankowski 2f8656334d
Combine double subjects in `admin/accounts` controller spec ()
Matt Jankowski 32eeca9c7b
Refresh instance counts in spec (fixes intermittent failure) ()
Matt Jankowski 00341c70ff
Use Sidekiq `fake!` instead of `inline!` in specs ()
Claire 6ad0fb5a77
Fix NULL MX handling and tighten DNS resolving specs ()
Claire dfdadb92e8
Add ability to require approval when users sign up using specific email domains ()
Claire 6fed0fcbaa
Remove unneeded settings cleanup from specs ()
Matt Jankowski cca19f5fbb
Use the `Admin::ActionLog` fabricator in admin/action_logs spec ()
Matt Jankowski 19ad51253d
Prevent triple-subject run in admin/domain_blocks spec ()
Matt Jankowski d848d8d87c
Add helper methods for domains allow and export blocks files ()
Matt Jankowski b751078fcd
Eliminate double subject call in admin/ controller specs ()
Matt Jankowski 32e19e3af6
Reduce `.times` usage in request and controller specs ()
Matt Jankowski b2c5b20ef2
Fix `RSpec/AnyInstance` cop ()
Matt Jankowski 49ba5a9f94
Use `hash_including` to check `AccountFilter` setup in `admin/accounts` controller spec ()
Matt Jankowski dc0bf87090
Remove unused before block from settings/branding spec ()
Matt Jankowski 49e2772064
Fix `RSpec/MessageSpies` cop ()
Matt Jankowski beee9ea991
Fix `RSpec/LetSetup` cop in spec/controllers/admin area ()
Matt Jankowski 2e6bf60f15
Use `deliveries.size` in mailer-related examples in controller specs ()
Matt Jankowski 9f218c9924
Refactor appeal partial to avoid brakeman XSS warning ()
Matt Jankowski 708299bb0d
Misc coverage improvements for `Admin::` and `Settings::` controllers ()
Claire b83e487502
Fix moderator rights inconsistencies ()
Matt Jankowski c75df62ccc
Fix `RSpec/SubjectDeclaration` cop ()
Matt Jankowski 05f9e39b32
Fix `RSpec/VerifiedDoubles` cop ()
Matt Jankowski 38433ccd0b
Reduce `Admin::Reports::Actions` spec db activity ()
Claire 602c458ab6
Add finer permission requirements for managing webhooks ()
Claire fd23f50243
Fix wrong view being displayed when a webhook fails validation ()
Matt Jankowski 4c5aa0e470
Update rubocop-rspec to version 2.22.0, fix `RSpec/IndexedLet` cop ()
Matt Jankowski 6c0e3f490a
Fix RSpec/MissingExampleGroupArgument cop ()
Matt Jankowski 1e243e2df7
Misc spec coverage for `Admin::` area controllers ()
Claire e9385e93e9
Add a confirmation screen when suspending a domain ()
Matt Jankowski 8b1bfaed3e
Add specs for admin/webhooks CRUD actions ()
Matt Jankowski 665bb237a8
Increase spec coverage for controllers - admin/ip_blocks, admin/relays, admin/rules ()
Matt Jankowski d2e5430d4a
Fix RSpec/ExpectChange cop ()
Matt Jankowski 2877c80dbc
Add specs for admin/announcements CRUD actions ()
Nick Schonning 99e2e9b81f
Fix minor typos in comments and spec names ()
Matt Jankowski 2c2d924942
Fix RSpec/RepeatedExampleGroupDescription cop ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Matt Jankowski a610a02d4f
Fix RSpec/ScatteredSetup cop ()
Nick Schonning da3bd913ae
Autofix Rubocop Style/HashSyntax ()
Matt Jankowski c97b611b6b
Fix RSpec/InferredSpecType cop ()
Matt Jankowski 710745e16b
Fix RSpec/ContextWording cop ()
Nick Schonning a3393d0d07
Autofix Rubocop RSpec/MatchArray ()