66 Commits (33b018648a4787d59ecab292ed06f29120951a42)

Author	SHA1	Message	Date
Eugen Rochko	6cf57c6765	Refactor how Redis locks are created (#18400) ... * Refactor how Redis locks are created * Fix autorelease duration on account deletion lock	3 years ago
Eugen Rochko	3917353645	Fix single Redis connection being used across all threads (#18135) ... * Fix single Redis connection being used across all Sidekiq threads * Fix tests	3 years ago
Eugen Rochko	cefa526c6d	Refactor formatter (#17828) ... * Refactor formatter * Move custom emoji pre-rendering logic to view helpers * Move more methods out of Formatter * Fix code style issues * Remove Formatter * Add inline poll options to RSS feeds * Remove unused helper method * Fix code style issues * Various fixes and improvements * Fix test	3 years ago
luzpaz	73f5e4a1d9	Fix various typos (#17621) ... Found via `codespell -q 3 -S ./CHANGELOG.md,./AUTHORS.md,./config/locales,./app/javascript/mastodon/locales -L ba,keypair,medias,ro`	3 years ago
Eugen Rochko	6e50134a42	Add trending links (#16917) ... * Add trending links * Add overriding specific links trendability * Add link type to preview cards and only trend articles Change trends review notifications from being sent every 5 minutes to being sent every 2 hours Change threshold from 5 unique accounts to 15 unique accounts * Fix tests	3 years ago
Eugen Rochko	39cdf61ab7	Add support for structured data and more OpenGraph tags to link cards (#16938) ... Save preview cards under their canonical URL Increase max redirects to follow from 2 to 3	3 years ago
Claire	9a19227f17	Fix some RedisLocks auto-releasing too fast (#16276) ... * Fix Delete and Create-related locks expiring too fast Fixes #16238 By default, RedisLock expires after 10 seconds, which may not be enough to process statuses, especially when those have attached media files. This commit extends those 10 seconds to 15 minutes, which should be plenty enough to handle any status, while being short enough to not waste many sidekiq job retries in the exceedingly rare case in which a sidekiq process would crash when processing a `Create` or `Delete`. * Fix other RedisLock autorelease durations Fixes #15645 - things that only perform a few simple database queries (e.g. finding and saving a record) have been left unchanged, so they'll still use the default 10s duration - things that perform significantly more complex database queries have been changed to a 5 minutes timeout - things that perform multiple HTTP queries have been changed to a 15 minutes timeout	4 years ago
Claire	5614e6724e	Fix URL scanning in note length validator and preview card fetching (#15827) ... * Add tests * Fix URL scanning in note length validator and preview card fetching	4 years ago
Claire	65db262550	Update twitter-text from 1.14 to 3.1.0 and fix toot character counting (#15382) ... * Update twitter-text from 1.14 to 3.1.0 * Disable emoji parsing * Properly depend on twitter-text for url detection * Fix some URLs being wrongly detected client-side * Add test for server-side validation of non-autolinkable URLs * Fix server-side status length counting	4 years ago
Takeshi Umeda	7f1c56954b	Fix first return value of FetchLinkCardService.html method (#15630)	4 years ago
luigi	087ed84367	Optimize map { ... }.compact calls (#15513) ... * Optimize map { ... }.compact using Enumerable#filter_map, supported since Ruby 2.7 * Add poyfill for Enumerable#filter_map	4 years ago
dependabot[bot]	8972e5f7f6	Bump rubocop from 0.86.0 to 0.88.0 (#14412) ... * Bump rubocop from 0.86.0 to 0.88.0 Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.88.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.86.0...v0.88.0) Signed-off-by: dependabot[bot] <support@github.com> * Fix for latest RuboCop Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	5 years ago
Eugen Rochko	ed04697510	Change User-Agent of link preview fetching service to include "Bot" (#14248) ... This forces Twitter to render OpenGraph tags in the response	5 years ago
ThibG	b364175e1b	Fix link crawler not specifying accepted content-type (#12646) ... The link crawler expects HTML documents, so set the `Accept` header accordingly. Fixes #12618	5 years ago
ThibG	c656cc2191	Fix FetchLinkCardServices crashing on a tags without a target (#12159) ... * Add test for links without targets * Fix FetchLinkCardServices crashing on a tags without a target	5 years ago
Eugen Rochko	d14e74eff5	Add cache for OEmbed endpoints to avoid extra HTTP requests (#12403) ... * add youtube oembed endpoint * add check for oembed endpoint * change unless for a more readable if * clear blank lines * endpoint via https * Fix string literal in condition * use cache for endpoints * use cache for endpoints * clean up and adding check * clean up and remove redundant return * add html check * add false to return * use double quotes * use double quotes * Clean up	5 years ago
nightpool	9762fe382c	microformat mentions can have an implicit property (#12189) ... See the first example here: http://microformats.org/wiki/microformats2#hyperlinked_person	5 years ago
Eugen Rochko	9ba40a6bfd	Remove HEAD request from fetching link previews (#12028) ... It is not really necessary and we need to reduce requests	5 years ago
Eugen Rochko	3ec80c7aec	Fix preview card image not being re-fetched even if link is re-posted (#11981) ... Fix #11956	5 years ago
Eugen Rochko	5d3feed191	Refactor fetching of remote resources (#11251)	6 years ago
Eugen Rochko	b851456139	Remove Atom feeds and old URLs in the form of `GET /:username/updates/:id` (#11247)	6 years ago
Daniel Aleksandersen	10bdd912d6	Treat meta[property] as a space-separated list (#10604) ... The @property attribute in HTML is a space-separated list of values. This change normalizes whitespace and finds the desired value in the list instead of requiring an exact single-value match. More details: https://www.ctrl.blog/entry/rdfa-socialmedia-metadata.html	6 years ago
ThibG	e709b8da0d	Ignore low-confidence CharlockHolmes guesses when parsing link cards (#9510) ... * Add failing test for windows-1251 link cards * Ignore low-confidence CharlockHolmes guesses Fixes #9466 * Fix no method error when charlock holmes cannot detect charset	6 years ago
ThibG	9b89c62d43	Check that twitter:player is valid before using it (#9254) ... Fixes #9251	6 years ago
ThibG	a03d506626	Fix Pleroma mentions being fetched as preview cards (#9158)	6 years ago
Eugen Rochko	795f0107d2	Include preview cards in status entity in REST API (#9120) ... * Include preview cards in status entity in REST API * Display preview card in-stream * Improve in-stream display of preview cards	6 years ago
ThibG	7fee968e9f	Do not fetch preview card for mentioned users (#6934)	6 years ago
Eugen Rochko	f4d549d300	Redesign forms, verify link ownership with rel="me" (#8703) ... * Verify link ownership with rel="me" * Add explanation about verification to UI * Perform link verifications * Add click-to-copy widget for verification HTML * Redesign edit profile page * Redesign forms * Improve responsive design of settings pages * Restore landing page sign-up form * Fix typo * Support <link> tags, add spec * Fix links not being verified on first discovery and passive updates	7 years ago
ThibG	bd9e47e9be	Handle relative URLs when fetching OEmbed/OpenGraph cards (#8669)	7 years ago
Yamagishi Kazutoshi	e3fb528d12	Skip processing when HEAD method returns 501 (#7730)	7 years ago
Akihiko Odaki	55fd55714a	Raise Mastodon::RaceConditionError if Redis lock failed (#7511) ... An explicit error allows user agents to know the error and Sidekiq to retry.	7 years ago
Yamagishi Kazutoshi	d2ee48977c	Rescue Mastodon::LengthValidationError in FetchLinkCardService (#7424)	7 years ago
Eugen Rochko	cb5b5cb5f7	Slightly reduce RAM usage (#7301) ... * No need to re-require sidekiq plugins, they are required via Gemfile * Add derailed_benchmarks tool, no need to require TTY gems in Gemfile * Replace ruby-oembed with FetchOEmbedService Reduce startup by 45382 allocated objects * Remove preloaded JSON-LD in favour of caching HTTP responses Reduce boot RAM by about 6 MiB * Fix tests * Fix test suite by stubbing out JSON-LD contexts	7 years ago
Akihiko Odaki	40e5d2303b	Validate HTTP response length while receiving (#6891) ... to_s method of HTTP::Response keeps blocking while it receives the whole content, no matter how it is big. This means it may waste time to receive unacceptably large files. It may also consume memory and disk in the process. This solves the inefficency by checking response length while receiving.	7 years ago
Akihiko Odaki	54b273bf99	Close http connection in perform method of Request class (#6889) ... HTTP connections must be explicitly closed in many cases, and letting perform method close connections makes its callers less redundant and prevent them from forgetting to close connections.	7 years ago
Eugen Rochko	f7765acf9d	Fix #5173: Click card to embed external content (#6471)	7 years ago
abcang	7e5c433dfc	Fix saving of oEmbed image (#6409)	7 years ago
Eugen Rochko	a8deb6648b	Fix redundant HTTP request in FetchLinkCardService (#6002)	7 years ago
Akihiko Odaki	f9f6918148	Store preview image for embedded photo in preview cards (#5986) ... The preview image would be useful to embed in timeline.	7 years ago
Renato "Lond" Cerqueira	19257d91bf	Return false if object does not respond to url (#5988) ... Avoid error when the service returns a mostly valid oembed, but has no url in it, causing a MethodError: undefined method `url' for #<OEmbed::Response::Photo:0x000056505def9620>	7 years ago
Yamagishi Kazutoshi	e7d55df38d	Ignore HEAD method if does not support (#5949)	7 years ago
Akihiko Odaki	c083816c24	Add embed_url to preview cards (#5775)	7 years ago
abcang	3dce6cbbd7	Fixed duplicating URL of photo type of oEmbed (#5763)	7 years ago
unarist	3bc8924940	Don't capture scheme-less URLs in the status (#5435) ... Specifically, this fixes status length calculation to be same as JS side. BTW, since this pattern used in not only preview card fetching, we should extract it (with twitter-regex?) and write tests I think.	7 years ago
unarist	35ec1c91e3	Fix some failure cases on FetchLinkCardService (#5347) ... * If OEmbed response doesn't have a required property `type`, ignore it. e.g. `NoMethodError: undefined method 'type' for ...` * If we failed to detect encoding, fallback to default behavior of Nokogiri. e.g. `KeyError: key not found: :encoding`	7 years ago
unarist	5c8ca024ef	Improve error handling on LinkCrawlWorker (#5250) ... * Improve error handling on LinkCrawlWorker * Ignore TimeoutError and InvalidURIError too * Record errors to debug log * Enable dead job queue on LinkCrawlWorker Since most of acceptable errors were already ignored, only our side issue should go to dead job queue. * Ignore all http gem errors	7 years ago
ふぁぼ原	3816943e6b	Enable to recognize most kinds of characters as URL paths (#4941)	8 years ago
Eugen Rochko	596dab06e9	Support OpenGraph video embeds (#4897) ... * Support OpenGraph video embeds It's not really OpenGraph, it's twitter:player property, but it's not OEmbed so that fits. For example, this allows Twitch clips to be displayed as embeds. Also, fixes glitch-soc/mastodon#135 * Fix invalid OpenGraph cards being saved through attaching and revisit URLs after 14 days	8 years ago
Eugen Rochko	7dc5035031	Make PreviewCard records reuseable between statuses (#4642) ... * Make PreviewCard records reuseable between statuses **Warning!** Migration truncates preview_cards tablec * Allow a wider thumbnail for link preview, display it in horizontal layout (#4648) * Delete preview cards files before truncating * Rename old table instead of truncating it * Add mastodon:maintenance:remove_deprecated_preview_cards * Ignore deprecated_preview_cards in schema definition * Fix null behaviour	8 years ago
Eugen Rochko	1618b68bfa	HTTP signatures (#4146) ... * Add Request class with HTTP signature generator Spec: https://tools.ietf.org/html/draft-cavage-http-signatures-06 * Add HTTP signature verification concern * Add test for SignatureVerification concern * Add basic test for Request class * Make PuSH subscribe/unsubscribe requests use new Request class Accidentally fix lease_seconds not being set and sent properly, and change the new minimum subscription duration to 1 day * Make all PuSH workers use new Request class * Make Salmon sender use new Request class * Make FetchLinkService use new Request class * Make FetchAtomService use the new Request class * Make Remotable use the new Request class * Make ResolveRemoteAccountService use the new Request class * Add more tests * Allow +-30 seconds window for signed request to remain valid * Disable time window validation for signed requests, restore 7 days as PuSH subscription duration (which was previous default due to a bug)	8 years ago