181 Commits (2a6a418f48fa9059ac26ba28449d7687f9721c76)

Author	SHA1	Message	Date
ThibG	00c219aa45	Fix empty poll options not being filtered on remote poll update (#12484) ... If a poll contains empty options (which is apparently possible on Pleroma), it is created without them. However, the poll update code doesn't filter empty options, and thus: 1. Clear known votes, as it assumes the set of options has changed 2. Errors out because it tries adding empty options, which fails validation This commit fixes that by filtering them out the same way they are filtered out at poll creation time.	5 years ago
ThibG	3babf8464b	Add voters count support (#11917) ... * Add voters count to polls * Add ActivityPub serialization and parsing of voters count * Add support for voters count in WebUI * Move incrementation of voters count out of redis lock * Reword “voters” to “people”	5 years ago
Eugen Rochko	cb447b28c4	Add profile directory to web UI (#11688) ... * Add profile directory to web UI * Add a line of bio to the directory	6 years ago
Eugen Rochko	5d3feed191	Refactor fetching of remote resources (#11251)	6 years ago
Eugen Rochko	4e92183227	Refactor domain block checks (#11268)	6 years ago
Eugen Rochko	2cfa427ea7	Change domain block behaviour to prevent creation of accounts from suspended domains (#11219)	6 years ago
Eugen Rochko	707ddf7808	Change domain blocks to automatically support subdomains (#11138) ... * Change domain blocks to automatically support subdomains If a more authoritative domain is blocked (example.com), then the same block will be applied to a subdomain (foo.example.com) * Match subdomains of existing accounts when blocking/unblocking domains * Improve code style	6 years ago
ThibG	14f6ce2885	Record account suspend/silence time and keep track of domain blocks (#10660) ... * Record account suspend/silence time and keep track of domain blocks * Also unblock users who were suspended/silenced before dates were recorded * Add tests * Keep track of suspending date for users suspended through the CLI * Show accurate number of accounts that would be affected by unsuspending an instance * Change migration to set silenced_at and suspended_at * Revert "Also unblock users who were suspended/silenced before dates were recorded" This reverts commit a015c65d2d. * Switch from using suspended and silenced to suspended_at and silenced_at * Add post-deployment migration script to remove `suspended` and `silenced` columns * Use Account#silence! and Account#suspend! instead of updating the underlying property * Add silenced_at and suspended_at migration to post-migration * Change account fabricator to translate suspended and silenced attributes * Minor fixes * Make unblocking domains always retroactive	6 years ago
Eugen Rochko	1714ea5978	Add ActivityPub representation for identity proofs (#10414) ... * Add ActivityPub representation for identity proofs * Add tests	6 years ago
ThibG	62dd0b7f9c	Fix processing poll Updates (#10333) ... ActivityPub::ProcessPollService was checking the JSON-LD context although it was passed only the `Question` object embedded in the `Update` activity.	6 years ago
Eugen Rochko	9f5b55ad4f	Fix poll update handler calling method was that was not available (#10246) ... * Fix poll update handler calling method was that was not available Fix regression from #10209 * Refactor VoteService * Refactor ActivityPub::DistributePollUpdateWorker and optimize it * Fix typo * Fix typo	6 years ago
ThibG	3a92885a86	Support pushing and receiving updates to poll tallies (#10209) ... * Process incoming poll tallies update * Send Update on poll vote * Do not send Updates for a poll more often than once every 3 minutes * Include voters in people to notify of results update * Schedule closing poll worker on poll creation * Add new notification type for ending polls * Add front-end support for ended poll notifications * Fix UpdatePollSerializer * Fix Updates not being triggered by local votes * Fix tests failure * Fix web push notifications for closing polls * Minor cleanup * Notify voters of both remote and local polls when those close * Fix delivery of poll updates to mentioned accounts and voters	6 years ago
ThibG	09c042aa10	Handle StaleObjectError when retrieving polls (#10208)	6 years ago
ThibG	df5924a1db	Do not error out on unsalvageable errors in FetchRepliesService (#10175) ... * Do not error out on unsalvageable errors in FetchRepliesService Fixes #10152 * Fix FetchRepliesWorker erroring out on deleted statuses	6 years ago
Eugen Rochko	4037b5eb1e	Fix last_fetched_at not being set on polls (#10170)	6 years ago
Eugen Rochko	e6900b167b	Fix another typo in ActivityPub::FetchRemotePollService (#10146)	6 years ago
Eugen Rochko	878a75ba21	Fix typo in ActivityPub::FetchRemotePollService (#10145)	6 years ago
Eugen Rochko	ae1b9cf70a	Fix remote poll expiration time (#10144)	6 years ago
ThibG	e13d3792f3	Make sure the poll is created before storing its id (#10142) ... * Make sure the poll is created before storing its id * Fix updating poll results * Support fetching Question activities from the search bar	6 years ago
Eugen Rochko	230a012f00	Add polls (#10111) ... * Add polls Fix #1629 * Add tests * Fixes * Change API for creating polls * Use name instead of content for votes * Remove poll validation for remote polls * Add polls to public pages * When updating the poll, update options just in case they were changed * Fix public pages showing both poll and other media	6 years ago
ThibG	9d3c6f1849	Improved remote thread fetching (#10106) ... * Fetch up to 5 replies when discovering a new remote status This is used for resolving threads downwards. The originating server must add a “replies” attributes with such replies for it to be useful. * Add some tests for ActivityPub::FetchRepliesWorker * Add specs for ActivityPub::FetchRepliesService * Serialize up to 5 public self-replies for ActivityPub notes * Add specs for ActivityPub::NoteSerializer * Move exponential backoff logic to a worker concern * Fetch first page of paginated collections when fetching thread replies * Add specs for paginated collections in replies * Move Note replies serialization to a first CollectionPage The collection isn't actually paginable yet as it has no id nor a `next` field. This may come in another PR. * Use pluck(:uri) instead of map(&:uri) to improve performances * Fix fetching replies when they are in a CollectionPage	6 years ago
Eugen Rochko	dad339da6d	Filter incoming Create activities by relation to local activity (#10005) ... Reject those from accounts with no local followers, from relays that are not enabled, which do not address local accounts and are not replies to accounts that do have local followers	6 years ago
abcang	e186bd2fb0	Fix Tombstone.delete_all ArgumentError (#9978)	6 years ago
ThibG	75b1488cf4	Add tombstones for remote statuses (#9830) ... * Add Tombstone model to remember object deletion * Do not recreate a status if it has been deleted * Record Tombstone for remote deleted items Also, only record deleted items from same-host actors * Clear an user's tombstones when their key change	6 years ago
ThibG	28b482874a	Improvements to signature verification (#9667) ... * Refactor signature verification a bit * Rescue signature verification if recorded public key is invalid Fixes #8822 * Always re-fetch AP signing key when HTTP Signature verification fails But when the account is not marked as stale, avoid fetching collections and media, and avoid webfinger round-trip. * Apply stoplight to key/account update as well as initial key retrieval	6 years ago
ThibG	290932602b	Reduce usage of LD signatures (#9659) ... * Do not LDS-sign Follow, Accept, Reject, Undo, Block * Do not use LDS for Create activities of private toots * Minor cleanup * Ignore unsigned activities instead of misattributing them * Use status.distributable? instead of querying visibility directly	6 years ago
Eugen Rochko	0f938ff29c	Add handler for Move activity (#9629)	6 years ago
ThibG	7f5a4be580	Fix emoji update date processing (#9255)	6 years ago
Eugen Rochko	eef8d9a5f7	Add locality check to ActivityPub::FetchRemoteAccountService (#9109) ... * Add locality check to ActivityPub::FetchRemoteAccountService Fix #8643 Because there are a few places where it is called, it is difficult to confirm if they all previously checked it for locality. It's better to make sure within the service. * Remove faux-remote duplicates of local accounts	6 years ago
Eugen Rochko	f4d549d300	Redesign forms, verify link ownership with rel="me" (#8703) ... * Verify link ownership with rel="me" * Add explanation about verification to UI * Perform link verifications * Add click-to-copy widget for verification HTML * Redesign edit profile page * Redesign forms * Improve responsive design of settings pages * Restore landing page sign-up form * Fix typo * Support <link> tags, add spec * Fix links not being verified on first discovery and passive updates	7 years ago
Eugen Rochko	cabdbb7f9c	Add CLI task for rotating keys (#8466) ... * If an Update is signed with known key, skip re-following procedure Because it means the remote actor did *not* lose their database * Add CLI method for rotating keys bin/tootctl accounts rotate [USERNAME] Generates a new RSA key per account and sends out an Update activity signed with the old key. * Key rotation: Space out Update fan-outs every 5 minutes per 1000 accounts * Skip suspended accounts in key rotation	7 years ago
ThibG	42573b76f1	Do not crash if remote custom emoji does not define updated date (fixes #8376) (#8377)	7 years ago
Eugen Rochko	802cf6a4c5	Improve federated ID validation (#8372) ... * Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible	7 years ago
Eugen Rochko	cc94b1d95a	Prevent ActivityPub movedTo recursion (#8092) ... Fix #8051	7 years ago
Akihiko Odaki	55fd55714a	Raise Mastodon::RaceConditionError if Redis lock failed (#7511) ... An explicit error allows user agents to know the error and Sidekiq to retry.	7 years ago
Wiktor	7fe2993b87	Fix account URI when updating ActivityPub account (#7488) ... Updates account `uri` field on each call to `update_account` instead of only once during `create_account` to mirror the same behavior in OStatus `ResolveAccountService` class [0]. ActivityPub accounts are identified using `@username` and `@domain` pair instead of URI since #6842. This fixes #7479: a bug when the account identified by `@username` and `@domain` changes its URI. [0]: 03b69ebc45/app/services/resolve_account_service.rb (L121)	7 years ago
ThibG	7467361d70	Fetch boosted statuses on behalf of a follower (fixes #7426) (#7459) ... When an ActivityPub Announce is processed and the boosted toot is not known, fetch it on behalf of one of the booster's followers. This is to allow fetching self-boosts of previously-unknown private toots. If fetching on behalf of a user fails, try fetching it anonymously: the selected follower of a boosting user may be banned by the boosted toot's author.	7 years ago
Surinna Curtis	01dfd6dbc8	Take the first recognized actor_type. (#7410)	7 years ago
Eugen Rochko	42cd363542	Bot nameplates (#7391) ... * Store actor type in database * Add bot nameplate to web UI, add setting to preferences, API, AP Fix #7365 * Fix code style issues	7 years ago
Eugen Rochko	c947e2e4c5	Fix handling of malformed ActivityPub payloads when URIs are nil (#7370) ... * Fix handling of malformed ActivityPub payloads when URIs are nil * Gracefully handle JSON-LD canonicalization failures	7 years ago
Eugen Rochko	965345316f	Guard against nil URLs in Request class (#7284) ... Fix #7265	7 years ago
Surinna Curtis	dc786c0cf4	Support Actors/Statuses with multiple types (#7305) ... * Add equals_or_includes_any? helper in JsonLdHelper * Support arrays in JSON-LD type fields for actors/tags/objects. * Spec for resolving accounts with extension types * Style tweaks for codeclimate	7 years ago
Eugen Rochko	78ed4ab75f	Add bio fields (#6645) ... * Add bio fields - Fix #3211 - Fix #232 - Fix #121 * Display bio fields in web UI * Fix output of links and missing fields * Federate bio fields over ActivityPub as PropertyValue * Improve how the fields are stored, add to Edit profile form * Add rel=me to links in fields Fix #121	7 years ago
Eugen Rochko	778562c223	Ensure SynchronizeFeaturedCollectionWorker is unique and clean up (#7043) ... * Ensure SynchronizeFeaturedCollectionWorker is unique and clean up Fix #7041 * Fix code style issue	7 years ago
Nolan Lawson	6ff3b3e4db	Fix nil account issue in ProcessAccountService (#7019)	7 years ago
Eugen Rochko	f890d2a766	Support all ActivityPub actor types (#6997) ... Fix #6973	7 years ago
David Underwood	123a343d11	[WIP] Enable custom emoji on account pages and in the sidebar (#6124) ... Federate custom emojis with accounts	7 years ago
Eugen Rochko	9381a7d9d5	Use username/domain to match existing accounts in ActivityPub (#6842) ... See also: #6837, #6667	7 years ago
Eugen Rochko	9110db41c5	Federate pinned statuses over ActivityPub (#6610) ... * Federate pinned statuses over ActivityPub * Display pinned toots in web UI Fix #6117 * Fix migration * Fix tests * Update outbox_serializer.rb * Update remove_serializer.rb * Update add_serializer.rb * Update fetch_featured_collection_service.rb	7 years ago
puckipedia	74c1c9ec01	Allow attributedTo in a status to be an embedded object (#6238)	7 years ago
Eugen Rochko	e4a241abef	Fix bad URL schemes being accepted (#6219) ... * Fix actors accepting invalid URI schemes or different host between URI and URL * Fix statuses accepting invalid URI scheme or different host to actor * Adjust tests to new requirements * Improve readability of mismatching_origin?/invalid_origin? methods	7 years ago
Eugen Rochko	d319b3dbe4	Update moved-to property when it's removed too (#6160) ... * Fix #6140 - Update moved-to property when it's removed too * Remove trailing whitespace	7 years ago
Yamagishi Kazutoshi	b21db9bbde	Using double splat operator (#5859)	7 years ago
Eugen Rochko	4c6b5dbe96	Add semi-support for Video/Image objects in ActivityPub (#5848) ... * Add semi-support for Video/Image objects in ActivityPub Video and Image objects will create corresponding status records with manually crafted text contents (title + URL) * Extract html-url-finding logic into JsonLdHelper * Fallback to id when url missing, extract supported object types	7 years ago
abcang	2bcc81700c	Fix NoMethodError at ActivityPub::FetchRemoteStatusService (#5753)	7 years ago
Eugen Rochko	58cede4808	Profile redirect notes (#5746) ... * Serialize moved accounts into REST and ActivityPub APIs * Parse federated moved accounts from ActivityPub * Add note about moved accounts to public profiles * Add moved account message to web UI * Fix code style issues	7 years ago
ThibG	d37a56c07c	Update remote ActivityPub users when fetching their toots (#5545)	7 years ago
Eugen Rochko	3888a12c79	Fix #5272 - Order of checks in ActivityPub handler (#5276)	7 years ago
Eugen Rochko	0717d9b3e6	Set snowflake IDs for backdated statuses (#5260) ... - Rename Mastodon::TimestampIds into Mastodon::Snowflake for clarity - Skip for statuses coming from inbox, aka delivered in real-time - Skip for statuses that claim to be from the future	7 years ago
ThibG	0e1b0f2747	Check Webfinger-returned author URI even when not redirected (#5213) ... The whole point of verified_webfinger? is to check the WebFinger-discoverable URI maps back to the known author URI. This was not actually verified if the first Webfinger request was not a redirection.	7 years ago
Akihiko Odaki	63f0979799	Validate id of ActivityPub representations (#5114) ... Additionally, ActivityPub::FetchRemoteStatusService no longer parses activities. OStatus::Activity::Creation no longer delegates to ActivityPub because the provided ActivityPub representations are not signed while OStatus representations are.	7 years ago
Eugen Rochko	c743b5e1fd	Fix possible acct: uri usurpation in ActivityPub account discovery (#5208) ... Signed-off-by: Eugen Rochko <eugen@zeonfederated.com>	7 years ago
Eugen Rochko	cf7fbf2c56	Fix #5059 - Stop processing payload if it's from local account (#5100)	8 years ago
Eugen Rochko	41e6c8b151	Fix incomplete account records being read (#4998) ... * Fix incomplete account records being read - Put account processing into redis lock - Do not save until record is complete * Fix spaces	8 years ago
ThibG	af00220d79	Fix refollowing (#4931) ... * Make RefollowWorker ActivityPub-only to avoid potential identifier mismatches * Don't call RefollowWorker on new accounts	8 years ago
Eugen Rochko	b9d241c6f5	Fix #4917 - Add missing suspend checks (#4921)	8 years ago
ThibG	f29918e707	[WiP] Whenever a remote keypair changes, unfollow them and re-subscribe to … (#4907) ... * Whenever a remote keypair changes, unfollow them and re-subscribe to them In Mastodon (it could be different for other OStatus or AP-enabled software), a keypair change is indicative of whole user (or instance) data loss. In this situation, the “new” user might be different, and almost certainly has an empty followers list. In this case, Mastodon instances will disagree on follower lists, leading to unreliable delivery and “shadow followers”, that is users believed by a remote instance to be followers, without the affected user knowing. Drawbacks of this change are: 1. If an user legitimately changes public key for some reason without losing data (not possible in Mastodon at the moment), they will have their remote followers unsubscribed/re-subscribed needlessly. 2. Depending of the number of remote followers, this may generate quite some traffic. 3. If the user change is an attempt at usurpation, the remote followers will unknowingly follow the usurper. Note that this is *not* a change of behavior, Mastodon already behaves like that, although delivery might be unreliable, and the usurper would not have known the former user's followers. * Rename ResubscribeWorker to RefollowWorker * Process followers in batches	8 years ago
Eugen Rochko	9e15eeec63	Add missing reject_media check before avatar download via ActivityPub (#4862)	8 years ago
Eugen Rochko	a4caa7eb62	Fetch statuses/following/followers numbers from ActivityPub collections (#4840)	8 years ago
Eugen Rochko	9b50a9dd83	Fix some ActivityPub JSON bugs (#4796) ... - Fix assumption that `url` is always a string. Handle it if it's an array of strings, array of objects, object, or string, both for accounts and for objects - `sharedInbox` is actually supposed to be under `endpoints`, handle both cases and adjust the serializer	8 years ago
Eugen Rochko	37fdddd927	Rename "locked" to "manuallyApprovesFollowers" in ActivityPub (#4779) ... See: <https://www.w3.org/wiki/Activity_Streams_extensions#as:manuallyApprovesFollowers>	8 years ago
Eugen Rochko	1b5806b744	Define missing JSON-LD properties (#4767) ... Using _: property names is discouraged, as in the future, canonicalization may throw an error when encountering that instead of discarding it silently like it does now. We are defining some ActivityStreams properties which we expect to land in ActivityStreams eventually, to ensure that future versions of Mastodon will remain compatible with this even once that happens. Those would be `locked`, `sensitive` and `Hashtag` We are defining a custom context inline for some properties which we do not expect to land in any other context. `atomUri`, `inReplyToAtomUri` and `conversation` are part of the custom defined OStatus context.	8 years ago
unarist	f7937d903c	Don't process ActivityPub payload if signature is invalid (#4752) ... * Don't process ActivityPub payload if signature is invalid * Fix style issue	8 years ago
Eugen Rochko	00840f4f2e	Add handling of Linked Data Signatures in payloads (#4687) ... * Add handling of Linked Data Signatures in payloads * Add a way to sign JSON, fix canonicalization of signature options * Fix signatureValue encoding, send out signed JSON when distributing * Add missing security context	8 years ago
unarist	b01a19fe39	Fetch reblogs as Announce activity instead of Note object (#4672) ... * Process Create / Announce activity in FetchRemoteStatusService * Use activity URL in ActivityPub for reblogs * Redirect to the original status on StatusesController#show	8 years ago
unarist	d63de55ef8	Fix bugs which OStatus accounts may detected as ActivityPub ready (#4662) ... * Fallback to OStatus in FetchAtomService * Skip activity+json link if that activity is Person without inbox * If unsupported activity was detected and all other URLs failed, retry with ActivityPub-less Accept header * Allow mention to OStatus account in ActivityPub * Don't update profile with inbox-less Person object	8 years ago
Eugen Rochko	72bb3e03fd	Support more variations of ActivityPub keyId in signature (#4630) ... - Tries to avoid performing HTTP request if the keyId is an actor URI - Likewise if the URI is a fragment URI on top of actor URI - Resolves public key, returns owner if the owner links back to the key	8 years ago
Eugen Rochko	6e9eda5331	ActivityPub migration procedure (#4617) ... * ActivityPub migration procedure Once one account is detected as going from OStatus to ActivityPub, invalidate WebFinger cache for other accounts from the same domain * Unsubscribe from PuSH updates once we receive an ActivityPub payload * Re-subscribe to PuSH unless already unsubscribed, regardless of protocol	8 years ago
Eugen Rochko	4e75f0d889	Hook up URL-based resource look-up to ActivityPub (#4589)	8 years ago
Eugen Rochko	ccdd5a9576	Add serializing/unserializing of "locked" actor attribute (#4585)	8 years ago
Eugen Rochko	dd7ef0dc41	Add ActivityPub inbox (#4216) ... * Add ActivityPub inbox * Handle ActivityPub deletes * Handle ActivityPub creates * Handle ActivityPub announces * Stubs for handling all activities that need to be handled * Add ActivityPub actor resolving * Handle conversation URI passing in ActivityPub * Handle content language in ActivityPub * Send accept header when fetching actor, handle JSON parse errors * Test for ActivityPub::FetchRemoteAccountService * Handle public key and icon/image when embedded/as array/as resolvable URI * Implement ActivityPub::FetchRemoteStatusService * Add stubs for more interactions * Undo activities implemented * Handle out of order activities * Hook up ActivityPub to ResolveRemoteAccountService, handle Update Account activities * Add fragment IDs to all transient activity serializers * Add tests and fixes * Add stubs for missing tests * Add more tests * Add more tests	8 years ago