855 Commits (2801b5409b0db2d2dab6e74f34114946f68d7746)

Author	SHA1	Message	Date
ThibG	1390cc194b	Add indication to admin UI of whether a report has been forwarded (#13237) ... * Add indication to admin UI of whether a report has been forwarded * Rework how forwarded status is displayed Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	e7e099d1a0	Fix deletes not reaching every server that interacted with status (#15200) ... Extract logic for determining ActivityPub inboxes to send deletes to to its own class and explicitly include the person the status replied to (even if not mentioned), people who favourited it, and people who replied to it (though that one is still not recursive)	4 years ago
ThibG	66832cbf33	Undo outgoing follows when suspending a remote account (#15188)	4 years ago
ThibG	8b8004a962	Fix webfinger redirect handling in ResolveAccountService (#15187) ... * Fix webfinger redirect handling in ResolveAccountService ResolveAccountService#process_webfinger! handled a one-step webfinger redirection, but only accepting the result if it matched the exact URI passed as input, defeating the point of a redirection check. Instead, use the same logic as in `ActivityPub::FetchRemoteAccountService`, updating the resulting `acct:` URI with the result of the first webfinger query. * Add tests	4 years ago
ThibG	96c1e71329	Add import/export feature for bookmarks (#14956) ... * Add ability to export bookmarks * Add support for importing bookmarks * Add bookmark import tests * Add bookmarks export test	4 years ago
ThibG	2f6831f318	Fix sending spurious Rejects when processing remote account deletion (#15104) ... * Fix sending spurious Rejects when processing remote account deletion * Make skip_side_effects imply skip_activitypub	4 years ago
Eugen Rochko	df1653174b	Add cache buster feature for media files (#15155) ... Nginx can be configured to bypass proxy cache when a special header is in the request. If the response is cacheable, it will replace the cache for that request. Proxy caching of media files is desirable when using object storage as a way of minimizing bandwidth costs, but has the drawback of leaving deleted media files for a configured amount of cache time. A cache buster can make those media files immediately unavailable. This especially makes sense when suspending and unsuspending an account.	4 years ago
ThibG	966593393e	Fix DMs not appearing into timelines (#15182) ... Fixes #15179	4 years ago
ThibG	1e64666662	Fix crash in SuspendAccountWorker (#15106) ... * Fix crash in SuspendAccountWorker `follows` is an array thanks to `to_a` * Fix code style issue Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>	4 years ago
Eugen Rochko	3134691948	Add support for reversible suspensions through ActivityPub (#14989)	4 years ago
ThibG	ee8cf246cf	Fix crashes in SuspendAccountService/UnsuspendAccountService (#15100) ... * Fix crashes in SuspendAccountService/UnsuspendAccountService * Catch filesystem errors	4 years ago
ThibG	f84239ecab	Fix suspension/unsuspension not working because of FeedManager change (#15099)	4 years ago
ThibG	1f945e7390	Fix followers synchronization mechanism not being triggered on mentions (#15026) ... e.g. if someone on an instance that previously had followers gets mentioned in a private toot, before this PR, they would not receive a Collection-Synchronization header and may show the toot to the former followers in addition to the mentioned person.	4 years ago
ThibG	fb586584f2	Fix account processing failing because of large collections (#15027) ... Fixes #15025	4 years ago
ThibG	ca56527140	Add follower synchronization mechanism (#14510) ... * Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each	4 years ago
OSAMU SATO	96761752ec	Add duration parameter to muting. (#13831) ... * Adding duration to muting. * Remove useless checks	4 years ago
Eugen Rochko	5e1364c448	Add IP-based rules (#14963)	4 years ago
Eugen Rochko	7d985f2aac	Remove dependency on goldfinger gem (#14919) ... There are edge cases where requests to certain hosts timeout when using the vanilla HTTP.rb gem, which the goldfinger gem uses. Now that we no longer need to support OStatus servers, webfinger logic is so simple that there is no point encapsulating it in a gem, so we can just use our own Request class. With that, we benefit from more robust timeout code and IPv4/IPv6 resolution. Fix #14091	4 years ago
Eugen Rochko	974b1b79ce	Add option to be notified when a followed user posts (#13546) ... * Add bell button Fix #4890 * Remove duplicate type from post-deployment migration * Fix legacy class type mappings * Improve query performance with better index * Fix validation * Remove redundant index from notifications	4 years ago
Eugen Rochko	ed099d8bdc	Change account suspensions to be reversible by default (#14726)	5 years ago
Eugen Rochko	65760f59df	Refactor feed manager (#14761)	5 years ago
Eugen Rochko	e8bc187845	Refactor how public and tag timelines are queried (#14728)	5 years ago
Eugen Rochko	1c308af84c	Change own direct-visibility statuses to be in the home feed again (#14711) ... And remove highlighting in web UI Full circle from #8940	5 years ago
dependabot[bot]	8972e5f7f6	Bump rubocop from 0.86.0 to 0.88.0 (#14412) ... * Bump rubocop from 0.86.0 to 0.88.0 Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.88.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.86.0...v0.88.0) Signed-off-by: dependabot[bot] <support@github.com> * Fix for latest RuboCop Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	5 years ago
Takeshi Umeda	b1bb1906be	Fix limited follower id in fan-out-on-write service (#14709)	5 years ago
Eugen Rochko	ce8f33dd2f	Fix inefficiencies in fan-out-on-write service (#14682)	5 years ago
Akihiko Odaki	41eeb9ebaa	Use Status.group instead of Status.distinct in HashQueryService (#14662) ... DISTINCT clause removes duplicated records according to all the selected attributes. In reality, it can remove duplicated records only looking at statuses.id, but the clause confuses the query planner and yields insufficient performance. The behavior is also problematic if the scope produced by HashQueryService is used to query columns without id (using pluck method, for example). The scope is expected to contain unique statuses, but the uniquness will be evaluated with some arbitrary columns other than id. GROUP BY clause resolves those problem by explicitly specifying the column to take into account for the record distinction. A workaround for the problem of DISTINCT clause in Api::V1::Timelines::TagController is no longer necessary and removed.	5 years ago
Takeshi Umeda	156af70e4d	Fix following restriction not working when exact match in account search (#14394)	5 years ago
Takeshi Umeda	939a47393c	Fix duplicate notification and delivery of mentions (#14378)	5 years ago
Takeshi Umeda	7540e235a2	Fix movie width and frame_rate returning nil (#14357) ... * Fix movie width and frame_rate returning nil * Add StreamValidationError and raise * Fix code style	5 years ago
ThibG	d658af7ff8	Fix removing allowed domains being done synchronously (#14302) ... * Fix removing allowed domains being done synchronously * Add tests	5 years ago
Eugen Rochko	98b3b80d6b	Fix account domain block not properly unfollowing accounts from domain (#14304) ... Fix #14303	5 years ago
ThibG	ee5a4030f7	Fix removing a DomainAllow rule wiping known accounts in open federation mode (#14298) ... Fixes #14296	5 years ago
Eugen Rochko	ed04697510	Change User-Agent of link preview fetching service to include "Bot" (#14248) ... This forces Twitter to render OpenGraph tags in the response	5 years ago
Eugen Rochko	64aac30733	Add customizable thumbnails for audio and video attachments (#14145) ... - Change audio files to not be stripped of metadata - Automatically extract cover art from audio if it exists - Add `thumbnail` parameter to `POST /api/v1/media`, `POST /api/v2/media` and `PUT /api/v1/media/:id` - Add `icon` to represent it in attachments in ActivityPub - Fix `preview_url` containing URL of missing missing image when there is no thumbnail instead of null - Fix duration of audio not being displayed on public pages until the file is loaded	5 years ago
ThibG	89f40b6c3e	Make domain block/silence/reject-media code more robust (#13424) ... * Split media cleanup from reject-media domain blocks to its own service * Slightly improve ClearDomainMediaService error handling * Lower DomainClearMediaWorker to lowest-priority queue * Do not catch ActiveRecord::RecordNotFound in domain block workers * Fix DomainBlockWorker spec labels * Add some specs * Change domain blocks to immediately mark accounts as suspended Rather than doing so sequentially, account after account, while cleaning their data. This doesn't change much about the time the block takes to complete, but it immediately prevents interaction with the blocked domain, while up to now, it would only be guaranteed when the process ends.	5 years ago
Takeshi Umeda	d890abfcab	Fix performance of follow import (#13836)	5 years ago
Takeshi Umeda	643065799b	Fix activity not being signed (#13948)	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820)	5 years ago
ThibG	27ea7c13a5	Fix hashtag search performing account search as well (#13758)	5 years ago
Takeshi Umeda	d8bad8fbf6	Fix not publishing update of remote timeline (#13745) ... * Fix not publishing update of remote timeline * fix @ missing * if/unless to if/else	5 years ago
Eugen Rochko	4b766f9846	Refactor monkey-patching of Goldfinger (#12561)	5 years ago
Eugen Rochko	2744f61696	Fix not being able to resolve public resources in development environment (#13505)	5 years ago
Eugen Rochko	c3965e28b3	Fix returning results when searching for URL with non-zero offset (#13377) ... Fix #13083	5 years ago
Takeshi Umeda	11169367e4	Fix incorrect deletion of local accounts imported by overwriting (#13350)	5 years ago
ThibG	f08f880f58	Fix media not being marked sensitive when client sets a CW but no text (#13277) ... Mastodon enforces the “sensitive” flag on media attachments whenever a toot is posted with a Content Warning. However, it does so *after* potentially converting the Content Warning to toot text (when there is no toot text), which leads to inconsistent and surprising behavior for API clients. This commit fixes this inconsistency.	5 years ago
ThibG	cb12a2cdd3	Fix some timeouts when searching URLs by limiting some database queries (#13253) ... Only look up private toots from database if the request failed because of 401, 403 or 404 errors, as those may indicate a private toot, rather than something that isn't a toot or cannot be processed.	5 years ago
ThibG	b154428e14	Add federation support for the "hide network" preference (#11673) ... * Change ActivityPub follower/following collections to not link first page * Add support for hiding followers and following of remote users * Switch to using a single `hide_collections` column * Address code style remarks	5 years ago
Eugen Rochko	9660aa4543	Change local media attachments to perform heavy processing asynchronously (#13210) ... Fix #9106	5 years ago
ThibG	5284e29e2f	Fix public posts from silenced accounts not being changed to unlisted visibility (#13096)	5 years ago
ThibG	6185bff4b3	Fix error when searching for URLs that contain the mention syntax (#13151) ... Fixes #13150	5 years ago
Eugen Rochko	339ce1c4e9	Add specific rate limits for posting and following (#13172)	5 years ago
ThibG	cf4fe6caef	Fix misleading error when attempting to re-send a pending follow request (#13133) ... Fixes #13131	5 years ago
ThibG	d91946ae13	Fix backups failing when files are missing from media attachments (#13146) ... Fixes #13123	5 years ago
ThibG	3704402dcc	Fix duplicate accounts being created when fetching an account for its key only (#13147) ... Fixes #13136 When a user's canonical acct domain is different from its id's domain (WEB_DOMAIN ≠ LOCAL_DOMAIN), two webfinger queries are required to find the canonical domain from the URI. However, we skip webfinger queries when updating only the key of a remote user, which led to the creation of a duplicate account, using the URI's domain instead of the canonical acct: one.	5 years ago
ThibG	983ab40086	Fix previously OStatus-based accounts not being detected as ActivityPub (#13129)	5 years ago
ThibG	d386d89179	Fix invalid votes from the API being accepted (#12601) ... * Fix invalid votes from the API being accepted Fixes #12556 - Ensure `choice` is an integer instead of silently converting to 0 - Ensure `choice` corresponds to an actual choice of the poll * Please CodeClimate	5 years ago
Daigo 3 Dango	206dfd7dad	Clarify keyword arguments with ** (#12769) ... This change is to suppress the warning below on on ruby-2.7.0: - warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/	5 years ago
ThibG	c306978190	Use quality values in Accept field to explicitly prefer JSON over HTML (#12806)	5 years ago
ThibG	e4d75f238b	Fix URL search not returning private toots user has access to (#12742)	5 years ago
Eugen Rochko	f86ee4b59f	Fix IDN mentions not being processed, IDN domains not being rendered (#12715) ... This changes the REST API to return unicode domains in the `acct` attribute instead of punycode, and to render unicode instead of punycode on public HTML pages as well. Fix #7812, fix #12246	5 years ago
chr v1.x	7e074610a6	Fix backups stopping due to read timeouts (#12281) ... * Make BackupService resilient to read timeouts If an attachment read times out, assume that the resources is inaccessible and continue the backup without it. This fixes #12280. * Both errors on one line	5 years ago
ThibG	b364175e1b	Fix link crawler not specifying accepted content-type (#12646) ... The link crawler expects HTML documents, so set the `Accept` header accordingly. Fixes #12618	5 years ago
Takeshi Umeda	68070e82cc	Add signature to exported status (#12649)	5 years ago
Takeshi Umeda	a391eaf4d8	Fix an error when ActivityPub::FetchRemoteStatusService url is called with nil (#12652)	5 years ago
ThibG	2ee5a9d9c3	Clean up OStatus-related codepaths (#12173) ... * Remove “protocol” argument and return value, as only ActivityPub is supported * Remove FetchRemoteAccountService, only use ActivityPub::FetchRemoteAccountService * Fix tests	5 years ago
Alice Gaudon	668f698077	Admin setting to disable default follows (#12566)	5 years ago
trwnh	1653ae91ce	Fix account search with no query (#12549) ... * Fix account search with no query Modeled after #12541. Fix #12548 * fix codeclimate	5 years ago
Eugen Rochko	bbf926b1c0	Fix error when using search API with no query (#12541) ... Fix #12462	5 years ago
ThibG	911cc14481	Add follow_request notification type (#12198) ... * Add follow_request notification type The notification type already existed in the backend but was never pushed to the front-end. This also means translation strings were also available for the backend, from the notification mailer. Unlike other notification types, these are off by default, to match what I remember of Gargron's view on the topic: that follow requests should not clutter notifications and should instead be reviewed at the user's own leisure in the dedicated column. Since follow requests have their own column, I've deemed it unnecessary to add a specific tab for them in the notification quick filter. * Show follow request link in single-column if there are pending requests, even if account isn't locked * Push follow requests from notifications to the follow_requests list * Offer to accept or reject follow request from the notification * Redesign follow request notification	5 years ago
ThibG	00c219aa45	Fix empty poll options not being filtered on remote poll update (#12484) ... If a poll contains empty options (which is apparently possible on Pleroma), it is created without them. However, the poll update code doesn't filter empty options, and thus: 1. Clear known votes, as it assumes the set of options has changed 2. Errors out because it tries adding empty options, which fails validation This commit fixes that by filtering them out the same way they are filtered out at poll creation time.	5 years ago
Eugen Rochko	a60b602ade	Fix OEmbed discovery not handling different URL variants in query (#12439) ... Fix #12433	5 years ago
ThibG	c656cc2191	Fix FetchLinkCardServices crashing on a tags without a target (#12159) ... * Add test for links without targets * Fix FetchLinkCardServices crashing on a tags without a target	5 years ago
ThibG	c4d45765e3	Change domain block behavior to update user records before deleting data (#12247) ... When suspending or silencing a domain, one probably wants the silence or suspend parts to take effect as soon as possible. Deleting media files can take a while (possibly days), so perform silencing as soon as possible, and clean up media afterwards.	5 years ago
Eugen Rochko	d14e74eff5	Add cache for OEmbed endpoints to avoid extra HTTP requests (#12403) ... * add youtube oembed endpoint * add check for oembed endpoint * change unless for a more readable if * clear blank lines * endpoint via https * Fix string literal in condition * use cache for endpoints * use cache for endpoints * clean up and adding check * clean up and remove redundant return * add html check * add false to return * use double quotes * use double quotes * Clean up	5 years ago
ThibG	dfea7368c9	Add bookmarks (#7107) ... * Add backend support for bookmarks Bookmarks behave like favourites, except they aren't shared with other users and do not have an associated counter. * Add spec for bookmark endpoints * Add front-end support for bookmarks * Introduce OAuth scopes for bookmarks * Add bookmarks to archive takeout * Fix migration * Coding style fixes * Fix rebase issue * Update bookmarked_statuses to latest UI changes * Update bookmark actions to properly reflect status changes in state * Add bookmarks item to single-column layout * Make active bookmarks red	5 years ago
ThibG	0d5f3ae331	Fix already-known remote private toots not being searchable by URL (#12336) ... * Fix already-known remote private toots not being searchable by URL Whenever an URL search fails, and an account is provided, try getting a private status matching that URL from database. * Fix searching by `id` field instead of `uri`	5 years ago
ThibG	66c1fe0495	Fix various issues with account migration (#12301) ... * Fix being able to follow oneself by moving to an account that was following the old one * Add specs * Add spec to catch MoveWorker issue with local followers following both accounts * Fix move worker breaking when a local account follows both source and target accounts * Fix migration from remote to local account not sending Undo Follow * Fix show_reblogs not being preserved for moved account's followers	5 years ago
ThibG	65e13cfacf	Add abilityto add oneself to lists (#12271) ... * Add ability to add oneself to lists * Change search results to include oneself when searching through followers * Mark follow relation as optional in ListAccount	5 years ago
nightpool	9762fe382c	microformat mentions can have an implicit property (#12189) ... See the first example here: http://microformats.org/wiki/microformats2#hyperlinked_person	5 years ago
Eugen Rochko	8386d9ec10	Fix hashtag timeline REST API accepting too many hashtags (#12091)	5 years ago
Eugen Rochko	eb83d6256e	Add `reason` param to `POST /api/v1/accounts` REST API (#12064) ... For approval-required registrations mode	5 years ago
ThibG	3a4d994c40	Fix BootstrapTimelineService crashing when bootstrapped accounts are invalid (#12037) ... * Add test to handle suspended and missing users in BootstrapTimelineService * Fix BootstrapTimelineService crashing when bootstrapped accounts are invalid	5 years ago
Eugen Rochko	9ba40a6bfd	Remove HEAD request from fetching link previews (#12028) ... It is not really necessary and we need to reduce requests	5 years ago
abcang	9ef5532a7e	Fix follow requests N+1 (#12004)	5 years ago
ThibG	3babf8464b	Add voters count support (#11917) ... * Add voters count to polls * Add ActivityPub serialization and parsing of voters count * Add support for voters count in WebUI * Move incrementation of voters count out of redis lock * Reword “voters” to “people”	5 years ago
Eugen Rochko	368a87755b	Fix account migration not affecting followers on origin server (#11980)	5 years ago
Eugen Rochko	3ec80c7aec	Fix preview card image not being re-fetched even if link is re-posted (#11981) ... Fix #11956	5 years ago
Eugen Rochko	ab33c4df94	Add `exclude_unreviewed` param to `GET /api/v2/search` REST API (#11977) ... Make it so normal search returns even unreviewed matches, but autosuggestions do not. Fix #11960	5 years ago
ThibG	18b451c0e6	Change silences to always require approval on follow (#11975) ... * Change silenced accounts to require approval on follow * Also require approval for follows by people explicitly muted by target accounts * Do not auto-accept silenced or muted accounts when switching from locked to unlocked * Add `follow_requests_count` to verify_credentials * Show “Follow requests” menu item if needed even if account is locked * Add tests * Correctly reflect that follow requests weren't auto-accepted when local account is silenced * Accept follow requests from user-muted accounts to avoid leaking mutes	5 years ago
Eugen Rochko	2f90a38f44	Fix unreviewed hashtag not being found by exact case-insensitive match (#11976)	5 years ago
Jeong Arm	00d7bdcc2a	Fix search error when ElasticSearch is enabled but not available (#11954) ... * Fallback to Database search when ES not available * Prevent double work if ES gives 0 result * Apply suggestion from code review	5 years ago
Eugen Rochko	4f6af87906	Change spam check to apply to local accounts and add a threshold (#11806) ... Instead of detecting spam on first duplicate message, add a threshold of 5 such messages to reduce false positives	6 years ago
Eugen Rochko	38dc51b2d6	Fix Move handler queuing jobs that will fail if account is suspended (#11864) ... Don't put Move handler on cooldown if it didn't run. Skip unmerging from timelines to save unnecessary work.	6 years ago
Eugen Rochko	50edf84898	Fix search API not resolving URL when type is given (#11822) ... Fix #11771	6 years ago
Eugen Rochko	c5d37f18cb	Change deletes to preserve soft-deleted statuses in unresolved reports (#11805) ... Change all account actions except "none" to resolve all unresolved reports Refactor `SuspendAccountService` to be more readable	6 years ago
Eugen Rochko	43f56f1291	Change account deletion page to have better explanations (#11753) ... Fix deletion of unconfirmed account not freeing up the username Add prefill of logged-in user's email in the reconfirmation form	6 years ago
Eugen Rochko	cb447b28c4	Add profile directory to web UI (#11688) ... * Add profile directory to web UI * Add a line of bio to the directory	6 years ago
Eugen Rochko	97192d9a77	Fix remote and staff-removed statuses leaving media behind for a day (#11638) ... The reason for unattaching media instead of removing it is to support delete & redraft functionality, but remote or staff-removed statuses will never be redrafted, so the media should be deleted immediately	6 years ago
Eugen Rochko	cc0a55cf9a	Add more accurate hashtag search (#11579) ... * Add more accurate hashtag search Using ElasticSearch to index hashtags with edge n-grams and score them by usage within the last 7 days since last activity. Only hashtags that have been reviewed and are listable can appear in searches, unless they match the query exactly * Fix search analyzer dropping non-ascii characters	6 years ago