368 Commits (26949607d25872d4549f96ecf38c317c2774c225)

Author	SHA1	Message	Date
Eugen Rochko	72698bc3b4	Fix regressions from #2683 (#2970) ... * Fix regressions from #2683 Properly format spoiler text HTML, while keeping old logic for blankness intact Process hashtags and mentions in spoiler text Format spoiler text for Atom Change "show more" toggle into a button instead of anchor Fix style regression on dropdowns for detailed statuses * Fix lint issue * Convert spoiler text to plaintext in desktop notifications	9 years ago
Eugen Rochko	a231f915a0	Fix #2955 - Send HEAD request ahead of GET when fetching URL previews (#2972)	9 years ago
alpaca-tc	c3ef5d5414	Add `account_id DESC` to optimize PrecomputeFeedService (#2967)	9 years ago
R Tucker	e2491680e6	Handle hashtags in spoiler_texts (partial fix for #699) (#2683) ... * services: scan spoiler_text for hashtags (#699) * views: link hashtags from spoiler_texts This covers linking hashtags from within the spoiler text on the server-generated pages. * services: fix string concat going into hashtag RE Cleaner Ruby syntax, may handle immutable strings better	9 years ago
Eugen Rochko	3a38322a54	Add spec for Pubsubhubbub::DistributionWorker. PuSH-deliver public items (#2954) ... to all subscribers. IDN-normalize callback URLs for subscriptions on insert.	9 years ago
Matt Jankowski	682507bc3c	Specs for pubsub subscribe service (#2951) ... * Add spec for pubsubhubbub/subscribe * Refactor pubsubhubbub/subscribe service	9 years ago
Matt Jankowski	441d6dc734	Spec and refactor for pubsubhubbub/unsubscribe service (#2946) ... * Add coverage for pubsub unsubscribe service * Refactor pubsub unsubscribe service	9 years ago
Matt Jankowski	5bea42412e	Services specs for subscribe and unsubscribe (#2928) ... * Add specs for unsubscribe service * Fix non existent methods in unsubscribe service * Clean up status handling in subscribe service	9 years ago
Matt Jankowski	b8ba719f73	Unblock domain service specs/refactor (#2867) ... * Add spec for unblock domain service * Refactor UnblockDomainService	9 years ago
alpaca-tc	74036a2c9d	Hotfix convert string from symbol (#2856) ... * Convert key to string from symbol * Prefer :public_send instead of	9 years ago
alpaca-tc	a0b1951791	Refactor domain_blocks_controller (#2843) ... * Set domain_block by before_action * Cast value with ActiveRecord::Type * Batch update	9 years ago
alpaca-tc	59804abc3d	Optimize MuteService and AfterBlockService (#2836)	9 years ago
alpaca-tc	1f15a15621	Handling failed http response (#2823)	9 years ago
Matt Jankowski	4e05751346	Move account header and avatar methods to a concern (#2825)	9 years ago
Matt Jankowski	20c37ed0f9	Add specs (and refactor) of FetchRemoteResourceService and SearchService (#2812) ... * Coverage for fetch remote resource service * Refactor fetch remote resource service * Coverage for search service * Refactor search service	9 years ago
Eugen Rochko	81584779cb	More robust PuSH subscription refreshes (#2799) ... * Fix #2473 - Use sidekiq scheduler to refresh PuSH subscriptions instead of cron Fix an issue where / in domain would raise exception in TagManager#normalize_domain PuSH subscriptions refresh done in a round-robin way to avoid hammering a single server's hub in sequence. Correct handling of failures/retries through Sidekiq (see also #2613). Optimize Account#with_followers scope. Also, since subscriptions are now delegated to Sidekiq jobs, an uncaught exception will not stop the entire refreshing operation halfway through Fix #2702 - Correct user agent header on outgoing http requests * Add test for SubscribeService * Extract #expiring_accounts into method * Make mastodon:push:refresh no-op * Queues are now defined in sidekiq.yml * Queues are now in sidekiq.yml	9 years ago
alpaca-tc	74c8ca699c	Delete records in smaller transaction (#2802)	9 years ago
Yamagishi Kazutoshi	e95983f5df	Decode IDNA in PreviewCard (#2781)	9 years ago
Eugen Rochko	13c16b4e95	Likely fix #2458, fix #2031 - handle out-of-order deletes for statuses (#2734) ... * Likely fix #2458, fix #2031 - handle out-of-order deletes for statuses If a delete arrives before the original status, cache that information for 6h, and if the original status arrives in that window, ignore it * Add test case	9 years ago
Eugen Rochko	bafd22ecf4	Fix #2706 - Always respond with 200 to PuSH payloads (#2733) ... Fix #2196 - Respond with 201 when Salmon accepted, 400 when unverified Fix #2629 - Correctly handle confirm_domain? for local accounts Unify rules for extracting author acct from XML, prefer <email>, fall back to <name> + <uri> (see also #2017, #2172)	9 years ago
yhirano	8325866c61	Downgrade rubocop 0.48.1 => 0.46.0 (#2628) ... * downgrade rubocop 0.48.1 => 0.46.0 * exclude vendor/**/* from rubocop target files * add frozen_string_literal comment line * fix percent literal delimited by ( and ) * fix alignment * remove comment disabling unknown cop	9 years ago
Patrick Figel	197af5de70	Set unknown attachment type when adding domain blocks (#2605) ... Follow-up to #2599. When a domain block with `reject_media` is added or `rake mastodon:media:remove_remote` is invoked, mastodon deletes the locally cached attachments and avatars but does not reflect that change in the database, causing the `file` fields to still have values. This change persists the deletion in the database and sets the attachment type to unknown. This also introduces a one-off rake task that sets all attachments without a local file to the "unknown" type. The upgrade notes for the next release should contain a post-upgrade step with `rake mastodon:media:set_unknown`.	9 years ago
Eugen Rochko	2af4f3c4e2	Improve shared status verification (#2525) ... * Instead of parsing shared status contents verbatim, make roundtrip to purported original URL. Confirm that the "original" URL is from the same domain as the author it claims to be from. * Fix obvious typo, add comment * Use URI look-up first * Add test, update Goldfinger dependency to make less useless HTTP requests per Webfinger lookup	9 years ago
Eugen Rochko	88725d6ce8	OEmbed support for PreviewCard (#2337) ... * OEmbed support for PreviewCard * Improve ProviderDiscovery code failure treatment * Do not crawl links if there is a content warning, since those don't display a link card anyway * Reset db schema * Fresh migrate * Fix rubocop style issues Fix #1681 - return existing access token when applicable instead of creating new * Fix test * Extract http client to helper * Improve oembed controller	9 years ago
Matt Jankowski	8857cabca4	Domain block service cleanup (#2490) ... * Add coverage for domain block service with silence * Get rid of warning about find_each and order * Move domain_block to attr_reader * Move optional clear_media into silence_accounts method * Use blocked_domain method to reduce passed vars * Extract blocked_domain_accounts method to find accounts on the domain * Extract media_from_blocked_domain method to find relevant attachments * Separate destruction of account images and account attachments	9 years ago
Keiji, Yoshimi	8fe36654ef	attach_media should be in transaction of creation status (#2426)	9 years ago
Eugen Rochko	8b5179d006	Fix #2402 - Add Idempotency-Key header to PostStatusService that prevents (#2419) ... duplicates. Web UI regenerates UUID for that header every time the compose form is changed or successfully submitted Also, fix Farsi i18n overwriting the English one	9 years ago
178inaba	d2159deaf2	Optimize account search (#2421)	9 years ago
Eugen	17c591ffba	Punycode URI normalization (#2370) ... * Fix #2119 - Whenever about to send a HTTP request, normalize the URI * Add test for IDN request in FetchLinkCardService * Perform IDN normalization on domains before they are stored in the DB	9 years ago
Yamagishi Kazutoshi	d670f72830	Show multibyte URI preview card (#2363)	9 years ago
Eugen	9d3be5579a	Improve bio compatibility (#2278) ... * Fix #1057 (close #1819) - Move HTML-formatted bio from <poco:note /> to <summary type="html" /> * Ensure <poco:note /> is plaintext for remote accounts, also, by stripping out HTML	9 years ago
ik-fib	47a3036ea6	Add Mastodon version to user agent (#2253)	9 years ago
Eugen	1d47910d3b	Fix possibility of unrightful webfinger redirect (#2147) ... * Fix possibility of unrightful webfinger redirect * Add more tests for FollowRemoteAccountService	9 years ago
Matt Jankowski	297c11dba2	Language detection refactor (#2099) ... * Extract detect_language to separate class * Use default locale, not just en * Add spec to confirm that whatlanguage cant identify empty string * Allow account locale to override default in language detector * PostStatusService supplies an account to detect language	9 years ago
ik-fib	23ecc681c4	Add "Mastodon" to user agent (#2073) ... Remove non-const version string Freeze option is unnecessary	9 years ago
Tomohiro Suwa	3399dd7a66	Fix nil query_username (#2013)	9 years ago
Keiji, Yoshimi	7a5086729a	reduce unneed query when post without attachements. (#1907) ... * reduce unneed query when post without attachements. This commit reduce following query: ``` MediaAttachment Load (0.9ms) SELECT "media_attachments".* FROM "media_attachments" WHERE "media_attachments"."status _id" IS NULL AND 1=0 ORDER BY id asc ``` * fixed for more simple changes.	9 years ago
Eugen	8ebed7fc68	Fix #1957 - WhatLanguage can return null. Fallback to 'en' (#1959)	9 years ago
Eugen	e4af4898de	Add language detection (#1772) ... * Add language detection via WhatLanguage and (de)serialization of it through Atom * Fix default language in ProcessFeedService * Re-add newline before 'react-rails' Gem to fix groupings Fixes Code Climate issue	9 years ago
alpaca-tc	19f63ff801	Check @recipient.user at the first (#1939)	9 years ago
Eugen	babbb2135e	Fix #1813 - Alleviate extra requests when processing mentions (#1938) ... The <link rel="mentioned" /> tag refers to accounts by href. So we were matching the DB by the url attribute, and falling back to HTTP look-up. However, GS and Mastodon use profile URLs as URIs, too, and the match for that was missing. This could potentially alleviate some extra network requests	9 years ago
Matt Jankowski	e0b5a94a4b	Clean up check that account needs a webfinger update (#1932)	9 years ago
alpaca-tc	8f8319852c	Fixed NoMethodError in UnfollowService (#1918)	9 years ago
Eugen	5d710b1139	Make file attachment on MediaAttachment optional (#1865) ... Create MediaAttachment but without actual file download when domain is blocked with reject_media set to true Clean up old media files when creating a new domain block with reject_media set to true Return remote_url in media attachments API if local file is not present Undo domain block action in admin UI Ability to enable reject_media from admin UI	9 years ago
alpaca-tc	f9d7ec8971	ActiveRecord::Relation does not respond to `#id` (#1834)	9 years ago
Matt Jankowski	40fd1de488	Account search service refactor (#1791) ... * Begin coverage for account search service * Coverage for hashtag query * Coverage for calling local vs remote find based on domain presence * Spec to check that exact matches are not duped * Coverage of resolve option * Coverage for account being provided * Start to refactor account search service * Isolate query username and domain methods * Isolate exact_match method * Extract methods for local and remote results * Simplify local vs remote and account isoliation * Extract methods for local and remote results * Simplify de-dupe of exact match * Simplify logic to check for non exact remotes * Cache some methods * Remove nil from exact_match from results array * Return exact matches first * Use find_remote even with no domain Account.find_local is just an alias for Account.find_remote(user, nil) - so we can not bother with the conditional here, and call find_remote directly.	9 years ago
ThibG	31f0bcf804	Refresh webfinger (#1323) ... * Refresh local info for remote accounts when webfinger returns new values It only refreshes account info if one of the URLs or the public-key changes, in which cases it refreshes the full info, re-downloading the feeds from that user. Some special handling should probably be done when the public key changes, but I have been unable to find any use for it in Mastodon yet. * Re-fetch remote users we aren't subscribed to. This might induce performance issues, we might want to only do that for users we explicitly attempted to subscribe but failed to. * Refactor changes * Do not refresh existing remote account details more than once a day * Avoid re-fetching webfinger info in tests unless otherwise specified	9 years ago
ThibG	a9529d3b4b	Allow running mastodon on a different domain as the one used for identifying users (#1267) ... * Allow running mastodon on a different domain as the one used for identifying users * Alter documentation of WEB_DOMAIN to make clear it shouldn't be used unless the admin knows what they are doing * Compare to web_domain instead of local_domain when dealing with feeds/API * Correctly identify mentions to local accounts Mentions URLs point to the person's web profile, i.e., the user page served on WEB_DOMAIN.	9 years ago
Matt Jankowski	323671a653	Silence more scope order warnings (#1604)	9 years ago
Matt Jankowski	53850bce93	Remove unused AtomBuilderHelper (#1364) ... This was used in the views/atom/user_stream.xml.ruby file, which no longer is used.	9 years ago
ThibG	d19ed18388	Get handle from atom feed's author/email field instead of guessing from URL (#1344) ... The goal of this change is to enhance Mastodon's handling of remote domains for which the APIs reside on a different host (see issue #1032). Indeed, when a remote user unknown to Mastodon is mentionned, only its profile URL (e.g. https://social.example.org/users/User) is known, and Mastodon has to build a @username@domain handle for it. To do so, Mastodon fetches the user's atom feed (e.g., https://social.example.org/users/User.atom) and uses its content to get the username part of the handle, and the URL's host part to build the domain (e.g., @User@social.example.org). This handle is then used for a Webfinger request. In the case where example.org serves the Webfinger info for @User@example.org and all feeds and APIs are hosted at social.example.org, Mastodon will still build @User@social.example.org and fail at resolving the account's details through Webfinger. This patch changes this behaviour by using the author's email address from the atom feed to build the handle. In Mastodon-generated atom feeds, the email address is always the handle it expects for federation.	9 years ago
Eugen	982fef811e	Fix #1141, fix #1126 - Avatar/profile info fetching (#1215) ... * Fix #1141, fix #1126 - Work through UpdateRemoteProfileService for both <feed> and <entry> top-level tags * Improve code quality, remove line unrelated to fix	9 years ago
Eugen	33849acfa7	Merge pull request #1218 from R0ckweb/patch-2 ... Fix #1141 on remote follow	9 years ago
Yann GUERN	485d75a805	#1141 on remote follow ... The async action is send before persist, account.id not yet generated Pull queue receive 'nil' so no profile update.	9 years ago
Eugen Rochko	b2a7218ab7	Fix #801 - Respect webfinger's canonical response of username/domain	9 years ago
Chad Pytel	ad5ddd5e95	Use I18n for media attachment validation errors ... These are currently user facing errors, but are not localized. This adds the ability for these messages to be localized.	9 years ago
Eugen	6d6a429af8	Rewrite Atom generation from stream entries to use Ox instead of Nokogiri (#1124) ... * Rewrite Atom generation from stream entries to use Ox instead of Nokogiri::Builder StreamEntry is now limited to only statuses, which allows some optimization. Removed extra queries on AccountsController#show. AtomSerializer instead of AtomBuilderHelper used in AccountsController#show, StreamEntriesController#show, StreamEntryRenderer and PubSubHubbub::DistributionWorker PubSubHubbub::DistributionWorker moves n+1 DomainBlock query to PubSubHubbub::DeliveryWorker instead. All Salmon slaps that aren't based on StreamEntry still use AtomBuilderHelper and Nokogiri * All Salmon slaps now use Ox instead of Nokogiri. No touch from status on account	9 years ago
Eugen Rochko	51d7caaf19	Fix wrong pubsub channel on public timelines	9 years ago
Eugen Rochko	dbd529109e	Fix notifications delivered to wrong pubsub channel, optimized RemoveStatusService, ... slightly optimized FanOutOnWriteService again	9 years ago
Eugen Rochko	5442083b3c	Split SalmonWorker into smaller parts, move profile updating into another job	9 years ago
Eugen Rochko	5b95be1c42	Replace calls to FeedManager#inline_render and #broadcast	9 years ago
Eugen Rochko	220bc48e8e	Only render public payload once in FanOutOnWrite	9 years ago
Eugen Rochko	6fd865c000	Spawn FeedInsertWorker to deliver status into personal feed	9 years ago
Eugen Rochko	82aaedec46	Reduce number of items in feeds, optimize regeneration worker slightly, ... make regeneration worker unique, (only schedule/execute once at a time)	9 years ago
Eugen Rochko	8232f76c48	Add check for visibility.nil? even though it can't ever be, to check for race conditions	9 years ago
Eugen Rochko	b7c1b12367	Make default admin UI page reports. Add admin UI for creating a domain block	9 years ago
Eugen Rochko	d6b965cf08	Fix issue with feed merge-in code as well	9 years ago
Eugen Rochko	e809caa0e1	Fix feed regeneration bug	9 years ago
Eugen Rochko	d93d6f5124	Fix reworked search	9 years ago
Eugen Rochko	d6ed2eb512	Prettier account and stream entry URLs	9 years ago
Eugen Rochko	33fac87e81	Shorter timeout on FetchAtomService	9 years ago
Eugen Rochko	5aa3df017b	Fix full-text search query quotation, improve tag search performance with an index, ... add ability to open status by URL from search (fix #53)	9 years ago
Eugen Rochko	05cf086766	New API method: /api/v1/search ... Returns accounts, statuses, hashtags arrays	9 years ago
Eugen Rochko	2816b1bf8e	Federate header images, fix open-uri http->https redirection error	9 years ago
Eugen Rochko	ad0d82d3ce	Make account search blazing fast and rank followers/followees higher in the results	9 years ago
Eugen Rochko	74ae158c2f	Add "direct" visibility level in the backend. Web UI is not yet ... adjusted to allow choosing it, yet	9 years ago
Eugen Rochko	a5daa806f2	Fix casuality of processing remote mentions such that notifications ... about them would be processed only after the entire status is processed	9 years ago
Eugen Rochko	c64a1c25c4	Fix #231 - Muting	9 years ago
Kit Redgrave	442fdbfc53	Mute button progress so far. WIP, doesn't entirely work correctly.	9 years ago
Eugen Rochko	175a9b9caa	Fix #104 - Style OAuth authorized applications page ... Add ability to search accounts by display name	9 years ago
Eugen Rochko	5f511324b6	Add validation of media attachments, clean up mastodon-own exception classes	9 years ago
Eugen Rochko	063432d7e3	Merge branch 'fix_462' of https://github.com/rmhasan/mastodon into rmhasan-fix_462	9 years ago
Eugen Rochko	3e9d794ea5	Add tuning documentation, add <content> tags back to most salmons, ... make status pagination headers generation more lax about next page existing	9 years ago
Eugen Rochko	53ae431867	Skip remote media URLs that don't have a hostname	9 years ago
Eugen Rochko	c77a54fe0a	Fix #651 - Do not reinsert original status into all followers feeds ... upon un-reblogging. Check if the reblog was in the feed in the first place. It might have been filtered on distribution.	9 years ago
Rakib Hasan	87a6bed9e9	previous commit was creating the status regardless ... of mix of video and images in status, just wasn't rendering the show action. I moved the validation before the status creation	9 years ago
Rakib Hasan	6f9ecd899e	revisted fix for #462 ... Moved validation to services/post_status_service.rb	9 years ago
Eugen Rochko	40a4053732	Disable PuSH for blocked domains	9 years ago
Eugen Rochko	8e08ae5bb9	Add IDs to salmon slaps even if they are transient. Add title, too, mostly ... in case of debugging incoming salmons. Add <thr:in-reply-to /> to favourite salmons because it seems to be required by GS.	9 years ago
Eugen Rochko	df63461ff0	Add handler for salmons of undoing favourites	9 years ago
Eugen Rochko	720ff55262	Adding more unit tests. Fixing Salmon slaps XML	9 years ago
Eugen Rochko	446267d1bf	Deduplicate delete salmons (send only one per mentioned-account domain)	9 years ago
Eugen Rochko	0518492158	Stop trying to shoehorn all Salmon updates into the poor database-connected ... StreamEntry model. Simply render Salmon slaps as they are needed	9 years ago
Eugen Rochko	94d2182717	Resolve issue with rendering authorize/reject Salmon slaps	9 years ago
Eugen Rochko	dc851c922e	Mentions in private statuses allow mentioned people to see them	9 years ago
Eugen Rochko	00b5731ecb	After FollowService, re-fetch remote account asynchronously, do nothing ... if account lock info was up to date, otherwise re-do the FollowService with now updated information	9 years ago
Eugen Rochko	e610555e10	Fix processing of incoming authorizations/rejections	9 years ago
Eugen Rochko	514fdfa268	Don't PuSH-resubscribe if already subscribed	9 years ago
Eugen Rochko	149887a0ff	Make follow requests federate	9 years ago
Eugen Rochko	6331ed16e5	Fix #614 - extra reply-boolean on statuses to account for cases when replied-to ... status is not in the system at time of distribution; fix #607 - reset privacy settings to defaults when cancelling replies	9 years ago