mastodon

Commit Graph

Author	SHA1	Message	Date
Wolfgang Fournès	cfadb87077	Update enum syntax to use the new Rails 7.0 style (#29217 )	1 year ago
Matt Jankowski	9d413cbaf8	Fix `Rails/WhereExists` cop in app/models (#28863 )	1 year ago
Matt Jankowski	aaa6f2e930	Group common `class_name` options in associations (#28779 )	1 year ago
Matt Jankowski	4ccba94489	Remove unused `*_silenced_accounts` scopes on Status (#28644 )	1 year ago
Claire	2bf84b93d4	Fix media attachment order of remote posts (#28469 )	1 year ago
Matt Jankowski	3918dc68c7	Use composite primary key for `PreviewCardsStatus` model (#28208 )	1 year ago
Matt Jankowski	f70f39dd04	Add explicit `dependent: nil` to associations (#28169 )	1 year ago
Matt Jankowski	440b80b2e7	Model concerns organization into module namespaces (#28149 )	1 year ago
Eugen Rochko	0d14fcebae	Change link previews to keep original URL from the status (#27312 )	1 year ago
Claire	9e77ab7db2	Change private statuses index to index without crutches (#26713 )	1 year ago
jsgoldstein	30c191aaa0	Add new public status index (#26344 ) Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	1 year ago
Claire	60b9fa641d	Fix cached posts including stale stats (#26409 )	2 years ago
Claire	d5bee37c57	Fix missing cached preview cards attributes (#26343 )	2 years ago
Matt Jankowski	644c5fddd8	Refactor `Status.tagged_with_all` for brakeman SQL injection warning (#25941 )	2 years ago
Matt Jankowski	0b249ebdb0	Extract StatusSafeReblogInsert concern from Status (#24821 )	2 years ago
Matt Jankowski	b5c4b47746	Fix Rails/ActiveRecordCallbacksOrder cop (#24689 )	2 years ago
Matt Jankowski	af824db398	Fix Rails/InverseOf cop (#24732 )	2 years ago
Claire	f53d009778	Refactor `Status._insert_record` slightly and tighten the test around reblogs of discarded statuses (#24516 )	2 years ago
Claire	2626097869	Fix Rails cache namespace being overriden with `v2` for cached statuses (#24202 )	2 years ago
Vyr Cossont	94cbd808b5	Webhooks for local status.create, status.update, account.update (#24133 )	2 years ago
Christian Schmidt	bd047acc35	Replace `Status#translatable?` with language matrix in separate endpoint (#24037 )	2 years ago
Christian Schmidt	5a8c651e8f	Only offer translation for supported languages (#23879 )	2 years ago
Nick Schonning	9909b4b653	Autofix Rubocop Rails/WhereEquals (#23759 )	2 years ago
Nick Schonning	717683d1c3	Autofix Rubocop remaining Layout rules (#23679 )	2 years ago
Nick Schonning	63e6353886	Autofix Rubocop Rails/EnumHash (#23737 )	2 years ago
Nick Schonning	597767a9f7	Autofix Rubocop Rails/RedundantForeignKey (#23731 )	2 years ago
Nick Schonning	2177daeae9	Autofix Rubocop Style/RedundantBegin (#23703 )	2 years ago
Nick Schonning	ab7816a414	Autofix Rubocop Style/Lambda (#23696 )	2 years ago
Claire	13a2abacc8	Add `roles` attribute to Account entities in REST API (#23255 )	2 years ago
Kaspar V	ae62e5fa53	Fix/remove calling private method with send in model (#22951 ) * fix(status): remove send usage for private unlink_from_conversations - make unlink_from_conversations public method - rename unlink_from_conversations to unlink_from_conversations! - fix send call on private method in statuses_vacuum and batched_remove_status_service * fix(feeds_vacuum): replace find_in_batches with in_batches because active record query results should be a little more efficient than itterating with map and each. Postgres can grasp such lists of ids much quicker than ruby can. Will probably make allmost no difference, but cannot hurt either.	2 years ago
Kaspar V	47f0d7021e	refactor(vacuum statuses): reduce amount of db queries and load for each query - improve performance (#21487 ) * refactor(statuses_vacuum): remove dead code - unused Method is not called inside class and private. Clean up dead code. * refactor(statuses_vacuum): make retention_period present test explicit This private method only hides functionality. It is best practice to be as explicit as possible. * refactor(statuses_vacuum): improve query performance - fix statuses_scope having sub-select for Account.remote scope by `joins(:account).merge(Account.remote)` - fix statuses_scope unnecessary use of `Status.arel_table[:id].lt` because it is inexplicit, bad practice and even slower than normal `.where('statuses.id < ?'` - fix statuses_scope remove select(:id, :visibility) for having reusable active record query batches (no re queries) - fix vacuum_statuses! to use in_batches instead of find_in_batches, because in_batches delivers a full blown active record query result, in stead of an array - no requeries necessary - send(:unlink_from_conversations) not to perform another db query, but reuse the in_batches result instead. - remove now obsolete remove_from_account_conversations method - remove_from_search_index uses array of ids, instead of mapping the ids from an array - this should be more efficient - use the in_batches scope to call delete_all, instead of running another db query for this - because it is again more efficient - add TODO comment for calling models private method with send * refactor(status): simplify unlink_from_conversations - add `has_many through:` relation mentioned_accounts - use model scope local instead of method call `Status#local?` - more readable add account to inbox_owners when account.local? * refactor(status): searchable_by way less sub selects These queries all included a sub-select. Doing the same with a joins should be more efficient. Since this method does 5 such queries, this should be significant, since it technically halves the query count. This is how it was: ```ruby [3] pry(main)> Status.first.mentions.where(account: Account.local, silent: false).explain Status Load (1.6ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (1.5ms) SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ``` This is how it is with this change: ```ruby [4] pry(main)> Status.first.mentions.joins(:account).merge(Account.local).active.explain Status Load (1.7ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (0.7ms) SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ```	2 years ago
Claire	c2170991c7	Fix reblogs being discarded after the reblogged status (#19731 )	2 years ago
Eugen Rochko	45ebdb72ca	Add support for language preferences for trending statuses and links (#18288 )	2 years ago
Eugen Rochko	9f65909f42	Change public timelines to be filtered by current locale by default (#19291 ) In the absence of an opt-in to multiple specific languages in the preferences, it makes more sense to filter by the user's presumed language only (interface language or `lang` override)	2 years ago
Eugen Rochko	0396acf39e	Add audit log entries for user roles (#19040 ) * Refactor audit log schema * Add audit log entries for user roles	3 years ago
Claire	25dda3061e	Fix unnecessary query on status creation (#17901 )	3 years ago
Claire	6e4d932da5	Fix possible crash when a post references an invalid media attachment (#18211 )	3 years ago
Jeong Arm	ea38327816	Let votes statuses are also searchable (#18070 )	3 years ago
Claire	ef196c913c	Fix error MethodError in Chewy::Strategy::Sidekiq::Worker (#17912 ) Also refactor a bit to reduce code duplication.	3 years ago
Eugen Rochko	71f2b95106	Fix edits with no actual changes being allowed (#17843 ) * Fix edits with no actual changes being allowed locally * Fix edits with no actual changes being allowed through ActivityPub * Fix false positive changes caused by description processing in model * Fix not recording poll expiration update * Fix test * Revert changes to ProcessStatusUpdateService * Various fixes and improvements * Fix code style issues * Various changes and improvements * Add guard clause	3 years ago
Eugen Rochko	a794117679	Fix individually approved/rejected statuses/links showing as pending review (#17787 )	3 years ago
Claire	2a56a890da	Fix rare race condition when rebloged status is deleted (#17693 ) * Fix rare race condition when rebloged status is deleted * Use INSERT INTO … SELECT	3 years ago
Eugen Rochko	b2cd34474b	Add rate limit for editing (#17728 )	3 years ago
Eugen Rochko	d17fb70131	Change how changes to media attachments are stored for edits (#17696 ) * Change how changes to media attachments are stored for edits Fix not being able to re-order media attachments * Fix not broadcasting updates when polls/media is changed through ActivityPub * Various fixes and improvements * Update app/models/report.rb Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Add tracking of media attachment description changes * Change poll in status edit to have a structure closer to the real one Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Eugen Rochko	8f6c67bfde	Fix performance of account timelines (#17709 ) * Fix performance of account timelines * Various fixes and improvements * Fix duplicate results being returned Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Fix grouping for pinned statuses scope Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Eugen Rochko	25d3dc4373	Add ability to mark statuses as sensitive from reports in admin UI (#17668 ) * Add ability to mark statuses as sensitive from reports in admin UI * Allow mark as sensitive action on statuses with preview cards	3 years ago
Eugen Rochko	27965ce5ed	Add trending statuses (#17431 ) * Add trending statuses * Fix dangling items with stale scores in localized sets * Various fixes and improvements - Change approve_all/reject_all to approve_accounts/reject_accounts - Change Trends::Query methods to not mutate the original query - Change Trends::Query#skip to offset - Change follow recommendations to be refreshed in a transaction * Add tests for trending statuses filtering behaviour * Fix not applying filtering scope in controller	3 years ago
Eugen Rochko	a29a982eaa	Change e-mail domain blocks to block IPs dynamically (#17635 ) * Change e-mail domain blocks to block IPs dynamically * Update app/workers/scheduler/email_domain_block_refresh_scheduler.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> * Update app/workers/scheduler/email_domain_block_refresh_scheduler.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	3 years ago
Eugen Rochko	8f03b7a2fb	Add notifications when a reblogged status has been updated (#17404 ) * Add notifications when a reblogged status has been updated * Change wording to say "edit" instead of "update" and add missing controls * Replace previous update notifications with the most up-to-date one	3 years ago
Eugen Rochko	63002cde03	Add editing for published statuses (#17320 ) * Add editing for published statuses * Fix change of multiple-choice boolean in poll not resetting votes * Remove the ability to update existing media attachments for now	3 years ago

1 2 3 4 5 ...

288 Commits (24319836de6046fb2985ec1a24c30ad7d47584d7)