mastodon

Commit Graph

Author	SHA1	Message	Date
Claire	54581d43e7	Bump version to 3.4.5 (#17402 )	3 years ago
Claire	a0e06c3c3e	Add more advanced migration tests (#17393 ) - populate the database with some data when testing migrations - try both one-step and two-step migrations (`SKIP_POST_DEPLOYMENT_MIGRATIONS`)	3 years ago
Claire	c6b291afc3	Change index corruption warning to be a little less scary (#17395 )	3 years ago
Claire	a99adeaad3	Fix edge case in migration helpers that caused crash because of PostgreSQL quirks (#17398 )	3 years ago
Claire	8a07ecd377	Remove leftover database columns from Devise::Models::Rememberable (#17191 ) * Remove leftover database columns from Devise::Models::Rememberable * Update fix-duplication maintenance script * Improve errors/warnings in the fix-duplicates maintenance script	3 years ago
Claire	1e8c885e5a	Change mastodon:webpush:generate_vapid_key task to not require functional env (#17338 ) Fixes #17297	3 years ago
Eugen Rochko	fe71548844	Fix warnings on Rails boot (#16946 )	3 years ago
Claire	76761d5fc0	Add ability for admins to delete canonical email blocks (#16644 ) * Add admin option to remove canonical email blocks from a deleted account * Add tootctl canonical_email_blocks to inspect and remove canonical email blocks	3 years ago
Takeshi Umeda	6c8c031bcd	Add remove orphans to tootctl statuses remove (#17067 ) * Add remove orphans to tootctl statuses remove * Add REINDEX and change option from vacuum to compression-database * Changed to extract the deletion target of conversations to a temporary table * Support progress bar and exceptions when media remove * Add continue option * Fix compression to compress * Remove skip_remove_orphans	3 years ago
Takeshi Umeda	0ac7efdc50	Fix performance of tootctl statuses remove (#17052 ) * Fix performance of tootctl statuses remove * Fix model class	3 years ago
Takeshi Umeda	06631fdc53	Fix ElasticSearch to Elasticsearch (#17050 )	3 years ago
OSAMU SATO	53aca8aecf	Add batch_size option to bin/tootctl search deploy (#17049 )	3 years ago
Eugen Rochko	6e50134a42	Add trending links (#16917 ) * Add trending links * Add overriding specific links trendability * Add link type to preview cards and only trend articles Change trends review notifications from being sent every 5 minutes to being sent every 2 hours Change threshold from 5 unique accounts to 15 unique accounts * Fix tests	3 years ago
Takeshi Umeda	3419d3ec84	Bump chewy from 5.2.0 to 7.2.3 (supports Elasticsearch 7.x) (#16915 ) * Bump chewy from 5.2.0 to 7.2.2 * fix style (codeclimate) * fix style * fix style * Bump chewy from 7.2.2 to 7.2.3	3 years ago
Claire	48f8658d34	Fix upload of remote media with OpenStack Swift sometimes failing (#16998 ) Under certain conditions, files fetched from remotes trigger an error when being uploaded using OpenStack Swift. This is because in some cases, the remote server will not return a content-length, so our ResponseWithLimitAdapter will hold a `nil` value for `#size`, which will lead to an invalid value for the Content-Length header of the Swift API call. This commit fixes that by taking the size from the actually-downloaded file size rather than the upstream-provided Content-Length header value.	3 years ago
Claire	18b885ee3a	Fix "bundle exec rails mastodon:setup" crashing in some circumstances (#16976 ) Fix regression from #16896	3 years ago
Eugen Rochko	2251db42ec	Forward port version bumps to 3.4.2 and 3.4.3 (#16945 ) * Bump version to 3.4.2 * Bump version to 3.4.3	3 years ago
Jeong Arm	884c60002e	Skip blocked domains media on tootctl media refresh (#16914 )	3 years ago
Claire	5ba46952af	Fix mastodon:setup to take dotenv/docker-compose differences into account (#16896 ) In order to work around https://github.com/mastodon/mastodon/issues/16895, add a warning to .env.production.sample, and change the mastodon:setup rake task to: - output a warning if a variable will be interpreted differently by dotenv and docker-compose - ensure the printed config is compatible with docker-compose	3 years ago
Claire	6ba8bc45cb	Add S3_FORCE_SINGLE_REQUEST env var to work around S3 compatibility issues (#16866 ) Fixes #16822	3 years ago
Jeong Arm	3f5f4273b3	Add optional domain restrict to tootctl accounts cull (#16511 ) * Add optional domain restrict to accounts cull * Use "unless" - codeclimate	3 years ago
Claire	a8ef6d24d8	Fix `tootctl accounts cull` not excluding domains on timeouts and certificate issues (#16433 ) Fixes #16410	3 years ago
Claire	959f7fc580	Fix tootctl self-destruct not sending Delete activities for recently-suspended accounts (#16688 ) * Do not block existing users' emails on self-destruct That is wasteful and unintuitive * Do not close registrations when running tootctl self-destruct with --dry-run * Close registrations on self-destruct regardless of known remote accounts * Fix tootctl self-destruct not sending Deletes for recently-suspended accounts * Suspend local users even if no remote account is known * Do not show scary confirmation text if ran with --dry-run	3 years ago
Claire	fc3ae1343d	Switch from unmaintained paperclip to kt-paperclip (#16724 ) * Switch from unmaintained paperclip to kt-paperclip * Drop some compatibility monkey-patches not required by kt-paperclip * Drop media spoof check monkey-patching It's broken with kt-paperclip and hopefully it won't be needed anymore * Fix regression introduced by paperclip 6.1.0 * Do not rely on pathname to call FastImage * Add test for ogg vorbis file with cover art * Add audio/vorbis to the accepted content-types This seems erroneous as this would be the content-type for a vorbis stream without an ogg container, but that's what the `marcel` gem outputs, so… * Restore missing for_as_default method * Refactor Attachmentable concern and delay Paperclip's content-type spoof check Check for content-type spoofing after setting the extension ourselves, this fixes a regression with kt-paperclip's validations being more strict than paperclip 6.0.0 and rejecting some Pleroma uploads because of unknown extensions. * Please CodeClimate * Add audio/vorbis to the unreliable set It doesn't correspond to a file format and thus has no extension associated.	3 years ago
Claire	4ac78e2a06	Add feature to automatically delete old toots (#16529 ) * Add account statuses cleanup policy model * Record last inspected toot to delete to speed up successive calls to statuses_to_delete * Add service to cleanup a given account's statuses within a budget * Add worker to go through account policies and delete old toots * Fix last inspected status id logic All existing statuses older or equal to last inspected status id must be kept by the current policy. This is an invariant that must be kept so that resuming deletion from the last inspected status remains sound. * Add tests * Refactor scheduler and add tests * Add user interface * Add support for discriminating based on boosts/favs * Add UI support for min_reblogs and min_favs, rework UI * Address first round of review comments * Replace Snowflake#id_at_start with with_random parameter * Add tests * Add tests for StatusesCleanupController * Rework settings page * Adjust load-avoiding mechanisms * Please CodeClimate	4 years ago
Takeshi Umeda	818e0b314f	Fix unsupported video error message handling (#16581 )	4 years ago
Claire	5a1e072517	Change references to tootsuite/mastodon to mastodon/mastodon (#16491 ) * Change references to tootsuite/mastodon to mastodon/mastodon * Remove obsolete test fixture * Replace occurrences of tootsuite/mastodon with mastodon/mastodon in CHANGELOG And a few other places	4 years ago
Eugen Rochko	771c9d4ba8	Add ability to skip sign-in token authentication for specific users (#16427 ) Remove "active within last two weeks" exception for sign in token requirement Change admin reset password to lock access until the password is reset	4 years ago
Claire	2e0eac71dd	Add --by-uri option to `tootctl domains purge` (#16434 ) Fixes #16410	4 years ago
Claire	f6088922c0	Update emoji codepoint mappings to v13.1 (#16352 )	4 years ago
Eugen Rochko	d6486c969f	Bump version to 3.4.1 (#16350 )	4 years ago
Claire	11d3c065a5	Fix migration script not being able to run if it fails midway (#16312 ) * Fix migration script not being able to run if it fails midway * Fix old migration script * Fix old migration script * Refactor CorruptionError	4 years ago
Claire	526332c545	Fix account deletion sometimes failing because of optimistic locks (#16317 ) * Fix account deletion sometimes failing because of optimistic locks In some rare occasions[1], deleting accounts would fail with a `StaleObjectError` exception. Indeed, account deletion manually sets the `AccountStat` values without handling cases where the optimistic locking on `AccountStat` would fail. To my knowledge, with the rewrite of account counters in #15913, the `DeleteAccountService` is now the only place that changes the counters in a way that is not atomic. Since in this specific case, we do not care about the previous values of the account counters, it appears we don't need locking at all for this table anymore. [1]: https://discourse.joinmastodon.org/t/account-cant-be-deleted/3602 * Bump MAX_SUPPORTED_VERSION in maintenance script	4 years ago
Claire	abf4c2ab21	Fix `tootctl search deploy` on Ruby 3 (#16346 ) Fixes #16344	4 years ago
Eugen Rochko	4c7efdba40	Bump version to 3.4.0 (#16239 )	4 years ago
Eugen Rochko	d862728ae1	Add more checks to `repo:check_locales_files` (#16249 )	4 years ago
Claire	76064e6608	Update fix-duplicates maintenance script to support latest migrations (#16231 ) * Update maintenance script to support latest database migrations * Update Account#merge_with!	4 years ago
rinsuki	5ed5f62705	Fix animated GIF generates animated thumbnail (#16216 )	4 years ago
Eugen Rochko	7bd2b54a46	Bump version to 3.4.0rc2 (#16206 )	4 years ago
Takeshi Umeda	9b18914c35	Add a Redis environment variable for sidekiq (#16188 )	4 years ago
Eugen Rochko	d1442a06c3	Bump version to 3.4.0rc1 (#16053 )	4 years ago
Claire	a5f91a11d0	Fix older migrations on Ruby 3 (#16174 )	4 years ago
Claire	566fc90913	Add Ruby 3.0 support (#16046 ) * Fix issues with POSIX::Spawn, Terrapin and Ruby 3.0 Also improve the Terrapin monkey-patch for the stderr/stdout issue. * Fix keyword argument handling throughout the codebase * Monkey-patch Paperclip to fix keyword arguments handling in validators * Change validation_extensions to please CodeClimate * Bump microformats from 4.2.1 to 4.3.1 * Allow Ruby 3.0 * Add Ruby 3.0 test target to CircleCI * Add test for admin dashboard warnings * Fix admin dashboard warnings on Ruby 3.0	4 years ago
Eugen Rochko	6d9ad30bf8	Fix media redownload worker retrying on unexpected response codes (#16111 )	4 years ago
Eugen Rochko	036556d350	Fix media processing getting stuck on too much stdin/stderr (#16136 ) * Fix media processing getting stuck on too much stdin/stderr See thoughtbot/terrapin#5 * Remove dependency on paperclip-av-transcoder gem * Remove dependency on streamio-ffmpeg gem * Disable stdin on ffmpeg process	4 years ago
Takeshi Umeda	25345c90ff	Fix how to change connection pool for rails 6 (#16158 ) * Fix how to change connection pool for rails 6 * Fix to match the code elsewhere	4 years ago
Takeshi Umeda	422df9d670	Fix cache redis not being used (#16131 )	4 years ago
Ikko Ashimine	0bc909687a	Fix typo in db.rake (#16126 ) occured -> occurred	4 years ago
Claire	e78d06eecf	Add border to 🚲 emoji (#16035 )	4 years ago
Eugen Rochko	ad61265268	Remove dependency on pluck_each gem (#16012 )	4 years ago
abcang	ddabbbf5a6	Fix DB connection pool settings in CLI (#15983 )	4 years ago
Stanislas	d33351af3c	tootctl emoji import: case insensitive duplicate check (#15738 )	4 years ago
Claire	cbd0ee1d07	Update Mastodon to Rails 6.1 (#15910 ) * Update devise-two-factor to unreleased fork for Rails 6 support Update tests to match new `rotp` version. * Update nsa gem to unreleased fork for Rails 6 support * Update rails to 6.1.3 and rails-i18n to 6.0 * Update to unreleased fork of pluck_each for Ruby 6 support * Run "rails app:update" * Add missing ActiveStorage config file * Use config.ssl_options instead of removed ApplicationController#force_ssl Disabled force_ssl-related tests as they do not seem to be easily testable anymore. * Fix nonce directives by removing Rails 5 specific monkey-patching * Fix fixture_file_upload deprecation warning * Fix yield-based test failing with Rails 6 * Use Rails 6's index_with when possible * Use ActiveRecord::Cache::Store#delete_multi from Rails 6 This will yield better performances when deleting an account * Disable Rails 6.1's automatic preload link headers Since Rails 6.1, ActionView adds preload links for javascript files in the Links header per default. In our case, that will bloat headers too much and potentially cause issues with reverse proxies. Furhermore, we don't need those links, as we already output them as HTML link tags. * Switch to Rails 6.0 default config * Switch to Rails 6.1 default config * Do not include autoload paths in the load path	4 years ago
Claire	82556834cf	Change mastodon:setup to not call assets:precompile in docker (#13942 ) It appears assets are built during image build, and they shouldn't need to be rebuilt, since we now have reproducible builds.	4 years ago
Claire	741d0952b1	Improve account counters handling (#15913 ) * Improve account counters handling * Use ActiveRecord::Base::sanitize_sql to pass values instead of interpolating them Keep using string interpolation for `key` as it is safe and using “ActiveRecord::Base::sanitize_sql_hash_for_assignment” would require stitching bits of SQL in a way that is not more easily checked for safety. * Add migration hook to catch PostgreSQL versions earlier than 9.5	4 years ago
Claire	c31c95ffe4	Remove MySQL-specific code from Mastodon::MigrationHelpers (#15924 ) Mastodon::MigrationHelpers has been forked from Gitlab a long time ago, but Mastodon has never supported using a MySQL database. Removing MySQL support from Mastodon::MigrationHelpers makes it a little easier to maintain. In particular, it removes code that would need updating with Rails 6.	4 years ago
Claire	82caed594c	Change deduplication order of tootctl maintenance fix-duplicates (#15923 ) Hopefully fixes #15922 Also update support up to latest database schema version	4 years ago
Claire	b358229834	Further preparation for Rails 6 (#15916 ) * Use ActiveRecord::Result#to_ary instead of deprecated to_hash They do the same thing, and to_hash has been removed from Rails 6.1 * Explicitly name polymorphic indexes to workaround a bug in Rails 6.1 cf. https://github.com/rails/rails/issues/41693 * Fix incorrect usage of “foreign_key” in migration script * Use `ActiveModel::Errors#delete` instead of deprecated clear method * Fix link headers tests on Rails 6.1 Rails 6.1 adds values to the Link header by default, thus it is not a LinkHeader object anymore. Fix the test to parse the Link header instead of assuming it is a LinkHeader.	4 years ago
Claire	9aaaa96d2f	Use more robust hook for loading timestamp_id function into database (#15919 )	4 years ago
Claire	a4dcaef53b	Prepare Mastodon for zeitwerk autoloader (#15917 ) * Prepare Mastodon for zeitwerk autoloader (Rails 6) Add inflections and rename/move a few classes. In particular, app/lib/exceptions.rb and app/lib/sanitize_config.rb were manually loaded while still in autoload paths. * Add inflection for Url → URL	4 years ago
Claire	43eff898a0	Prepare Mastodon for Rails 6 (#15911 ) * Fix misuse of foreign_type * Fix use of removed "add_template_helper" * Use response.media_type instead of response.content_type in tests * Fix CSV export controller test on Rails 6 Rails 6 sets a "filename" field in the Content-Disposition header to explicitly encode the filename as UTF-8. This changes checks the first part of the Content-Disposition header so it matches in both Rails 5 and Rails 6. Fix emoji formatting with Rails 6 * Make emoji output more idiomatic and robust * Switch from redis-rails gem to built-in Rails redis cache storage	4 years ago
Claire	a8139ab016	Add borders to 📱 and 📲 emojis (#15794 )	4 years ago
Justin Tracey	c9e8e1739c	replace all instances of "ends_with?" with "end_with?" (#15745 ) The "ends_with?" method is just a Rails alias of Ruby's "end_with?" method. Using the latter makes the code less brittle.	4 years ago
Justin Tracey	3f8523130d	use host instead of headers to make Rack happy (#15741 ) "headers" is provided by Rails, Rack can't rely on it	4 years ago
Cecylia Bocovich	3447bd2f80	Monkey patch Rack::Session to send secure cookies to onions (#15725 )	4 years ago
Claire	21fb3f3684	Drop dependency on secure_headers, fix response headers (#15712 ) * Drop dependency on secure_headers, use always_write_cookie instead * Fix cookies in Tor Hidden Services by moving configuration to application.rb * Instead of setting always_write_cookie at boot, monkey-patch ActionDispatch	4 years ago
Claire	6feaad33f2	Fix obsolete digitalocean.rake file breaking rake tasks (#15618 )	4 years ago
Shubhendra Singh Chauhan	c8d11b8bdb	Fixed code quality issues (#15541 ) * Added .deepsource.toml * Removed bad use of `alias` * Fixed operand order in the binary expression * Prefixed unused method arguments with an underscore * Replaced the old OpenSSL algorithmic constants with the newer strings initializers. * Removed unnecessary UTF-8 encoding comment	4 years ago
ThibG	13d5b81579	Fix “tootctl accounts unfollow” (#15639 ) Fixes #15635 Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
luigi	eb51e43fb4	Optimize some regex matching (#15528 ) * Use Regex#match? * Replace =~ too * Avoid to call match? from Nil * Keep value of Regexp.last_match	4 years ago
ThibG	54d4e5252b	Use Rails' index_by where it makes sense (#15542 ) * Use Rails' index_by where it makes sense * Fix tests Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
luigi	087ed84367	Optimize map { ... }.compact calls (#15513 ) * Optimize map { ... }.compact using Enumerable#filter_map, supported since Ruby 2.7 * Add poyfill for Enumerable#filter_map	4 years ago
ThibG	9395143126	Fix maintenance script not re-indexing some indexes on textual values (#15515 ) * Fix maintenance script not re-indexing some indexes on textual values Fixes #15475 * Refresh instance view at the end of the maintenance script run Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
abcang	efffdd3778	Fix rubocop config and warnings (#15503 ) * disable NewCops * update TargetRubyVersion * Fix Lint/MissingSuper for ActiveModelSerializers::Model * Fix Lint/MissingSuper for feed * Fix Lint/FloatComparison * Do not use instance variables	4 years ago
Sophie Parker	c7262d12b2	Improve Emoji import (fix #15429 ) (#15430 ) * Improve Emoji import Skip macOS '._' shadow files in tar archive to speed up import * Fix codeclimate format issue with whitespace * Update lib/mastodon/emoji_cli.rb suggestions from Gargron to improve comment Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> * Update emoji_cli.rb Remove extraneous comment (macOS-specific comment now with correct line) Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>	4 years ago
Eugen Rochko	633d175146	Bump version to 3.3.0 (#15433 )	4 years ago
ThibG	f1f96ebf02	Fix being able to import more than allowed number of follows (#15384 ) * Fix being able to import more than allowed number of follows Without this commit, if someone tries importing a second list of accounts to follow before the first one has been processed, this will queue imports for the two whole lists, even if they exceed the account's allowed number of outgoing follows. This commit changes it so the individual queued imports aren't exempt from the follow limit check (they remain exempt from the rate-limiting check though). * Catch validation errors to not re-queue failed follows Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	444b21b55f	Bump version to 3.3.0rc3 (#15411 )	4 years ago
ThibG	1cf2c3a810	Fix external user creation failing when invite request text is required (#15405 ) * Fix external user creation failing when invite request text is required Also fixes tootctl-based user creation. * Add test about invites when invite request text is otherwise required Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	9915d11c0d	Fix unnecessary queries when batch-removing statuses, 100x faster (#15387 )	4 years ago
ThibG	c4e860277d	Fix "tootctl accounts fix-duplicates" (#15373 ) - `pluck_each` cannot be used this way with `group` - typo Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	c6598b17d9	Bump version to 3.3.0rc2 (#15365 )	4 years ago
ThibG	a60d9335d8	Fix resolving accounts sometimes creating duplicate records for a given AP id (#15364 ) * Fix ResolveAccountService accepting mismatching acct: URI * Set attributes that should be updated regardless of suspension * Fix key fetching * Automatically merge remote accounts with duplicate `uri` * Add tests * Add "tootctl accounts fix-duplicates" Finds duplicate accounts sharing a same ActivityPub `id`, re-fetch them and merge them under the canonical `acct:` URI. Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	75944a2f2d	Bump max supported schema version in maintenance script (#15359 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	8485c436d5	Bump max supported schema version in maintenance script (#15349 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
Eugen Rochko	1045549f85	Add stoplight for object storage failures, return HTTP 503 (#13043 )	4 years ago
Eugen Rochko	216b85b053	Fix performance on instances list in admin UI (#15282 ) - Reduce duplicate queries - Remove n+1 queries - Add accounts count to detailed view - Add separate action log entry for updating existing domain blocks	4 years ago
ThibG	fbe7519243	Fix account merging in maintenance script (#15264 ) Also include AccountNote and AccountDeletionRequest to the list of classes needing to be reassigned the merged account.	4 years ago
ThibG	fbff89be03	Fix tootctl ip_blocks add failing if not given a comment (#15263 ) Fixes #15261	4 years ago
Eugen Rochko	8e0b98556f	Bump version to 3.3.0rc1 (#15230 )	4 years ago
Eugen Rochko	e7f1439b97	Bump version to 3.2.1 (#15227 )	4 years ago
Eugen Rochko	ec0edf74d6	Fix post-migration warning about index corruption being too scary (#15223 )	4 years ago
Eugen Rochko	f844386809	Add `tootctl accounts merge` (#15201 ) * Add `tootctl accounts merge` * Update lib/mastodon/accounts_cli.rb Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	4 years ago
ThibG	1242e57c27	Deal with collation-related index corruption (#14860 ) * Add tootctl maintenance fix-duplicates This tool goes through the database to detect and fix duplicates. This operation is very slow and may cause data loss (of data that would be inaccessible without intervention because of the existing index corruptions). It tries its best to make sensible decisions, and asks the user in some cases. * Add warning message in db:migrate hook * Clear Rails cache after being done with database deduplication Avoids followers hash cache being incorrect, among other things	4 years ago
Eugen Rochko	3134691948	Add support for reversible suspensions through ActivityPub (#14989 )	4 years ago
Eugen Rochko	9b1f2a4b61	Add subresource integrity for JS and CSS assets (#15096 ) Fix #2744	4 years ago
Eugen Rochko	5e1364c448	Add IP-based rules (#14963 )	4 years ago
ThibG	5bbc9a4f78	Fix downloading remote media files when server returns empty filename (#14867 ) Fixes #14817	4 years ago
Eugen Rochko	ed099d8bdc	Change account suspensions to be reversible by default (#14726 )	5 years ago
Eugen Rochko	e6b272e5c9	Change REST API to return empty data for suspended accounts (#14765 )	5 years ago

1 2 3 4 5 ...

562 Commits (16122761c5eca0f25f17968a208a24ddd99e073e)