194 Commits (0d14fcebae0b9a0e5da73049c960064338dfee8e)

Author	SHA1	Message	Date
ThibG	5d9acc0ce4	Fix not handling Undo on some activity types when they aren't inlined (#14346) ... * Fix not handling Undo on some activity types when they aren't inlined When receiving an Undo for a non-inlined activity, try looking it up in database using the URI. The queries are ad-hoc because we don't have a global index of object URIs, and not all activity types are stored in database with an index on their URI. Announces are just statuses, and have an index on URIs, so this check can be done efficiently. Accepts cannot be handled at all because we don't record their URI at any point. Follows don't have an index on URI, but they have an index on the issuing account, which should make such queries largely manageable. Likes don't have an index on URI, they have an index on the issuing account, but the number of favs per account may be very high, so I decided not to handle that. Blocks don't have an index on URI, but they have an index on the issuing account, which should make such queries largely manageable. In all cases, if an Undo could not be handled properly, we call `delete_later!` because that does not require us to know more than the URI of the undone property. * Add tests * Make newer blocks overwrite older ones Allows re-synchronizing block info by re-blocking and un-blocking again when the original Undo Block has been lost.	5 years ago
ThibG	bcf85b5208	Dereference object URIs in Create and Update messages (#14359) ... * Dereference object URIs in Create and Update messages Fixes #14353 Signed-off-by: Thibaut Girka <thib@sitedethib.com> * Refactor, and perform origin check *before* attempting to fetch object Co-authored-by: Fire Demon <firedemon@creature.cafe>	5 years ago
Takeshi Umeda	fcb3f259e5	Fix to add RedisLock to handle Announce activity (#14365)	5 years ago
abcang	6a96af4d20	Fix rubocop warning (#14288) ... * Fix rubocop warning * use limit variable * use ContextCreatingMethods option	5 years ago
Eugen Rochko	6d23d40420	Change Redis#exists calls to Redis#exists? to avoid deprecation warning (#14191)	5 years ago
Eugen Rochko	64aac30733	Add customizable thumbnails for audio and video attachments (#14145) ... - Change audio files to not be stripped of metadata - Automatically extract cover art from audio if it exists - Add `thumbnail` parameter to `POST /api/v1/media`, `POST /api/v2/media` and `PUT /api/v1/media/:id` - Add `icon` to represent it in attachments in ActivityPub - Fix `preview_url` containing URL of missing missing image when there is no thumbnail instead of null - Fix duration of audio not being displayed on public pages until the file is loaded	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820)	5 years ago
ThibG	a319c1e60f	Add support for `summary` field for media description (#13763)	5 years ago
ThibG	2ee5a9d9c3	Clean up OStatus-related codepaths (#12173) ... * Remove “protocol” argument and return value, as only ActivityPub is supported * Remove FetchRemoteAccountService, only use ActivityPub::FetchRemoteAccountService * Fix tests	5 years ago
ThibG	da2143b308	Fixes featured hashtag setting page erroring out instead of rejecting invalid tags (#12436) ... * Revert "Fix ignoring whole status because of one invalid hashtag (#11621)" This reverts commit dff46b260b. * Fix statuses being rejected because of invalid hashtag names * Add spec for invalid hashtag names in statuses * Add test for featured tags controller	5 years ago
ThibG	f05b0463db	Fallback to Create audience when object has no defined audience (#12249) ... Fixes #11137	5 years ago
puckipedia	d2919f7e94	Allow Accept/Reject with a non-embedded object (#12199) ... Some ActivityPub servers refuse to embed remote objects into their own output. This is because they are not the authoritative source for these objects, and as such embedding them is always a waste of space. The follow request and follow models contain a URI, so this can be used to match them.	5 years ago
ThibG	3babf8464b	Add voters count support (#11917) ... * Add voters count to polls * Add ActivityPub serialization and parsing of voters count * Add support for voters count in WebUI * Move incrementation of voters count out of redis lock * Reword “voters” to “people”	5 years ago
Eugen Rochko	368a87755b	Fix account migration not affecting followers on origin server (#11980)	5 years ago
ThibG	18b451c0e6	Change silences to always require approval on follow (#11975) ... * Change silenced accounts to require approval on follow * Also require approval for follows by people explicitly muted by target accounts * Do not auto-accept silenced or muted accounts when switching from locked to unlocked * Add `follow_requests_count` to verify_credentials * Show “Follow requests” menu item if needed even if account is locked * Add tests * Correctly reflect that follow requests weren't auto-accepted when local account is silenced * Accept follow requests from user-muted accounts to avoid leaking mutes	5 years ago
Eugen Rochko	4f6af87906	Change spam check to apply to local accounts and add a threshold (#11806) ... Instead of detecting spam on first duplicate message, add a threshold of 5 such messages to reduce false positives	5 years ago
Eugen Rochko	38dc51b2d6	Fix Move handler queuing jobs that will fail if account is suspended (#11864) ... Don't put Move handler on cooldown if it didn't run. Skip unmerging from timelines to save unnecessary work.	5 years ago
Eugen Rochko	c5d37f18cb	Change deletes to preserve soft-deleted statuses in unresolved reports (#11805) ... Change all account actions except "none" to resolve all unresolved reports Refactor `SuspendAccountService` to be more readable	5 years ago
Eugen Rochko	031ca25014	Add retry for failed media downloads and `tootctl media refresh` (#11775)	5 years ago
Eugen Rochko	97192d9a77	Fix remote and staff-removed statuses leaving media behind for a day (#11638) ... The reason for unattaching media instead of removing it is to support delete & redraft functionality, but remote or staff-removed statuses will never be redrafted, so the media should be deleted immediately	5 years ago
Eugen Rochko	b9b0313c78	Revert "Remove conversation URI (#11423)" (#11424) ... This reverts commit 75f7f9930e.	6 years ago
Eugen Rochko	75f7f9930e	Remove conversation URI (#11423) ... It is not part of ActivityPub and will free up a lot of space	6 years ago
Eugen Rochko	f371b32137	Change hashtags to preserve first-used casing (#11416)	6 years ago
ThibG	730c4053d6	Add ActivityPub actor representing the entire server (#11321) ... * Add support for an instance actor * Skip username validation for local Application accounts * Add migration script to create instance actor * Make Codeclimate happy * Switch to id -99 for instance actor * Remove unused `icon` and `image` attributes from instance actor * Use if/elsif/else instead of return + ternary operator * Add instance actor to fresh installs * Use instance actor as instance representative Use instance actor for forwarding reports, relay operations, and spam auto-reporting. * Seed database in test environment * Fix single-user mode * Fix tests * Fix specs to accomodate for an extra `Account` * Auto-reject follows on instance actor Following an instance actor might make sense, but we are not handling that right now, so auto-reject. * Fix webfinger lookup and serialization for instance actor * Rename instance actor * Make it clear in the HTML view that the instance actor should not be blocked * Raise cache time for instance actor as there's no dynamic content * Re-use /about/more with a flash message for instance actor profile	6 years ago
Eugen Rochko	6ff67be0f6	Add a spam check (#11217) ... * Add a spam check * Use Nilsimsa to generate locality-sensitive hashes and compare using Levenshtein distance * Add more tests * Add exemption when the message is a reply to something that mentions the sender * Use Nilsimsa Compare Value instead of Levenshtein distance * Use MD5 for messages shorter than 10 characters * Add message to automated report, do not add non-public statuses to automated report, add trust level to accounts and make unsilencing raise the trust level to prevent repeated spam checks on that account * Expire spam check data after 3 months * Add support for local statuses, reduce expiration to 1 week, always create a report * Add content warnings to the spam check and exempt empty statuses * Change Nilsimsa threshold to 95 and make sure removed statuses are removed from the spam check * Add all matched statuses into automatic report	6 years ago
Eugen Rochko	63c7fe8e48	Refactor controllers for statuses, accounts, and more (#11249)	6 years ago
Eugen Rochko	aa9b37822b	Fix audio not being downloaded from remote servers (#11145)	6 years ago
Eugen Rochko	707ddf7808	Change domain blocks to automatically support subdomains (#11138) ... * Change domain blocks to automatically support subdomains If a more authoritative domain is blocked (example.com), then the same block will be applied to a subdomain (foo.example.com) * Match subdomains of existing accounts when blocking/unblocking domains * Improve code style	6 years ago
Eugen Rochko	8746f4d17b	Change priority of delete activity forwards for replies and reblogs (#11002) ... Fix #11001	6 years ago
Eugen Rochko	f2b743e715	Refactor all ActivityPub deliveries to be serialized and signed through one concern (#10966)	6 years ago
ThibG	3a84bacf86	Handle blank poll options more gracefully (#10946) ... Pleroma currently allows (erroneously imho) empty poll options, that is, options with an empty (but existing) `name`.	6 years ago
ThibG	9a5561a5b8	Fix possible race condition when processing statuses (#10815)	6 years ago
Eugen Rochko	fba96c808d	Add blurhash (#10630) ... * Add blurhash * Use fallback color for spoiler when blurhash missing * Federate the blurhash and accept it as long as it's at most 5x5 * Display unknown media attachments as blurhash placeholders * Improve style of embed actions and spoiler button * Change blurhash resolution from 3x3 to 4x4 * Improve dependency definitions * Fix code style issues	6 years ago
Eugen Rochko	f1bc90ab50	Rename :poll to :preloadable_poll and :owned_poll to :poll on Status (#10401) ... Also, fix some n+1 queries Resolve #10365	6 years ago
Eugen Rochko	e86663b1da	Fix alternative relay support regression (#10398) ... Fix #10324	6 years ago
ThibG	a20354a20b	Set and store report URIs (#10303) ... Fixes #10271	6 years ago
Eugen Rochko	9f5b55ad4f	Fix poll update handler calling method was that was not available (#10246) ... * Fix poll update handler calling method was that was not available Fix regression from #10209 * Refactor VoteService * Refactor ActivityPub::DistributePollUpdateWorker and optimize it * Fix typo * Fix typo	6 years ago
ThibG	3a92885a86	Support pushing and receiving updates to poll tallies (#10209) ... * Process incoming poll tallies update * Send Update on poll vote * Do not send Updates for a poll more often than once every 3 minutes * Include voters in people to notify of results update * Schedule closing poll worker on poll creation * Add new notification type for ending polls * Add front-end support for ended poll notifications * Fix UpdatePollSerializer * Fix Updates not being triggered by local votes * Fix tests failure * Fix web push notifications for closing polls * Minor cleanup * Notify voters of both remote and local polls when those close * Fix delivery of poll updates to mentioned accounts and voters	6 years ago
ThibG	3aaac4f134	Do not allow adding votes to expired polls (#10214) ... * Do not allow adding votes to expired polls * Only validate expires_at on create	6 years ago
ThibG	34f261e6af	Avoid unnecessarily fetching the replies collection when it is empty (#10201)	6 years ago
ThibG	833ffce2df	Store remote votes URI (#10158) ... * Store remote votes URI * Add spec for accepting remote votes * Make poll vote id generation work the same way as follows	6 years ago
Eugen Rochko	0e6998da3c	Add tests for ActivityPub poll processing (#10143)	6 years ago
Eugen Rochko	ae1b9cf70a	Fix remote poll expiration time (#10144)	6 years ago
Eugen Rochko	230a012f00	Add polls (#10111) ... * Add polls Fix #1629 * Add tests * Fixes * Change API for creating polls * Use name instead of content for votes * Remove poll validation for remote polls * Add polls to public pages * When updating the poll, update options just in case they were changed * Fix public pages showing both poll and other media	6 years ago
ThibG	9d3c6f1849	Improved remote thread fetching (#10106) ... * Fetch up to 5 replies when discovering a new remote status This is used for resolving threads downwards. The originating server must add a “replies” attributes with such replies for it to be useful. * Add some tests for ActivityPub::FetchRepliesWorker * Add specs for ActivityPub::FetchRepliesService * Serialize up to 5 public self-replies for ActivityPub notes * Add specs for ActivityPub::NoteSerializer * Move exponential backoff logic to a worker concern * Fetch first page of paginated collections when fetching thread replies * Add specs for paginated collections in replies * Move Note replies serialization to a first CollectionPage The collection isn't actually paginable yet as it has no id nor a `next` field. This may come in another PR. * Use pluck(:uri) instead of map(&:uri) to improve performances * Fix fetching replies when they are in a CollectionPage	6 years ago
ThibG	9edab46368	Fix mention processing for unknwon accounts on incoming ActivityPub Notes (#10125) ... `::FetchRemoteAccountService` is not `ActivityPub::FetchRemoteAccountService`, its second argument is the pre-fetched body. Passing `id: false` actually passed a `Hash` as the prefetched body, instead of properly resolving unknown remote accounts.	6 years ago
Eugen Rochko	147b4c2c3a	Add logging for rejected ActivityPub payloads and add tests (#10062)	6 years ago
Eugen Rochko	c417e8c198	Filter incoming Announce activities by relation to local activity (#10041) ... * Filter incoming Announce activities by relation to local activity Reject if announcer is not followed by local accounts, and is not from an enabled relay, and the object is not a local status Follow-up to #10005 * Fix tests	6 years ago
Eugen Rochko	dad339da6d	Filter incoming Create activities by relation to local activity (#10005) ... Reject those from accounts with no local followers, from relays that are not enabled, which do not address local accounts and are not replies to accounts that do have local followers	6 years ago
ThibG	6a5307a573	Alternative handling of private self-boosts (#9998) ... * When self-boosting, embed original toot into Announce serialization * Process unknown self-boosts from Announce object if it is more than an URI * Add some self-boost specs * Only serialize private toots in self-Announces	6 years ago
ThibG	75b1488cf4	Add tombstones for remote statuses (#9830) ... * Add Tombstone model to remember object deletion * Do not recreate a status if it has been deleted * Record Tombstone for remote deleted items Also, only record deleted items from same-host actors * Clear an user's tombstones when their key change	6 years ago
Eugen Rochko	31f396b57d	Add support for non-public reblogs from ActivityPub (#9841) ... Fix #9838	6 years ago
Eugen Rochko	4ab42287c0	Use summary as summary for converted ActivityPub objects (#9823) ... Fix #8609	6 years ago
ThibG	a4f07bad95	Reduce chances of race conditions when processing deleted toots (#9815) ... * Reduce chances of race conditions when processing deleted toots * Prevent race condition when processing deleted toots	6 years ago
ThibG	70be301d69	Ensure blocked user unfollows blocker if Block/Undo Block are processed out of order (#9687) ... * Ensure blocked user unfollows blocker if Block/Undo Block are processed out of order * Add specs for Block causing unfollow and for out-of-order Block + Undo	6 years ago
ThibG	b2f4114550	Do not ignore federated reports targetting already-reported accounts (#9534)	6 years ago
ThibG	290932602b	Reduce usage of LD signatures (#9659) ... * Do not LDS-sign Follow, Accept, Reject, Undo, Block * Do not use LDS for Create activities of private toots * Minor cleanup * Ignore unsigned activities instead of misattributing them * Use status.distributable? instead of querying visibility directly	6 years ago
Eugen Rochko	0f938ff29c	Add handler for Move activity (#9629)	6 years ago
Eugen Rochko	aa9a20cde0	Fix ThreadResolveWorker getting queued with invalid URLs (#9628)	6 years ago
Eugen Rochko	9311430ed7	Prevent multiple handlers for Delete of Actor from running (#9292)	6 years ago
ThibG	7f5a4be580	Fix emoji update date processing (#9255)	6 years ago
Eugen Rochko	be202f9377	Accept the same payload in multiple inboxes and deliver (#9150)	6 years ago
m.b	2b18f5f85d	Add Page AP type support (#9121)	6 years ago
ThibG	e53cc673e7	Ignore invalid hashtags on remote statuses instead of rejecting them (#9118) ... Fixes #9115	6 years ago
ThibG	82e7988afc	Fix missing `mention` argument when processing incoming Create activities (#9114) ... * Fix missing `mention` argument when processing incoming Create activities * Fix typo (param → params)	6 years ago
Eugen Rochko	d4cf963749	Allow inbox owner to view implicitly targeted ActivityPub payload (#9093) ... Fix #9091	6 years ago
Eugen Rochko	fd5285658f	Add option to block reports from domain (#8830)	6 years ago
Eugen Rochko	ddd30f331c	Improve support for aspects/circles (#8950) ... * Add silent column to mentions * Save silent mentions in ActivityPub Create handler and optimize it Move networking calls out of the database transaction * Add "limited" visibility level masked as "private" in the API Unlike DMs, limited statuses are pushed into home feeds. The access control rules between direct and limited statuses is almost the same, except for counter and conversation logic * Ensure silent column is non-null, add spec * Ensure filters don't check silent mentions for blocks/mutes As those are "this person is also allowed to see" rather than "this person is involved", therefore does not warrant filtering * Clean up code * Use Status#active_mentions to limit returned mentions * Fix code style issues * Use Status#active_mentions in Notification And remove stream_entry eager-loading from Notification	6 years ago
Eugen Rochko	61d44dd11f	Fix typo in ActivityPub Create handler (#8952) ... Regression from #8951	6 years ago
Eugen Rochko	790d3bc637	Move network calls out of transaction in ActivityPub handler (#8951) ... Mention and emoji code may perform network calls, but does not need to do that inside the database transaction. This may improve availability of database connections when using pgBouncer in transaction mode.	6 years ago
ThibG	ba444797d2	Fix handling of ActivityPub activities lacking some attributes (#8864)	6 years ago
Eugen Rochko	ef69c655cc	Fix class autoloading issue in ActivityPub::Activity::Create (#8820)	6 years ago
Eugen Rochko	f4d549d300	Redesign forms, verify link ownership with rel="me" (#8703) ... * Verify link ownership with rel="me" * Add explanation about verification to UI * Perform link verifications * Add click-to-copy widget for verification HTML * Redesign edit profile page * Redesign forms * Improve responsive design of settings pages * Restore landing page sign-up form * Fix typo * Support <link> tags, add spec * Fix links not being verified on first discovery and passive updates	6 years ago
Eugen Rochko	cabdbb7f9c	Add CLI task for rotating keys (#8466) ... * If an Update is signed with known key, skip re-following procedure Because it means the remote actor did *not* lose their database * Add CLI method for rotating keys bin/tootctl accounts rotate [USERNAME] Generates a new RSA key per account and sends out an Update activity signed with the old key. * Key rotation: Space out Update fan-outs every 5 minutes per 1000 accounts * Skip suspended accounts in key rotation	6 years ago
M Somerville	95bd0d4528	Support ActivityStreams’ summaryMap. (#8422) ... In the same way as contentMap and nameMap.	6 years ago
ThibG	42573b76f1	Do not crash if remote custom emoji does not define updated date (fixes #8376) (#8377)	6 years ago
ThibG	59f7f4c923	Implement Undo { Accept { Follow } } (fixes #8234) (#8245) ... * Add Follow#revoke_request! * Implement Undo { Accept { Follow } } (fixes #8234)	6 years ago
ThibG	1ee675d68b	Use correct activity id in Accept when receiving duplicate Follow (fixes #8218) (#8244)	6 years ago
Eugen Rochko	39e361a56d	Expect relays to answer with accept/reject (#8179)	6 years ago
Eugen Rochko	6ba7d9d0d9	Do not accept ActivityPub follow requests from blocked user (#7756) ... * Do not accept ActivityPub follow requests from blocked user Fix #7745 * Deliver auto-rejection immediately when follow-requested by blocked account * Fix trailing whitespace	7 years ago
Eugen Rochko	1e938b966e	Exclude unlisted, private and direct toots from affecting trends (#7686)	7 years ago
Eugen Rochko	ab36e0ef72	Record trending tags from ActivityPub, too (#7647)	7 years ago
ThibG	cdbdf7f98b	Ignore multiple occurrences of a hashtag within a status (fixes #7585) (#7606)	7 years ago
Eugen Rochko	57b503d4ef	Resolve unknown status from Add activity, skip Remove if unknown (#7526) ... Fix #7518	7 years ago
Akihiko Odaki	55fd55714a	Raise Mastodon::RaceConditionError if Redis lock failed (#7511) ... An explicit error allows user agents to know the error and Sidekiq to retry.	7 years ago
ThibG	7467361d70	Fetch boosted statuses on behalf of a follower (fixes #7426) (#7459) ... When an ActivityPub Announce is processed and the boosted toot is not known, fetch it on behalf of one of the booster's followers. This is to allow fetching self-boosts of previously-unknown private toots. If fetching on behalf of a user fails, try fetching it anonymously: the selected follower of a boosting user may be banned by the boosted toot's author.	7 years ago
Eugen Rochko	6793bec4c6	Store URIs of follows, follow requests and blocks for ActivityPub (#7160) ... Same URI passed between follow request and follow, since they are the same thing in ActivityPub. Local URIs are generated during creation using UUIDs and are passed to serializers.	7 years ago
ThibG	a24605961a	Fixes/do not override timestamps (#7336) ... * Revert "Fixes/do not override timestamps (#7331)" This reverts commit 581a5c9d29. * Document Snowflake ID corner-case a bit more Snowflake IDs are used for two purposes: making object identifiers harder to guess and ensuring they are in chronological order. For this reason, they are based on the `created_at` attribute of the object. Unfortunately, inserting items with older snowflakes IDs will break the assumption of consumers of the paging APIs that new items will always have a greater identifier than the last seen one. * Add `override_timestamps` virtual attribute to not correlate snowflake ID with created_at	7 years ago
ThibG	581a5c9d29	Fixes/do not override timestamps (#7331) ... * Do not override timestamps for incoming toots * Remove every reference to override_timestamps Statuses are now created with the announced publishing date and are only pushed to timelines if that date is at most 6 hours earlier than the time at which it is processed.	7 years ago
ThibG	d0cdd5cf94	Accept actor object updates from all supported actor types (#7312)	7 years ago
Surinna Curtis	dc786c0cf4	Support Actors/Statuses with multiple types (#7305) ... * Add equals_or_includes_any? helper in JsonLdHelper * Support arrays in JSON-LD type fields for actors/tags/objects. * Spec for resolving accounts with extension types * Style tweaks for codeclimate	7 years ago
Eugen Rochko	b5726def55	Forward deletes on the same path as reply forwarding (#7058) ... * Forward deletes on the same path as reply forwarding * Remove trailing whitespace	7 years ago
ThibG	e573bb0990	Fix compatibility with PeerTube (#6968) ... * Support fetching objects of convertible types by URL (fixes #6924) * Ignore invalid hashtags	7 years ago
ThibG	9ed5eebd7c	Do not ignore unknown media attachments, only skip them (#6948) ... That way, they are displayed in a list below the corresponding toot.	7 years ago
Eugen Rochko	f02411da40	Ignore media validation when attaching to status during processing (#6822) ... Fix #6821	7 years ago
MitarashiDango	6dcf96271e	fix validation error (media only status) (#6684) ... * fix validation error (media only status) * Incorporating review suggestions * Reflect similar fix to OStatus side * Fix not to include media in transaction * Restore the limit of the number of media * Fix not to return nil	7 years ago
Eugen Rochko	e6520c0270	Fix #6657 - Use target instead of origin in Remove activity (#6664)	7 years ago
Eugen Rochko	9110db41c5	Federate pinned statuses over ActivityPub (#6610) ... * Federate pinned statuses over ActivityPub * Display pinned toots in web UI Fix #6117 * Fix migration * Fix tests * Update outbox_serializer.rb * Update remove_serializer.rb * Update add_serializer.rb * Update fetch_featured_collection_service.rb	7 years ago
Eugen Rochko	e852872846	Fix #5708: Reject->Follow will remove the follow if it exists (#6571)	7 years ago
Eugen Rochko	41a01bec23	Federated reports (#6570) ... * Fix #2176: Federated reports * UI for federated reports * Add spec for ActivityPub Flag handler * Add spec for ReportService	7 years ago