mastodon

Commit Graph

Author	SHA1	Message	Date
Jeong Arm	720e8ab0f5	Fix duplicate record on admin/accounts when searching with IP (#17150 )	3 years ago
Claire	76761d5fc0	Add ability for admins to delete canonical email blocks (#16644 ) * Add admin option to remove canonical email blocks from a deleted account * Add tootctl canonical_email_blocks to inspect and remove canonical email blocks	3 years ago
Claire	7f803c41e2	Add ability to purge undeliverable domains from admin interface (#16686 ) * Add ability to purge undeliverable domains from admin interface * Add tests	3 years ago
Eugen Rochko	fe45184b36	Change trending hashtags threshold back from 15 to 5 (#17122 )	3 years ago
Eugen Rochko	0fb9536d38	Add batch suspend for accounts in admin UI (#17009 )	3 years ago
Eugen Rochko	7de0ee7aba	Remove Keybase integration (#17045 )	3 years ago
Eugen Rochko	12b3ff6c6d	Fix error on trending hashtags/links pages in admin UI due to missing constant (#17044 )	3 years ago
Eugen Rochko	6e50134a42	Add trending links (#16917 ) * Add trending links * Add overriding specific links trendability * Add link type to preview cards and only trend articles Change trends review notifications from being sent every 5 minutes to being sent every 2 hours Change threshold from 5 unique accounts to 15 unique accounts * Fix tests	3 years ago
Claire	02a87431cf	Fix error when suspending user with an already-existing canonical email block (#17036 ) * Fix error when suspending user with an already-existing canonical email block Fixes #17033 While attempting to create a `CanonicalEmailBlock` with an existing hash would raise an `ActiveRecord::RecordNotUnique` error, this being done within a transaction would cancel the whole transaction. For this reason, checking for uniqueness in Rails would query the database within the transaction and avoid invalidating the whole transaction for this reason. A race condition is still possible, where multiple accounts sharing a canonical email would be blocked in concurrent transactions, in which only one would succeed, but that is way less likely to happen that the current issue, and can always be retried after the first failure, unlike the current situation. * Add tests	3 years ago
Takeshi Umeda	3419d3ec84	Bump chewy from 5.2.0 to 7.2.3 (supports Elasticsearch 7.x) (#16915 ) * Bump chewy from 5.2.0 to 7.2.2 * fix style (codeclimate) * fix style * fix style * Bump chewy from 7.2.2 to 7.2.3	3 years ago
Claire	6da135a493	Fix reviving revoked sessions and invalidating login (#16943 ) Up until now, we have used Devise's Rememberable mechanism to re-log users after the end of their browser sessions. This mechanism relies on a signed cookie containing a token. That token was stored on the user's record, meaning it was shared across all logged in browsers, meaning truly revoking a browser's ability to auto-log-in involves revoking the token itself, and revoking access from all logged-in browsers. We had a session mechanism that dynamically checks whether a user's session has been disabled, and would log out the user if so. However, this would only clear a session being actively used, and a new one could be respawned with the `remember_user_token` cookie. In practice, this caused two issues: - sessions could be revived after being closed from /auth/edit (security issue) - auto-log-in would be disabled for all browsers after logging out from one of them This PR removes the `remember_token` mechanism and treats the `_session_id` cookie/token as a browser-specific `remember_token`, fixing both issues.	3 years ago
Claire	87085a5152	Fix AccountNote not having a maximum length (#16942 )	3 years ago
Claire	989c67d29d	Fix handling announcements with links (#16941 ) Broken since #15827	3 years ago
Takeshi Umeda	17f4e457b3	Add remove from followers api (#16864 ) * Add followed_by? to account_interactions * Add RemoveFromFollowersService * Fix AccountBatch to use RemoveFromFollowersService * Add remove from followers API	3 years ago
Jeong Arm	f4081d1564	Allow keeping only 1 boosts/favs on auto deleting posts (#16653 ) * Allow keeping 1 boosts/favs on auto deleting posts * Fix tests	3 years ago
Claire	9b978872cc	Fix 404 error when filtering admin action logs by non-existent target account (#16643 ) Currently, there is no way for an admin to delete an account record. However, should that happen in the future, or should an admin mistype an account id, `/admin/action_logs?target_account_id=<non-existent-account-id>` currently returns a 404 instead of an empty list. With this commit, the aforementioned page returns a correct list instead (potentially non-empty if the account has been manually deleted)	3 years ago
Claire	216570ad98	Fix scheduled statuses decreasing statuses counts (#16791 ) * Add tests * Fix scheduled statuses decreasing statuses counts Fixes #16774	3 years ago
Claire	5159ba26e4	Fix error when rendering public pages with media attachments (#16763 ) * Add tests * Fix error when rendering public pages with media attachments * Add tests * Fix tests * Please CodeClimate	3 years ago
Claire	84ceebe1c4	Fix media attachment size validation not correctly accounting for file type (#16819 ) * Fix media attachment size validation not correctly accounting for file type Fixes a regression introduced in #16724 caused by the fact that kt-paperclip now correctly runs validations before processing, meaning that file size verification could not rely on our before_post_processing hook. Moved the `before_post_processing` hooks to `before_validate` to make sure the media attachment type is set correctly before the file gets validated. * Add tests	3 years ago
Claire	fc3ae1343d	Switch from unmaintained paperclip to kt-paperclip (#16724 ) * Switch from unmaintained paperclip to kt-paperclip * Drop some compatibility monkey-patches not required by kt-paperclip * Drop media spoof check monkey-patching It's broken with kt-paperclip and hopefully it won't be needed anymore * Fix regression introduced by paperclip 6.1.0 * Do not rely on pathname to call FastImage * Add test for ogg vorbis file with cover art * Add audio/vorbis to the accepted content-types This seems erroneous as this would be the content-type for a vorbis stream without an ogg container, but that's what the `marcel` gem outputs, so… * Restore missing for_as_default method * Refactor Attachmentable concern and delay Paperclip's content-type spoof check Check for content-type spoofing after setting the extension ourselves, this fixes a regression with kt-paperclip's validations being more strict than paperclip 6.0.0 and rejecting some Pleroma uploads because of unknown extensions. * Please CodeClimate * Add audio/vorbis to the unreliable set It doesn't correspond to a file format and thus has no extension associated.	3 years ago
Claire	db57bff11d	Stop setting a shortcode to newly-created media attachments (#16730 ) * Stop setting a shortcode to newly-created media attachments The WebUI has stopped using the “short media URL” in ages. This isn't used anywhere except for mail notifications. Deprecating it would allow us to eventually get rid of at least a database column and corruption-prone index, as well as a controller. * Fix tests	3 years ago
Claire	2b18f7a943	Fix processing mentions to domains with non-ascii TLDs (#16689 ) Fixes #16602	4 years ago
Claire	5efb1ff337	Fix followers synchronization mechanism not working when URI has empty path (#16510 ) * Fix followers synchronization mechanism not working when URI has empty path To my knowledge, there is no current implementation on the fediverse that can use bare domains (e.g., actor is at https://example.org instead of something like https://example.org/actor) that also plans to support the followers synchronization mechanism. However, Mastodon's current implementation would exclude such accounts from followers list. Also adds tests and rename them to reflect the proper method names. * Move url prefix regexp to its own constant	4 years ago
Claire	13b08610a0	Fix crash when encountering invalid account fields (#16598 ) * Add test * Fix crash when encountering invalid account fields	4 years ago
Claire	4ac78e2a06	Add feature to automatically delete old toots (#16529 ) * Add account statuses cleanup policy model * Record last inspected toot to delete to speed up successive calls to statuses_to_delete * Add service to cleanup a given account's statuses within a budget * Add worker to go through account policies and delete old toots * Fix last inspected status id logic All existing statuses older or equal to last inspected status id must be kept by the current policy. This is an invariant that must be kept so that resuming deletion from the last inspected status remains sound. * Add tests * Refactor scheduler and add tests * Add user interface * Add support for discriminating based on boosts/favs * Add UI support for min_reblogs and min_favs, rework UI * Address first round of review comments * Replace Snowflake#id_at_start with with_random parameter * Add tests * Add tests for StatusesCleanupController * Rework settings page * Adjust load-avoiding mechanisms * Please CodeClimate	4 years ago
Claire	763ab0c7eb	Fix owned account notes not being deleted when an account is deleted (#16579 ) * Add account_notes relationship * Add tests * Fix owned account notes not being deleted when an account is deleted * Add post-migration to clean up orphaned account notes	4 years ago
Claire	30ce6e395c	Fix user email address being banned on self-deletion (#16503 ) * Add tests * Fix user email address being banned on self-deletion Fixes #16498	4 years ago
Eugen Rochko	7095c80373	Add ability to filter reports by origin of target account (#16487 )	4 years ago
Eugen Rochko	771c9d4ba8	Add ability to skip sign-in token authentication for specific users (#16427 ) Remove "active within last two weeks" exception for sign in token requirement Change admin reset password to lock access until the password is reset	4 years ago
Claire	8569126c2e	Fix upgrade path from 3.4.0 (#16465 ) 3.4.1 dropped account_stats.lock_version, but in a way breaking the usual upgrade path by requiring services to be reloaded after the post-migrations. Indeed, `self.locking_column = nil` was not enough for Rails to ignore the `lock_version` column when preparing statements on application load, resulting in some ActiveRecord queries (typically those involving `includes(:account_stat)`) erroring out with: ActiveRecord::StatementInvalid (PG::UndefinedColumn: ERROR: column account_stats.lock_version does not exist	4 years ago
Eugen Rochko	38b3419950	Fix not being able to suspend accounts that already have a canonical e-mail block (#16455 )	4 years ago
Eugen Rochko	d174d12c83	Add authentication history (#16408 )	4 years ago
Claire	526332c545	Fix account deletion sometimes failing because of optimistic locks (#16317 ) * Fix account deletion sometimes failing because of optimistic locks In some rare occasions[1], deleting accounts would fail with a `StaleObjectError` exception. Indeed, account deletion manually sets the `AccountStat` values without handling cases where the optimistic locking on `AccountStat` would fail. To my knowledge, with the rewrite of account counters in #15913, the `DeleteAccountService` is now the only place that changes the counters in a way that is not atomic. Since in this specific case, we do not care about the previous values of the account counters, it appears we don't need locking at all for this table anymore. [1]: https://discourse.joinmastodon.org/t/account-cant-be-deleted/3602 * Bump MAX_SUPPORTED_VERSION in maintenance script	4 years ago
Claire	76064e6608	Update fix-duplicates maintenance script to support latest migrations (#16231 ) * Update maintenance script to support latest database migrations * Update Account#merge_with!	4 years ago
Takeshi Umeda	c403c3695b	Fix to be able to redownload avatar and header (#16190 ) * Fix to reset if header and avatar download fails * Add RedownloadAvatarWorker and RedownloadHeaderWorker	4 years ago
Claire	f9c2d1b9a1	Fix FollowRecommendationsScheduler failing because of unpopulated views (#16189 ) Since #16173, `account_summaries` and `follow_recommendations` are not populated at creation time, which causes concurrent refresh to fail. As we currently only use those materialized views right after explicitly refreshing them, this commit changes refreshes to not be performed concurrently. This will fix the issue and ensure the refresh completes faster while using less resources.	4 years ago
Eugen Rochko	1294f9ee4f	Remove PubSubHubbub-related columns from accounts table (#16170 )	4 years ago
Eugen Rochko	74081433d0	Change trending hashtags to be affected be reblogs (#16164 ) If a status with a hashtag becomes very popular, it stands to reason that the hashtag should have a chance at trending Fix no stats being recorded for hashtags that are not allowed to trend, and stop ignoring bots Remove references to hashtags in profile directory from the code and the admin UI	4 years ago
Claire	566fc90913	Add Ruby 3.0 support (#16046 ) * Fix issues with POSIX::Spawn, Terrapin and Ruby 3.0 Also improve the Terrapin monkey-patch for the stderr/stdout issue. * Fix keyword argument handling throughout the codebase * Monkey-patch Paperclip to fix keyword arguments handling in validators * Change validation_extensions to please CodeClimate * Bump microformats from 4.2.1 to 4.3.1 * Allow Ruby 3.0 * Add Ruby 3.0 test target to CircleCI * Add test for admin dashboard warnings * Fix admin dashboard warnings on Ruby 3.0	4 years ago
Takeshi Umeda	7cb34b32f8	Add management of delivery availability in Federation settings (#15771 ) * Add management of delivery availavility in Federation settings * fix translate * Remove useless object creation * Fix DeepSource issue * Add shortcut for all * Fix DeepSource(skipcq) * Change 'remove' to 'clear' * Fix style * Change class method name (exhausted_deliveries_key_by)	4 years ago
Claire	d9ae3db8d5	Improve performance of follow recommendation scheduler (#16159 ) Express follow_recommendations in terms of account_summaries rather than accounts, integrate filters that are unconditionally used, and materialize the resulting view. This should result in the bulk of the computation being performed only once instead of once per recommendation language.	4 years ago
Eugen Rochko	036556d350	Fix media processing getting stuck on too much stdin/stderr (#16136 ) * Fix media processing getting stuck on too much stdin/stderr See thoughtbot/terrapin#5 * Remove dependency on paperclip-av-transcoder gem * Remove dependency on streamio-ffmpeg gem * Disable stdin on ffmpeg process	4 years ago
Eugen Rochko	fab65848d2	Fix empty home feed before first follow has finished processing (#16152 ) Change queue of merge worker from pull to default	4 years ago
abcang	7f0c49c58a	Improve tag search query (#16104 )	4 years ago
Eugen Rochko	daccc07dc1	Change auto-following admin-selected accounts, show in recommendations (#16078 )	4 years ago
Eugen Rochko	f4b7c6b619	Fix nil error when removing status caused by race condition (#16099 )	4 years ago
Claire	a6564d56d6	Fix edge case where accepted follow cannot be processed because of follow limit (#16098 )	4 years ago
Eugen Rochko	b3ceb3dcc4	Add canonical e-mail blocks for suspended accounts (#16049 ) Prevent new accounts from being created using the same underlying e-mail as a suspended account using extensions and period permutations. Stores e-mails as a SHA256 hash	4 years ago
Eugen Rochko	ce2148c571	Add `policy` param to `POST /api/v1/push/subscriptions` (#16040 ) With possible values `all`, `followed`, `follower`, and `none`, control from whom notifications will generate a Web Push alert	4 years ago
Eugen Rochko	120965eb0b	Change Web Push API deliveries to use request pooling (#16014 )	4 years ago

1 2 3 4 5 ...

1118 Commits (0a25c9595004d5d2a5d5f2a7d70549161692426f)