Commit Graph

2699 Commits (main)

Author SHA1 Message Date
Emelia Smith d94a367aeb
Add test coverage for POST /api/v2/media's max description length (#32683) 2 months ago
Matt Jankowski b107fc2e65
Use nil for timestamp column in admin/confirmations spec (#32682) 2 months ago
Matt Jankowski 1edb527072
Enhance coverage for `StatusPin` model (#32515) 3 months ago
Jonny Saunders 9074c1fac9
Use `likes` and `shares` totalItems on status creations and updates (#32620) 3 months ago
Matt Jankowski 1775e151ec
Simplify model validation specs for `DomainAllow` (#32496) 3 months ago
Matt Jankowski 9464281f29
Simplify model validation specs for `AccountStatusCleanupPolicy` (#32495) 3 months ago
Matt Jankowski 15f6336cdd
Simplify model validation specs for `AccountMigration` (#32494) 3 months ago
Matt Jankowski 86132f7dd3
Provide `establish_policy` helper method in `AccountStatusesCleanupPolicy` spec (#32490) 3 months ago
Matt Jankowski 2a13d6824c
Use `subject` for `FeedManager` lib spec (#32486) 3 months ago
Matt Jankowski 2e3bbb6861
Move account suspension related coverage to concern spec (#32432) 3 months ago
Matt Jankowski 4134ccdbe0
Simplify model validation specs for `WebauthnCredential` (#32466) 3 months ago
Matt Jankowski e5be4bf8d8
Simplify model validation specs for `PreviewCard` (#32469) 3 months ago
Matt Jankowski 37bcbeab4a
Simplify model validation spec in AccountModerationNote/ReportNote (#31792) 3 months ago
Matt Jankowski dea6c454fd
Contribute more coverage for `Account` model (#32474) 3 months ago
Matt Jankowski b16435e79f
Explore more resplendent model validation specs for `Form::AdminSettings` (#32465) 3 months ago
Matt Jankowski 67504dbf9c
Simplify uniqueness validation spec for `IpBlock` (#32066) 3 months ago
Matt Jankowski 5c910dc82e
Add coverage for `DatabaseHelper` primary/replica methods (#32642) 3 months ago
Matt Jankowski 745c4f900a
Remove unused `ApplicationHelper#visibility_icon` helper method (#32644) 3 months ago
Matt Jankowski 5a4f4f3e83
Remove single-use `ProfileStories` method (#31164) 3 months ago
Matt Jankowski 2f906ed55a
Constants for account refresh (#32420) 3 months ago
David Roetzel 05f23df3b7
Add endpoint to remove web push subscription (#32626) 3 months ago
Matt Jankowski d1b20ea8f7
Worker specs coverage increase (#32541) 3 months ago
Matt Jankowski bd0c826a3d
Simplify model validation specs for `Announcement` (#32481) 3 months ago
Matt Jankowski c0f46e9031
Fortify coverage for `Follow` model (#32472) 3 months ago
Matt Jankowski 1f3722904f
Top off coverage for `Appeal` model (#32464) 3 months ago
Matt Jankowski 67403e7b01
Add coverage for ActivityPub likes/shares endpoints (#32305) 3 months ago
Matt Jankowski 0a4a73f9a6
Add coverage for `api/v1/domain_blocks/preview` endpoint (#32303) 3 months ago
Matt Jankowski 6d2f865862
Add coverage for `AccountAlias` validations (#31936) 3 months ago
Matt Jankowski bfe3d49cca
Add `inline_jobs` to admin/reset spec (#32517) 3 months ago
Matt Jankowski c40cd79c4d
Convert `admin/invites` controller specs to system specs (#32450) 3 months ago
Matt Jankowski 9e8f099d38
Improve `app/policies` coverage (#32426) 3 months ago
Matt Jankowski 28131b4b00
Convert status embed controller to request spec (#32448) 3 months ago
Matt Jankowski b78597979a
Fix missing content warning text in rss formatter (#32406) 3 months ago
Matt Jankowski b742ce9d09
Reduce factory creation (17 -> 0) in `PlainTextFormatter` spec (#32487) 3 months ago
Matt Jankowski e9b27852be
Reduce factory creation (14 -> 8) in `ActivityPub::Activity::Block` spec (#32488) 3 months ago
Matt Jankowski 27f05e9016
Expand coverage for `User#token_for_app` (#32434) 3 months ago
Matt Jankowski bfb41e61a3
Expand coverage for `Block` model (#32480) 3 months ago
Christian Schmidt 227d46883f
Translate to regional language variant (e.g. pt-BR) (#32428) 3 months ago
Matt Jankowski 6a39212b02
Reduce factories (36 > 12) in `AccountReachFinder` spec (#32482) 3 months ago
Matt Jankowski 92bb19773a
Use `context` for repeated scenarios in `AccountStatusCleanupPolicy` spec (#32489) 3 months ago
Matt Jankowski d1d2278e70
Reduce factory creation (73 -> 64) in `PublicFeed` spec (#32491) 3 months ago
Matt Jankowski b1c10969ac
Reduce factory creation (48 -> 8) in `AP::Note` serializer spec (#32492) 3 months ago
Matt Jankowski a11b599ffa
Expand coverage for `Scheduler::IpCleanupScheduler` worker (#32499) 3 months ago
Matt Jankowski 0cc21f1ded
Reduce factory creation (132 -> 40) in lib/vacuum/* specs (#32498) 3 months ago
Matt Jankowski d74c2c583a
Extend spec coverage for `Poll` model (#32500) 3 months ago
Matt Jankowski cc70acc11c
Augment coverage for `Status` model (#32468) 3 months ago
Matt Jankowski d8eab3d81f
Reinforce coverage for `DomainBlock` model (#32473) 3 months ago
Matt Jankowski 06d6b35e88
Convert `admin/tags` controller specs to system specs (#32447) 3 months ago
Claire d9fbb071da
Fix notification requests from suspended accounts still being listed (#32354) 3 months ago
Matt Jankowski f49161ab1d
Oauth system spec cleanup / helper method extraction (#32287) 3 months ago
Leni Kadali 4238da6ee3
Add error message when user tries to follow their own account (#31910) 3 months ago
Matt Jankowski ebdeac0731
Add coverage for missing status scenario in NotificationMailer (#32256) 3 months ago
Matt Jankowski e4e07b1c34
Reduce factory usage across `spec/services` area (#32098) 3 months ago
Matt Jankowski 463f9197d8
Add regression coverage for admin reports resolution button within form (#32248) 3 months ago
Matt Jankowski cc8d723e71
Register an XML encoder for response tests (#32220) 3 months ago
Matt Jankowski d95f6f4410
Extract `ExportSummary` class for account object counts (#32227) 3 months ago
Matt Jankowski b7bb850efd
Enable hostname config for all system specs (#32109) 3 months ago
Matt Jankowski d270d6dd4f
Provide `use_path` to qr generator for svg data size reduction (#32127) 3 months ago
Matt Jankowski 2151dfb8d6
Add `relevant_params` to ReportFilter (matches account filter) (#32136) 3 months ago
Matt Jankowski 4aa26eba53
Extract `WebPushRequest` from push notification worker and subscription (#32208) 3 months ago
Matt Jankowski ebab3b80c7
Expand coverage for `Export` utility class (#32212) 3 months ago
Christian Schmidt 33d3ca7cf1
Support /.well-known/host-meta.json (#32206) 3 months ago
Jeong Arm 66b2bc1c84
Ignore error if mentioned account was not processable (#29215)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
3 months ago
David Roetzel e6cda8388c
Move OTP secret length to configuration (#32125) 3 months ago
Matt Jankowski cdd7526531
Remove completed TODO note in tags request spec (#32108) 4 months ago
Claire 513f187daf
Add “A Mastodon update is available.” message on admin dashboard for non-bugfix updates (#32106) 4 months ago
Matt Jankowski db57fe80c8
Remove `page_json` var from ap/replies spec (#32000) 4 months ago
Renaud Chaput 28966fa0a6
Remove deprecated `v2_alpha` endpoint for grouped notifications (#32089) 4 months ago
Matt Jankowski 51777fe3e2
Prefer structure checks over multi-line size/parts checks in `parsed_body` (#32063) 4 months ago
Renaud Chaput 3dc4ddc663
Fix search params being dropped when redirected to non-deck path (#31984) 4 months ago
Matt Jankowski 83574f641a
Add coverage and use mailer callback to check functional user in notification mailer (#32055) 4 months ago
Matt Jankowski c2ef83ea4c
Consolidate shared `a scope` example parts into one attributes check (#32046) 4 months ago
Matt Jankowski c3b6a7a297
Reduce factory creation (36 -> 12) in `spec/controllers/oauth/*` area (#32045) 4 months ago
Matt Jankowski 06ecf9008b
Remove single-use shared examples in controller specs (#32044) 4 months ago
André Menrath 556837f156
Fix the summary of converted object types to be treated as HTML (#28629) 4 months ago
Claire c36a76b9eb
Fix error when accepting appeal for sensitive posts deleted in the meantime (#32037)
Co-authored-by: David Roetzel <david@roetzel.de>
4 months ago
Matt Jankowski 780e2e9d66
Convert notification mailer spec shared examples to matchers (#32047) 4 months ago
Matt Jankowski 5dfdec6453
Convert `settings/applications` controller spec to system/request specs (#32006) 4 months ago
Matt Jankowski bbf7752256
Combine assertions in `Notification` model spec (#32015) 4 months ago
Matt Jankowski 2b4bda8004
Add `response_avatar_link` helper to webfinger request spec (#31999) 4 months ago
Matt Jankowski 447d0a3e88
Remove double no-records cases in `api/v1/admin` req specs (#32014) 4 months ago
Matt Jankowski 66ed7ea4b5
Move status creation to "with rss" context in accounts request spec (#32020) 4 months ago
Matt Jankowski cd7b670cd8
Reduce factory creation in `User#reset_password!` spec (#32021) 4 months ago
Matt Jankowski 0ba3ad4a35
Remove `body_json_ids` from api/v2/admin/accounts spec (#32003) 4 months ago
Matt Jankowski e0b45b35c9
Combine repeated parsed_body assertions into single (#32002) 4 months ago
Matt Jankowski d55f4fbda1
Add content type checks to api/v2 request specs (#31983) 4 months ago
Matt Jankowski 171394e914
Add coverage for CSV responses for severed relationships (#31962) 4 months ago
Matt Jankowski 66326065b0
Add `response.content_type` checks for JSON to `api/v1` request specs (#31981) 4 months ago
Matt Jankowski 04a939d640
Add `reviewed` and `unreviewed` scopes to `Reviewable` model concern (#31988) 4 months ago
Matt Jankowski 9a03902ab6
Capture actual behavior in v2/notifications "someone else" dismiss scenario (#31985) 4 months ago
Matt Jankowski 5a8f2fe31d
Convert `settings/exports` controller spec to system/request specs (#31965) 4 months ago
renovate[bot] 6801afa12f
Update dependency devise-two-factor to v6 [SECURITY] (#31957)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Roetzel <david@roetzel.de>
4 months ago
Matt Jankowski b071e618e7
Combine API request spec assertions (#31970) 4 months ago
Matt Jankowski e3baa1cdda
Add coverage for `AccountDeletionRequest` class (#31937) 4 months ago
Matt Jankowski bf8eaaa9a5
Convert controller spec for security_key_options endpoint to request spec (#31938) 4 months ago
Matt Jankowski 5405bdd344
Remove unused E2EE messaging code (#31193) 4 months ago
Matt Jankowski eb16763bff
Use `have_http_link_header` matcher in `api/v1/trends/*` specs (#31940) 4 months ago
Matt Jankowski 943738671c
Remove unneeded `to_s` on `Link` header comparison in statuses controller spec (#31941) 4 months ago
Claire e0648a916a
Rename `/api/v2_alpha/notifications*` to `/api/v2/notifications*` (#31840) 4 months ago
Matt Jankowski c54cbf7943
Remove `follow` creation from `ListAccount` fabricator (#31902) 4 months ago
Matt Jankowski abd2f5654a
Add validation coverage for `CustomEmoji` shortcode value (#31906) 4 months ago
Matt Jankowski 822e918a56
Add coverage for `Bookmark` validation and reblog/status check callback (#31907) 4 months ago
Claire 4b40d13cb3
Increase preview card image size limit from 2MB to 8MB when using libvips (#31904) 4 months ago
David Roetzel c1b2c4fd9a
Strip protocol from attribution domains (#31900) 4 months ago
Claire ba81e4e019
Fix inability to locally suspend remotely-suspended accounts in moderation interface (#31899) 4 months ago
Matt Jankowski a2c4f5f5c0
Add coverage for `ListAccount` follow/follow_request set up (#31896) 4 months ago
Matt Jankowski 202077517c
Add "search" group for chewy classes in simplecov config (#31890) 4 months ago
Matt Jankowski 207c073bf8
Remove debug output in migration controller spec (#31886) 4 months ago
Taylor Chaparro 1b6a82b799
Fix invalid date searches returning 503 (#31526) 4 months ago
Matt Jankowski 4aa600387e
Move redirect/base body class to view (#31796) 4 months ago
Christian Schmidt 8cdc148167
Handle invalid visibility (#31571) 4 months ago
Matt Jankowski 17c57c46e7
Add coverage for title/limit validations in `List` model (#31869) 4 months ago
Claire a496aeabcb
Change form-action Content-Security-Policy directive to be more restrictive (#26897) 4 months ago
Claire c35ea59ee6
Fix security context sometimes not being added in LD-Signed activities (#31871) 4 months ago
David Roetzel ab763c493f
Ignore `undefined` as canonical url (#31882) 4 months ago
Eugen Rochko 3d46f47817
Change embedded posts to use web UI (#31766)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
4 months ago
Matt Jankowski cdcd834f3c
Add coverage for `AnnualReport::*` source child classes (#31849) 4 months ago
Matt Jankowski cee71b9892
Remove `fa_` prefix from status visibility icon method (#31846) 4 months ago
Eugen Rochko e0c27a5047
Add ability to manage which websites can credit you in link previews (#31819) 4 months ago
Matt Jankowski d0ab94c4d2
Add `FeaturedTag` coverage, use `pick` in model (#31828) 4 months ago
Mike Dalessio a0ea2fa3b0
Change fetch link card service to parse as HTML5 (#31814) 4 months ago
Matt Jankowski c6a0768fe5
Use shared system spec helper methods (#31784) 4 months ago
Mike Dalessio afa2e257e4
Change verify link service to use CSS selectors instead of a complex XPath query (#31815) 4 months ago
Matt Jankowski 4f81ad2494
Add coverage for `media#player`, move body class to view (#31790) 4 months ago
Emelia Smith c88ba523ee
Fix sort order of moderation notes on Reports and Accounts (#31528) 4 months ago
Matt Jankowski a9d0b48b65
Set "admin" body class from `admin` nested layout (#31269) 4 months ago
Matt Jankowski 6b6a80b407
Remove `body_as_json` in favor of built-in `response.parsed_body` for JSON response specs (#31749) 4 months ago
Matt Jankowski 7efe0bde9d
Add `have_http_link_header` matcher and set header values as strings (#31010) 4 months ago
Matt Jankowski 09017dd8f0
Add worker spec for annual report worker (#31778) 4 months ago
Matt Jankowski 5acec087ca
Simplify basic presence validations (#29664) 4 months ago
David Roetzel f85694acfd
Add credentials to redis sentinel configuration (#31768) 4 months ago
Matt Jankowski e820cc30b8
Convert invites controller spec to system/request specs (#31755) 4 months ago
Matt Jankowski ba9fd1c32e
Add coverage for `Account#prepare_contents` callback (#31748) 4 months ago
David Roetzel 7d91723f05
Support `REDIS_SENTINEL_PORT` variables (#31767) 4 months ago
Matt Jankowski 4d5c91e99a
Remove `before` block in spec with TODOs which have been TO-DONE already (#31754) 4 months ago
Matt Jankowski e1b5f3fc6f
Use `response.parsed_body` for html response checks (#31750) 4 months ago
David Roetzel ef2bc8ea26
Add redis sentinel support to ruby part of code (#31744) 4 months ago
Claire 1fcffa573c
Fix 500 error in `GET /api/v2_alpha/notifications` when there are no notifications to return (#31746) 4 months ago
Matt Jankowski 14af5b47ac
Add coverage for model normalizations (#31734) 4 months ago
Matt Jankowski 9ed1aab9b7
Remove accidental matcher debug code (#31732) 4 months ago
Matt Jankowski f1003b2560
Enable "zero monkey patching" mode in RSpec (#31614) 4 months ago
Matt Jankowski c9ea91f868
Add coverage for `api/v1/annual_reports` area (#31730) 4 months ago
Matt Jankowski 19849eb91d
Skip paperclip spoof detector unless opted into attachment processing specs (#31454) 4 months ago
Matt Jankowski 69dbc23038
Only enable chewy in search-tagged specs (#30583) 4 months ago
Matt Jankowski 7c26e5e4a1
Add `Reviewable` model concern (#31152) 4 months ago
Matt Jankowski 2f0d0fc127
Add coverage for `CLI::Accounts#fix_duplications` task (#30639) 4 months ago
Matt Jankowski e1fa456c7c
Add `have_cacheable_headers` matcher for responses (#31727) 4 months ago
Matt Jankowski 490bdb7944
Add coverage for `StatusesHelper#media_summary` method (#31726) 4 months ago
Matt Jankowski 8922786ef4
Fix `RSpec/LetSetup` cop in api/v1/timelines/tag spec (#30796) 4 months ago
Matt Jankowski 67faaf5557
Simplify account model username presence validation spec (#31013) 4 months ago
Matt Jankowski fcb83be8b2
Improve coverage specificity for Webhook enable/disable/secret specs (#31194) 4 months ago
Matt Jankowski 928390c2ba
Convert `admin/settings` controller specs to system specs (#31548) 4 months ago
Matt Jankowski ef4920c6c9
Pull out https/hostname setup for request specs to shared config (#31622) 4 months ago
Matt Jankowski 79b1841805
Disable `without_verify_partial_doubles` in statuses/show view spec (#29132) 4 months ago
Matt Jankowski 5b595b8a5a
Remove usage of `assigns` in controller specs (#30195) 4 months ago
Claire ea0d691e19
Add `GET /api/v2_alpha/notifications/:group_key/accounts` (#31725) 4 months ago
Matt Jankowski 219458d7d4
Convert `tags` controller spec to system and request specs (#31708) 4 months ago
Matt Jankowski 31c00108a4
Add first pass coverage for `AnnualReport` class (#31704) 4 months ago
Matt Jankowski b8957241af
Add coverage for `JsonLdHelper#uri_from_bearcap` method (#31700) 4 months ago
Matt Jankowski 25bbb01666
Remove unused helper method in spec (#31699) 4 months ago
Matt Jankowski 24a0b20408
Use `body_as_json` directly instead of via local var assignment (#31696) 4 months ago
Christian Schmidt a5bbe83dfd
media_ids is an array of strings (#31709) 4 months ago
Christian Schmidt 491033c86c
Reject status creation with invalid `media_ids` parameter (#31681) 4 months ago
Matt Jankowski 40f993b3a0
Use built-in `response.parsed_body` for JSON response specs (#31674) 4 months ago
David Roetzel 388d5473e1
Refactor (ruby) redis configuration (#31694) 4 months ago
Matt Jankowski 1ee1c329cc
Convert `admin/announcements` controller spec to system spec (#31655) 4 months ago
Claire ad0a28a8bf
Add `grouped_types` parameter to allow clients to restrict which notifications types get grouped (#31594) 5 months ago
Matt Jankowski 02585d8789
Convert `media` controller spec to request spec (#31634) 5 months ago
Matt Jankowski b9269c8d38
Convert `admin/reset` controller spec to system spec (#31643) 5 months ago
Matt Jankowski 0ef636f72d
Convert `shares` controller spec to system spec (#31619) 5 months ago
Matt Jankowski 00586d27cb
Convert `instance_actor` controller spec to request spec (#31621) 5 months ago
Matt Jankowski 3959f36d19
Add checks about response body content to admin/dash spec (#30716) 5 months ago
Matt Jankowski 48f4e5444d
Convert `media_proxy` controller spec to request spec (#31600) 5 months ago
Matt Jankowski a7f8417795
Convert "CSV export" settings controller specs to request specs (#31601) 5 months ago
Matt Jankowski 38a3466741
Convert `api/oembed` controller spec to request spec (#31605) 5 months ago
Matt Jankowski c09d232ee3
Convert `api/web/settings` controller spec to request spec (#31606) 5 months ago
Matt Jankowski 14d7fe05d0
Use `describe` instead of `context` in top-level spec declaration (#31607) 5 months ago
Matt Jankowski 4c2534d12e
Convert "static page" controller specs to system specs (#31599) 5 months ago
Matt Jankowski dbe0ee8a81
Convert `emojis` controller spec to request spec (#31597)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
5 months ago
Matt Jankowski 5172d84946
Convert `manifest` controller spec to request spec (#31596) 5 months ago
Matt Jankowski 36ccdcc9e1
Convert "custom css" controller spec to request spec (#31595) 5 months ago
Matt Jankowski 641ae6a2cf
Convert health check endpoint controller spec to request spec (#31565) 5 months ago
Matt Jankowski bcc4b1078c
Fix `Rails/RootPathnameMethods` cop (#31582) 5 months ago
David Roetzel 0374918746
Add spec for doorkeeper behavior around issuing tokens (#31545) 5 months ago
Renaud Chaput 4a968cb7a9
Add `icon` field to instance endpoint (#30205) 5 months ago
Claire 19a1acb38b
Add `api_versions` to `/api/v2/instance` (#31354) 5 months ago
Matt Jankowski f91403ccaa
Remove unused `fa_icon` helper method (#31511) 5 months ago
Claire 711e1fce0a
Fix pagination parameters in `GET /api/v2_alpha/notificatins` (#31509) 5 months ago
Matt Jankowski fa2e7b1708
Migrate fontawesome->material in more views (#31360) 5 months ago
Claire 53c183f899
Reload notifications when accepted notifications are merged (streaming only) (#31419) 5 months ago
Edward Moulsdale d4f135bc6d
Fix in memoriam accounts appearing in follow recommendations (#31474)
Co-authored-by: Utkarsh Wankar <46633523+kernal053@users.noreply.github.com>
5 months ago
Claire d2e4be0456
Hopefully fix notifications pagination flaky test (#31494) 5 months ago
Renaud Chaput 5d04e29775
Disable Chrome's search engine selection screen when running system specs (#31437) 5 months ago
Renaud Chaput 4545b8d6cb
Add the ability to ignore specific browser errors for a spec (#31436) 5 months ago
Jeong Arm 95c11d365d
Don't push to cache buster if attachment path is nil (#31414) 5 months ago
Claire 7996a9543d
Change notification request acceptance to immediately delete the request (#31256) 5 months ago
Renaud Chaput c3e1d86d58
Fix log out from user menu not working on Safari (#31402) 5 months ago
Matt Jankowski 02df1b4e4a
Finish email allow/deny list naming migration (#30530) 5 months ago
Claire 8a5b57f668
Revert "Support JSON-LD named graph (#31288)" (#31355) 5 months ago
Claire cbdd8edf68
Revamp notification policy options (#31343) 5 months ago