Use strings instead of numeric literals and remove `rubocop:disable` in cache spec (#27742)

2 years ago · a688a9ed20
parent dc0bf87090
commit a688a9ed20
1 changed files with 3 additions and 5 deletions
--- a/spec/requests/cache_spec.rb
+++ b/spec/requests/cache_spec.rb
@ -171,12 +171,10 @@ describe 'Caching behavior' do
  let(:user)  { Fabricate(:user, role: UserRole.find_by(name: 'Moderator')) }

  before do
-    # rubocop:disable Style/NumericLiterals
-    status = Fabricate(:status, account: alice, id: 110224538612341312)
-    Fabricate(:status, account: alice, id: 110224538643211312, visibility: :private)
+    status = Fabricate(:status, account: alice, id: '110224538612341312')
+    Fabricate(:status, account: alice, id: '110224538643211312', visibility: :private)
    Fabricate(:invite, code: 'abcdef')
-    Fabricate(:poll, status: status, account: alice, id: 12345)
-    # rubocop:enable Style/NumericLiterals
+    Fabricate(:poll, status: status, account: alice, id: '12345')

    user.account.follow!(alice)
  end