Enable `Rails/ReversibleMigration` cop (#33264)

pull/33274/head
Matt Jankowski 2 weeks ago committed by GitHub
parent 315c170910
commit 43702b95a2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -3,12 +3,17 @@ inherit_from: ../../.rubocop.yml
Naming/VariableNumber:
CheckSymbols: false
# Enabled here as workaround for https://docs.rubocop.org/rubocop/configuration.html#path-relativity
# Below are all enabled as workaround for https://docs.rubocop.org/rubocop/configuration.html#path-relativity
# TODO: Delete this file and move above config to base naming config
Rails/CreateTableWithTimestamps:
Include:
- '*.rb'
# Enabled here as workaround for https://docs.rubocop.org/rubocop/configuration.html#path-relativity
Rails/ThreeStateBooleanColumn:
Include:
- '*.rb'
Rails/ReversibleMigration:
Include:
- '*.rb'

@ -1,7 +1,11 @@
# frozen_string_literal: true
class RemoveDevices < ActiveRecord::Migration[5.0]
def change
def up
drop_table :devices if table_exists?(:devices)
end
def down
raise ActiveRecord::IrreversibleMigration
end
end

@ -3,10 +3,10 @@
class FixNullBooleans < ActiveRecord::Migration[5.1]
def change
safety_assured do
change_column_default :domain_blocks, :reject_media, false
change_column_default :domain_blocks, :reject_media, false # rubocop:disable Rails/ReversibleMigration
change_column_null :domain_blocks, :reject_media, false, false
change_column_default :imports, :approved, false
change_column_default :imports, :approved, false # rubocop:disable Rails/ReversibleMigration
change_column_null :imports, :approved, false, false
change_column_null :statuses, :sensitive, false, false
@ -14,7 +14,7 @@ class FixNullBooleans < ActiveRecord::Migration[5.1]
change_column_null :users, :admin, false, false
change_column_default :users, :otp_required_for_login, false
change_column_default :users, :otp_required_for_login, false # rubocop:disable Rails/ReversibleMigration
change_column_null :users, :otp_required_for_login, false, false
end
end

@ -2,6 +2,6 @@
class ChangeCanonicalEmailBlocksNullable < ActiveRecord::Migration[6.1]
def change
safety_assured { change_column :canonical_email_blocks, :reference_account_id, :bigint, null: true, default: nil }
safety_assured { change_column :canonical_email_blocks, :reference_account_id, :bigint, null: true, default: nil } # rubocop:disable Rails/ReversibleMigration
end
end

Loading…
Cancel
Save