Convert `auth/challenges` spec controller->request (#33495)

pull/33506/head
Matt Jankowski 4 days ago committed by GitHub
parent b6c2923cf7
commit 0c690511c2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -2,9 +2,7 @@
require 'rails_helper' require 'rails_helper'
RSpec.describe Auth::ChallengesController do RSpec.describe 'Auth Challenges' do
render_views
let(:password) { 'foobar12345' } let(:password) { 'foobar12345' }
let(:user) { Fabricate(:user, password: password) } let(:user) { Fabricate(:user, password: password) }
@ -14,9 +12,9 @@ RSpec.describe Auth::ChallengesController do
let(:return_to) { edit_user_registration_path } let(:return_to) { edit_user_registration_path }
context 'with correct password' do context 'with correct password' do
before { post :create, params: { form_challenge: { return_to: return_to, current_password: password } } }
it 'redirects back and sets challenge passed at in session' do it 'redirects back and sets challenge passed at in session' do
post '/auth/challenge', params: { form_challenge: { return_to: return_to, current_password: password } }
expect(response) expect(response)
.to redirect_to(return_to) .to redirect_to(return_to)
expect(session[:challenge_passed_at]) expect(session[:challenge_passed_at])
@ -25,13 +23,12 @@ RSpec.describe Auth::ChallengesController do
end end
context 'with incorrect password' do context 'with incorrect password' do
before { post :create, params: { form_challenge: { return_to: return_to, current_password: 'hhfggjjd562' } } }
it 'renders challenge, displays error, does not set session' do it 'renders challenge, displays error, does not set session' do
expect(response) post '/auth/challenge', params: { form_challenge: { return_to: return_to, current_password: 'hhfggjjd562' } }
.to render_template('auth/challenges/new')
expect(response.body) expect(response.body)
.to include 'Invalid password' .to include(I18n.t('challenge.prompt'))
.and include('Invalid password')
expect(session[:challenge_passed_at]) expect(session[:challenge_passed_at])
.to be_nil .to be_nil
end end
Loading…
Cancel
Save