From 0c690511c220d2ee9de9fc41e0d1f94b3cdb0b88 Mon Sep 17 00:00:00 2001 From: Matt Jankowski Date: Wed, 8 Jan 2025 03:54:08 -0500 Subject: [PATCH] Convert `auth/challenges` spec controller->request (#33495) --- .../auth/challenges_spec.rb} | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) rename spec/{controllers/auth/challenges_controller_spec.rb => requests/auth/challenges_spec.rb} (64%) diff --git a/spec/controllers/auth/challenges_controller_spec.rb b/spec/requests/auth/challenges_spec.rb similarity index 64% rename from spec/controllers/auth/challenges_controller_spec.rb rename to spec/requests/auth/challenges_spec.rb index 3c9d2a5964..628bfe499b 100644 --- a/spec/controllers/auth/challenges_controller_spec.rb +++ b/spec/requests/auth/challenges_spec.rb @@ -2,9 +2,7 @@ require 'rails_helper' -RSpec.describe Auth::ChallengesController do - render_views - +RSpec.describe 'Auth Challenges' do let(:password) { 'foobar12345' } let(:user) { Fabricate(:user, password: password) } @@ -14,9 +12,9 @@ RSpec.describe Auth::ChallengesController do let(:return_to) { edit_user_registration_path } context 'with correct password' do - before { post :create, params: { form_challenge: { return_to: return_to, current_password: password } } } - it 'redirects back and sets challenge passed at in session' do + post '/auth/challenge', params: { form_challenge: { return_to: return_to, current_password: password } } + expect(response) .to redirect_to(return_to) expect(session[:challenge_passed_at]) @@ -25,13 +23,12 @@ RSpec.describe Auth::ChallengesController do end context 'with incorrect password' do - before { post :create, params: { form_challenge: { return_to: return_to, current_password: 'hhfggjjd562' } } } - it 'renders challenge, displays error, does not set session' do - expect(response) - .to render_template('auth/challenges/new') + post '/auth/challenge', params: { form_challenge: { return_to: return_to, current_password: 'hhfggjjd562' } } + expect(response.body) - .to include 'Invalid password' + .to include(I18n.t('challenge.prompt')) + .and include('Invalid password') expect(session[:challenge_passed_at]) .to be_nil end