From d76c9237300c97d60b9e5f4f23280278b813b460 Mon Sep 17 00:00:00 2001
From: Mikael Finstad <finstaden@gmail.com>
Date: Tue, 3 Jan 2023 18:12:38 +0800
Subject: [PATCH] improve success dialog

---
 src/dialogs.jsx | 21 ++++++++++-----------
 src/ffmpeg.js   |  2 ++
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/dialogs.jsx b/src/dialogs.jsx
index 53905826..52720f64 100644
--- a/src/dialogs.jsx
+++ b/src/dialogs.jsx
@@ -1,5 +1,5 @@
 import React, { useState, useCallback, useRef, useEffect } from 'react';
-import { UnorderedList, ListItem, WarningSignIcon, InfoSignIcon, Button, TextInputField, Checkbox, RadioGroup, Paragraph, LinkIcon } from 'evergreen-ui';
+import { HelpIcon, TickCircleIcon, UnorderedList, ListItem, WarningSignIcon, InfoSignIcon, Button, TextInputField, Checkbox, RadioGroup, Paragraph, LinkIcon } from 'evergreen-ui';
 import Swal from 'sweetalert2';
 import i18n from 'i18next';
 import { Trans } from 'react-i18next';
@@ -615,15 +615,14 @@ export async function openDirToast({ filePath, text, html, ...props }) {
 
 export async function openCutFinishedToast({ filePath, warnings, notices }) {
   const html = (
-    <>
-      <div>
-        {i18n.t('Done! Note: cutpoints may be inaccurate. Make sure you test the output files in your desired player/editor before you delete the source. If output does not look right, see the HELP page.')}
-      </div>
-      <UnorderedList>
-        {warnings.map((msg) => <ListItem key={msg} icon={WarningSignIcon} iconColor="warning">{msg}</ListItem>)}
-        {notices.map((msg) => <ListItem key={msg} icon={InfoSignIcon} iconColor="info">{msg}</ListItem>)}
-      </UnorderedList>
-    </>
+    <UnorderedList>
+      <ListItem icon={TickCircleIcon} iconColor="success" fontWeight="bold">{i18n.t('Export is done!')}</ListItem>
+      <ListItem icon={InfoSignIcon}>{i18n.t('Note: cutpoints may be inaccurate. Please test the output files in your desired player/editor before you delete the source file.')}</ListItem>
+      <ListItem icon={HelpIcon}>{i18n.t('If output does not look right, see the Help menu.')}</ListItem>
+      {notices.map((msg) => <ListItem key={msg} icon={InfoSignIcon} iconColor="info">{msg}</ListItem>)}
+      {warnings.map((msg) => <ListItem key={msg} icon={WarningSignIcon} iconColor="warning">{msg}</ListItem>)}
+    </UnorderedList>
   );
-  await openDirToast({ filePath, html, width: '90%', position: 'center', timer: 15000 });
+
+  await openDirToast({ filePath, html, width: 800, position: 'center', timer: 15000 });
 }
diff --git a/src/ffmpeg.js b/src/ffmpeg.js
index 49f9f27f..282f0a34 100644
--- a/src/ffmpeg.js
+++ b/src/ffmpeg.js
@@ -748,6 +748,8 @@ export function isIphoneHevc(format, streams) {
 }
 
 export function isProblematicAvc1(outFormat, streams) {
+  // it seems like this only happens for files that are also 4.2.2 10bit (yuv422p10le)
+  // https://trac.ffmpeg.org/wiki/Chroma%20Subsampling
   return isMov(outFormat) && streams.some((s) => s.codec_name === 'h264' && s.codec_tag === '0x31637661' && s.codec_tag_string === 'avc1' && s.pix_fmt === 'yuv422p10le');
 }