From 7da03ebdad9d836241e9d33fe1fe3a11c2e49fd2 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 29 Jul 2026 13:26:31 +0000 Subject: [PATCH] Fix skipped Windows x64 build steps after windows-2022 matrix change The matrix was switched from windows-latest to windows-2022, but the Windows x64 ffmpeg download, electron-builder, e2e and screenshot upload steps were still gated on matrix.os == 'windows-latest', so they never ran and the artifact upload failed with 'File dist/LosslessCut-win-x64.7z does not exist'. Gate them on runner.os == 'Windows' && matrix.os != 'windows-11-arm' instead, so they are independent of the exact Windows runner image. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01PWvFPqUcXUzsYf3DY7RziJ --- .github/workflows/build.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 20859a3f..63eea1bf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -81,7 +81,7 @@ jobs: yarn download-ffmpeg-darwin-arm64 - name: (Windows x64) Download ffmpeg - if: matrix.os == 'windows-latest' + if: runner.os == 'Windows' && matrix.os != 'windows-11-arm' run: yarn download-ffmpeg-win32-x64 - name: (Windows ARM64) Download ffmpeg @@ -116,7 +116,7 @@ jobs: GH_TOKEN: ${{ secrets.github_token }} - name: Build for Windows x64 - if: matrix.os == 'windows-latest' + if: runner.os == 'Windows' && matrix.os != 'windows-11-arm' run: yarn electron-builder --publish onTag --win --x64 env: GH_TOKEN: ${{ secrets.github_token }} @@ -131,7 +131,7 @@ jobs: if: runner.os == 'macOS' && env.is_tag == 'false' - run: node script/e2e.ts 'dist\win-unpacked\LosslessCut.exe' desktop screenshot.jpeg - if: matrix.os == 'windows-latest' && env.is_tag == 'false' + if: runner.os == 'Windows' && matrix.os != 'windows-11-arm' && env.is_tag == 'false' - run: | export DISPLAY=:0 @@ -173,7 +173,7 @@ jobs: yarn upload-artifacts dist/LosslessCut-win-${{ matrix.os == 'windows-11-arm' && 'arm64' || 'x64' }}.7z - name: (Windows x64) Upload screenshot - if: matrix.os == 'windows-latest' && env.is_tag == 'false' + if: runner.os == 'Windows' && matrix.os != 'windows-11-arm' && env.is_tag == 'false' env: ACTIONS_RUNTIME_TOKEN: ${{ env.ACTIONS_RUNTIME_TOKEN }} ACTIONS_RESULTS_URL: ${{ env.ACTIONS_RESULTS_URL }}