From 84e3f3706bb7c2374f8cd423a142a4a30f5273a9 Mon Sep 17 00:00:00 2001
From: nawaji <jonathant15191@gmail.com>
Date: Mon, 11 Dec 2023 16:05:29 -0800
Subject: [PATCH 1/3] Tooltips for icons in tracks selection menu

Adds mouseover tooltips for the icons in the track selection menu that were missing them (i.e the 'edit file metadata' pencil icon).
---
 src/StreamsSelector.jsx | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/StreamsSelector.jsx b/src/StreamsSelector.jsx
index b7ac8f61..37e3fce3 100644
--- a/src/StreamsSelector.jsx
+++ b/src/StreamsSelector.jsx
@@ -210,7 +210,7 @@ const Stream = memo(({ filePath, stream, onToggle, batchSetCopyStreamIds, copySt
       </td>
 
       <td style={{ display: 'flex', justifyContent: 'flex-end' }}>
-        <IconButton icon={InfoSignIcon} onClick={() => onInfoClick(stream, t('Track {{num}} info', { num: stream.index + 1 }))} appearance="minimal" iconSize={18} />
+        <IconButton icon={InfoSignIcon} title={t('Track {{trackNum}} info', { trackNum: stream.index + 1 })} onClick={() => onInfoClick(stream, t('Track {{trackNum}} info', { trackNum: stream.index + 1 }))} appearance="minimal" iconSize={18} />
 
         <Popover
           position={Position.BOTTOM_LEFT}
@@ -254,12 +254,12 @@ const FileHeading = ({ path, formatData, chapters, onTrashClick, onEditClick, se
 
       <div style={{ flexGrow: 1 }} />
 
-      <IconButton icon={InfoSignIcon} onClick={() => onInfoClick(formatData, t('File info'))} appearance="minimal" iconSize={18} />
+      <IconButton icon={InfoSignIcon} title={t('File info')} onClick={() => onInfoClick(formatData, t('File info'))} appearance="minimal" iconSize={18} />
       {chapters && chapters.length > 0 && <IconButton icon={BookIcon} onClick={() => onInfoClick(chapters, t('Chapters'))} appearance="minimal" iconSize={18} />}
-      {onEditClick && <IconButton icon={EditIcon} onClick={onEditClick} appearance="minimal" iconSize={18} />}
+      {onEditClick && <IconButton icon={EditIcon} title={t('Edit file metadata')} onClick={onEditClick} appearance="minimal" iconSize={18} />}
       {onTrashClick && <IconButton icon={TrashIcon} onClick={onTrashClick} appearance="minimal" iconSize={18} />}
-      <IconButton iconSize={18} color="#52BD95" icon={FaCheckCircle} onClick={() => setCopyAllStreams(true)} appearance="minimal" />
-      <IconButton iconSize={18} color="#D14343" icon={FaBan} onClick={() => setCopyAllStreams(false)} appearance="minimal" />
+      <IconButton iconSize={18} color="#52BD95" icon={FaCheckCircle} title={t('Keep all tracks')} onClick={() => setCopyAllStreams(true)} appearance="minimal" />
+      <IconButton iconSize={18} color="#D14343" icon={FaBan} title={t('Discard all tracks')} onClick={() => setCopyAllStreams(false)} appearance="minimal" />
       {onExtractAllStreamsPress && <IconButton iconSize={16} title={t('Export each track as individual files')} icon={ForkIcon} onClick={onExtractAllStreamsPress} appearance="minimal" />}
     </div>
   );

From b944c0768e59b970eed1deb40fb7ea9673b295d7 Mon Sep 17 00:00:00 2001
From: nawaji <jonathant15191@gmail.com>
Date: Mon, 11 Dec 2023 17:25:38 -0800
Subject: [PATCH 2/3] Adjusts margin to prevent overlapping elements
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Naïve solution to prevent the "Click to select which tracks to keep when exporting" text from overlapping with the button to close the tracks selection menu.
---
 src/StreamsSelector.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/StreamsSelector.jsx b/src/StreamsSelector.jsx
index 37e3fce3..a29cbd6b 100644
--- a/src/StreamsSelector.jsx
+++ b/src/StreamsSelector.jsx
@@ -333,7 +333,7 @@ const StreamsSelector = memo(({
 
   return (
     <>
-      <p style={{ margin: '.5em 1em' }}>{t('Click to select which tracks to keep when exporting:')}</p>
+      <p style={{ margin: '.5em 2em .5em 1em' }}>{t('Click to select which tracks to keep when exporting:')}</p>
 
       <div style={fileStyle}>
         {/* We only support editing main file metadata for now */}

From b5cdbffc4b750a6a18c0ce87c53f9e455237192a Mon Sep 17 00:00:00 2001
From: Mikael Finstad <finstaden@gmail.com>
Date: Thu, 21 Dec 2023 16:58:12 +0800
Subject: [PATCH 3/3] Update src/StreamsSelector.jsx

---
 src/StreamsSelector.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/StreamsSelector.jsx b/src/StreamsSelector.jsx
index a29cbd6b..2384aa59 100644
--- a/src/StreamsSelector.jsx
+++ b/src/StreamsSelector.jsx
@@ -210,7 +210,7 @@ const Stream = memo(({ filePath, stream, onToggle, batchSetCopyStreamIds, copySt
       </td>
 
       <td style={{ display: 'flex', justifyContent: 'flex-end' }}>
-        <IconButton icon={InfoSignIcon} title={t('Track {{trackNum}} info', { trackNum: stream.index + 1 })} onClick={() => onInfoClick(stream, t('Track {{trackNum}} info', { trackNum: stream.index + 1 }))} appearance="minimal" iconSize={18} />
+        <IconButton icon={InfoSignIcon} title={t('Track {{num}} info', { num: stream.index + 1 })} onClick={() => onInfoClick(stream, t('Track {{num}} info', { num: stream.index + 1 }))} appearance="minimal" iconSize={18} />
 
         <Popover
           position={Position.BOTTOM_LEFT}