diff --git a/src/main/index.ts b/src/main/index.ts index 189490ce..cf02de1b 100644 --- a/src/main/index.ts +++ b/src/main/index.ts @@ -439,6 +439,8 @@ const setProgressBar = (v: number) => mainWindow?.setProgressBar(v); function sendOsNotification(options: NotificationConstructorOptions) { if (!Notification.isSupported()) return; const notification = new Notification(options); + // Note: For notifications on macOS, your application will need to be code-signed in order for notification events to emit correctly. This requirement stems from the underlying UNNotification API provided by Apple. Unsigned binaries will emit a `failed` event when notification APIs are called. + // https://www.electronjs.org/docs/latest/tutorial/notifications#macos notification.on('failed', (_e, error) => logger.warn('Notification failed', error)); notification.show(); } diff --git a/src/renderer/src/App.tsx b/src/renderer/src/App.tsx index 45aabe88..7f2de655 100644 --- a/src/renderer/src/App.tsx +++ b/src/renderer/src/App.tsx @@ -1397,7 +1397,7 @@ function App() { async function tryFindAndLoadProjectFile({ chapters, cod }: { chapters: FFprobeChapter[], cod: string | undefined }) { try { - // First try to open from from working dir + // First try to open from working dir if (await tryOpenProjectPath(getEdlFilePath(fp, cod))) return; // then try to open project from source file dir @@ -1572,7 +1572,7 @@ function App() { const mediaFilePath = pathJoin(dirname(path), mediaFileName); - // Note: MAS only allows fs.stat (pathExists) if we don't have access to input dir yet + // Note: MAS doesn't allow anything else than fs.access before the user has granted our app access to input dir if (!(await mainApi.pathExists(mediaFilePath))) { errorToast(i18n.t('The media file referenced by the project file you tried to open does not exist in the same directory as the project file: {{mediaFileName}}', { mediaFileName })); return;