refactor(clients): describe behaviour in comments without naming Qt

pull/18/head
reionwong 2 weeks ago
parent d2572aaf1c
commit afb62d8ef1

@ -1,4 +1,4 @@
# Qt-free clients of system services, one library per directory, linking only
# Clients of system services, one library per directory, linking only
# the toolkit's base library. They form the CutefishClients package; a
# consumer asks for them by directory name:
# find_package(CutefishClients REQUIRED COMPONENTS appearance)

@ -54,7 +54,7 @@ static void updateChoice(std::vector<AudioObject::Choice>& list, AudioObject::Ch
list.push_back(std::move(choice));
}
// A whole number, as QString::toUInt() and toInt() read one.
// A whole number that fills the text: digits, with a leading '-' for a signed type.
template<typename T>
static bool parseNumber(const std::string& text, T& value)
{

@ -6,7 +6,7 @@
// Revision: 7acd40ddefff49c9d36144999aafdbb674dbd07a
//
// Adapted for Cutefish: plain value types for the compositor's versioned
// session D-Bus tuples, without Ash, Mojo or Qt.
// session D-Bus tuples, without Ash or Mojo.
#pragma once

@ -38,7 +38,7 @@ struct Rect
int height = 0;
bool isEmpty() const { return width <= 0 || height <= 0; }
// At least one pixel in common, as QRect::intersects() has it.
// At least one pixel in common; an empty rectangle intersects nothing.
bool intersects(const Rect& other) const
{
return !isEmpty() && !other.isEmpty() && x < other.x + other.width && other.x < x + width

@ -577,7 +577,7 @@ static const std::map<std::string, Table>& tables()
static bool toBool(const std::string& value)
{
// As a QVariant holding text reads as a bool.
// Text is true unless empty, "0" or "false" in any case.
return !value.empty() && value != "0" && text::lower(value) != "false";
}

Loading…
Cancel
Save