Merge branch 'soru/autofill-hints' into 'main'

fix: Wrap login form into `AutofillGroup`

Closes #503

See merge request famedly/fluffychat!481

lib/pages/views/login_view.dart

@@ -26,78 +26,80 @@ class LoginView extends StatelessWidget {
           ),
         ),
         body: Builder(builder: (context) {
-          return ListView(
-            children: <Widget>[
-              Padding(
-                padding: const EdgeInsets.all(12.0),
-                child: TextField(
-                  readOnly: controller.loading,
-                  autocorrect: false,
-                  autofocus: true,
-                  onChanged: controller.checkWellKnownWithCoolDown,
-                  controller: controller.usernameController,
-                  autofillHints:
-                      controller.loading ? null : [AutofillHints.username],
-                  decoration: InputDecoration(
-                      prefixIcon: Icon(Icons.account_box_outlined),
-                      hintText: L10n.of(context).username,
-                      errorText: controller.usernameError,
-                      labelText: L10n.of(context).username),
+          return AutofillGroup(
+            child: ListView(
+              children: <Widget>[
+                Padding(
+                  padding: const EdgeInsets.all(12.0),
+                  child: TextField(
+                    readOnly: controller.loading,
+                    autocorrect: false,
+                    autofocus: true,
+                    onChanged: controller.checkWellKnownWithCoolDown,
+                    controller: controller.usernameController,
+                    autofillHints:
+                        controller.loading ? null : [AutofillHints.username],
+                    decoration: InputDecoration(
+                        prefixIcon: Icon(Icons.account_box_outlined),
+                        hintText: L10n.of(context).username,
+                        errorText: controller.usernameError,
+                        labelText: L10n.of(context).username),
+                  ),
                 ),
-              ),
-              Padding(
-                padding: const EdgeInsets.all(12.0),
-                child: TextField(
-                  readOnly: controller.loading,
-                  autocorrect: false,
-                  autofillHints:
-                      controller.loading ? null : [AutofillHints.password],
-                  controller: controller.passwordController,
-                  obscureText: !controller.showPassword,
-                  onSubmitted: controller.login,
-                  decoration: InputDecoration(
-                    prefixIcon: Icon(Icons.lock_outlined),
-                    hintText: '****',
-                    errorText: controller.passwordError,
-                    suffixIcon: IconButton(
-                      tooltip: L10n.of(context).showPassword,
-                      icon: Icon(controller.showPassword
-                          ? Icons.visibility_off_outlined
-                          : Icons.visibility_outlined),
-                      onPressed: controller.toggleShowPassword,
+                Padding(
+                  padding: const EdgeInsets.all(12.0),
+                  child: TextField(
+                    readOnly: controller.loading,
+                    autocorrect: false,
+                    autofillHints:
+                        controller.loading ? null : [AutofillHints.password],
+                    controller: controller.passwordController,
+                    obscureText: !controller.showPassword,
+                    onSubmitted: controller.login,
+                    decoration: InputDecoration(
+                      prefixIcon: Icon(Icons.lock_outlined),
+                      hintText: '****',
+                      errorText: controller.passwordError,
+                      suffixIcon: IconButton(
+                        tooltip: L10n.of(context).showPassword,
+                        icon: Icon(controller.showPassword
+                            ? Icons.visibility_off_outlined
+                            : Icons.visibility_outlined),
+                        onPressed: controller.toggleShowPassword,
+                      ),
+                      labelText: L10n.of(context).password,
                     ),
-                    labelText: L10n.of(context).password,
                   ),
                 ),
-              ),
-              SizedBox(height: 12),
-              Hero(
-                tag: 'loginButton',
-                child: Padding(
-                  padding: EdgeInsets.symmetric(horizontal: 12),
-                  child: ElevatedButton(
-                    onPressed: controller.loading
-                        ? null
-                        : () => controller.login(context),
-                    child: controller.loading
-                        ? LinearProgressIndicator()
-                        : Text(L10n.of(context).login),
+                SizedBox(height: 12),
+                Hero(
+                  tag: 'loginButton',
+                  child: Padding(
+                    padding: EdgeInsets.symmetric(horizontal: 12),
+                    child: ElevatedButton(
+                      onPressed: controller.loading
+                          ? null
+                          : () => controller.login(context),
+                      child: controller.loading
+                          ? LinearProgressIndicator()
+                          : Text(L10n.of(context).login),
+                    ),
                   ),
                 ),
-              ),
-              Center(
-                child: TextButton(
-                  onPressed: controller.passwordForgotten,
-                  child: Text(
-                    L10n.of(context).passwordForgotten,
-                    style: TextStyle(
-                      color: Colors.blue,
-                      decoration: TextDecoration.underline,
+                Center(
+                  child: TextButton(
+                    onPressed: controller.passwordForgotten,
+                    child: Text(
+                      L10n.of(context).passwordForgotten,
+                      style: TextStyle(
+                        color: Colors.blue,
+                        decoration: TextDecoration.underline,
+                      ),
                     ),
                   ),
                 ),
-              ),
-            ],
+              ],
+            ),
           );
         }),
       ),