feat: small performance tweaks for Message

It is the widget most often built, so every small bit helps.
- replace a List with an array (should be easier to optimize for the
  compiler)
- remove a Padding widget and use the parent Container's padding instead
pull/490/head
gilice 2 years ago committed by Krille-chan
parent 5aa0f62021
commit eba3eeee25

@ -75,11 +75,11 @@ class Message extends StatelessWidget {
nextEvent == null || nextEvent == null ||
!event.originServerTs.sameEnvironment(nextEvent!.originServerTs); !event.originServerTs.sameEnvironment(nextEvent!.originServerTs);
final sameSender = nextEvent != null && final sameSender = nextEvent != null &&
[ {
EventTypes.Message, EventTypes.Message,
EventTypes.Sticker, EventTypes.Sticker,
EventTypes.Encrypted, EventTypes.Encrypted,
].contains(nextEvent!.type) && }.contains(nextEvent!.type) &&
nextEvent?.relationshipType == null && nextEvent?.relationshipType == null &&
nextEvent!.senderId == event.senderId && nextEvent!.senderId == event.senderId &&
!displayTime; !displayTime;
@ -407,13 +407,11 @@ class Message extends StatelessWidget {
: Theme.of(context).primaryColor.withAlpha(0), : Theme.of(context).primaryColor.withAlpha(0),
constraints: constraints:
const BoxConstraints(maxWidth: FluffyThemes.columnWidth * 2.5), const BoxConstraints(maxWidth: FluffyThemes.columnWidth * 2.5),
child: Padding( padding: EdgeInsets.symmetric(
padding: EdgeInsets.symmetric( horizontal: 8.0,
horizontal: 8.0, vertical: 4.0 * AppConfig.bubbleSizeFactor,
vertical: 4.0 * AppConfig.bubbleSizeFactor,
),
child: container,
), ),
child: container,
), ),
), ),
); );

Loading…
Cancel
Save