From a2e086a0d76fb302f737dae575ae29d06d6c1119 Mon Sep 17 00:00:00 2001
From: TheOneWithTheBraid <the-one@with-the-braid.cf>
Date: Sat, 21 May 2022 12:08:52 +0200
Subject: [PATCH] fix: privacy in sign up

- allow no mail registration after dismissing marning banner
- defaultly hide password characters

Signed-off-by: TheOneWithTheBraid <the-one@with-the-braid.cf>
---
 assets/l10n/intl_de.arb            |  2 +-
 assets/l10n/intl_en.arb            |  4 +++-
 assets/l10n/intl_fr.arb            |  2 +-
 lib/pages/sign_up/signup_view.dart | 13 +++++++------
 4 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/assets/l10n/intl_de.arb b/assets/l10n/intl_de.arb
index a428e0881..5a65a2d63 100644
--- a/assets/l10n/intl_de.arb
+++ b/assets/l10n/intl_de.arb
@@ -896,7 +896,7 @@
     "type": "text",
     "placeholders": {}
   },
-  "enterAnEmailAddress": "Gib eine E-Mail-Adresse ein",
+  "enterAnEmailAddress": "E-Mail-Adresse (nicht erforderlich)",
   "@enterAnEmailAddress": {
     "type": "text",
     "placeholders": {}
diff --git a/assets/l10n/intl_en.arb b/assets/l10n/intl_en.arb
index b0741688d..3aa8566e8 100644
--- a/assets/l10n/intl_en.arb
+++ b/assets/l10n/intl_en.arb
@@ -955,11 +955,13 @@
     "type": "text",
     "placeholders": {}
   },
-  "enterAnEmailAddress": "Enter an email address",
+  "enterAnEmailAddress": "Email address (not mandatory)",
   "@enterAnEmailAddress": {
     "type": "text",
     "placeholders": {}
   },
+  "emailContinueAnyway": "Continue anyway",
+  "emailEmptyWarning": "Warning: Even though adding a mail address leaks sensitive personal data, you have no way to recover your password without it.",
   "enterASpacepName": "Enter a space name",
   "@enterASpacepName": {},
   "enterAUsername": "Enter a username",
diff --git a/assets/l10n/intl_fr.arb b/assets/l10n/intl_fr.arb
index f9b8fbb74..d3fb92f1c 100644
--- a/assets/l10n/intl_fr.arb
+++ b/assets/l10n/intl_fr.arb
@@ -910,7 +910,7 @@
     "type": "text",
     "placeholders": {}
   },
-  "enterAnEmailAddress": "Saisissez une adresse de courriel",
+  "enterAnEmailAddress": "Adresse de courriel (ne pas mandatoire)",
   "@enterAnEmailAddress": {
     "type": "text",
     "placeholders": {}
diff --git a/lib/pages/sign_up/signup_view.dart b/lib/pages/sign_up/signup_view.dart
index 8f27b3c9d..93de63ecb 100644
--- a/lib/pages/sign_up/signup_view.dart
+++ b/lib/pages/sign_up/signup_view.dart
@@ -88,12 +88,13 @@ class SignupPageView extends StatelessWidget {
                     controller.loading ? null : [AutofillHints.username],
                 validator: controller.emailTextFieldValidator,
                 decoration: FluffyThemes.loginTextFieldDecoration(
-                    prefixIcon: const Icon(
-                      Icons.mail_outlined,
-                      color: Colors.black,
-                    ),
-                    hintText: L10n.of(context)!.enterAnEmailAddress,
-                    errorText: controller.error),
+                  prefixIcon: const Icon(
+                    Icons.mail_outlined,
+                    color: Colors.black,
+                  ),
+                  hintText: L10n.of(context)!.enterAnEmailAddress,
+                  errorText: controller.error,
+                ),
               ),
             ),
             Hero(