chore: Minor design changes in chatlist item

lib/components/dialogs/simple_dialogs.dart

@@ -10,13 +10,10 @@ class SimpleDialogs {
 
   Future<dynamic> tryRequestWithLoadingDialog(Future<dynamic> request,
       {Function(MatrixException) onAdditionalAuth}) async {
-    var completed = false;
     final futureResult = tryRequestWithErrorToast(
       request,
       onAdditionalAuth: onAdditionalAuth,
-    ).whenComplete(() => completed = true);
+    );
-    await Future.delayed(Duration(seconds: 1));
-    if (completed) return futureResult;
     return showDialog<dynamic>(
       context: context,
       barrierDismissible: false,

lib/components/list_items/chat_list_item.dart

@@ -163,25 +163,14 @@ class ChatListItem extends StatelessWidget {
                   softWrap: false,
                 ),
               ),
-              room.isFavourite
+              if (isMuted)
-                  ? Padding(
+                Padding(
-                      padding: const EdgeInsets.only(left: 4.0),
+                  padding: const EdgeInsets.only(left: 4.0),
-                      child: Icon(
+                  child: Icon(
-                        Icons.favorite_rounded,
+                    Icons.notifications_off_outlined,
-                        size: 16,
+                    size: 16,
-                        color: Theme.of(context).primaryColor,
+                  ),
-                      ),
+                ),
-                    )
-                  : Container(),
-              isMuted
-                  ? Padding(
-                      padding: const EdgeInsets.only(left: 4.0),
-                      child: Icon(
-                        Icons.notifications_off_outlined,
-                        size: 16,
-                      ),
-                    )
-                  : Container(),
               Padding(
                 padding: const EdgeInsets.only(left: 4.0),
                 child: Text(
@@ -250,26 +239,35 @@ class ChatListItem extends StatelessWidget {
                           ),
               ),
               SizedBox(width: 8),
-              room.notificationCount > 0
+              if (room.isFavourite)
-                  ? Container(
+                Padding(
-                      padding: EdgeInsets.symmetric(horizontal: 7),
+                  padding: EdgeInsets.only(
-                      height: 20,
+                      right: room.notificationCount > 0 ? 4.0 : 0.0),
-                      decoration: BoxDecoration(
+                  child: Icon(
-                        color: room.highlightCount > 0
+                    Icons.favorite_rounded,
-                            ? Colors.red
+                    size: 20,
-                            : Theme.of(context).primaryColor,
+                    color: Theme.of(context).primaryColor,
-                        borderRadius: BorderRadius.circular(20),
+                  ),
-                      ),
+                ),
-                      child: Center(
+              if (room.notificationCount > 0)
-                        child: Text(
+                Container(
-                          room.notificationCount.toString(),
+                  padding: EdgeInsets.symmetric(horizontal: 7),
-                          style: TextStyle(
+                  height: 20,
-                            color: Colors.white,
+                  decoration: BoxDecoration(
-                          ),
+                    color: room.highlightCount > 0
-                        ),
+                        ? Colors.red
+                        : Theme.of(context).primaryColor,
+                    borderRadius: BorderRadius.circular(20),
+                  ),
+                  child: Center(
+                    child: Text(
+                      room.notificationCount.toString(),
+                      style: TextStyle(
+                        color: Colors.white,
                       ),
-                    )
+                    ),
-                  : Text(' '),
+                  ),
+                ),
             ],
           ),
           onTap: () => clickAction(context),