common/BitField: Support sign extension

5 years ago · e7d68ba304
parent 004c22f031
commit e7d68ba304
1 changed files with 10 additions and 2 deletions
--- a/src/common/bitfield.h
+++ b/src/common/bitfield.h
@ -112,11 +112,19 @@ struct BitField

  DataType GetValue() const
  {
-    // TODO: Handle signed types
-    if (std::is_same<DataType, bool>::value)
+    if constexpr (std::is_same_v<DataType, bool>)
+    {
      return static_cast<DataType>(!!((data & GetMask()) >> BitIndex));
+    }
+    else if constexpr (std::is_signed_v<DataType>)
+    {
+      constexpr int shift = 8 * sizeof(DataType) - BitCount;
+      return (static_cast<DataType>((data & GetMask()) >> BitIndex) << shift) >> shift;
+    }
    else
+    {
      return static_cast<DataType>((data & GetMask()) >> BitIndex);
+    }
  }

  void SetValue(DataType value)