From 9576a3adf159a914003a4c14aa7acff0ec0474f6 Mon Sep 17 00:00:00 2001 From: Davide Pesavento Date: Sun, 10 Aug 2025 22:10:01 -0400 Subject: [PATCH] Achievements: Fix "beaten" condition (#3506) Apparently there are sets (e.g. Colin McRae Rally) with zero progression achievements. --- dep/rcheevos/src/rc_client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dep/rcheevos/src/rc_client.c b/dep/rcheevos/src/rc_client.c index ad0d66eb7..3665ff930 100644 --- a/dep/rcheevos/src/rc_client.c +++ b/dep/rcheevos/src/rc_client.c @@ -976,9 +976,9 @@ static void rc_client_subset_get_user_game_summary(const rc_client_subset_info_t } /* Game considered beaten when all progression achievements are unlocked and any win condition achievement - * is unlocked, or all progression achievements are unlocked and no there are no win condition achievements. */ + * is unlocked, or all progression achievements are unlocked and there are no win condition achievements. */ summary->beaten_time = 0; - if (num_progression_achievements > 0 && unlocked_progression_achievements == num_progression_achievements && + if (unlocked_progression_achievements == num_progression_achievements && (num_win_condition_achievements == 0 || first_win_condition_unlock > 0)) { summary->beaten_time = (num_win_condition_achievements == 0) ? last_progression_unlock : first_win_condition_unlock; }